Skip to content

Commit

Permalink
update comment on CreateContext, update Travis go versions
Browse files Browse the repository at this point in the history
  • Loading branch information
SebastiaanKlippert committed Apr 22, 2021
1 parent 37c5d0f commit ae3cf72
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ before_install:
- if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then rm "wkhtmltox_0.12.6-1.bionic_amd64.deb" ; fi
go:
- tip
- 1.16
- 1.15
- 1.14
script: go test -v -coverprofile=coverage.txt -covermode=atomic -bench .
os:
- linux
Expand Down
4 changes: 2 additions & 2 deletions wkhtmltopdf.go
Original file line number Diff line number Diff line change
Expand Up @@ -286,10 +286,10 @@ func (pdfg *PDFGenerator) findPath() error {

// Create creates the PDF document and stores it in the internal buffer if no error is returned
func (pdfg *PDFGenerator) Create() error {
return pdfg.run(context.TODO())
return pdfg.run(context.Background())
}

// Create creates the PDF document and stores it in the internal buffer if no error is returned
// CreateContext is Create with a context passed to exec.CommandContext when calling wkhtmltopdf
func (pdfg *PDFGenerator) CreateContext(ctx context.Context) error {
return pdfg.run(ctx)
}
Expand Down

0 comments on commit ae3cf72

Please sign in to comment.