Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop backward compatibility with versions earlier than 1.7.2 #185

Closed
SebastianMC opened this issue Jan 3, 2025 · 0 comments · Fixed by #186
Closed

Drop backward compatibility with versions earlier than 1.7.2 #185

SebastianMC opened this issue Jan 3, 2025 · 0 comments · Fixed by #186
Assignees
@SebastianMC
Labels
refactoring

Comments

@SebastianMC
Copy link
Owner

SebastianMC commented Jan 3, 2025 •
edited
Loading

For now the plugin code contains a series of backward compatible conditional sections, which make the code complex and less readable in some places.

The goal of this ticket:

  • bump up the npm dependency on Obsidian (API) to 1.7.2
  • bump up the required Obsidian to 1.7.2
  • remove the support for core Starred plugin - it was superseded by the Bookmarks
  • remove the two areas of code which handle the integration with legacy Obsidian sorting

Also take the opportunity to upgrade TS and other libraries and tools
@SebastianMC SebastianMC self-assigned this Jan 3, 2025
SebastianMC added a commit that referenced this issue Jan 3, 2025
@SebastianMC
#185 - drop backward compatibility
c300894 
- removed integration with Starred code plugin (which hasn't already been there for months)
SebastianMC added a commit that referenced this issue Jan 3, 2025
@SebastianMC
#185 - drop backward compatibility
51ea92f 
- removed legacy code to handle backward compatibility with <0.15.0, <1.2.0, <1.4.11 and <1.6.0
@SebastianMC SebastianMC mentioned this issue Jan 3, 2025
Merged
@SebastianMC SebastianMC linked a pull request Jan 3, 2025 that will close this issue
185 drop backward compatibility and require Obsidian 1.7.2 or newer #186
Merged
SebastianMC added a commit that referenced this issue Jan 3, 2025
@SebastianMC
Merge pull request #186 from SebastianMC/185-drop-backward-compatibil…
b0d2140 
…ity-and-require-1-7-2

#185 drop backward compatibility and require Obsidian 1.7.2 or newer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebastianMC SebastianMC

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

185 drop backward compatibility and require Obsidian 1.7.2 or newer SebastianMC/obsidian-custom-sort
1 participant
@SebastianMC