Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding bytes in mcp2518fd_TransmitChannelLoad method is written into wrong locations #128

Closed
AntDeM opened this issue Oct 12, 2021 · 2 comments
Assignees
Labels
enhancement Seeed_Arduino_CAN Label for Seeed_Arduino_CAN UAY Unassigned yet

Comments

@AntDeM
Copy link

AntDeM commented Oct 12, 2021

Padding bytes added to write a multiple of 4 bytes into RAM is written to wrong location because the offset of 8 is added two times:

The worst case is when txdNumBytes is greater than 56. In this case txBuffer is written out of bounds.

@Pillar1989
Copy link
Member

@thePapero welcome to send PR to us. we hope your name appears in the code commit history.

@MatthewJeffson MatthewJeffson added UAY Unassigned yet Seeed_Arduino_CAN Label for Seeed_Arduino_CAN labels Oct 9, 2024
@Lesords Lesords self-assigned this Oct 14, 2024
@Lesords
Copy link
Contributor

Lesords commented Oct 30, 2024

Hello,

I'm going to close this issue, feel free to re-open it if you have any other questions.

[Autocommentary]

@Lesords Lesords closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PR Assemble Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Seeed_Arduino_CAN Label for Seeed_Arduino_CAN UAY Unassigned yet
Projects
Status: Done
Development

No branches or pull requests

4 participants