Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for CORS configuration #386

Closed
JakeNeyer opened this issue Nov 15, 2021 · 1 comment
Closed

Feature Request: Add support for CORS configuration #386

JakeNeyer opened this issue Nov 15, 2021 · 1 comment

Comments

@JakeNeyer
Copy link
Contributor

Context:
As kserve is moving to it's v2 api, it's defaulting the server images to ml-server. It looks like kserve and knative are pushing off adding CORS configurations on their CRDs due to complexity (knative/serving#10040). The simplest way I have seen to get around that is adding an OPTIONS route and CORS options on the actual servers themselves.

Request
Add OPTIONS routes and the ability to apply runtime configuration for CORS on the MLServer

@adriangonz
Copy link
Contributor

Fixed by #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants