Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand Icons not included. #49

Open
Samistine opened this issue Apr 16, 2018 · 12 comments
Open

Brand Icons not included. #49

Samistine opened this issue Apr 16, 2018 · 12 comments

Comments

@Samistine
Copy link

Brand icons do not seem to be included in the build. If this is intended behavior, please document it.

@GottZ
Copy link

GottZ commented Jun 19, 2018

api.addFiles([
// icons
'themes/default/assets/fonts/icons.eot',
'themes/default/assets/fonts/icons.svg',
'themes/default/assets/fonts/icons.ttf',
'themes/default/assets/fonts/icons.woff',
'themes/default/assets/fonts/icons.woff2',
// flags
'themes/default/assets/images/flags.png',
// release
'semantic.css',
'semantic.js'
], 'client');

should definitely be put in there.

small work around until it get's fixed for your ember-cli-build.js:

'eot,svg,ttf,woff,woff2'.split(',').forEach(type => {
  ['brand', 'outline'].forEach(asset => {
    app.import(`node_modules/semantic-ui-css/themes/default/assets/fonts/${asset}-icons.${type}`, {
      destDir: 'assets/themes/default/assets/fonts'
    });
  });
});

@piotrwawrzyn
Copy link

Semantic-UI-CSS/package.js

Lines 18 to 32 in 980e4be

api.addFiles([
// icons
'themes/default/assets/fonts/icons.eot',
'themes/default/assets/fonts/icons.svg',
'themes/default/assets/fonts/icons.ttf',
'themes/default/assets/fonts/icons.woff',
'themes/default/assets/fonts/icons.woff2',

// flags
'themes/default/assets/images/flags.png',

// release
'semantic.css',
'semantic.js'
], 'client');

should definitely be put in there.
small work around until it get's fixed for your ember-cli-build.js:

'eot,svg,ttf,woff,woff2'.split(',').forEach(type => {
  ['brand', 'outline'].forEach(asset => {
    app.import(`node_modules/semantic-ui-css/themes/default/assets/fonts/${asset}-icons.${type}`, {
      destDir: 'assets/themes/default/assets/fonts'
    });
  });
});

How do I fix this if I'm not using ember-cli?

@jlukic
Copy link
Member

jlukic commented Oct 22, 2018

I’ll fix the github admin build tools to generate the correct css repo files in the next patch. This build is automatically produced using tools from the main repo.

@rainrivas
Copy link

Any updates on possibly when the update will be pushed?

@YassienW
Copy link

Since this is probably not getting fixed in the near future (if ever), does anyone have a workaround?

@amerryma
Copy link

Since this is probably not getting fixed in the near future (if ever), does anyone have a workaround?

Could try this: https://github.com/fomantic/Fomantic-UI-CSS

@YassienW
Copy link

Nope, using fomantic's CSS doesn't add the icons i need, those icons are missing from Fomantic's website too.

@amerryma
Copy link

Nope, using fomantic's CSS doesn't add the icons i need, those icons are missing from Fomantic's website too.

Which brand icons are missing? This is what I see.
Screen Shot 2020-03-17 at 11 47 37 AM

@YassienW
Copy link

Facebook, instagram, twitter, linkedin for example are missing

@amerryma
Copy link

Facebook, instagram, twitter, linkedin for example are missing

I see them.
Screen Shot 2020-03-17 at 11 51 26 AM

@YassienW
Copy link

Hmm i think my cache was messed up, i'll see if i can get it working with Fomantic.

@YassienW
Copy link

YassienW commented Mar 22, 2020

Just in case this happens to someone; the semantic UI icons are working but they were getting blocked by my ad blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants