Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled menu item text color defined with !important breaks text color for disabled items in inverted menu #43

Open
hanshenrik opened this issue Jun 5, 2018 · 1 comment
Open

Disabled menu item text color defined with !important breaks text color for disabled items in inverted menu #43

hanshenrik opened this issue Jun 5, 2018 · 1 comment

Comments

@hanshenrik
Copy link

hanshenrik commented Jun 5, 2018 •
edited
Loading

https://github.com/Semantic-Org/Semantic-UI-LESS/blob/master/definitions/collections/menu.less#L457 <-- This line overrides the definition for disabled items in inverted menus at https://github.com/Semantic-Org/Semantic-UI-LESS/blob/master/definitions/collections/menu.less#L1367, since the rule for non-inverted menus is defined with !important.
@aurbano
Copy link

aurbano commented Jul 26, 2018

Just came here to post this exact issue - I can submit a PR removing it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aurbano @hanshenrik