v3: roadmap to release #4409

layershifter · 2022-12-13T11:52:56Z

vinodhrajamuralidharan · 2023-01-29T10:44:24Z

@layershifter what is the status user.React.forwardRef PR status? I see it is still in open

layershifter · 2023-01-30T12:51:28Z

@vinodhrajamuralidharan I had a conversation with @levithomason about that PR. The agreement was that he will review it and then we can proceed. I am also waiting for that PR to be merged 😉

sunech · 2023-02-21T21:04:08Z

Is there any ETA on v3 progress @levithomason / @layershifter ?
There was such a great traction in December, so I started to get my hopes up for SUIR again 🤞 Would hate to see it stall again, with all the great work that has been put in to it 🙏

layershifter · 2023-02-28T17:38:39Z

3.0.0-beta.0 is out 🎉 Please try and report issues 🙏

DreierF · 2023-03-19T11:16:29Z

Thanks a lot @layershifter for the effort!
I didn't run into any issues yet with the beta besides the probably expected Typescript issues such as https://stackblitz.com/edit/react-ts-ejdyij?file=App.tsx.

See the roadmap: Semantic-Org/Semantic-UI-React#4409 See the breaking change: Semantic-Org/Semantic-UI-React#4286

sunech · 2023-06-16T17:56:07Z

Is there anything further that we can help test, in order to proceed with the v3 release?

tourman · 2023-07-04T11:21:12Z

@layershifter could you please update the status? FYI @levithomason

Is the roadmap todo list still relevant? If not, please refresh or update it. In particular, please add the links to the appropriate PRs, branches, etc.
Please add more clear description for each point. E.g. what is Document breaking changes that is not checked?
If you are not about to move on with the project, please initiate a process to pass it to the community. There are projects and people who are waiting for the new version trying to replace SUIR with a fork or something else.

layershifter · 2023-07-04T11:32:33Z

@tourman

1/2. Yes, it's relevant. I will update it to be more precise and detailed 👍
3. To be clear, I don't have time and motivation to maintain this project currently. If there people who are interested in move forward it would be great to hear back 🐱

sunech · 2023-07-04T13:40:46Z

@layershifter thank you for all you great work so far, highly appreciate your effort!

This project is too good to just die, so I really hope someone wants to pick up from here.
Would love to support if I can, not experienced enough to contribute with code though.
If any freelancers are considering, I would gladly pay for some of your time to get the ball rolling on this again.

layershifter · 2023-07-09T15:10:00Z

Thanks a lot @layershifter for the effort! I didn't run into any issues yet with the beta besides the probably expected Typescript issues such as https://stackblitz.com/edit/react-ts-ejdyij?file=App.tsx.

@DreierF it's indeed a bug, see #4432 for details.

Is there anything further that we can help test, in order to proceed with the v3 release?

@sunech @tourman I updated changelog and created migration guide (https://react.semantic-ui.com/migration-guide). I also updated issues that needs to be solved to release the next beta. Both issues contain action items and examples of changes needed to be done.

Help on these issues is much appreciated 🐱

siarheipashkevich · 2023-12-21T15:22:55Z

@layershifter thanks for your work on this package, do you have approximate time when you plan to release 3.0 version?

layershifter · 2023-12-30T15:04:03Z

3.0.0-beta.2 is out 🎉

It fixes .defaultProps warnings, TypeScript typings & issues with appDir in Next.js.

Please try and report issues 🙏

fniessink · 2024-01-05T12:06:08Z

I can report that after making a few small changes all frontend unit tests of Quality-time pass with 3.0.0-beta.2:

Test Suites: 85 passed, 85 total
Tests:       694 passed, 694 total
Snapshots:   0 total
Time:        67.751 s, estimated 70 s

Most changes were needed because popups would not appear at the right position with 3.0.0-beta.2. Adding a span or div around triggers solved this. I can't reproduce this issue on the Semantic UI React documentation site so I guess it's an issue on our side.

dominikdosoudil · 2024-05-06T13:31:15Z

I don't think that it's worth creating a issue but the Sticky component didn't work after the upgrade. I needed to add scrollContext because there is a scrollable div instead of whole window. I am not sure if it's somehow breaking change or I had it wrong even before. I am just mentioning as a possible information to migration guide.

Noahkoole · 2024-05-25T15:18:33Z

I can report that after making a few small changes all frontend unit tests of Quality-time pass with 3.0.0-beta.2:
Test Suites: 85 passed, 85 total
Tests:       694 passed, 694 total
Snapshots:   0 total
Time:        67.751 s, estimated 70 s
Most changes were needed because popups would not appear at the right position with 3.0.0-beta.2. Adding a span or div around triggers solved this. I can't reproduce this issue on the Semantic UI React documentation site so I guess it's an issue on our side.

This seems to also be an issue on our side. Started with the transition to beta.2 and adding a span around it indeed fixed it

atti187 · 2024-06-26T12:02:57Z

@layershifter - I fixed the first task in the beta-3 release. Could you please add issues for the rest of tasks in the list and I'll see if I can have a go at some of them? Would be nice to get v3 out!

BlenesiAron · 2024-09-02T05:57:49Z

When is the v3 release scheduled for?

triemstr · 2024-11-10T03:48:57Z

When is the v3 release scheduled for?

Outside of the eventStack breaking change, it looks like it is just a lot of testing and documentation for the 3.0.0 beta 3 release. I'm not sure if @layershifter is taking pull requests, but maybe some in the community can assist.

layershifter · 2024-11-11T10:32:31Z

I'm not sure if @layershifter is taking pull requests, but maybe some in the community can assist.

Yep, if somebody is brave enough to get rid of EventStack, I would be happy to review the changes.

triemstr · 2024-11-11T17:42:28Z

@layershifter Would you consider just going with the current state as version 3 and then working on the rest as version 4?

Only reason is that so many people are getting the props and other javascript warnings now and they don't know that the version 3 beta solves them. Running outdated on npm sources wouldn't show the version 3 beta. Might be a good way to keep the upgrades occurring so that a few more community members may jump in on EventStack.

Just a thought, unless someone is about there on EventStack.

dominikdosoudil · 2024-11-12T09:09:52Z

@triemstr I am up to looking into the EventStack however there might be one more thing blocking the release that needs to be fixed: https://github.com/Semantic-Org/Semantic-UI-React/pull/4233/files#r1837715017

dominikdosoudil · 2024-11-18T07:44:58Z

@layershifter So few past days, I've been looking into the EventStack in the Modal (and source code of the event-stack) and there is the thing "eventPool". As I think that I understand that it might help keeping multiple references to same callback (I imagine some independent unsubscribing), I can't really see the real purpose of it (or what and if something would break after removing it).

Could you possibly give me some hint or direction or use case where it's necessary?

layershifter · 2024-11-22T08:50:14Z

@dominikdosoudil My previous attempt there #3734 (ignore it, just to provide a perspective). The EventStack pattern is so fundamentally broken that it’s not even worth explaining what it does 💩. The eventPool prop should definitely be removed.

Let me break down the complexity behind this issue. The .contains() method is used to determine whether to close a Modal (for example) on an inside or outside click. This works well in straightforward cases like the following (e.g., clicking a button):

// JSX
<Modal>
  <Button />
</Modal>

// HTML
<body>
  <div class="ui modal">
    <button class="ui button"></button>
  </div>
</body>

However, it fails in nested scenarios. For example:

// JSX
<Modal>
  <Popup>
    <Button />
  </Popup>
</Modal>

// HTML
<body>
  <div class="ui modal">
  </div>
  <div class="ui popup">
    <button class="ui button"></button>
  </div>
</body>

In this case, the ui popup is not a child of ui modal, causing .contains() to break. A more detailed explanation of this issue can be found here: Virtual Parents.

To address this, I propose the following steps:

Add a test case for this scenario (refer to cypress/integration/Sidebar/Sidebar.spec.js as an example).
Implement the virtual parent approach, as seen in this PR: microsoft/fluentui#18148, and the related code: https://github.com/microsoft/fluentui/tree/master/packages/react-components/react-utilities/src/virtualParent).

Hope this helps.

dominikdosoudil · 2024-11-22T09:11:16Z

@layershifter I see, the nesting is tricky. Converted #4504 to draft. I am gonna look into it and decide if i am "brave enough" after all. 😆

Thank you for explaining it.

dominikdosoudil · 2024-11-28T09:41:13Z

I've explored the links you sent me and I must say that the prop injecting into element object seems pretty hacky to me. However it actually seems to be the most straightforward solution. I think that I might start working on porting that mechanism into SUIR about next week or so.

layershifter · 2024-11-28T10:06:05Z

I've explored the links you sent me and I must say that the prop injecting into element object seems pretty hacky to me. However it actually seems to be the most straightforward solution. I think that I might start working on porting that mechanism into SUIR about next week or so.

@dominikdosoudil sounds great ❤️ FYI I explored other solutions (with React Context), however that one in Fluent worked so far the best and is the most straightforward. But in general, I agree with you 🐱

layershifter pinned this issue Dec 13, 2022

This was referenced Dec 13, 2022

chore: replace ta-scripts with release-it #4410

Merged

feat: use React.forwardRef in all components #4233

Merged

avsd mentioned this issue Mar 21, 2023

Make it work with react-semantic-ui v.3 arthurdenner/react-semantic-ui-datepickers#839

Open

avsd added a commit to avsd/react-semantic-ui-datepickers that referenced this issue Mar 21, 2023

Make it work with Semantic-UI-React v3.

07d1c45

See the roadmap: Semantic-Org/Semantic-UI-React#4409 See the breaking change: Semantic-Org/Semantic-UI-React#4286

layershifter mentioned this issue Aug 4, 2023

[Button] should not throw findDOMNode warning in browser #4396

Closed

wkoot mentioned this issue Mar 7, 2024

Replace Fomantic UI CSS with Semantic UI CSS ICTU/quality-time#3233

Closed

fniessink mentioned this issue May 24, 2024

Upgrade to Semantic UI React v3 ICTU/quality-time#8764

Closed

layershifter mentioned this issue Aug 8, 2024

Vision for SUIR? #4230

Open

layershifter mentioned this issue Nov 22, 2024

chore(Portal): Listen for Escape keypress using addEventListener instead of event-stack #4504

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3: roadmap to release #4409

v3: roadmap to release #4409

layershifter commented Dec 13, 2022 •

edited

Loading

vinodhrajamuralidharan commented Jan 29, 2023

layershifter commented Jan 30, 2023

sunech commented Feb 21, 2023

layershifter commented Feb 28, 2023

DreierF commented Mar 19, 2023

sunech commented Jun 16, 2023

tourman commented Jul 4, 2023

layershifter commented Jul 4, 2023

sunech commented Jul 4, 2023

layershifter commented Jul 9, 2023 •

edited

Loading

siarheipashkevich commented Dec 21, 2023

layershifter commented Dec 30, 2023

fniessink commented Jan 5, 2024

dominikdosoudil commented May 6, 2024

Noahkoole commented May 25, 2024

atti187 commented Jun 26, 2024

BlenesiAron commented Sep 2, 2024

triemstr commented Nov 10, 2024 •

edited

Loading

layershifter commented Nov 11, 2024 •

edited

Loading

triemstr commented Nov 11, 2024 •

edited

Loading

dominikdosoudil commented Nov 12, 2024

dominikdosoudil commented Nov 18, 2024

layershifter commented Nov 22, 2024 •

edited

Loading

dominikdosoudil commented Nov 22, 2024 •

edited

Loading

dominikdosoudil commented Nov 28, 2024

layershifter commented Nov 28, 2024 •

edited

Loading

v3: roadmap to release #4409

v3: roadmap to release #4409

Comments

layershifter commented Dec 13, 2022 • edited Loading

Pre beta-0 ✅

For beta-0 ✅

Post beta-0 ✅

For beta-2 ✅

For beta-3

For RC

After release

vinodhrajamuralidharan commented Jan 29, 2023

layershifter commented Jan 30, 2023

sunech commented Feb 21, 2023

layershifter commented Feb 28, 2023

DreierF commented Mar 19, 2023

sunech commented Jun 16, 2023

tourman commented Jul 4, 2023

layershifter commented Jul 4, 2023

sunech commented Jul 4, 2023

layershifter commented Jul 9, 2023 • edited Loading

siarheipashkevich commented Dec 21, 2023

layershifter commented Dec 30, 2023

fniessink commented Jan 5, 2024

dominikdosoudil commented May 6, 2024

Noahkoole commented May 25, 2024

atti187 commented Jun 26, 2024

BlenesiAron commented Sep 2, 2024

triemstr commented Nov 10, 2024 • edited Loading

layershifter commented Nov 11, 2024 • edited Loading

triemstr commented Nov 11, 2024 • edited Loading

dominikdosoudil commented Nov 12, 2024

dominikdosoudil commented Nov 18, 2024

layershifter commented Nov 22, 2024 • edited Loading

dominikdosoudil commented Nov 22, 2024 • edited Loading

dominikdosoudil commented Nov 28, 2024

layershifter commented Nov 28, 2024 • edited Loading

layershifter commented Dec 13, 2022 •

edited

Loading

layershifter commented Jul 9, 2023 •

edited

Loading

triemstr commented Nov 10, 2024 •

edited

Loading

layershifter commented Nov 11, 2024 •

edited

Loading

triemstr commented Nov 11, 2024 •

edited

Loading

layershifter commented Nov 22, 2024 •

edited

Loading

dominikdosoudil commented Nov 22, 2024 •

edited

Loading

layershifter commented Nov 28, 2024 •

edited

Loading