Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoTip and Labymod not working together #13

Open
Alex33856 opened this issue Aug 7, 2019 · 8 comments
Open

AutoTip and Labymod not working together #13

Alex33856 opened this issue Aug 7, 2019 · 8 comments

Comments

@Alex33856
Copy link

When using LabyMod and AT (3.0), AT does not detect the client as playing on Hypixel(image

@Alex33856
Copy link
Author

Okay, so I've used the /at debug command on a different client (BLC), and it came up with basically the same except it showed "Tab Header: You're connected to mc.hypixel.net" or something. So I think LB changes the tab list in some way

@Semx11
Copy link
Owner

Semx11 commented Aug 11, 2019

This would be an issue related to Labymod, please reach out to its developers to figure out why it can't be read.

Autotip reads the tab header through Java's reflection library. It does so by reading the relevant field during runtime. The field in question can be found here. This should be enough info for the developers to figure out what's going on.

I'm very busy myself at the moment, so that's why reaching out to them myself isn't an option right now. If you can contact them and figure out what's the issue using the details I supplied above, I'll try my best to fix it and add Labymod support. Thanks for reporting the issue!

@Alex33856
Copy link
Author

Alright, I've reached out to them and I'll tell you when I get a response

@ugcodrr
Copy link

ugcodrr commented Sep 13, 2019

I might be "necro-posting" but, what if you had a version or a command where you could toggle it is so you would ignore whether or not you were on hypixel. Maybe "/at bypassip"

@mendel3
Copy link

mendel3 commented Jan 24, 2020

While I am 100% sure this is a terrible solution, you can disable the hypixel check by replacing
manager.setOnHypixel(true);
on line 90 of EventClientConnection.java with
manager.setOnHypixel(true); if (autotip.getConfig().isEnabled()) { taskManager.executeTask(TaskType.LOGIN, manager::login); taskManager.schedule(manager::checkVersions, 5); }
which makes the mod say that you are on hypixel even if you are not. This will probably cause the mod to tip on any server as long it is toggled on. I can provide a compiled jar, although would prefer not to for security reasons. Sorry for the necropost!
EDIT: This doesn't work, nvm. I will try to find a solution tomorow

@js6pak
Copy link
Contributor

js6pak commented Jul 6, 2020

Generally the problem is labymod is reimplementing GuiPlayerTabOverlay with its net.labymod.core_implementation.mc18.gui.ModPlayerTabOverlay, and for some reason instead of using already existing header/footer fields its creating new ones. I made working workaround, but it should be resolved at labymod side.

@Semx11
Copy link
Owner

Semx11 commented Jul 9, 2020

@js6pak Could you create a pull request for this change? I'll make some additional changes on top of your commit but it's a good start for a fix 👍

@js6pak js6pak mentioned this issue Jul 9, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

Instead of doing this and using reflection, you can check the client (server, mcp is bad) brand for "BungeeCord (Hypixel)", as used here in Skyblock Addons https://github.com/BiscuitDevelopment/SkyblockAddons/blob/69d036aff9cd978d8b411df44983c40f4f4c7f2d/src/main/java/codes/biscuit/skyblockaddons/utils/Utils.java#L189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants