[remove Compiler Warning]: caused by unused Variable in SHTSensor.h

[hasenradball]

Hi,

I have a proposal to remove a silly Compiler warning in line 160 of SHTSensor.h:

see here:

          virtual bool setAccuracy(SHTSensor::SHTAccuracy newAccuracy) {
                 return false;
          }

causes a silly compiler warning which can be prevented like:

          virtual bool setAccuracy(SHTSensor::SHTAccuracy newAccuracy) {
                (void) newAccuracy;
                return false;
          }

[winkj]

Looks good, thanks for reporting this. While harmless, libraries should not generate warnings. Alternatively, we could used __attribute__((unused))

[hasenradball]

Hi thanks for watching 😀.
How will it look like with the attribute((unused))?

[winkj]

It would look like this:

virtual bool setAccuracy(__attribute__((unused)) SHTSensor::SHTAccuracy newAccuracy) {
    return false;
}

I've briefly tried to recreate the compiler warning in Arduino IDE, but failed to do so. Could you share the setup you used to get this warning so we can verify that it's fixed? Thanks

[winkj]

Alternatively, we can simply omit the parameter name:

virtual bool setAccuracy(SHTSensor::SHTAccuracy /* newAccuracy* /) {
    return false;
}

This should fix it too

[hasenradball]

Hi Johannes,

I use Platform IO where I am able to set the Warning level in GCC compiler like that:

; Debug Flag Serial or Serial1
build_flags =
    -Wall
    -Wextra

The sesult is like that:

In file included from D:\PIO_libs\cSensorSHT31/cSensor_SHT31.h:7,
                 from D:\PIO_libs\cSensorSHT31\cSensor_SHT31.cpp:8:
.pio\libdeps\esp12e\arduino-sht/SHTSensor.h: In member function 'virtual bool SHTSensorDriver::setAccuracy(SHTSensor::SHTAccuracy)':
.pio\libdeps\esp12e\arduino-sht/SHTSensor.h:160:51: warning: unused parameter 'newAccuracy' [-Wunused-parameter]
  160 |   virtual bool setAccuracy(SHTSensor::SHTAccuracy newAccuracy) {

[hasenradball]

I tried to set the warning level in Arduino IDE, but I didn't found where.

[hasenradball]

virtual bool setAccuracy(__attribute__((unused)) SHTSensor::SHTAccuracy newAccuracy) {
    return false;
  }

works also fine
:-)

[hasenradball]

Hi Johannes,
kann ich noch eine Frage stellen?
Ich habe einen ESP8266 mit einem SHT31 Sensor.

Ich nutze folgendes Setup:

namespace SHT {
  class Sensor_SHT31 {
    private:
      uint8_t _sda_pin, _scl_pin;
      SHTSensor sht = SHTSensor(SHTSensor::SHT3X);

    public:
      bool sensor_available;
      bool send_data2DB;
      struct Messung {
        time_t zeit;
        float Messwert1;
        float Messwert2;
        float Messwert3;
        float Messwert4;
      } Data;
      explicit Sensor_SHT31(uint8_t sda_pin, uint8_t scl_pin);
      bool setup(void);
      void measure();
  };
}

bool SHT::Sensor_SHT31::setup() {
  // SDA, SCL
  Wire.begin(_sda_pin, _scl_pin);
  delay(100);
  sensor_available = sht.init();
  DBG__PRINT(">>> SHT31D-Sensor - init(): ", sensor_available, "\n\n");
  // only supported by SHT3x
  sht.setAccuracy(SHTSensor::SHT_ACCURACY_MEDIUM);
  return sensor_available;

Das sht.init() liefert mir einen true Wert obwohl kein Sensor angeschlossen ist.

Ist das normal?

[winkj]

@hasenradball das ist konsistent mit dem Code wenn ein Sensor-Typ angegeben wird, aber nicht unbedingt sinnvoll. Werde das auch gleich anschauen

[winkj]

@hasenradball both issues are addressed in pull request #17

[hasenradball]

Thank you :-)