From 17f2b8bff64a1247a5e8e78e37ca791e92effe02 Mon Sep 17 00:00:00 2001
From: Anton Chubov <antonchubov@gmail.com>
Date: Mon, 12 Jun 2023 23:30:31 +0300
Subject: [PATCH 1/2] WIP Ability to copy admin logs Set of AdminLogsLabel have
 been changed to single TextEdit Recieved logs now stored in class's field
 Only content of TextEdit refreshes on filter changes Filters now recieve base
 SharedAdminLog as input instead AdminLogLabel TODO: Add autoscroll to the end

---
 .../UI/Logs/AdminLogsControl.xaml             |  4 +-
 .../UI/Logs/AdminLogsControl.xaml.cs          | 78 +++++++++----------
 2 files changed, 37 insertions(+), 45 deletions(-)

diff --git a/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml b/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml
index 9d3506c6ba04f2..e5bc610f7ff462 100644
--- a/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml
+++ b/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml
@@ -61,8 +61,8 @@
                     <Button Name="RefreshButton" Access="Public" Text="{Loc admin-logs-refresh}" StyleClasses="ButtonSquare"/>
                     <Button Name="NextButton" Access="Public" Text="{Loc admin-logs-next}" StyleClasses="OpenLeft"/>
                 </BoxContainer>
-                <ScrollContainer VerticalExpand="True" HorizontalExpand="True" HScrollEnabled="False">
-                    <BoxContainer Name="LogsContainer" Access="Public" Orientation="Vertical" VerticalExpand="True"/>
+                <ScrollContainer Name="AdminLogsScrollContainer" Access="Public" VerticalExpand="True" HorizontalExpand="True" HScrollEnabled="False">
+                    <TextEdit Name="AdminLogsTextEdit" Access="Public" VerticalExpand="True"/>
                 </ScrollContainer>
             </BoxContainer>
         </BoxContainer>
diff --git a/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs b/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs
index 665b8eced02089..05239ed56607c4 100644
--- a/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs
+++ b/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs
@@ -16,12 +16,14 @@ namespace Content.Client.Administration.UI.Logs;
 public sealed partial class AdminLogsControl : Control
 {
     private readonly Comparer<AdminLogTypeButton> _adminLogTypeButtonComparer =
-        Comparer<AdminLogTypeButton>.Create((a, b) =>
-            string.Compare(a.Type.ToString(), b.Type.ToString(), StringComparison.Ordinal));
+        Comparer<AdminLogTypeButton>.Create(
+            (a, b) => string.Compare(a.Type.ToString(), b.Type.ToString(), StringComparison.Ordinal)
+        );
 
     private readonly Comparer<AdminLogPlayerButton> _adminLogPlayerButtonComparer =
-        Comparer<AdminLogPlayerButton>.Create((a, b) =>
-            string.Compare(a.Text, b.Text, StringComparison.Ordinal));
+        Comparer<AdminLogPlayerButton>.Create(
+            (a, b) => string.Compare(a.Text, b.Text, StringComparison.Ordinal)
+        );
 
     public AdminLogsControl()
     {
@@ -44,6 +46,8 @@ public AdminLogsControl()
 
         ResetRoundButton.OnPressed += ResetRoundPressed;
 
+        RecievedLogs = new List<SharedAdminLog>();
+
         SetImpacts(Enum.GetValues<LogImpact>().OrderBy(impact => impact).ToArray());
         SetTypes(Enum.GetValues<LogType>());
     }
@@ -55,6 +59,7 @@ public AdminLogsControl()
     private int ShownLogs { get; set; }
     private int TotalLogs { get; set; }
     private int RoundLogs { get; set; }
+    private List<SharedAdminLog> RecievedLogs { get; set; }
     public bool IncludeNonPlayerLogs { get; set; }
 
     public HashSet<LogType> SelectedTypes { get; } = new();
@@ -239,22 +244,27 @@ private void UpdatePlayers()
     private void UpdateLogs()
     {
         ShownLogs = 0;
+        var logsText = "";
 
-        foreach (var child in LogsContainer.Children)
+        for (int i = RecievedLogs.Count - 1; i >= 0; i--)
         {
-            if (child is not AdminLogLabel log)
-            {
-                continue;
-            }
-
-            child.Visible = ShouldShowLog(log);
-            if (child.Visible)
+            var log = RecievedLogs[i];
+            if (ShouldShowLog(log))
             {
                 ShownLogs++;
+                logsText += string.Format(
+                    "{0:HH:mm:ss} - {1}\n{2}\n\n",
+                    log.Date,
+                    log.Type,
+                    log.Message
+                );
             }
         }
 
-        UpdateCount();
+        AdminLogsTextEdit.TextRope = new Robust.Shared.Utility.Rope.Leaf(logsText);
+        AdminLogsScrollContainer.SetScrollValue(default);
+
+        UpdateCount(ShownLogs, RecievedLogs.Count);
     }
 
     private bool ShouldShowType(AdminLogTypeButton button)
@@ -269,30 +279,30 @@ private bool ShouldShowPlayer(AdminLogPlayerButton button)
                button.Text.Contains(PlayerSearch.Text, StringComparison.OrdinalIgnoreCase);
     }
 
-    private bool LogMatchesPlayerFilter(AdminLogLabel label)
+    private bool LogMatchesPlayerFilter(SharedAdminLog log)
     {
-        if (label.Log.Players.Length == 0)
+        if (log.Players.Length == 0)
             return SelectedPlayers.Count == 0 || IncludeNonPlayerLogs;
 
-        return SelectedPlayers.Overlaps(label.Log.Players);
+        return SelectedPlayers.Overlaps(log.Players);
     }
 
-    private bool ShouldShowLog(AdminLogLabel label)
+    private bool ShouldShowLog(SharedAdminLog log)
     {
         // Check log type
-        if (!SelectedTypes.Contains(label.Log.Type))
+        if (!SelectedTypes.Contains(log.Type))
             return false;
 
         // Check players
-        if (!LogMatchesPlayerFilter(label))
+        if (!LogMatchesPlayerFilter(log))
             return false;
 
         // Check impact
-        if (!SelectedImpacts.Contains(label.Log.Impact))
+        if (!SelectedImpacts.Contains(log.Impact))
             return false;
 
         // Check search
-        if (!label.Log.Message.Contains(LogSearch.Text, StringComparison.OrdinalIgnoreCase))
+        if (!log.Message.Contains(LogSearch.Text, StringComparison.OrdinalIgnoreCase))
             return false;
 
         return true;
@@ -458,32 +468,14 @@ public void SetPlayers(Dictionary<Guid, string> players)
 
     public void AddLogs(List<SharedAdminLog> logs)
     {
-        var span = CollectionsMarshal.AsSpan(logs);
-        for (var i = 0; i < span.Length; i++)
-        {
-            ref var log = ref span[i];
-            var separator = new HSeparator();
-            var label = new AdminLogLabel(ref log, separator);
-            label.Visible = ShouldShowLog(label);
-
-            TotalLogs++;
-            if (label.Visible)
-            {
-                ShownLogs++;
-            }
-
-            LogsContainer.AddChild(label);
-            LogsContainer.AddChild(separator);
-        }
-
-        UpdateCount();
+        RecievedLogs.AddRange(logs);
+        UpdateLogs();
     }
 
     public void SetLogs(List<SharedAdminLog> logs)
     {
-        LogsContainer.RemoveAllChildren();
-        UpdateCount(0, 0);
-        AddLogs(logs);
+        RecievedLogs = logs;
+        UpdateLogs();
     }
 
     public void UpdateCount(int? shown = null, int? total = null, int? round = null)

From 28844bc762b20cdb6524788629bc76913e02578e Mon Sep 17 00:00:00 2001
From: Anton Chubov <antonchubov@gmail.com>
Date: Thu, 22 Jun 2023 01:32:36 +0300
Subject: [PATCH 2/2] Autoscroll of AdminLogsTextEdit Regex-based BB-codes
 removing Added more comments

---
 .../UI/Logs/AdminLogsControl.xaml.cs          | 42 ++++++++++++++++---
 1 file changed, 36 insertions(+), 6 deletions(-)

diff --git a/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs b/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs
index 05239ed56607c4..3ff408667a7579 100644
--- a/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs
+++ b/Content.Client/Administration/UI/Logs/AdminLogsControl.xaml.cs
@@ -1,5 +1,5 @@
 using System.Linq;
-using System.Runtime.InteropServices;
+using System.Text.RegularExpressions;
 using Content.Client.Administration.UI.CustomControls;
 using Content.Shared.Administration.Logs;
 using Content.Shared.Database;
@@ -15,6 +15,11 @@ namespace Content.Client.Administration.UI.Logs;
 [GenerateTypedNameReferences]
 public sealed partial class AdminLogsControl : Control
 {
+    /// <summary>
+    /// <para>List of used tags can be found here: Robust.Client/UserInterface/RichText/MarkupTagManager.cs</para>
+    /// <para>Pattern test online: https://regex101.com/r/3krK2I/2</para>
+    /// </summary>
+    private const string BBCodeRegexPattern = "((\\[|\\[/)(color|cmdlink|font|bold|italic)=?\\w*\\])";
     private readonly Comparer<AdminLogTypeButton> _adminLogTypeButtonComparer =
         Comparer<AdminLogTypeButton>.Create(
             (a, b) => string.Compare(a.Type.ToString(), b.Type.ToString(), StringComparison.Ordinal)
@@ -59,7 +64,12 @@ public AdminLogsControl()
     private int ShownLogs { get; set; }
     private int TotalLogs { get; set; }
     private int RoundLogs { get; set; }
+
+    /// <summary>
+    /// Storage of recieved logs
+    /// </summary>
     private List<SharedAdminLog> RecievedLogs { get; set; }
+
     public bool IncludeNonPlayerLogs { get; set; }
 
     public HashSet<LogType> SelectedTypes { get; } = new();
@@ -246,7 +256,8 @@ private void UpdateLogs()
         ShownLogs = 0;
         var logsText = "";
 
-        for (int i = RecievedLogs.Count - 1; i >= 0; i--)
+        // build logs string
+        for (var i = RecievedLogs.Count - 1; i >= 0; i--)
         {
             var log = RecievedLogs[i];
             if (ShouldShowLog(log))
@@ -260,11 +271,30 @@ private void UpdateLogs()
                 );
             }
         }
-
-        AdminLogsTextEdit.TextRope = new Robust.Shared.Utility.Rope.Leaf(logsText);
-        AdminLogsScrollContainer.SetScrollValue(default);
-
+        // set new text in TextEdit and clear BB tags only in result log string to
+        // preserve original log messages for posible future use
+        AdminLogsTextEdit.TextRope = new Robust.Shared.Utility.Rope.Leaf(
+                Regex.Replace(logsText, BBCodeRegexPattern, "")
+            );
         UpdateCount(ShownLogs, RecievedLogs.Count);
+        ScrollLogsToBottom();
+    }
+
+    /// <summary>
+    /// Try to scroll AdminLogsTextEdit to the end
+    /// </summary>
+    private void ScrollLogsToBottom()
+    {
+        // find scrollbar in TextEdit's children
+        // it must be at index 1, but may be changed in future
+        for (var i = 0; i < AdminLogsTextEdit.ChildCount; i++)
+        {
+            if (AdminLogsTextEdit.GetChild(i) is VScrollBar scrollbar)
+            {
+                scrollbar.ValueTarget = float.PositiveInfinity;
+                break;
+            }
+        }
     }
 
     private bool ShouldShowType(AdminLogTypeButton button)