You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When determining the version number of Brave, the code following code is used:
However, this is invalid (at least on Windows) as this retrieves the version of the browser itself, not the version of Chromium used. Thus later, when this version number is used to look up the latest full version number from the JSON at this url, dict look up fails. Instead of using Brave's version number, the Chromium version number should be used, as these are not the same, for example:
The text was updated successfully, but these errors were encountered:
@leopph thank you for report. You are welcome to provide the command to determine chromium version of Brave/Opera and others.
To be honest Brave support have never been planned to determine chromium version by this block of code because its planned to use determined version of Brave to get Chromium version number from Brave Browser’s github https://github.com/brave/brave-browser/releases/tag/v1.61.109
So, you and everyone are also welcome to help to complete this work by providing a PR for this feature.
When determining the version number of Brave, the code following code is used:
However, this is invalid (at least on Windows) as this retrieves the version of the browser itself, not the version of Chromium used. Thus later, when this version number is used to look up the latest full version number from the JSON at this url, dict look up fails. Instead of using Brave's version number, the Chromium version number should be used, as these are not the same, for example:
The text was updated successfully, but these errors were encountered: