Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version number for Brave #650

Open
leopph opened this issue Dec 21, 2023 · 2 comments
Open

Incorrect version number for Brave #650

leopph opened this issue Dec 21, 2023 · 2 comments

Comments

@leopph
Copy link

leopph commented Dec 21, 2023

When determining the version number of Brave, the code following code is used:
brave-version-detection
However, this is invalid (at least on Windows) as this retrieves the version of the browser itself, not the version of Chromium used. Thus later, when this version number is used to look up the latest full version number from the JSON at this url, dict look up fails. Instead of using Brave's version number, the Chromium version number should be used, as these are not the same, for example:
brave-version-example

@aleksandr-kotlyar
Copy link
Collaborator

aleksandr-kotlyar commented Dec 22, 2023

@leopph thank you for report. You are welcome to provide the command to determine chromium version of Brave/Opera and others.

To be honest Brave support have never been planned to determine chromium version by this block of code because its planned to use determined version of Brave to get Chromium version number from Brave Browser’s github https://github.com/brave/brave-browser/releases/tag/v1.61.109

So, you and everyone are also welcome to help to complete this work by providing a PR for this feature.

@ndepaola
Copy link
Contributor

related: #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants