-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaults for Gong Fu style #19
Comments
Thanks for your feedback! |
Hi :) I was coming for the same issue! What about including both gongfucha and Western defaults and maybe an option to hide some of the options so that users can choose what they want to see when they open the app? |
I'm so used to Gong Fu style that I totally missed the western style option 😄 I will just update the values with the information from that guide, thanks. Just to add something more to @victornoel answer, to improve the UX even more, you could add an initial presentation and configuration wizard that asks the user to choose the style that they prefer. |
Good idea yep :) In any case this is not blocking at all, I will also add those data in the app manually and anyway, I expect to very quickly adapt them to my particular case. Great app! |
I like your ideas. The only issue I see is that the default teas would need to be marked as such internally. For older installations, I cannot reliably determine which ones were the defaults. This makes a migration tricky. I guess for app upgrades, I could treat all saved teas as "manually added" and disable both types of defaults. Another potential problem is that the defaults can be edited completely. Someone could take the default entry for green teas and change it to contain the information about some random specific tea they have. If they then disable the default entries, their specific tea will be hidden as well - possibly unexpected. Any thoughts on this? |
Hey @Sesu8642, sorry for the late answer :) Maybe an idea would be to separate the list of default entries from the list of entries used by the user. On upgrade, you could notify them the first time: "Hey, there are new default teas available that you may want to include in your everyday tea list, click here to see them. You can always find them later in the settings". Then you show a list (accessible via the notification or via the settings) where the user can select which entries they want to add to their everyday list. And we can forget about that idea of disabling entries that I proposed or the idea of editing defaults: the defaults are not editable but they are templates that can be added (copied!) to the user's tea list. |
I think the app is suggesting the wrong concentration value for every tea. For example green tea should be 5g / 100ml, instead the app says 0.5g / 100ml, which is just too few tea leaves.
Thanks for this very useful app.
The text was updated successfully, but these errors were encountered: