Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Hide Recommended Channels" now hides Followed Channels, "Hide Viewers Also Watch" now hides Recommended Channels #1061

Open
2 tasks done
mrtnxby opened this issue Aug 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mrtnxby
Copy link

mrtnxby commented Aug 14, 2024

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest nightly version

  • I am using the latest nightly version

What browsers are you seeing the problem on?

Chrome

Current Behavior

Hi guys. So I logged on to Twitch today and noticed something unusual as I usually have my 7TV settings set to hide "Recommended Channels" and "Viewers Also Watch".

The "Hide Recommend Channels" and "Hide Viewers Also Watch" toggles were hiding the wrong parts of the sidebar. I noticed this when I couldn't find my Followed Channels in the sidebar unless I minimised it, as that shows the icons at least.

Probable Cause

I am 99% sure that this issue is due to the addition of Instagram-like stories to Twitch. I've never seen this before and saw that this is at the top of the sidebar now above Followed Channels and below the "For You" text / open and close sidebar toggle.

My gut feeling is that this has shifted all of the elements in the sidebar downwards down by one (not sure of a better way to phrase this) and that means that the hide toggles in the extension are probably targeting the wrong elements or the one directly above them.

Hoping this is an easy enough fix and also perhaps an opportunity to add in a "Hide Stories" toggle also, but I realise this is a big ask. It might be worth checking other toggles as well that may have been affected.

Video

bugReport.mp4

Hide Recommended Channels ON + Hide Viewers Also Watch ON:

bug1

Hide Recommended Channels OFF + Hide Viewers Also Watch ON:

bug2

Hide Recommended Channels OFF + Hide Viewers Also Watch OFF:

bug3

Hide Recommended Channels ON + Hide Viewers Also Watch OFF:

bug4

Expected Behavior

  • Hide Recommended Channels should hide the correct element, "Recommend Channels" in the sidebar
  • Hide Viewers Also Watch should hide the correct element, "Viewers Also Watch" in the sidebar

Steps to Reproduce:

Open 7TV and select Site Layout > Sidebar and toggle on and off the following:

Hide Viewers Also Watch:

  • Viewers also watch is being shown despite being hide being enabled
  • When disabling, "Recommended Channels" is displayed

Hide Recommended Channels:

  • If Viewers Also Watch is disabled and Hide Recommended Channels is enabled, Recommend Channels is shown
  • At any point where Hide Recommend Channels is enabled, Followed Channels is hidden
  • Enabling both this and Hide Viewers Also Watch will result in only Viewers Also Watch being shown in the sidebar
@mrtnxby mrtnxby added the bug Something isn't working label Aug 14, 2024
@mrtnxby
Copy link
Author

mrtnxby commented Aug 14, 2024

Ah, my apologies, I just saw this was already reported yesterday: SevenTV/SevenTV#72

Closing on that basis, but feel free to use this if it's useful in any way.

@mrtnxby mrtnxby closed this as completed Aug 14, 2024
@lennartkloock
Copy link
Member

Was this ever fixed?

@lennartkloock lennartkloock reopened this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants