Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't load custom profile list correctly #27

Open
nanikit opened this issue Dec 26, 2021 · 2 comments
Open

It doesn't load custom profile list correctly #27

nanikit opened this issue Dec 26, 2021 · 2 comments
Assignees

Comments

@nanikit
Copy link

nanikit commented Dec 26, 2021

Steps to reproduce

  1. Install SaberTailer v3.4.1 on beat saber 1.18.3 (I know I should test against the latest version, but I haven't migrated to the latest beat saber yet. If it was fixed, feel free to close.)
  2. Save any custom profile as different name in SaberTailor settings page.
  3. Apply the setting(restart beat saber).
  4. Open custom profile setting page again and tap custom profile name.

Expected behavior

It should show two profiles.

Actual behavior

It shows only one profile. I could correct it by saving another custom profile.

Just thought

It may need to improve UI.

  • It can save profile immediately after input the name.
  • It can load profile immediately after select the profile.
@Shadnix-was-taken
Copy link
Owner

Shadnix-was-taken commented Dec 26, 2021

Hi there and thanks for reporting an issue. This sounds like a new issue that wasn't touched in the 3.5.0 release. If you can, please also test with the latest release. It should work on Beat Saber 1.18.3.

I'll try to take a look at the problem within the next couple of days.

One question, in order to avoid a possible confusion: When you save your first ever profile, the list should only show one entry, since it is the first time time you actually added one. The list up until that point should be "NONE AVAILABLE". After that, you should have one entry. Then additional entries for every new profile you save. Was this maybe the behaviour you observed? Or is the profile list also faulty for every additional saved profile?

Regarding the "load on select", I think I'd prefer to keep this as a two step process. Keep in mind that loading a profile will override the current active settings.

For the settings, I'd agree, although that part would need a cancel action in that case, I think. In general, I'd agree that the SaberTailor UI needs a major overhaul at this point. This is on my ToDo list, but currently held back due to a lack of enough spare time on my part.

@Shadnix-was-taken Shadnix-was-taken self-assigned this Dec 26, 2021
@nanikit
Copy link
Author

nanikit commented Dec 26, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants