Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the design #1

Open
Shanky1001 opened this issue Sep 5, 2023 · 19 comments
Open

Improve the design #1

Shanky1001 opened this issue Sep 5, 2023 · 19 comments
Assignees
Labels
good first issue Good for newcomers hactoberfest Hactoberfest2023 help wanted Extra attention is needed

Comments

@Shanky1001
Copy link
Owner

Try to improve the UI of the pages

@Shanky1001 Shanky1001 added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 5, 2023
@Shanky1001 Shanky1001 added the hactoberfest Hactoberfest2023 label Sep 23, 2023
@Sarvaswa-Mohata
Copy link

Hi, I would like to get this issue assigned to me

@Shanky1001
Copy link
Owner Author

Shanky1001 commented Sep 26, 2023

Hi, I would like to get this issue assigned to me

Sure @Sarvaswa-Mohata , Good luck

@Sarvaswa-Mohata
Copy link

Hi, I made changes in a figma file for the landing page. I am attaching a screenshot of the same below :
Group 4

If you approve of the changes, I'll proceed with coding the same.

@Shanky1001
Copy link
Owner Author

Shanky1001 commented Sep 29, 2023

@Sarvaswa-Mohata

Form is looking good. Please provide the figma link as the place for the generated image is not getting clear to me from this image.

I have only a few suggestions -

  • I guess you missed the prompt generate button on the second input field.
  • background image is taking too much of focus rather than form so managing that will be great.

@Sarvaswa-Mohata
Copy link

Hi, @Shanky1001
I was planning to do it this way:
image

where if a person hovers over the image, he/she can download it. So, the car image is not a background image, rather it is assumed to be a generated image based on the given prompt.

I am also attaching the figma file below. Apart from this I plan on showing a set of similar images on the sidebar, but that totally depends on whether your ai generator can handle it. A design implementation of the same can be seen if you open up the figma file. Looking forward to your comments :)

Link to the figma file

@Shanky1001
Copy link
Owner Author

hi @Sarvaswa-Mohata ,

looks good to me. Go ahead, give it a try.

@parinitapatil
Copy link

parinitapatil commented Oct 2, 2023

@Shanky1001, I recommend implementing UI improvements, particularly with regards to padding and borders. Let me know if you need any help. Kind regards.

@Shanky1001
Copy link
Owner Author

@parinitapatil What kind of UI improvements regarding padding and border, you are suggesting?
if you can provide a bit more info on that it will be helpful in understanding what exactly you want to do.

@parinitapatil
Copy link

@parinitapatil What kind of UI improvements regarding padding and border, you are suggesting? if you can provide a bit more info on that it will be helpful in understanding what exactly you want to do.

I have identified areas that require improvement:

  1. The buttons need to be resized.
  2. The colors are too dull.
  3. The input labels are not aligned with the UI.

@Shanky1001
Copy link
Owner Author

@parinitapatil Okay sounds good, Give it a try.

but in my opinion, it will be better if you and @Sarvaswa-Mohata can collaborate over his figma and implement the design together.

@parinitapatil
Copy link

@parinitapatil Okay sounds good, Give it a try.

but in my opinion, it will be better if you and @Sarvaswa-Mohata can collaborate over his figma and implement the design together.

Screenshot 2023-10-02 121727
I hope this is helpful to you.

@Shanky1001
Copy link
Owner Author

@parinitapatil Okay sounds good, Give it a try.

but in my opinion, it will be better if you and @Sarvaswa-Mohata can collaborate over his figma and implement the design together.

Screenshot 2023-10-02 121727
I hope this is helpful to you.

Yeah, this looks a bit more intuitive. let's get it done.
@Sarvaswa-Mohata @parinitapatil .
We can later have other design changes if required.

@parinitapatil
Copy link

Sir, do you happen to have any remaining Hacktoberfest projects? It's proving to be quite challenging to locate them.

@Shanky1001
Copy link
Owner Author

Sir, do you happen to have any remaining Hacktoberfest projects? It's proving to be quite challenging to locate them.

Yeah, you can try this project Apex Legend Clone
you can also raise issues on your own if find any.

Or you can search hacktoberfest keyword on github search and filter it using tags, you will get the repos. Just make sure they are in hacktoberfest2023.

@Sarvaswa-Mohata
Copy link

Hi @parinitapatil, do you wanna collaborate over this project?

@parinitapatil
Copy link

yeh sure!!

@Sarvaswa-Mohata
Copy link

@parinitapatil can we connect via discord?, I think it would be better to communicate over there.

@GauraviVeling
Copy link

Hello. Please can you assign this issue to me. I would like contributing to this issue.

@Shanky1001
Copy link
Owner Author

Hello. Please can you assign this issue to me. I would like contributing to this issue.

sure, go ahead and fix the issue. It will be assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hactoberfest Hactoberfest2023 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants