From 7e40db52e0489984768b8d3d8bf629cea7954d83 Mon Sep 17 00:00:00 2001 From: Henrique Holtz Date: Sun, 21 Jul 2024 09:04:09 -0300 Subject: [PATCH 1/2] feat: Adding manual job "Postman collection validations" for dev environment --- .github/workflows/postman-collection.yml | 17 ++++++++++ ShareBook API - Tests.postman_collection.json | 33 +++++++++++++++---- 2 files changed, 44 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/postman-collection.yml diff --git a/.github/workflows/postman-collection.yml b/.github/workflows/postman-collection.yml new file mode 100644 index 00000000..07f7d8dd --- /dev/null +++ b/.github/workflows/postman-collection.yml @@ -0,0 +1,17 @@ +name: Postman collection validations + +on: + workflow_dispatch: + +jobs: + run-postman-collection-dev: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@master + - name: Postman collection - Development environment + uses: matt-ball/newman-action@master + with: + collection: ShareBook API - Tests.postman_collection.json + delayRequest: 2000 + envVar: '[{ "key": "sharebookUrl", "value": "https://dev.sharebook.com.br/" }, { "key": "sharebookEmail", "value": "raffacabofrio@gmail.com" }, { "key": "sharebookPassword", "value": "123456" }]' +# TODO: Add a job for production environment which must get username and password from github secrets diff --git a/ShareBook API - Tests.postman_collection.json b/ShareBook API - Tests.postman_collection.json index c40a2f37..16cf565c 100644 --- a/ShareBook API - Tests.postman_collection.json +++ b/ShareBook API - Tests.postman_collection.json @@ -1,6 +1,6 @@ { "info": { - "_postman_id": "f7913a70-c6f4-4636-86a3-347efa40216f", + "_postman_id": "4a0b707e-0039-4e40-8fbe-17d85d626c63", "name": "ShareBook API - Tests", "schema": "https://schema.getpostman.com/json/collection/v2.1.0/collection.json", "_exporter_id": "29881360" @@ -583,7 +583,7 @@ ], "body": { "mode": "raw", - "raw": "{\r\n\t\"email\": \"raffacabofrio@gmail.com\",\r\n\t\"password\": \"123456\"\r\n}", + "raw": "{\r\n\t\"email\": \"{{sharebookEmail}}\",\r\n\t\"password\": \"{{sharebookPassword}}\"\r\n}", "options": { "raw": { "language": "json" @@ -891,13 +891,34 @@ "type": "text/javascript", "packages": {}, "exec": [ + "\r", + "console.log('Setting up...')\r", + "\r", "const sharebookUrlName = 'sharebookUrl'\r", - "if (pm.globals.has(sharebookUrlName))\r", - " console.log(`Running using ${pm.globals.get(sharebookUrlName)}`)\r", + "if (pm.environment.has(sharebookUrlName))\r", + " console.log(`Running with ${sharebookUrlName} ${pm.environment.get(sharebookUrlName)}`)\r", "else {\r", " const fallbackUrl = 'https://dev.sharebook.com.br/'\r", - " console.log(`The global variable ${sharebookUrlName} isn't found. Using ${fallbackUrl} as default value... `)\r", - " pm.globals.set(sharebookUrlName, fallbackUrl)\r", + " console.log(`The environment variable ${sharebookUrlName} isn't found. Using ${fallbackUrl} as default value... `)\r", + " pm.environment.set(sharebookUrlName, fallbackUrl)\r", + "}\r", + "\r", + "const sharebookEmailName = 'sharebookEmail';\r", + "if (pm.environment.has(sharebookEmailName))\r", + " console.log(`Running with ${sharebookEmailName} : ${pm.environment.get(sharebookEmailName)}`)\r", + "else {\r", + " const fallBackEmail = 'raffacabofrio@gmail.com'\r", + " console.log(`The environment variable ${sharebookEmailName} isn't found. Using ${fallBackEmail} as default value... `)\r", + " pm.environment.set(sharebookEmailName, fallBackEmail)\r", + "}\r", + "\r", + "const sharebookPasswordName = 'sharebookPassword';\r", + "if (pm.environment.has(sharebookPasswordName))\r", + " console.log(`Running with ${sharebookPasswordName} : ${pm.environment.get(sharebookPasswordName)}`)\r", + "else {\r", + " const fallBackPassword = '123456'\r", + " console.log(`The environment variable ${sharebookPasswordName} isn't found. Using ${fallBackPassword} as default value... `)\r", + " pm.environment.set(sharebookPasswordName, fallBackPassword)\r", "}" ] } From c1daf7a1e247b11e6b08ea712606c9485071c072 Mon Sep 17 00:00:00 2001 From: Henrique Holtz Date: Sat, 28 Sep 2024 13:51:34 -0300 Subject: [PATCH 2/2] fix: EmailService => Using correctly the config "EmailSettings:UseSSL" from appsettings --- ShareBook/ShareBook.Service/Email/EmailService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShareBook/ShareBook.Service/Email/EmailService.cs b/ShareBook/ShareBook.Service/Email/EmailService.cs index da2a9f60..68e55c96 100644 --- a/ShareBook/ShareBook.Service/Email/EmailService.cs +++ b/ShareBook/ShareBook.Service/Email/EmailService.cs @@ -157,7 +157,7 @@ public async Task> ProcessBounceMessagesAsync() return log; } - await _imapClient.ConnectAsync(_settings.HostName, _settings.ImapPort, true); + await _imapClient.ConnectAsync(_settings.HostName, _settings.ImapPort, _settings.UseSSL); await _imapClient.AuthenticateAsync(_settings.Username, _settings.Password); var bounceFolder = await GetBounceFolderAsync();