We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, I think the code in TypeExtensions.cs
public static bool IsCustomType(this Type? type) { var builtInTypes = new[] { typeof(string), typeof(decimal), typeof(DateTime), typeof(DateTimeOffset), typeof(TimeSpan), typeof(Guid) }; return type != null && type.IsClass && !type.IsEnum && !type.IsValueType && !type.IsPrimitive && !builtInTypes.Contains(type); }
can be simplified by changing the method to:
public static bool IsCustomType(this Type? type) { return type != null && type.IsClass && !type.IsEnum && !type.IsValueType && !type.IsPrimitive && type != typeof(string); }
you can check it just with unit-test below (i was using NUnit):
[TestCase(typeof(DateTime))] [TestCase(typeof(DateTimeOffset))] [TestCase(typeof(TimeSpan))] [TestCase(typeof(Guid))] [TestCase(typeof(decimal))] [TestCase(typeof(string))] [TestCase(null)] public void TypeIsCustom(Type? type) { Assert.IsFalse( type != null && type.IsClass && !type.IsEnum && !type.IsValueType && !type.IsPrimitive && type != typeof(string)); }
The text was updated successfully, but these errors were encountered:
@Tihomirov-Vasiliy interesting, I just added some tests to test the IsCustomType extension method. Feel free to open a PR!
IsCustomType
Sorry, something went wrong.
@mvdgun I've just created the pull request #32, feel free to review!
Moved this issue to the v2.0 milestone
Successfully merging a pull request may close this issue.
Hi, I think the code in TypeExtensions.cs
can be simplified by changing the method to:
you can check it just with unit-test below (i was using NUnit):
The text was updated successfully, but these errors were encountered: