Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchDagInsCmd线程处理continue cmd异常导致task在Precheck时block状态无法放开 #46

Closed
lxn3642 opened this issue Dec 15, 2023 · 4 comments · Fixed by #48
Closed

watchDagInsCmd线程处理continue cmd异常导致task在Precheck时block状态无法放开 #46

lxn3642 opened this issue Dec 15, 2023 · 4 comments · Fixed by #48

Comments

@lxn3642
Copy link

lxn3642 commented Dec 15, 2023

parseCmd：
WechatIMG6450

precheck逻辑：
image

image

综上：
watchDagInsCmd线程在处理continue命令时，针对precheck阻塞场景，无法使任务继续执行，请作者大大看下~

image
本地修改后可正常处理该场景
@lxn3642
Copy link
Author

lxn3642 commented Dec 16, 2023 •
edited
Loading

另一个推动流程的方法就是在执行continue命令前，手动update dag实例用于阻塞该任务的变量，该方法貌似没有封装，需要自己写，如图：
image

@ShiningRush
Copy link
Owner

感谢反馈，我现在看看

@ShiningRush ShiningRush mentioned this issue Dec 16, 2023
Merged
@ShiningRush
Copy link
Owner

hi, 我已经在#48 修复了该问题，这里对于需要Continue的Task其实我们不应该再次block。目前这个判断做的比较粗糙，如果存在多个block条件的话，可能还需要把上次造成Block的PreCheckName给记录下来，否则会导致其他Block的PreCheck也没法执行，不过我们先这样吧，等有需求再补充

@lxn3642
Copy link
Author

lxn3642 commented Dec 18, 2023

感谢更新，continue 命令在该场景下可以正常运行了

@lxn3642 lxn3642 closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: should not block a continued task ShiningRush/fastflow
2 participants
@ShiningRush @lxn3642