Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a reference CobaltCore.dll assembly for use in Github actions #51

Open
Shockah opened this issue Jan 11, 2024 · 4 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@Shockah
Copy link
Owner

Shockah commented Jan 11, 2024

No description provided.

@Shockah Shockah added the enhancement New feature or request label Jan 11, 2024
@Shockah Shockah added this to the 1.0.0+ milestone Jan 11, 2024
@Fayti1703
Copy link
Collaborator

Fayti1703 commented Jan 15, 2024

See branch fayti1703/reference-assembly.

Current status:

  • We have a .csproj to create a reference assembly from a CobaltCore install. (Though this is slightly hacky, I'd love to not pull in the entire C# build config and instead just the stuff for PackageReference and running MSBuild tasks)
  • We have a pre-built reference assembly in Git LFS storage. GitHub has install instructions for LFS -- might be worth adding those to the README (along with instructions on how to rebuild the assembly, which is just 'run this target in CobaltCoreReference').
  • The reference assembly is currently not used in building Nickel.

@Shockah
Copy link
Owner Author

Shockah commented Jan 15, 2024

The reference assembly is currently not used in building Nickel.

I think that's a good thing, actually. It could be potentially used as a fallback, but being able to jump to the concrete definitions of CobaltCore members is too useful to just switch altogether.

@Shockah
Copy link
Owner Author

Shockah commented Jan 15, 2024

I guess it actually has to be the fallback for it to work with Github actions.

@Fayti1703
Copy link
Collaborator

Yup -- at minimum in CI we'd need to use the stored assembly rather than a live-generated one.
Though that can also be done by setting an environment variable and doing MSBuild-conditionals based on that.

@Shockah Shockah modified the milestones: 1.0.0+, 1.1.0+ Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants