Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra quoted period in abbreviations for some locales, eg Mio'.' #95

Open
spy-v2 bot opened this issue Dec 19, 2022 · 3 comments
Open

Extra quoted period in abbreviations for some locales, eg Mio'.' #95

spy-v2 bot opened this issue Dec 19, 2022 · 3 comments
Assignees
@dvincelli

Comments

@spy-v2
Copy link

spy-v2 bot commented Dec 19, 2022 •
edited by dvincelli
Loading

While testing we found some values being formatted with unexpected characters:

If I call

condenseCurrency(259000000, 'de', 'GBP', {maxPrecision: 2})
I get as a result

"259 Mio'.' £"
and I was expecting

"259 Mio. £"

Actual

Expected
dvincelli added a commit that referenced this issue Dec 19, 2022
@dvincelli
Remove extra quotes around . in number abbreviations
e948b16 
See #95
@dvincelli dvincelli self-assigned this Dec 19, 2022
dvincelli added a commit that referenced this issue Dec 19, 2022
@dvincelli
Remove extra quotes around . in number abbreviations
483f3a0 
See #95
@dvincelli dvincelli mentioned this issue Dec 19, 2022
Open
@dvincelli dvincelli changed the title Extra quoted period in abbreviations for some locales, eg Mio'..' Extra quoted period in abbreviations for some locales, eg Mio'.' Dec 19, 2022
dvincelli added a commit that referenced this issue Dec 19, 2022
@dvincelli
Remove extra quotes around . in number abbreviations
9190b9c 
See #95
@zbathen
Copy link

zbathen commented Oct 23, 2024

Looks like there is an approved PR with a fix for this problem -- any reason why it hasn't been submitted? Would be great to get it in!

@drivasperez
Copy link

I would also love to get this fix merged!

@asmockler
Copy link
Contributor

cc @thetrevorharmon want to merge #95?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvincelli dvincelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@drivasperez @dvincelli @asmockler @zbathen