Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrector deprecations from Rubocop #368

Closed
MikeMcQuaid opened this issue Aug 19, 2024 · 4 comments · Fixed by #378
Closed

Corrector deprecations from Rubocop #368

MikeMcQuaid opened this issue Aug 19, 2024 · 4 comments · Fixed by #378

Comments

@MikeMcQuaid
Copy link 

Linting and autocorrecting 62 files with 19 linters (12 autocorrectable)...
vendor/ruby/ruby/3.3.0/gems/erb_lint-0.6.0/lib/erb_lint/corrector.rb:20: warning: `Corrector.new` with corrections is deprecated.
See https://docs.rubocop.org/rubocop/v1_upgrade_notes.html

vendor/ruby/ruby/3.3.0/gems/rubocop-1.65.1/lib/rubocop/cop/legacy/corrector.rb:22: warning: `Corrector#corrections` is deprecated. Open an issue if you have a valid usecase.
See https://docs.rubocop.org/rubocop/v1_upgrade_notes.html

Details are in https://docs.rubocop.org/rubocop/v1_upgrade_notes.html#detailed-api-changes
@Earlopain Earlopain mentioned this issue Sep 18, 2024
Merged
Earlopain added a commit to Earlopain/erb_lint that referenced this issue Sep 20, 2024
@Earlopain
Don't use deprecated corrector apis
7fddf50 
Closes Shopify#368

This is pretty much just a compatibility layer in itself.

Cops here are still declared with the old style (`autocorrect` instance method for example)
but rewriting that all is not trivial and also works just fine
@Earlopain Earlopain mentioned this issue Sep 20, 2024
Merged
@docljn
Copy link

docljn commented Oct 28, 2024

Delighted to see this is in hand. Thank you! I'm trying to convince my colleagues to add to our linter collection, but without -a It's going to be a very hard sell.

@thomaswitt
Copy link

Me too, I would love to see a release soon. The warnings are really annoying.

etiennebarrie pushed a commit to Earlopain/erb_lint that referenced this issue Jan 7, 2025
@Earlopain @etiennebarrie
Don't use deprecated corrector apis
733c51d 
Closes Shopify#368

This is pretty much just a compatibility layer in itself.

Cops here are still declared with the old style (`autocorrect` instance method for example)
but rewriting that all is not trivial and also works just fine
etiennebarrie pushed a commit that referenced this issue Jan 7, 2025
@Earlopain
Don't use deprecated corrector apis (#378)
6280c79 
Closes #368

This is pretty much just a compatibility layer in itself.

Cops here are still declared with the old style (`autocorrect` instance method for example)
but rewriting that all is not trivial and also works just fine
@etiennebarrie
Copy link
Member

Sorry about that, thanks to @Earlopain for the fixes. I just released them.

@docljn
Copy link

docljn commented Jan 13, 2025

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve autocorrect deprecations Earlopain/erb_lint
4 participants
@etiennebarrie @thomaswitt @MikeMcQuaid @docljn