Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty headers export #49

Open
ramiroazar opened this issue May 28, 2024 · 0 comments
Open

Empty headers export #49

ramiroazar opened this issue May 28, 2024 · 0 comments

Comments

@ramiroazar
Copy link

We often look at the demo store for reference.

I'm having trouble understanding the current caching strategy.

I can see that routes and loaders share headers.

export const headers = routeHeaders;

However, the headers export doesn't seem to be doing anything, since headers were removed from loaders.

Shopify/hydrogen#991

Can someone please explain the reasoning behind that pull request a bit more?

Cart requests are deferred and cart components are suspended, but are they still at risk of incorrectly getting cached?

cart: cart.get(),

function CartDrawer({isOpen, onClose}: {isOpen: boolean; onClose: () => void}) {

function CartCount({

Is there some way of leveraging route and/or loader caching for improved performance without interfering with the cart components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant