Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection in URL #40

Open
cerenervia opened this issue Apr 12, 2022 · 5 comments
Open

Redirection in URL #40

cerenervia opened this issue Apr 12, 2022 · 5 comments

Comments

@cerenervia
Copy link

Lighthouse seems to make redirection for each tested URL.
Is it normal? Are results altered by this waring?

Screnshot attached:
image

@vfonic
Copy link

vfonic commented May 30, 2022

I believe this is normal, because we need to somehow set the theme ID with the changes from the repo.
We can achieve that with preview_theme_id parameter that then redirects to preview of the theme from the repo.

@joshistoast
Copy link

Running into this now, @vfonic isn't the problem because of the preview_theme_id parameter? Or are you suggesting we can prevent a redirect by manually including that parameter in the theme url?

@vfonic
Copy link

vfonic commented Aug 9, 2024

When you say "theme url" do you mean "store url"?

In order to use the theme with your latest changes so that you can test it with Lighthouse, you need to:

  1. Upload the theme to the store

  2. Instruct the browser to use that theme

  3. is done automatically

  4. is done via preview_theme_id parameter in the link to the store page. This is stored in session or cookie and that's how this works.
    I don't think there's a way to prevent the page redirect because we'd need a very low level access to achieve that.

@joshistoast
Copy link

Not sure how those first 3 steps help, the lighthouse ci action automatically generates this theme id and uses it when requesting to run.

I don't think there's a way to prevent the page redirect

So we should all just expect less than helpful and erroneous performance scores?

@vfonic
Copy link

vfonic commented Aug 12, 2024

No idea. I'm not working for Shopify. I'm just trying to be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants