Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to run a build before this action does the theme push? #85

Closed
shawngrona opened this issue Jul 24, 2024 · 3 comments
Closed

Any way to run a build before this action does the theme push? #85

shawngrona opened this issue Jul 24, 2024 · 3 comments

Comments

@shawngrona
Copy link

It seems like this action is designed for liquid only templates? When I look at the source code for entrypoint.sh it does a theme push, does anyone have any recs to run a build before the theme push runs? That way we can build up the js and any other auto-generated templating stuff

@shawngrona
Copy link
Author

shawngrona commented Jul 24, 2024

alternatively, have you found another lighthouse action that will work with the shopify password?

[edit] i may have to do this custom, spinning up my own docker container, build, push development theme, then use a package like lighthouse with the Puppeteer auth

@charlespwd
Copy link
Collaborator

You can run as many GitHub actions as you want prior to running this one.

This one also has a theme_root property that you can set to point to a different folder prior to doing the uploading.

What you'll need to write depends on your particular situation.

What's preventing you from doing a npm run build in a previously defined step?

@charlespwd
Copy link
Collaborator

(Closing as this is not an issue with this repo).

@charlespwd charlespwd closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants