Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Failing with CLI 3.70.0 #87

Closed
jacobkossman opened this issue Nov 23, 2024 · 8 comments
Closed

Action Failing with CLI 3.70.0 #87

jacobkossman opened this issue Nov 23, 2024 · 8 comments
Labels
Severity: 2 High Severity

Comments

@jacobkossman
Copy link

Recently, something has changed and my CI has been failing with this action. I think it has something to do with the 3.70.0 CLI as this is the first time i'm seeing the "Release notes for..." line.

An action run 2 days ago worked but any action after that with lighthouse been failing.

==============================
Configuring shopify CLI
Will run Lighthouse CI on https://***
==============================
Creating development theme


╭─ info ───────────────────────────────────────────────────────────────────────╮
│                                                                              │
│  Release notes for 3.70.0                                                    │
│                                                                              │
│  Release highlights:                                                         │
│                                                                              │
│    - Ruby is no longer required                                              │
│    - The `theme dev` command is more stable                                  │
│    - A new notification system (expect more of these!)                       │
│    - Numerous bug fixes                                                      │
│                                                                              │
│                                                                              │
│                                                                              │
│  Read the complete release notes [1]                                         │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯
[1] https://github.com/Shopify/cli/releases/tag/3.70.0

{"theme":{"id":[13]([REDACTED])9663769781,"name":"Development (9876eb-c7985bd11eca)","role":"development","shop":"***","editor_url":"https://***/admin/themes/139663769781/editor","preview_url":"https://***?preview_theme_id=139663769781"}}
parse error: Invalid numeric literal at line 1, column 7

Any ideas? Thanks.

@jacobkossman
Copy link
Author

Confirmed to be an issue with CLI 3.70.0

Forked the repo with an update to the Docker: jacobkossman@17521a2 to pin the CLI version to 3.69.4 and the action now runs properly when pointing to my forked repo.

@ChalzZy
Copy link

ChalzZy commented Nov 25, 2024

Can confirm the same issue here

@charlespwd
Copy link
Collaborator

Appears to be fixed in https://github.com/Shopify/cli/pull/4910/files and will appear in the next CLI release.

@gonzaloriestra
Copy link

The notification has been removed, so it should work again with 3.70.0. Sorry for the inconvenience!

@kmishal
Copy link

kmishal commented Nov 27, 2024

@charlespwd any idea when the next release will happen that will fix the action?

@gonzaloriestra
Copy link

@kmishal it should work now, have you tried again?

@kmishal
Copy link

kmishal commented Nov 27, 2024

@kmishal it should work now, have you tried again?

Hey @gonzaloriestra Its resolved. Thank you! 🥳

@ChalzZy
Copy link

ChalzZy commented Nov 27, 2024

+1 working again. Thanks team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: 2 High Severity
Projects
None yet
Development

No branches or pull requests

5 participants