[Bug Fix]: Adjust tooltip position on StackedAreaChart when page is scrolled #1595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Fixes: https://github.com/Shopify/core-issues/issues/60331
Issue
Received a possible bug that the
ReturningCustomerRate
card was not rendering a tooltip.Screen.Recording.2023-09-22.at.2.32.57.PM.mov
ReturningCustomerRate
card is displayed (currently the only StackedArea chart available).Does this close any currently open issues?
Fixes https://github.com/Shopify/core-issues/issues/60331
What do the changes look like?
Note: Tested in Storybook - need to confirm this fix works once updated and available in web.
Screen.Recording.2023-09-29.at.12.43.20.PM.mov
Extra Thoughts
There are a few similar functions across the charts now to adjust the position of the tooltip in various scenarios. I was thinking it might be worth combining these into one function to adjust the positioning that (ideally) works for all of the charts.
Happy to look into this further if there's consensus this needs to happen.
Storybook link
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package