[UA][Polaris-Viz]: Fixed Tooltip Positioning When There Are Many Bars #1620
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
precillieo
requested review from
envex,
JeremyLudwigDev,
blboyle,
kvendrik and
philschoefer
|
@precillieo can you describe the steps needed to tophat this? Thanks! |
I updated the PR description! Thank you for pointing it out🙏 |
envex
requested changes
Jan 18, 2024
envex
reviewed
Jan 18, 2024
| @@ -79,7 +79,7 @@ export function getAlteredVerticalBarPosition( | |||
| } | |||
| } | |||
| } else { | |||
| y = 0; | |||
| y = props.dimensions?.y ?? 0; | |||
There was a problem hiding this comment.
Can we also clamp this value so if it's at the top of the page it "sticks" in place?
JeremyLudwigDev
approved these changes
Jan 18, 2024
envex
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
I fixed the tooltip issue in Vertical BarChart. It incorrectly jumps to the top of the page when there are many bars. Why?
getAlteredVerticalBarPositionfunction function sets itsyvalue to0, whenprops.isPerformanceImpactedistrue(truewhen there are more than60bars).I solved this by passing down the
dimensionsprop inChartofVerticalBarChart(it determines the position of the container on a page, with scrollY applied), through theTooltipWrappercomponent togetAlteredVerticalBarPosition, then using itsyvalue when performance is impacted.Does this close any currently open issues?
Fix https://github.com/Shopify/core-issues/issues/64419
What do the changes look like?
Storybook link
Storybook link
Chromatic Link
Tophat Instructions
Series Colors Up To Sixteen.Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package