Limit Donut legend to 50% of chart width #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
envex
force-pushed
the
envex/donut-legends
branch
2 times, most recently
from
d60e7b6 to
8dff0e1
Compare
envex
force-pushed
the
envex/donut-legends
branch
2 times, most recently
from
f0a4b1b to
efc72ef
Compare
|
@michaelnesen Can you look over this when you have some time, you have the most context around |
michaelnesen
approved these changes
Apr 2, 2024
| @@ -2,4 +2,5 @@ | |||
| width: 100%; | |||
| border-collapse: separate; | |||
| border-spacing: 0 10px; | |||
| table-layout: fixed; | |||
There was a problem hiding this comment.
With table-layout: fixed i'm seeing some extra spacing in the table. It's only really visible with the legend positioned to the left as it pushes the viz to the right
Perhaps adding a width to the trend indictor table cell could fix this?
There was a problem hiding this comment.
Yeah, fixed makes all the cells fill the space unless they have an explicit width. I'll add it!
envex
force-pushed
the
envex/donut-legends
branch
from
efc72ef to
c3a5eac
Compare
envex
force-pushed
the
envex/donut-legends
branch
from
c3a5eac to
e371426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Limit the
DonutChartlegends from taking up more than 50% of the chart space.Does this close any currently open issues?
https://github.com/Shopify/core-issues/issues/68612
What do the changes look like?
Storybook link
https://6062ad4a2d14cd0021539c1b-xydvmesepk.chromatic.com/?path=/story/polaris-viz-charts-donutchart--truncated-legends
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package