Add group sum labels for the horizontal stacked bar #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
envex
reviewed
Mar 1, 2024
| @@ -147,6 +185,17 @@ export function HorizontalStackedBars({ | |||
| </Fragment> | |||
| ); | |||
| })} | |||
| {!isSimple && ( | |||
There was a problem hiding this comment.
Just spit balling here, I wonder if we still want a way to show/hide labels even for non-simple charts.
What do you think?
There was a problem hiding this comment.
@envex I do think we should be able to hide these labels. If the x-axis labels are displayed and we also have the group labels, it becomes overwhelming.
I will look into adding this functionality.
There was a problem hiding this comment.
@envex I added an option to the Theme that supports hiding group labels.
envex
approved these changes
Mar 4, 2024
envex
requested changes
Mar 4, 2024
There was a problem hiding this comment.
Sorry, It looks like a UI test was broken: https://shopify.chromatic.com/test?appId=6062ad4a2d14cd0021539c1b&id=65e24099b59ea560c35266e0
Can you take a peek?
rita-morozova
force-pushed
the
rita-morozova/add-group-sum-labels-for-stacked-bar
branch
from
af48f49 to
208b1c1
Compare
rita-morozova
force-pushed
the
rita-morozova/add-group-sum-labels-for-stacked-bar
branch
from
208b1c1 to
61df7a0
Compare
envex
approved these changes
Mar 4, 2024
rita-morozova
deleted the
rita-morozova/add-group-sum-labels-for-stacked-bar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
While transitioning our reports to MAAPI, we needed to update the stacked horizontal bar chart to support group sum labels, a similar approach to what we have in the Simple Bar Chart.
Does this close any currently open issues?
Resolves https://github.com/Shopify/core-issues/issues/67692
What do the changes look like?
In our planned usage of this chart for UA, we will not display X-axis labels with vertical grid lines.
Storybook link
Stacked Horizontal Bar
Stacked Horizontal Bar With No Group Labels
Simple Bar Chart
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package