From 58b5605b2d6a194387c26dd77922f626c7977906 Mon Sep 17 00:00:00 2001 From: Matt Elphick Date: Tue, 19 Mar 2024 09:56:26 +0000 Subject: [PATCH 1/2] fix: Expose Uplift theme We need to be able to have two variations of the Uplift theme: a standard and a "ghost" version. As such we can't simply overwrite properties of the theme as shown [here](https://polaris-viz.shopify.com/iframe.html?viewMode=docs&id=shared-themes-customizing--page#titleAnchor-81). Instead we need to define multiple themes as shown [here](https://polaris-viz.shopify.com/iframe.html?viewMode=docs&id=shared-themes-customizing--page#titleAnchor-86). To do this with Uplift as a base however, the theme needs to be exposed, which it currently isn't. In theory this can be retrieved via the `@shopify/polaris-viz-core`, but the same is true for the other themes and that would mean that dependency becomes a direct dependency of the project, rather than through `@shopify/polaris-viz`. Instead, it's proposed here that we just expose the Uplift theme in a manner similar to the others. --- packages/polaris-viz/src/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/polaris-viz/src/index.ts b/packages/polaris-viz/src/index.ts index d08c010a4..cc3b02a8f 100644 --- a/packages/polaris-viz/src/index.ts +++ b/packages/polaris-viz/src/index.ts @@ -40,6 +40,7 @@ export { DEFAULT_THEME as PolarisVizDefaultTheme, LIGHT_THEME as PolarisVizLightTheme, PRINT_THEME as PolarisVizPrintTheme, + UPLIFT_THEME as PolarisUpliftTheme, } from './constants'; export type { From 35bc7435c250cee4553edd3d3e346099850d862b Mon Sep 17 00:00:00 2001 From: Matt Elphick Date: Tue, 19 Mar 2024 10:05:42 +0000 Subject: [PATCH 2/2] docs: Update Changelog --- packages/polaris-viz/CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/polaris-viz/CHANGELOG.md b/packages/polaris-viz/CHANGELOG.md index 531fcb304..a5e07c1bf 100644 --- a/packages/polaris-viz/CHANGELOG.md +++ b/packages/polaris-viz/CHANGELOG.md @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). - +## Unreleased + +### Changed + +- Added `PolarisUpliftTheme` to better support extending the Uplift theme. ## [11.0.0] - 2024-03-12