Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add filter" in Filters component button text not overridable #12758

Closed
csm-genov opened this issue Oct 7, 2024 · 3 comments
Closed

"Add filter" in Filters component button text not overridable #12758

csm-genov opened this issue Oct 7, 2024 · 3 comments
Labels
Bug Something is broken and not working as intended in the system.

Comments

@csm-genov
Copy link

Summary

I was unable to find a way to override the "Add filters +" button text in the Polaris component.

Could this be added as a prop or is there some workaround that I cannot find?

Expected behavior

This should be an adjustable value

Actual behavior

Wrap animated gifs/videos in a details tag:

Summary of your gif(s) Description of what the gif shows

Steps to reproduce

Link to sandbox
1.
2.
3.

Are you using React components?

Yes

Polaris version number

No response

Browser

No response

Device

No response

@csm-genov csm-genov added Bug Something is broken and not working as intended in the system. untriaged labels Oct 7, 2024
@csm-genov csm-genov changed the title "Add filter +" "Add filter" in Filters component button text not overridable Oct 7, 2024
@chloerice
Copy link
Member

chloerice commented Oct 8, 2024

Hey @csm-genov! 👋🏽 Can you share context on why you need to customize this button text? We're making changes to this component, so any color you can add about your use case would be helpful to understand the current gap.

@csm-genov
Copy link
Author

Hi @chloerice ,
In our specific case, it is required due to the fact that we offer admin side translation to our customers and we would like this text to be translated in the supported languages along with the rest of the text in our app.

@chloerice
Copy link
Member

Hi @chloerice , In our specific case, it is required due to the fact that we offer admin side translation to our customers and we would like this text to be translated in the supported languages along with the rest of the text in our app.

Ahh okay! Polaris components are already localized, you can dynamically ensure the correct translations are passed into the Polaris AppProvider using shopify/react-i18n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

No branches or pull requests

2 participants