We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I noticed that the rounded corners are resolved like this:
polaris/polaris-react/src/components/Card/Card.tsx
Lines 42 to 50 in 70bfcbe
This poses a problem for people that always want rounded corners as the default is always 0 during SSR
During SSR, namely Remix, breakpoints are not available, thus yieldien a false value for
const hasBorderRadius = Boolean(breakpoints[`${roundedAbove}Up`]);
Can we have a way to set rounded corners via non-browser-dependant props so during SSR it doesn't look all square before hydration?
I should be able to define the rounded corners from in an SSR way
It always looks like this 1-2s.. while is hydrating
tried to set up remix on codesanbox but couldn't set node version necessary for this version of polaris...
Yes
13.9.1
Chrome
Windows 11 PC
The text was updated successfully, but these errors were encountered:
I have the same issue, is this going to be resolved?
Sorry, something went wrong.
No branches or pull requests
Summary
Hi,
I noticed that the rounded corners are resolved like this:
polaris/polaris-react/src/components/Card/Card.tsx
Lines 42 to 50 in 70bfcbe
This poses a problem for people that always want rounded corners as the default is always 0 during SSR
During SSR, namely Remix, breakpoints are not available, thus yieldien a false value for
Can we have a way to set rounded corners via non-browser-dependant props so during SSR it doesn't look all square before hydration?
Expected behavior
I should be able to define the rounded corners from in an SSR way
Actual behavior
It always looks like this 1-2s.. while is hydrating
Steps to reproduce
tried to set up remix on codesanbox but couldn't set node version necessary for this version of polaris...
Are you using React components?
Yes
Polaris version number
13.9.1
Browser
Chrome
Device
Windows 11 PC
The text was updated successfully, but these errors were encountered: