We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
any
The documentation for <Page> and other components lists the type of many props as any. <PageActions> has the same issue. There may be others.
<Page>
<PageActions>
For the purposes of this issue, secondaryActions will be used as an example.
secondaryActions
secondaryActions should be typed as something like MenuActionDescriptor[] | ReactNode, making it clear to consumers what they can provide as props.
MenuActionDescriptor[] | ReactNode
secondaryActions is typed as any.
Meanwhile, actionGroups is correctly typed as MenuGroupDescriptor[].
actionGroups
MenuGroupDescriptor[]
Look at the documentation for <Page>, and others.
None
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Summary
The documentation for
<Page>
and other components lists the type of many props asany
.<PageActions>
has the same issue. There may be others.For the purposes of this issue,
secondaryActions
will be used as an example.Expected behavior
secondaryActions
should be typed as something likeMenuActionDescriptor[] | ReactNode
, making it clear to consumers what they can provide as props.Actual behavior
secondaryActions
is typed asany
.Meanwhile,
actionGroups
is correctly typed asMenuGroupDescriptor[]
.Steps to reproduce
Look at the documentation for
<Page>
, and others.Are you using React components?
None
Polaris version number
No response
Browser
No response
Device
No response
The text was updated successfully, but these errors were encountered: