Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clip path of Group component cause glitch on rerender. #1075

Open
kyimoemin opened this issue Nov 11, 2022 · 10 comments
Open

clip path of Group component cause glitch on rerender. #1075

kyimoemin opened this issue Nov 11, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@kyimoemin
Copy link

kyimoemin commented Nov 11, 2022

Description

adding path to clip props of Group component cause glitch on canvas when rerender. I tested in two versions both cause the bug.

OS: Android

devices ( doesn't cause glitches in the android emulator)

  • Redmi Note 7 Pro.
  • Xiaomi Mi9
  • Samsung S8+
  • Samsung Note 10+
  • Samsung Fold 4 (only on the outer screen)

Version

0.1.156, 0.1.157

Steps to reproduce

https://github.com/kyimoemin/skiaTest

Snack, code example, screenshot, or link to a repository

photo_2022-11-11_14-22-02

@kyimoemin kyimoemin added the bug Something isn't working label Nov 11, 2022
@wcandillon
Copy link
Contributor

We were not able to reproduce the example on android real device. We also tried on iOS and Web. Can you try with another android device to check if the bug also appear there with the exact same project?

@kyimoemin
Copy link
Author

kyimoemin commented Nov 14, 2022

I think it only happens on some specific Android devices not happen in iOS, not sure about Web tho. in my case, it is Redmi Note 7 pro. One of my coworker face that bug too I'll update you soon after I ask him for the device info

@kyimoemin
Copy link
Author

@wcandillon I updated the devices list

@kyimoemin
Copy link
Author

the glitch also happen some component that doesn't use clip-path

@daentech
Copy link

I have managed to reproduce this issue on 2 pixel devices as well (Pixel 3XL and Pixel 4XL). We are using a <Group> tag with the clip being an SkRect and outside the clipping area it renders parts of the canvas in a tiling manner. We have a list of paths we're adding from user input and every one we add alters the broken rendering

@wcandillon
Copy link
Contributor

Thanks for reporting this @daentech
We have this example already: https://github.com/kyimoemin/skiaTest/blob/master/App.js
Just in case, it sounds like you may have an even smaller example you could link here so we can test it as well?
I am planning on getting one of these devices.

@Hassaan68
Copy link

hi @kyimoemin , @wcandillon any solution as I am getting similar issue, it seems that when you increase the padding, the canvas renders items multiple times. getting this bug in android

@kyimoemin
Copy link
Author

I just change to react native svg lib.

@Hassaan68
Copy link

@kyimoemin , nice and easy fix mate :D

@SimasZurauskas
Copy link

SimasZurauskas commented Mar 17, 2023

having the same truoble,
it happens to me when using expo bare and running with expo go app, running natively on android seems to be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants