Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisionOS Support #2280

Open
robertherber opened this issue Mar 12, 2024 · 1 comment
Open

VisionOS Support #2280

robertherber opened this issue Mar 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@robertherber
Copy link

robertherber commented Mar 12, 2024

Description

I just gave VisionOS a quick try, and I guess it's something that would be nice to have supported :)

  1. First thing I ran into was that the Podfile doesn't get installed, which was easily resolved by updating the react-native-skia.podspec by adding visionOS together with ios:
    s.platforms = { :ios => "13.0", :visionos => "1.0"}
  2. The next thing I ran into is 'UIScreen' is unavailable: not available on visionOS in RNSKiOSPlatformContext.h:36. I fixed this by hard-coding 3.0 since it's just a scale
  3. Now I'm running into a potentially bigger issue. Seems like GLKit is not available on VisionOS. I tried removing it from the podspec, but that gives me lots of missing symbols. I see the podspec also includes MetalKit which I guess is the proposed successor of GLKit - but I guess skia depends on both or could there be a way around this?

I have no idea how deep this hole goes, but if it's not too difficult I'd appreciate some pointers on next steps, and would be happy to test out and potentially make some PRs for adding VisionOS support.

@robertherber robertherber added the enhancement New feature or request label Mar 12, 2024
@wcandillon
Copy link
Contributor

could it be as easy as implement this PR for visionPro? https://github.com/Shopify/react-native-skia/pull/2857/files
We have it for WebGPU: https://github.com/wcandillon/react-native-webgpu/blob/main/packages/webgpu/scripts/build/dawn.ts

Not sure if Skia is supported on vision pro however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants