-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visionos support #2286
visionos support #2286
Conversation
To get to the next step we also need to remove the dependency on UIScreen: https://github.com/robertherber/react-native-skia/pull/1/files#diff-b648d2a9fc3cd98b71316186a559b3e9e2396eeee45fc7cad6c04cdaf49ce3f5R36 After that this is what I see in XCode when building the react-native-visionos template project, which I guess is hinting at missing Skia framework for VisionOS? |
Hey! I spent some time trying to make this work and I'm pretty sure that we should first adjust the configuration file to build skia for visionOS and then pack it up as an
Unfortunately, it looks like Google's |
@okwasniewski as soon as Skia supports building it for visionOS we will definitely provide it part of the package. |
@okwasniewski thanks for looking into this :) |
This issue might be interesting to track of, since Flutter will need to solve the same issues (unless they go Impeller-only for VisionOS). Thanks @okwasniewski and @wcandillon for digging in this, looking forward to the possibilities with rn-skia on VisionOS will bring :) |
@okwasniewski we will start to look at the graphite migration. When migrating, we will take all the lessons learned from the work you did on rn-webgpu and hopefully that will offer a path for Skia on visionos |
This sounds awesome @wcandillon thank you! |
Hi, looking a bit late into this, I see that Skia has experimental support for Bazel, which now has rules for visionos. That may be a potential alternative. I might try to play around with that for my own purposes, but wanted to share the finding. I'm also curious how hard it would be to just build from source with cocoapods 🤔 but I'm probably not trying that. |
fixes #2280