Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log message flow #523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix log message flow #523

wants to merge 1 commit into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 8, 2024

@andyw8 andyw8 added the bugfix This PR fixes an existing bug label Nov 8, 2024
@andyw8 andyw8 requested a review from a team as a code owner November 8, 2024 21:01
@andyw8 andyw8 changed the title Fix log message Fix log message flow Nov 8, 2024
@vinistock
Copy link
Member

This is still not 100% correct. We can only return a response back if the server received a request and not a notification.

We may need to start including what each message is as part of their name, so that we can handle errors appropriately in the server. For example, something like:

def process_request(...)
  case request
  when "request/association_target_location"
  end
rescue => e
  if request.start_with?("request")
    send_message({ error: e.full_message })
  end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants