More ractor test-all fixes

Author: luke-gruber

test/ruby/test_argf.rb

@@ -7,7 +7,7 @@
 
 class TestArgf < Test::Unit::TestCase
   def setup
-    omit "ARGF is not shareable" if non_main_ractor?
+    omit "ARGF is not shareable" unless main_ractor?
     @tmpdir = Dir.mktmpdir
     @tmp_count = 0
     @t1 = make_tempfile("argf-foo", %w"1 2", binmode: true)
@@ -16,7 +16,7 @@ def setup
   end
 
   def teardown
-    return if non_main_ractor?
+    return unless main_ractor?
     FileUtils.rmtree(@tmpdir)
   end
 

test/ruby/test_autoload.rb

@@ -3,6 +3,10 @@
 require 'tempfile'
 
 class TestAutoload < Test::Unit::TestCase
+  def setup
+    pend "autoload" unless main_ractor?
+  end
+
   def test_autoload_so
     # Date is always available, unless excluded intentionally.
     assert_in_out_err([], <<-INPUT, [], [])
@@ -66,7 +70,7 @@ def test_autoload_p
   end
 
   def test_autoload_p_with_static_extensions
-    pend "belonging issue" if non_main_ractor?
+    pend "belonging issue" unless main_ractor?
     require 'rbconfig'
     omit unless RbConfig::CONFIG['EXTSTATIC'] == 'static'
     begin
@@ -85,7 +89,7 @@ def test_autoload_p_with_static_extensions
   end
 
   def test_autoload_with_unqualified_file_name # [ruby-core:69206]
-    omit "global variable access" if non_main_ractor?
+    omit "global variable access" unless main_ractor?
     Object.send(:remove_const, :A) if Object.const_defined?(:A)
 
     lp = $LOAD_PATH.dup
@@ -114,7 +118,7 @@ module A
   end
 
   def test_require_explicit
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     Tempfile.create(['autoload', '.rb']) {|file|
       file.puts 'class Object; AutoloadTest = 1; end'
       file.close
@@ -131,7 +135,7 @@ def test_require_explicit
   end
 
   def test_threaded_accessing_constant
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     # Suppress "warning: loading in progress, circular require considered harmful"
     EnvUtil.default_warning {
       Tempfile.create(['autoload', '.rb']) {|file|
@@ -152,7 +156,7 @@ def test_threaded_accessing_constant
   end
 
   def test_threaded_accessing_inner_constant
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     # Suppress "warning: loading in progress, circular require considered harmful"
     EnvUtil.default_warning {
       Tempfile.create(['autoload', '.rb']) {|file|
@@ -173,7 +177,7 @@ def test_threaded_accessing_inner_constant
   end
 
   def test_nameerror_when_autoload_did_not_define_the_constant
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     verbose_bak, $VERBOSE = $VERBOSE, nil
     Tempfile.create(['autoload', '.rb']) {|file|
       file.puts ''
@@ -192,7 +196,7 @@ def test_nameerror_when_autoload_did_not_define_the_constant
   end
 
   def test_override_autoload
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     Tempfile.create(['autoload', '.rb']) {|file|
       file.puts ''
       file.close
@@ -207,7 +211,7 @@ def test_override_autoload
   end
 
   def test_override_while_autoloading
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     Tempfile.create(['autoload', '.rb']) {|file|
       file.puts 'class AutoloadTest; sleep 0.5; end'
       file.close
@@ -259,7 +263,7 @@ def ruby_impl_require
   end
 
   def test_require_implemented_in_ruby_is_called
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     ruby_impl_require do |called_with|
       Tempfile.create(['autoload', '.rb']) {|file|
         file.puts 'class AutoloadTest; end'
@@ -277,7 +281,7 @@ def test_require_implemented_in_ruby_is_called
   end
 
   def test_autoload_while_autoloading
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     ruby_impl_require do |called_with|
       Tempfile.create(%w(a .rb)) do |a|
         Tempfile.create(%w(b .rb)) do |b|
@@ -407,7 +411,7 @@ class AutoloadTest
   end
 
   def test_autoload_fork
-    pend "Tempfile" if non_main_ractor?
+    pend "Tempfile" unless main_ractor?
     EnvUtil.default_warning do
       Tempfile.create(['autoload', '.rb']) {|file|
         file.puts 'sleep 0.3; class AutoloadTest; end'

test/ruby/test_class.rb

@@ -291,6 +291,7 @@ def test_uninitialized
   end
 
   def test_nonascii_name
+    omit "global side effects" if multiple_ractors?
     c = eval("class ::C\u{df}; self; end")
     assert_equal("C\u{df}", c.name, '[ruby-core:24600]')
     c = eval("class C\u{df}; self; end")

test/ruby/test_defined.rb

@@ -373,6 +373,8 @@ def x; b {return defined?(super)}; end
   end
 
   def test_super_in_basic_object
+    omit "global side effects" if multiple_ractors?
+    run_ensure = true
     BasicObject.class_eval do
       def a
         defined?(super)
@@ -383,7 +385,7 @@ def a
   ensure
     BasicObject.class_eval do
       undef_method :a if defined?(a)
-    end
+    end if run_ensure
   end
 
   def test_super_toplevel

test/ruby/test_dir.rb

@@ -7,6 +7,7 @@
 class TestDir < Test::Unit::TestCase
 
   def setup
+    omit "lots of Dir.chdir" if multiple_ractors?
     @verbose = $VERBOSE
     @root = File.realpath(Dir.mktmpdir('__test_dir__'))
     @nodir = File.join(@root, "dummy")
@@ -23,6 +24,7 @@ def setup
   end
 
   def teardown
+    return if multiple_ractors?
     $VERBOSE = @verbose
     FileUtils.remove_entry_secure @root if File.directory?(@root)
     ENV.update(@envs) if @envs
@@ -97,7 +99,7 @@ def test_rewind
   end
 
   def test_class_chdir
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     pwd = Dir.pwd
     setup_envs
 
@@ -137,7 +139,7 @@ def test_class_chdir
   end
 
   def test_instance_chdir
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     pwd = Dir.pwd
     dir = Dir.new(pwd)
     root_dir = Dir.new(@root)
@@ -205,7 +207,7 @@ def Warning.warn(message)
   end
 
   def test_chdir_conflict
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     pwd = Dir.pwd
     q = Thread::Queue.new
     t = Thread.new do
@@ -282,7 +284,7 @@ def test_glob
   end
 
   def test_glob_recursive
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     bug6977 = '[ruby-core:47418]'
     bug8006 = '[ruby-core:53108] [Bug #8006]'
     Dir.chdir(@root) do
@@ -312,7 +314,7 @@ def test_glob_recursive
   end
 
   def test_glob_recursive_directory
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     Dir.chdir(@root) do
       ['d', 'e'].each do |path|
         FileUtils.mkdir_p("c/#{path}/a/b/c")
@@ -330,7 +332,7 @@ def test_glob_recursive_directory
   end
 
   def test_glob_starts_with_brace
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     Dir.chdir(@root) do
       bug15649 = '[ruby-core:91728] [Bug #15649]'
       assert_equal(["#{@root}/a", "#{@root}/b"],
@@ -339,7 +341,7 @@ def test_glob_starts_with_brace
   end
 
   def test_glob_recursive_with_brace
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     Dir.chdir(@root) do
       bug19042 = '[ruby-core:110220] [Bug #19042]'
       %w"c/dir_a c/dir_b c/dir_b/dir".each do |d|
@@ -354,7 +356,7 @@ def test_glob_recursive_with_brace
   end
 
   def test_glob_order
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     Dir.chdir(@root) do
       assert_equal(["#{@root}/a", "#{@root}/b"], Dir.glob("#{@root}/[ba]"))
       assert_equal(["#{@root}/b", "#{@root}/a"], Dir.glob(%W"#{@root}/b #{@root}/a"))
@@ -384,7 +386,7 @@ def test_glob_too_may_open_files
   end
 
   def test_glob_base
-    omit "not ractor safe (Dir.chdir)" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     files = %w[a/foo.c c/bar.c]
     files.each {|n| File.write(File.join(@root, n), "")}
     Dir.mkdir(File.join(@root, "a/dir"))
@@ -425,7 +427,7 @@ def test_glob_base
   end
 
   def test_glob_base_dir
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     files = %w[a/foo.c c/bar.c]
     files.each {|n| File.write(File.join(@root, n), "")}
     Dir.mkdir(File.join(@root, "a/dir"))
@@ -448,7 +450,7 @@ def test_glob_base_dir
   end
 
   def test_glob_ignore_casefold_invalid_encoding
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     bug14456 = "[ruby-core:85448]"
     filename = "\u00AAa123".encode('ISO-8859-1')
     File.write(File.join(@root, filename), "")
@@ -566,7 +568,7 @@ def test_glob_metachar
   end
 
   def test_glob_cases
-    omit "not ractor safe (Dir.chdir)" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     feature5994 = "[ruby-core:42469] [Feature #5994]"
     feature5994 << "\nDir.glob should return the filename with actual cases on the filesystem"
     Dir.chdir(File.join(@root, "a")) do
@@ -732,7 +734,7 @@ def test_fileno
   end
 
   def test_for_fd
-    omit "not ractor safe" unless main_ractor?
+    omit "Dir.chdir" unless main_ractor?
     if Dir.respond_to? :for_fd
       begin
         new_dir = Dir.new('..')

test/ruby/test_gc.rb

@@ -323,6 +323,7 @@ def test_measure_total_time
 
   def test_latest_gc_info
     omit 'stress' if GC.stress
+    omit "GC.stress=" if multiple_ractors?
 
     assert_separately([], __FILE__, __LINE__, <<-'RUBY')
       GC.start
@@ -342,10 +343,12 @@ def test_latest_gc_info
     assert_equal true,    h[:immediate_sweep]
     assert_equal true,    h.key?(:need_major_by)
 
-    GC.stress = true
-    assert_equal :force, GC.latest_gc_info[:major_by]
-  ensure
-    GC.stress = false
+    begin
+      GC.stress = true
+      assert_equal :force, GC.latest_gc_info[:major_by]
+    ensure
+      GC.stress = false
+    end
   end
 
   def test_latest_gc_info_argument
@@ -904,7 +907,7 @@ def test_ast_node_buffer
   end
 
   def test_old_to_young_reference
-    pend "ObjectSpace.dump not yet ractor safe" if non_main_ractor?
+    pend "ObjectSpace.dump not yet ractor safe" unless main_ractor?
     EnvUtil.without_gc do
       require "objspace"
 

test/ruby/test_hash.rb

@@ -2265,6 +2265,7 @@ def test_label_syntax
   end
 
   def test_broken_hash_value
+    omit "too many objects" if multiple_ractors?
     bug14218 = '[ruby-core:84395] [Bug #14218]'
 
     assert_equal(0, 1_000_000.times.count{a=Object.new.hash; b=Object.new.hash; a < 0 && b < 0 && a + b > 0}, bug14218)

test/ruby/test_integer.rb

@@ -7,7 +7,7 @@ class TestInteger < Test::Unit::TestCase
   LONG_MAX = RbConfig::LIMITS['LONG_MAX']
 
   def test_aref
-
+    pend "TODO: why taking too long" if multiple_ractors?
     [
       *-16..16,
       *(FIXNUM_MIN-2)..(FIXNUM_MIN+2),

test/ruby/test_io.rb

@@ -1860,6 +1860,7 @@ def test_close_write_non_readable
   end
 
   def test_close_read_write_separately
+    pend "TODO: buggy with ractors" if multiple_ractors?
     bug = '[ruby-list:49598]'
     (1..10).each do |i|
       assert_nothing_raised(IOError, "#{bug} trying ##{i}") do
@@ -2529,6 +2530,7 @@ def try_fdopen(fd, autoclose = true, level = 50)
   end
 
   def test_autoclose
+    pend "TODO: assert_raise fails sometimes under multiple ractors" if multiple_ractors?
     feature2250 = '[ruby-core:26222]'
     pre = 'ft2250'
 
@@ -2615,6 +2617,7 @@ def o.to_open(kw); kw; end
   end
 
   def test_open_pipe
+    omit "fork" unless main_ractor?
     assert_deprecated_warning(/Kernel#open with a leading '\|'/) do # https://bugs.ruby-lang.org/issues/19630
       open("|" + EnvUtil.rubybin, "r+") do |f|
         f.puts "puts 'foo'"
@@ -3993,6 +3996,7 @@ def test_sysread_unlocktmp_ensure
   end if /cygwin/ !~ RUBY_PLATFORM
 
   def test_exception_at_close
+    pend "TODO: assert_raise fails sometimes under multiple ractors" if multiple_ractors?
     bug10153 = '[ruby-core:64463] [Bug #10153] exception in close at the end of block'
     assert_raise(Errno::EBADF, bug10153) do
       IO.pipe do |r, w|
@@ -4472,4 +4476,18 @@ def test_fork_close
       assert_predicate(status, :success?)
     RUBY
   end
+
+  def test_no_fork_in_ractor
+    omit "fork is not supported" unless Process.respond_to?(:fork)
+
+    assert_ractor(<<~'RUBY')
+      r = Ractor.new do
+          fork { }
+        end
+      end
+      assert_raise Ractor::IsolationError do
+        r.value
+      end
+    RUBY
+  end
 end