Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

Make 64bit compliant #21

Open
Sohojoe opened this issue Feb 28, 2014 · 8 comments
Open

Make 64bit compliant #21

Sohojoe opened this issue Feb 28, 2014 · 8 comments

Comments

@Sohojoe
Copy link
Contributor

Sohojoe commented Feb 28, 2014

The library requires the main app to be NON 64 bit...

@jbrennan
Copy link
Contributor

It should be easy enough to upgrade. I don’t think Superdb is actively maintained any more, but feel free to toss in a pull request and I’ll review it.

@Sohojoe
Copy link
Contributor Author

Sohojoe commented Feb 28, 2014

Just tried adding 64bit to architectures in SuperDBCore

I get a bunch of these errors:
error: direct access to Objective-C's isa is deprecated in favor of object_getClass()

for example on this line:
args[1] = (id)(selector ? selector : [FSCompiler selectorFromString:selectorStr]);

adding sel_getName... fixes the warning
args[1] = (id)sel_getName((selector ? selector : [FSCompiler selectorFromString:selectorStr]));

I don't really understand what is going on under the hood is this the right path???

@jbrennan
Copy link
Contributor

@Sohojoe Unfortunately I’m not sure, as most of the F-Script stuff wasn’t written by me. A lot of it was written before the ObjC 2.x runtime functions were made available so my guess is it might take more effort.

I take back my earlier statement this morning about this being an easier task. I’d forgotten about the arm64 isa changes. It might be as simple as changing those to use object_getClass() as you mentioned, but I’m not sure.

Also note there were already lots of warnings in the project (due to F-Script) before arm64, unfortunately.

@Sohojoe
Copy link
Contributor Author

Sohojoe commented Mar 1, 2014

I was able to make some progress using object_getClass() - this was simple...

I've hit a new problem with some assembly code - it doesn't like the @ (used for comments) - I found [see html link at bottom of post] on SO I'm not sure if it just needs a different syntax for comments of if the whole of the assembly language changed for 64bit - I don't have experience of assembly in arm - do you have insight??

these are the errors

/Users/apple/development/superdb/SuperDBCore/SuperDBCore/iphone-sysv.S:62:1: error: unexpected token at start of statement
@ This selects the minimum architecture level required.
^
/Users/apple/development/superdb/SuperDBCore/SuperDBCore/iphone-sysv.S:145:2: error: unexpected token at start of statement
@ r0: ffi_prep_args
^
/Users/apple/development/superdb/SuperDBCore/SuperDBCore/iphone-sysv.S:146:2: error: unexpected token at start of statement
@ r1: &ecif
^
/Users/apple/development/superdb/SuperDBCore/SuperDBCore/iphone-sysv.S:147:2: error: unexpected token at start of statement
@ r2: cif->bytes
^
/Users/apple/development/superdb/SuperDBCore/SuperDBCore/iphone-sysv.S:148:2: error: unexpected token at start of statement
@ r3: fig->flags
^

http://stackoverflow.com/questions/21770379/xcode5-build-ios-arm64-static-library-error-when-building-the-assembly-file

@mralexgray
Copy link

any word on this?

@jbrennan
Copy link
Contributor

@mralexgray Sorry no not really. The project hasn’t been maintained in a while, unfortunately.

@fiftytwo
Copy link

I'm also interested in 64-bit version, we'll wait for it.

@javierquevedo
Copy link

Since it has been such a long time since the project is not updated, and there are no plan for the developers to add support for 64 bits architecture, I would suggest to make this quickly known in the readme so that people do not waste too much time in trying to make this run.

Thanks for the effort in any case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants