Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Feature request: Add - and versions of brackets to autoClosingPairs #108

Closed
nikitaourazbaev opened this issue Dec 27, 2022 · 1 comment · Fixed by Shopify/theme-tools#242

Comments

@nikitaourazbaev
Copy link

Adding ["{{-", "-}}"], ["{{ ", " }}"], and ["{%-", "-%}"], ["{% ", " %}"], to autoClosingPairs in language-configuration.json makes for a nicer typing experience as the spaces inside the brackets are then automatically balanced when typing.

Before:
CleanShot 2022-12-27 at 09 11 11

After:
CleanShot 2022-12-27 at 09 11 52

@timdmackey
Copy link

timdmackey commented Mar 8, 2023

Agreed! I made these enhancements to my own Liquid for Mechanic extension, and they're a nice improvement.

I've submitted a pull request (#115) to implement these and a couple other improvements into this extension.

charlespwd added a commit to Shopify/theme-tools that referenced this issue Nov 9, 2023
charlespwd added a commit to Shopify/theme-tools that referenced this issue Nov 9, 2023
charlespwd added a commit to Shopify/theme-tools that referenced this issue Nov 9, 2023
charlespwd added a commit to Shopify/theme-tools that referenced this issue Nov 9, 2023
charlespwd added a commit to Shopify/theme-tools that referenced this issue Nov 9, 2023
charlespwd added a commit to Shopify/theme-tools that referenced this issue Nov 9, 2023
* Use typescript for the VS Code language config

* Add better auto-closing UX for Liquid pairs

Fixes #202
Fixes Shopify/theme-check-vscode#108

xoxo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants