Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme block JSON preset validation #624

Open
4 tasks
Tracked by #545
charlespwd opened this issue Nov 28, 2024 · 1 comment
Open
4 tasks
Tracked by #545

Theme block JSON preset validation #624

charlespwd opened this issue Nov 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@charlespwd
Copy link
Contributor

charlespwd commented Nov 28, 2024

Maybe duplicate of what @navdeep5 is doing?

Should we add a tasklist in here?

Or a duplicate of #602

Top of mind:

Tasks

Preview Give feedback
@bakura10
Copy link

I think this is somehow related. But since theme blocks are introduced (I think) we can now connect a block value as a default. For instance, inside a section, I have this block:

"blocks": [
    {
      "type": "collection",
      "name": "t:sections.featured_collections.blocks.collection.name",
      "settings": [
        {
          "type": "collection",
          "id": "collection",
          "label": "t:sections.featured_collections.blocks.collection.collection"
        },
        {
          "type": "text",
          "id": "title",
          "label": "t:global.text.title",
          "default": "{{ block.settings.collection.title }}"
        }
  }
]

This is convenient and allow to automatically connect the title with the collection's title of the block.

Theme check report does not currently allow that though:

Image

I am not sure if this is expected @charlespwd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants