Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customer account ui extensions: ProductThumbnail fit property #2460

Closed
mateusvahl opened this issue Nov 7, 2024 · 2 comments
Closed

customer account ui extensions: ProductThumbnail fit property #2460

mateusvahl opened this issue Nov 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mateusvahl
Copy link

mateusvahl commented Nov 7, 2024 •
edited
Loading

Please list the package(s) involved in the issue, and include the version you are using

"@shopify/ui-extensions": "2024.10.x",
"@shopify/ui-extensions-react": "2024.10.x",

Feature request

When compared to <Image />, there's no fit property for <ProductThumbnail />.

Example:

// cover | contain
<ProductThumbnail fit="cover"  />

We wan't to be able to control how the image fits in the component, examples

fit=contain (same as current)
Image

fit=cover:
Image
@mateusvahl mateusvahl added the enhancement New feature or request label Nov 7, 2024
@Osarumwense
Copy link

Hey @mateusvahl, I can confirm we're working on bringing support for this by year's end.

@mateusvahl
Copy link
Author

@Osarumwense Cool! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mateusvahl @Osarumwense