Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stand-alone theme #480

Open
matteeyah opened this issue Jun 24, 2023 · 1 comment
Open

Stand-alone theme #480

matteeyah opened this issue Jun 24, 2023 · 1 comment

Comments

@matteeyah
Copy link

It would be great if we could install the theme used in the pack (Spinel) by itself.

@Shaglock
Copy link

Shaglock commented Oct 28, 2023

Yes, it is very unfortunate that we need to install the extension pack just to get the theme

I actually found an explanation to why it is made this way and it makes perfect sense

The reason we don’t have the themes split into a separate extension is simply the maintenance cost of yet another repository. Our team is small, so preferably we’d like to keep things as low maintenance as possible.
There are a few points I’d like to address though:

  • Without the Ruby LSP, the theme will not look like advertised. It needs semantic highlighting information to remove ambiguity from the syntax and then highlight code consistently
  • As Ufuk said, you can use a custom Gemfile to use the Ruby LSP with versions older than 3.0.0
  • Lastly, why is installing the extension pack (vscode-shopify-ruby) an issue? If an extension included in the pack doesn’t make sense for you, you can always uninstall that extension and it will never reinstall automatically. Also, if you don’t want the automatic configuration, you can just refuse it completely.
  • You can uninstall the Sorbet and the RDBG extensions if you don’t use it. They won’t be reinstalled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants