Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to add a second WAVEGUIDES.xml file for custom waveguide #150

Open
JinWallner opened this issue Jul 6, 2021 · 5 comments
Open

Comments

@JinWallner
Copy link
Contributor

Hi,

Can we add a second WAVEGUIDES.xml file, e.g. WAVEGUIDES_custom.xml for custom waveguide configuration? Currently, custom waveguides and PDK waveguides share the same file. It needs to be remerged for every new PDK release.

Thanks,

Jin

@mustafacc
Copy link
Member

Good idea, perhaps instead of importing WAVEGUIDES.xml we should just import every xml file containing "WAVEGUIDE".

lukasc-ubc added a commit that referenced this issue Jul 8, 2021
@lukasc-ubc
Copy link
Member

I have implemented this. I loads WAVEGUIDES.xml and then all WAVEGUIDE_*.xml files. It is on GitHub, but not released in Package Manager. Can you please check?

@mustafacc
Copy link
Member

Works okay for EBeam but there seems to be issues with AMF and AIM

AMF: generated waveguides missing pinrec layers + asterisk
image

AIM: waveguides don't generate properly
image

@lukasc-ubc
Copy link
Member

lukasc-ubc commented Jul 8, 2021 via email

lukasc-ubc added a commit that referenced this issue Jul 8, 2021
- sometimes Waveguides don't show up, and there is a "*" in the cell name. In this case it was when a string was a parameter when expecting a float.
@lukasc-ubc
Copy link
Member

I found an issue where a string representation of the bezier parameter caused the waveguide to not generate. Just fixed. Before updating, can you check if this problem only occurred for Bezier curve waveguides? i.e., you shouldn't have had this issue with non-bezier waveguides (e.g., TM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants