From 83e529a77939f3c86c1e73931724b1704ef8e44f Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 01:34:15 -0500
Subject: [PATCH 01/29] refactor: lowercase and typo function, parameter, and
 variable names in tv.py

Signed-off-by: miigotu <miigotu@gmail.com>
---
 SickChill.py                                  |  11 +-
 .../gui/slick/views/config_providers.mako     |  68 +-
 sickchill/oldbeard/classes.py                 |   2 +-
 sickchill/oldbeard/dailysearcher.py           |   2 +-
 sickchill/oldbeard/failedProcessor.py         |   2 +-
 sickchill/oldbeard/helpers.py                 |   2 +-
 sickchill/oldbeard/nzbSplitter.py             |   4 +-
 sickchill/oldbeard/postProcessor.py           |   4 +-
 sickchill/oldbeard/properFinder.py            |   2 +-
 sickchill/oldbeard/providers/bjshare.py       |   4 +-
 sickchill/oldbeard/scene_numbering.py         |   2 +-
 sickchill/oldbeard/search.py                  |   8 +-
 sickchill/oldbeard/searchBacklog.py           |   2 +-
 sickchill/oldbeard/show_queue.py              |  42 +-
 sickchill/oldbeard/subtitles.py               |   2 +-
 sickchill/oldbeard/traktChecker.py            |   4 +-
 sickchill/oldbeard/tvcache.py                 |   6 +-
 sickchill/providers/GenericProvider.py        |   9 +-
 sickchill/providers/metadata/generic.py       |  12 +-
 .../providers/torrent/TorrentProvider.py      |   2 +-
 sickchill/show/ComingEpisodes.py              |   2 +-
 sickchill/show/History.py                     |   4 +-
 sickchill/show/Show.py                        |   2 +-
 sickchill/show_updater.py                     |   2 +-
 sickchill/start.py                            | 125 ++--
 sickchill/tv.py                               | 698 +++++++++---------
 sickchill/views/api/webapi.py                 |  18 +-
 sickchill/views/home.py                       |  22 +-
 sickchill/views/manage/index.py               |   4 +-
 tests/conftest.py                             |   8 +-
 tests/sickchill_tests/show/test_show.py       |   2 +-
 tests/test_notifier.py                        |   4 +-
 tests/test_pp.py                              |   4 +-
 tests/test_search.py                          |   4 +-
 tests/test_snatch.py                          |   4 +-
 tests/test_tv.py                              |  26 +-
 36 files changed, 560 insertions(+), 559 deletions(-)

diff --git a/SickChill.py b/SickChill.py
index d11749a6c0..70d0ecfc23 100755
--- a/SickChill.py
+++ b/SickChill.py
@@ -1,6 +1,7 @@
 #!/usr/bin/env python3
 
 import datetime
+import mimetypes
 import os
 import platform
 import shutil
@@ -28,14 +29,12 @@
 
 setup_gettext()
 
-import mimetypes
-
 mimetypes.add_type("text/css", ".css")
 mimetypes.add_type("application/sfont", ".otf")
 mimetypes.add_type("application/sfont", ".ttf")
 mimetypes.add_type("application/javascript", ".js")
 mimetypes.add_type("application/font-woff", ".woff")
-# Not sure about this one, but we also have halflings in .woff so I think it wont matter
+# Not sure about this one, but we also have halflings in .woff, so I think it won't matter
 # mimetypes.add_type("application/font-woff2", ".woff2")
 
 from configobj import ConfigObj
@@ -67,6 +66,8 @@ def __init__(self):
         self.run_as_daemon = False
 
         # web server constants
+        self.flask_server = None
+
         self.web_server = None
         self.forced_port = None
         self.no_launch = False
@@ -253,7 +254,7 @@ def load_shows_from_db():
         for sql_show in sql_results:
             try:
                 cur_show = TVShow(sql_show["indexer"], sql_show["indexer_id"])
-                cur_show.nextEpisode()
+                cur_show.next_episode()
                 settings.showList.append(cur_show)
             except Exception as error:
                 logger.exception("There was an error creating the show in {}: Error {}".format(sql_show["location"], error))
@@ -301,7 +302,7 @@ def shutdown(self, event):
         """
         if settings.started:
             sickchill.start.halt()  # stop all tasks
-            sickchill.start.saveAll()  # save all shows to DB
+            sickchill.start.save_all()  # save all shows to DB
 
             # shutdown web server
             if self.web_server:
diff --git a/sickchill/gui/slick/views/config_providers.mako b/sickchill/gui/slick/views/config_providers.mako
index 3a7cedb406..1eac64b38b 100644
--- a/sickchill/gui/slick/views/config_providers.mako
+++ b/sickchill/gui/slick/views/config_providers.mako
@@ -75,7 +75,7 @@
                         <ul id="provider_order_list">
                             % for provider in providers.sorted_provider_list(only_enabled=True):
                             <%
-                                if provider.has_option('custom_url'):
+                                if hasattr(provider, 'custom_url'):
                                     provider_url = provider.custom_url or provider.url
                                 else:
                                     provider_url = provider.url
@@ -157,7 +157,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('enable_daily'):
+                                % if hasattr(provider, 'enable_daily'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable daily searches')}</label>
@@ -172,7 +172,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('enable_backlog'):
+                                % if hasattr(provider, 'enable_backlog'):
                                      <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable backlog searches')}</label>
@@ -187,7 +187,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('search_mode'):
+                                % if hasattr(provider, 'search_mode'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Season search mode')}</label>
@@ -214,7 +214,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('search_fallback'):
+                                % if hasattr(provider, 'search_fallback'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable fallback')}</label>
@@ -233,7 +233,7 @@
 
                         % for provider in [provider for provider in providers.sorted_provider_list() if provider.provider_type == GenericProvider.NZB and provider not in settings.newznab_provider_list]:
                             <div class="providerDiv" id="${provider.get_id("Div")}">
-                                % if provider.has_option('username'):
+                                % if hasattr(provider, 'username'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Username')}</label>
@@ -244,7 +244,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('api_key'):
+                                % if hasattr(provider, 'api_key'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('API key')}</label>
@@ -255,7 +255,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('enable_daily'):
+                                % if hasattr(provider, 'enable_daily'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable daily searches')}</label>
@@ -270,7 +270,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('enable_backlog'):
+                                % if hasattr(provider, 'enable_backlog'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable backlog searches')}</label>
@@ -285,7 +285,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('search_mode'):
+                                % if hasattr(provider, 'search_mode'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Season search mode')}</label>
@@ -312,7 +312,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('search_fallback'):
+                                % if hasattr(provider, 'search_fallback'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable fallback')}</label>
@@ -332,7 +332,7 @@
                         % for provider in [provider for provider in providers.sorted_provider_list() if provider.provider_type == GenericProvider.TORRENT]:
                             <div class="providerDiv" id="${provider.get_id("Div")}">
 
-                                % if provider.has_option('custom_url'):
+                                % if hasattr(provider, 'custom_url'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Custom URL')}</label>
@@ -344,7 +344,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('api_key'):
+                                % if hasattr(provider, 'api_key'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Api key')}</label>
@@ -355,7 +355,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('digest'):
+                                % if hasattr(provider, 'digest'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Digest')}</label>
@@ -366,7 +366,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('hash'):
+                                % if hasattr(provider, 'hash'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Hash')}</label>
@@ -377,7 +377,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('username'):
+                                % if hasattr(provider, 'username'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Username')}</label>
@@ -388,7 +388,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('password'):
+                                % if hasattr(provider, 'password'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Password')}</label>
@@ -399,7 +399,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('passkey'):
+                                % if hasattr(provider, 'passkey'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Passkey')}</label>
@@ -434,7 +434,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('pin'):
+                                % if hasattr(provider, 'pin'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Pin')}</label>
@@ -445,7 +445,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('ratio'):
+                                % if hasattr(provider, 'ratio'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title" id="${provider.get_id("_ratio_desc")}">${_('Seed ratio')}</label>
@@ -465,7 +465,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('minseed'):
+                                % if hasattr(provider, 'minseed'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title" id="${provider.get_id("_minseed_desc")}">${_('Minimum seeders')}</label>
@@ -476,7 +476,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('minleech'):
+                                % if hasattr(provider, 'minleech'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title" id="${provider.get_id("_minleech_desc")}">${_('Minimum leechers')}</label>
@@ -487,7 +487,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('confirmed'):
+                                % if hasattr(provider, 'confirmed'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Confirmed download')}</label>
@@ -499,7 +499,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('ranked'):
+                                % if hasattr(provider, 'ranked'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Ranked torrents')}</label>
@@ -511,7 +511,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('engrelease'):
+                                % if hasattr(provider, 'engrelease'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('English torrents')}</label>
@@ -523,7 +523,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('onlyspasearch'):
+                                % if hasattr(provider, 'onlyspasearch'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('For Spanish torrents')}</label>
@@ -535,7 +535,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('sorting'):
+                                % if hasattr(provider, 'sorting'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Sorting results by')}</label>
@@ -550,7 +550,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('freeleech'):
+                                % if hasattr(provider, 'freeleech'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Freeleech')}</label>
@@ -562,7 +562,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('enable_daily'):
+                                % if hasattr(provider, 'enable_daily'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable daily searches')}</label>
@@ -577,7 +577,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('enable_backlog'):
+                                % if hasattr(provider, 'enable_backlog'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable backlog searches')}</label>
@@ -593,7 +593,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('search_mode'):
+                                % if hasattr(provider, 'search_mode'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Season search mode')}</label>
@@ -620,7 +620,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('search_fallback'):
+                                % if hasattr(provider, 'search_fallback'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Enable fallback')}</label>
@@ -634,7 +634,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('cat'):
+                                % if hasattr(provider, 'cat'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Category')}</label>
@@ -649,7 +649,7 @@
                                     </div>
                                 % endif
 
-                                % if provider.has_option('subtitle'):
+                                % if hasattr(provider, 'subtitle'):
                                     <div class="field-pair row">
                                         <div class="col-lg-3 col-md-4 col-sm-5 col-xs-12">
                                             <label class="component-title">${_('Subtitled')}</label>
diff --git a/sickchill/oldbeard/classes.py b/sickchill/oldbeard/classes.py
index 6bdfc70ed3..1726f9a156 100644
--- a/sickchill/oldbeard/classes.py
+++ b/sickchill/oldbeard/classes.py
@@ -76,7 +76,7 @@ def make_result(cls, result_dict):
             return show[0]
 
         show = show[1]
-        episode_objects = [show.getEpisode(result_dict.get("season"), ep) for ep in result_dict.get("episodes").split("|") if ep]
+        episode_objects = [show.get_episode(result_dict.get("season"), ep) for ep in result_dict.get("episodes").split("|") if ep]
         result = cls(episode_objects)
         result.from_json(result_dict)
         result.show = show
diff --git a/sickchill/oldbeard/dailysearcher.py b/sickchill/oldbeard/dailysearcher.py
index 9704e9557e..d2c8e40cfb 100644
--- a/sickchill/oldbeard/dailysearcher.py
+++ b/sickchill/oldbeard/dailysearcher.py
@@ -66,7 +66,7 @@ def run(self, force=False):
                 if air_time > curTime:
                     continue
 
-            ep = show.getEpisode(sqlEp["season"], sqlEp["episode"])
+            ep = show.get_episode(sqlEp["season"], sqlEp["episode"])
             with ep.lock:
                 prefix = _("New episode {episode_string} airs today,").format(episode_string=ep.pretty_name)
                 if ep.season == 0:
diff --git a/sickchill/oldbeard/failedProcessor.py b/sickchill/oldbeard/failedProcessor.py
index 302ebeade1..9b445c4052 100644
--- a/sickchill/oldbeard/failedProcessor.py
+++ b/sickchill/oldbeard/failedProcessor.py
@@ -56,7 +56,7 @@ def process(self):
         self._log(f"{parsed.air_date}", logger.DEBUG)
 
         for episode in parsed.episode_numbers:
-            segment = parsed.show.getEpisode(parsed.season_number, episode)
+            segment = parsed.show.get_episode(parsed.season_number, episode)
 
             cur_failed_queue_item = search_queue.FailedQueueItem(parsed.show, [segment])
             settings.searchQueueScheduler.action.add_item(cur_failed_queue_item)
diff --git a/sickchill/oldbeard/helpers.py b/sickchill/oldbeard/helpers.py
index 10084c6b75..03d13e50da 100644
--- a/sickchill/oldbeard/helpers.py
+++ b/sickchill/oldbeard/helpers.py
@@ -659,7 +659,7 @@ def get_all_episodes_from_absolute_number(show, absolute_numbers, indexer_id=Non
             show = Show.find(settings.showList, indexer_id)
 
         for absolute_number in absolute_numbers if show else []:
-            ep = show.getEpisode(None, None, absolute_number=absolute_number)
+            ep = show.get_episode(None, None, absolute_number=absolute_number)
             if ep:
                 episodes.append(ep.episode)
                 season = ep.season  # this will always take the last found season so eps that cross the season border are not handeled well
diff --git a/sickchill/oldbeard/nzbSplitter.py b/sickchill/oldbeard/nzbSplitter.py
index 4935eaea6d..297fa4c86e 100644
--- a/sickchill/oldbeard/nzbSplitter.py
+++ b/sickchill/oldbeard/nzbSplitter.py
@@ -164,7 +164,7 @@ def split_result(obj):
 
         want_ep = True
         for ep_num in parsed_obj.episode_numbers:
-            if not obj.show.wantEpisode(season, ep_num, obj.quality):
+            if not obj.show.want_episode(season, ep_num, obj.quality):
                 logger.debug("Ignoring result: " + new_nzb)
                 want_ep = False
                 break
@@ -172,7 +172,7 @@ def split_result(obj):
             continue
 
         # get all the associated episode objects
-        ep_obj_list = [obj.show.getEpisode(season, ep) for ep in parsed_obj.episode_numbers]
+        ep_obj_list = [obj.show.get_episode(season, ep) for ep in parsed_obj.episode_numbers]
 
         # make a result
         cur_obj = classes.NZBDataSearchResult(ep_obj_list)
diff --git a/sickchill/oldbeard/postProcessor.py b/sickchill/oldbeard/postProcessor.py
index b6fff5683a..0c069c7bee 100644
--- a/sickchill/oldbeard/postProcessor.py
+++ b/sickchill/oldbeard/postProcessor.py
@@ -758,7 +758,7 @@ def _get_ep_obj(self, show, season, episodes):
 
             # now that we've figured out which episode this file is just load it manually
             try:
-                curEp = show.getEpisode(season, cur_episode)
+                curEp = show.get_episode(season, cur_episode)
                 if not curEp:
                     raise EpisodeNotFoundException()
             except EpisodeNotFoundException as error:
@@ -1058,7 +1058,7 @@ def process(self):
                 raise EpisodePostProcessingFailedException(_("Unable to create the show directory: ") + episode_object.show._location)
 
             # get metadata for the show (but not episode because it hasn't been fully processed)
-            episode_object.show.writeMetadata(True)
+            episode_object.show.write_metadata(True)
 
         # update the ep info before we rename so the quality & release name go into the name properly
         sql_l = []
diff --git a/sickchill/oldbeard/properFinder.py b/sickchill/oldbeard/properFinder.py
index e16e85631e..ddc5e4ea27 100644
--- a/sickchill/oldbeard/properFinder.py
+++ b/sickchill/oldbeard/properFinder.py
@@ -222,7 +222,7 @@ def _download_propers(self, proper_list):
                     continue
 
                 # get the episode object
-                episode_object = proper.show.getEpisode(proper.season, proper.episode)
+                episode_object = proper.show.get_episode(proper.season, proper.episode)
 
                 # make the result object
                 result = proper.provider.get_result([episode_object])
diff --git a/sickchill/oldbeard/providers/bjshare.py b/sickchill/oldbeard/providers/bjshare.py
index 7bff78fcd2..e60d363fea 100644
--- a/sickchill/oldbeard/providers/bjshare.py
+++ b/sickchill/oldbeard/providers/bjshare.py
@@ -11,9 +11,7 @@
 
 
 class Provider(TorrentProvider):
-    """
-    BJ-Share Torrent provider.
-    """
+    """BJ-Share Torrent provider."""
 
     def __init__(self):
         """Initialize the class."""
diff --git a/sickchill/oldbeard/scene_numbering.py b/sickchill/oldbeard/scene_numbering.py
index 42427e92aa..d541d82bec 100644
--- a/sickchill/oldbeard/scene_numbering.py
+++ b/sickchill/oldbeard/scene_numbering.py
@@ -209,7 +209,7 @@ def set_scene_numbering(indexer_id, indexer, season=None, episode=None, absolute
 
     # Reload data from DB so that cache and db are in sync
     show = Show.find(settings.showList, indexer_id)
-    show.flushEpisodes()
+    show.flush_episodes()
 
 
 def find_xem_numbering(indexer_id, indexer, season, episode):
diff --git a/sickchill/oldbeard/search.py b/sickchill/oldbeard/search.py
index 0148851dae..1a63bc11c0 100644
--- a/sickchill/oldbeard/search.py
+++ b/sickchill/oldbeard/search.py
@@ -317,7 +317,7 @@ def wanted_episodes(show, from_date):
             elif quality in allowed_qualities:
                 continue
 
-        episode_object = show.getEpisode(result["season"], result["episode"])
+        episode_object = show.get_episode(result["season"], result["episode"])
         episode_object.wantedQuality = [i for i in all_qualities if i > quality and i != common.Quality.UNKNOWN]
         wanted.append(episode_object)
 
@@ -526,7 +526,7 @@ def search_providers(show, episodes, manual=False, downCurQuality=False):
             some_wanted = False
             for episode_number in all_episodes:
                 for season in (x.season for x in episodes):
-                    if not show.wantEpisode(season, episode_number, season_quality, downCurQuality):
+                    if not show.want_episode(season, episode_number, season_quality, downCurQuality):
                         all_wanted = False
                     else:
                         some_wanted = True
@@ -537,7 +537,7 @@ def search_providers(show, episodes, manual=False, downCurQuality=False):
                 episode_objects = []
                 for episode_number in all_episodes:
                     for season in {x.season for x in episodes}:
-                        episode_objects.append(show.getEpisode(season, episode_number))
+                        episode_objects.append(show.get_episode(season, episode_number))
                 best_season_result.episodes = episode_objects
 
                 # Remove provider from thread name before return results
@@ -575,7 +575,7 @@ def search_providers(show, episodes, manual=False, downCurQuality=False):
                     episode_objects = []
                     for episode_number in all_episodes:
                         for season in {x.season for x in episodes}:
-                            episode_objects.append(show.getEpisode(season, episode_number))
+                            episode_objects.append(show.get_episode(season, episode_number))
                     best_season_result.episodes = episode_objects
 
                     if MULTI_EP_RESULT in found_results[curProvider.name]:
diff --git a/sickchill/oldbeard/searchBacklog.py b/sickchill/oldbeard/searchBacklog.py
index 1659184249..3467e5987a 100644
--- a/sickchill/oldbeard/searchBacklog.py
+++ b/sickchill/oldbeard/searchBacklog.py
@@ -139,7 +139,7 @@ def _get_segments(show, fromDate):
                 elif cur_quality in allowed_qualities:
                     continue
 
-            episode_object = show.getEpisode(sql_result["season"], sql_result["episode"])
+            episode_object = show.get_episode(sql_result["season"], sql_result["episode"])
 
             if episode_object.season not in wanted:
                 wanted[episode_object.season] = [episode_object]
diff --git a/sickchill/oldbeard/show_queue.py b/sickchill/oldbeard/show_queue.py
index 87373d264c..a66586f58b 100644
--- a/sickchill/oldbeard/show_queue.py
+++ b/sickchill/oldbeard/show_queue.py
@@ -480,7 +480,7 @@ def run(self):
         self.show.load_imdb_info()
 
         try:
-            self.show.saveToDB()
+            self.show.save_to_db()
         except Exception as error:
             logger.exception(f"Error saving the show to the database: {error}")
             logger.debug(traceback.format_exc())
@@ -492,7 +492,7 @@ def run(self):
             settings.showList.append(self.show)
 
         try:
-            self.show.loadEpisodesFromIndexer(force_all=True)
+            self.show.load_episodes_from_indexer(force_all=True)
         except Exception as error:
             logger.exception(f"Error with {self.show.idxr.name}, not creating episode list: {error}")
             logger.debug(traceback.format_exc())
@@ -501,7 +501,7 @@ def run(self):
         name_cache.build_name_cache(self.show)
 
         try:
-            self.show.loadEpisodesFromDir()
+            self.show.load_episodes_from_dir()
         except Exception as error:
             logger.exception(f"Error searching dir for episodes: {error}")
             logger.debug(traceback.format_exc())
@@ -512,11 +512,11 @@ def run(self):
             logger.info("Launching backlog for this show since its episodes are WANTED")
             settings.backlogSearchScheduler.action.searchBacklog([self.show])
 
-        self.show.writeMetadata()
-        self.show.updateMetadata()
-        self.show.populateCache()
+        self.show.write_metadata()
+        self.show.update_metadata()
+        self.show.populate_cache()
 
-        self.show.flushEpisodes()
+        self.show.flush_episodes()
 
         if settings.USE_TRAKT:
             # if there are specific episodes that need to be added by trakt
@@ -565,11 +565,11 @@ def run(self):
 
         logger.info(f"Performing refresh on {self.show.name}")
 
-        self.show.refreshDir()
-        self.show.writeMetadata()
+        self.show.refresh_dir()
+        self.show.write_metadata()
         if self.force:
-            self.show.updateMetadata()
-        self.show.populateCache()
+            self.show.update_metadata()
+        self.show.populate_cache()
 
         # Load XEM data to DB for show
         scene_numbering.xem_refresh(self.show.indexerid, self.show.indexer)
@@ -597,7 +597,7 @@ def run(self):
 
         ep_obj_rename_list = []
 
-        ep_obj_list = self.show.getAllEpisodes(has_location=True)
+        ep_obj_list = self.show.get_all_episodes(has_location=True)
         for cur_ep_obj in ep_obj_list:
             # Only want to rename if we have a location
             if cur_ep_obj.location:
@@ -655,18 +655,18 @@ def run(self):
 
         # have to save show before reading episodes from db
         try:
-            self.show.saveToDB()
+            self.show.save_to_db()
         except Exception as error:
             logger.exception(f"Error saving show info to the database: {error}")
             logger.debug(traceback.format_exc())
 
         # get episode list from DB
-        DBEpList = self.show.loadEpisodesFromDB()
+        DBEpList = self.show.load_episodes_from_db()
 
         # get episode list from TVDB
         logger.debug(f"Loading all episodes from {self.show.idxr.name}")
         try:
-            IndexerEpList = self.show.loadEpisodesFromIndexer(self.force)
+            IndexerEpList = self.show.load_episodes_from_indexer(self.force)
         except Exception as error:
             logger.exception(f"Unable to get info from {self.show.idxr.name}, the show info will not be refreshed: {error}")
             IndexerEpList = None
@@ -674,8 +674,8 @@ def run(self):
         if IndexerEpList:
             for curSeason in IndexerEpList:
                 for curEpisode in IndexerEpList[curSeason]:
-                    curEp = self.show.getEpisode(curSeason, curEpisode)
-                    curEp.saveToDB()
+                    curEp = self.show.get_episode(curSeason, curEpisode)
+                    curEp.save_to_db()
 
                     if curSeason in DBEpList and curEpisode in DBEpList[curSeason]:
                         del DBEpList[curSeason][curEpisode]
@@ -684,15 +684,15 @@ def run(self):
             for curSeason in DBEpList:
                 for curEpisode in DBEpList[curSeason]:
                     logger.info("Permanently deleting episode {0:02d}E{1:02d} from the database".format(curSeason, curEpisode))
-                    curEp = self.show.getEpisode(curSeason, curEpisode)
+                    curEp = self.show.get_episode(curSeason, curEpisode)
                     try:
-                        curEp.deleteEpisode()
+                        curEp.delete_episode()
                     except EpisodeDeletedException:
                         pass
 
         #  save show again, in case episodes have changed
         try:
-            self.show.saveToDB()
+            self.show.save_to_db()
         except Exception as error:
             logger.exception(f"Error saving show info to the database: {error}")
             logger.debug(traceback.format_exc())
@@ -716,7 +716,7 @@ def __init__(self, show=None, full=False):
     def run(self):
         super(QueueItemRemove, self).run()
         logger.info(f"Removing {self.show.name}")
-        self.show.deleteShow(full=self.full)
+        self.show.delete_show(full=self.full)
 
         if settings.USE_TRAKT:
             try:
diff --git a/sickchill/oldbeard/subtitles.py b/sickchill/oldbeard/subtitles.py
index 74da7ffc01..38d37bc41c 100644
--- a/sickchill/oldbeard/subtitles.py
+++ b/sickchill/oldbeard/subtitles.py
@@ -446,7 +446,7 @@ def dhm(td):
                     logger.debug(f"Show with ID {ep_show_id} not found in the database")
                     continue
 
-                episode_object = show_object.getEpisode(ep_season, ep_episode)
+                episode_object = show_object.get_episode(ep_season, ep_episode)
                 if isinstance(episode_object, str):
                     logger.debug(f"{ep_show_name} {ep_string} not found in the database")
                     continue
diff --git a/sickchill/oldbeard/traktChecker.py b/sickchill/oldbeard/traktChecker.py
index 3e449c8fc7..c35b507669 100644
--- a/sickchill/oldbeard/traktChecker.py
+++ b/sickchill/oldbeard/traktChecker.py
@@ -594,7 +594,7 @@ def _set_episode_to_wanted(show, season, episode):
         """
         Sets an episode to wanted, only if it is currently skipped
         """
-        episode_object = show.getEpisode(season, episode)
+        episode_object = show.get_episode(season, episode)
         if episode_object:
             with episode_object.lock:
                 if episode_object.status != SKIPPED or episode_object.airdate == datetime.date.min:
@@ -604,7 +604,7 @@ def _set_episode_to_wanted(show, season, episode):
                 # figure out what segment the episode is in and remember it, so we can backlog it
 
                 episode_object.status = WANTED
-                episode_object.saveToDB()
+                episode_object.save_to_db()
 
             cur_backlog_queue_item = search_queue.BacklogQueueItem(show, [episode_object])
             settings.searchQueueScheduler.action.add_item(cur_backlog_queue_item)
diff --git a/sickchill/oldbeard/tvcache.py b/sickchill/oldbeard/tvcache.py
index bde58fbb84..5698c00199 100644
--- a/sickchill/oldbeard/tvcache.py
+++ b/sickchill/oldbeard/tvcache.py
@@ -419,7 +419,7 @@ def list_propers(self, date=None):
         propers_results = cache_db_con.select(sql, [self.provider_id])
         return [x for x in propers_results if x["indexerid"]]
 
-    def find_needed_episodes(self, episode, manualSearch=False, downCurQuality=False):
+    def find_needed_episodes(self, episode, manual_search=False, down_cur_quality=False):
         needed_eps = {}
         cl = []
 
@@ -477,11 +477,11 @@ def find_needed_episodes(self, episode, manualSearch=False, downCurQuality=False
             cur_version = cur_result["version"]
 
             # if the show says we want that episode then add it to the list
-            if not show_obj.wantEpisode(cur_season, cur_ep, cur_quality, manualSearch, downCurQuality):
+            if not show_obj.want_episode(cur_season, cur_ep, cur_quality, manual_search, down_cur_quality):
                 logger.debug("Ignoring " + cur_result["name"])
                 continue
 
-            episode_object = show_obj.getEpisode(cur_season, cur_ep)
+            episode_object = show_obj.get_episode(cur_season, cur_ep)
 
             # build a result object
             title = cur_result["name"]
diff --git a/sickchill/providers/GenericProvider.py b/sickchill/providers/GenericProvider.py
index 00346295bb..dcdd5870f6 100644
--- a/sickchill/providers/GenericProvider.py
+++ b/sickchill/providers/GenericProvider.py
@@ -281,7 +281,7 @@ def find_search_results(self, show, episodes, search_mode, manual_search=False,
                 continue
 
             for episode_number in actual_episodes:
-                if not show_object.wantEpisode(actual_season, episode_number, quality, manual_search, download_current_quality):
+                if not show_object.want_episode(actual_season, episode_number, quality, manual_search, download_current_quality):
                     skip_release = True
                     break
 
@@ -293,7 +293,7 @@ def find_search_results(self, show, episodes, search_mode, manual_search=False,
 
             episode_objects = []
             for current_episode in actual_episodes:
-                episode_objects.append(show_object.getEpisode(actual_season, current_episode))
+                episode_objects.append(show_object.get_episode(actual_season, current_episode))
 
             result = self.get_result(episode_objects)
             result.show = show_object
@@ -587,9 +587,6 @@ def add_cookies_from_ui(self):
 
         return False, f"No Cookies added from ui for provider: {self.name}"
 
-    def has_option(self, option):
-        return hasattr(self, option)
-
     def check_set_option(self, view, option, default="", cast: Callable = str, unhide=False):
         if hasattr(self, option):
             if view.request.method == "GET":
@@ -636,7 +633,7 @@ def __restore_original_urls(self):
     def check_and_update_urls(self):
         has_custom_url = False
         custom_url_valid = True
-        if hasattr(self, "custom_url") and self.has_option("url") and self.has_option("urls"):
+        if hasattr(self, "custom_url") and hasattr(self, "url") and hasattr(self, "urls"):
             has_custom_url = bool(self.custom_url)
             custom_url_valid = self.valid_url(self.custom_url)
             if has_custom_url and custom_url_valid:
diff --git a/sickchill/providers/metadata/generic.py b/sickchill/providers/metadata/generic.py
index de04b71f28..9c0b83f75d 100644
--- a/sickchill/providers/metadata/generic.py
+++ b/sickchill/providers/metadata/generic.py
@@ -115,7 +115,7 @@ def _check_exists(location):
     def _has_show_metadata(self, show_obj):
         return self._check_exists(self.get_show_file_path(show_obj))
 
-    def _has_episode_metadata(self, episode_object):
+    def has_episode_metadata(self, episode_object):
         return self._check_exists(self.get_episode_file_path(episode_object))
 
     def _has_fanart(self, show_obj):
@@ -127,7 +127,7 @@ def _has_poster(self, show_obj):
     def _has_banner(self, show_obj):
         return self._check_exists(self.get_banner_path(show_obj))
 
-    def _has_episode_thumb(self, episode_object):
+    def has_episode_thumb(self, episode_object):
         return self._check_exists(self.get_episode_thumb_path(episode_object))
 
     def _has_season_poster(self, show_obj, season):
@@ -248,7 +248,7 @@ def update_show_indexer_metadata(self, show_obj):
                 if indexerid is not None:
                     if indexerid.text == str(show_obj.indexerid):
                         return True
-                        indexerid.text = str(show_obj.indexerid)
+                    indexerid.text = str(show_obj.indexerid)
                 else:
                     ElementTree.SubElement(root, "id").text = str(show_obj.indexerid)
 
@@ -263,13 +263,13 @@ def update_show_indexer_metadata(self, show_obj):
                 logger.error(f"Unable to write file to {nfo_file_path} - are you sure the folder is writable? {error}")
 
     def create_episode_metadata(self, episode_object):
-        if self.episode_metadata and episode_object and not self._has_episode_metadata(episode_object):
+        if self.episode_metadata and episode_object and not self.has_episode_metadata(episode_object):
             logger.debug(f"[{self.name} META] Creating episode metadata for {episode_object.pretty_name}")
             return self.write_ep_file(episode_object)
         return False
 
     def update_episode_metadata(self, episode_object):
-        if self.episode_metadata and episode_object and self._has_episode_metadata(episode_object):
+        if self.episode_metadata and episode_object and self.has_episode_metadata(episode_object):
             logger.debug(f"[{self.name} META] Updating episode indexer info metadata file for {episode_object.pretty_name}")
             nfo_file_path = self.get_episode_file_path(episode_object)
 
@@ -342,7 +342,7 @@ def create_banner(self, show_obj):
         return False
 
     def create_episode_thumb(self, episode_object):
-        if self.episode_thumbnails and episode_object and not self._has_episode_thumb(episode_object):
+        if self.episode_thumbnails and episode_object and not self.has_episode_thumb(episode_object):
             logger.debug(f"[{self.name} META] Creating episode thumbnail for {episode_object.pretty_name}")
             return self.save_thumbnail(episode_object)
         return False
diff --git a/sickchill/providers/torrent/TorrentProvider.py b/sickchill/providers/torrent/TorrentProvider.py
index 027524b8a2..1a9f4c2931 100644
--- a/sickchill/providers/torrent/TorrentProvider.py
+++ b/sickchill/providers/torrent/TorrentProvider.py
@@ -31,7 +31,7 @@ def find_propers(self, search_date=None):
             show = Show.find(settings.showList, int(result["showid"]))
 
             if show:
-                episode = show.getEpisode(result["season"], result["episode"])
+                episode = show.get_episode(result["season"], result["episode"])
                 self.current_episode_object = episode
 
                 for term in self.proper_strings:
diff --git a/sickchill/show/ComingEpisodes.py b/sickchill/show/ComingEpisodes.py
index b531506cd0..03fee34290 100644
--- a/sickchill/show/ComingEpisodes.py
+++ b/sickchill/show/ComingEpisodes.py
@@ -76,7 +76,7 @@ def get_coming_episodes(categories, sort, group, paused=settings.COMING_EPS_DISP
 
         sql_l = []
         for show_obj in settings.showList:
-            next_air_date = show_obj.nextEpisode()
+            next_air_date = show_obj.next_episode()
             sql_l.append(
                 [
                     "SELECT DISTINCT {0} ".format(fields_to_select) + "FROM tv_episodes e, tv_shows s "
diff --git a/sickchill/show/History.py b/sickchill/show/History.py
index 8ce3e5141c..aa55d98a82 100644
--- a/sickchill/show/History.py
+++ b/sickchill/show/History.py
@@ -312,7 +312,7 @@ def revert_episode(self, episode_object: "TVEpisode"):
                 else:
                     logger.debug("Episode don't have a previous snatched status to revert. Setting it back to WANTED")
                     episode_object.status = WANTED
-                    episode_object.saveToDB()
+                    episode_object.save_to_db()
 
         except EpisodeNotFoundException as error:
             logger.warning(f"Unable to create episode, please set its status manually: {error}")
@@ -332,7 +332,7 @@ def mark_failed(self, episode_object: "TVEpisode"):
             with episode_object.lock:
                 quality = Quality.splitCompositeStatus(episode_object.status)[1]
                 episode_object.status = Quality.compositeStatus(FAILED, quality)
-                episode_object.saveToDB()
+                episode_object.save_to_db()
 
         except EpisodeNotFoundException as error:
             logger.warning(f"Unable to get episode, please set its status manually: {error}")
diff --git a/sickchill/show/Show.py b/sickchill/show/Show.py
index 36b0f76570..204f8e2b39 100644
--- a/sickchill/show/Show.py
+++ b/sickchill/show/Show.py
@@ -161,7 +161,7 @@ def pause(indexer_id, pause=None):
         else:
             show.paused = pause
 
-        show.saveToDB()
+        show.save_to_db()
 
         return None, show
 
diff --git a/sickchill/show_updater.py b/sickchill/show_updater.py
index 8d9f2f9cec..db14cbf1e0 100644
--- a/sickchill/show_updater.py
+++ b/sickchill/show_updater.py
@@ -50,7 +50,7 @@ def run(self, force=False):
                 pi_list = []
                 for cur_show in settings.showList:
                     try:
-                        cur_show.nextEpisode()
+                        cur_show.next_episode()
 
                         skip_update = False
                         # Skip ended or paused shows until interval is met
diff --git a/sickchill/start.py b/sickchill/start.py
index ea7592a809..51185eb422 100644
--- a/sickchill/start.py
+++ b/sickchill/start.py
@@ -124,18 +124,17 @@ def initialize(console_logging: bool = True, debug: bool = False, dbdebug: bool
             restore_dir = os.path.join(settings.DATA_DIR, "restore")
             if os.path.exists(restore_dir) and os.path.exists(os.path.join(restore_dir, "cache")):
 
-                def restore_cache(srcDir, dstDir):
+                def restore_cache(source, destination):
                     def path_leaf(path):
                         head, tail = os.path.split(path)
                         return tail or os.path.basename(head)
 
                     try:
-                        if os.path.isdir(dstDir):
-                            # noinspection PyTypeChecker
-                            bakFilename = "{0}-{1}".format(path_leaf(dstDir), datetime.datetime.strftime(datetime.datetime.now(), "%Y%m%d_%H%M%S"))
-                            shutil.move(dstDir, os.path.join(os.path.dirname(dstDir), bakFilename))
+                        if os.path.isdir(destination):
+                            backup_name = "{0}-{1}".format(path_leaf(destination), datetime.datetime.strftime(datetime.datetime.now(), "%Y%m%d_%H%M%S"))
+                            shutil.move(destination, os.path.join(os.path.dirname(destination), backup_name))
 
-                        shutil.move(srcDir, dstDir)
+                        shutil.move(source, destination)
                         logger.info("Restore: restoring cache successful")
                     except Exception as er:
                         logger.exception(f"Restore: restoring cache failed: {er}")
@@ -784,59 +783,59 @@ def path_leaf(path):
             curProvider.enabled = (curProvider.can_daily or curProvider.can_backlog) and check_setting_bool(
                 settings.CFG, curProvider.get_id().upper(), curProvider.get_id()
             )
-            if curProvider.has_option("custom_url"):
+            if hasattr(curProvider, "custom_url"):
                 curProvider.custom_url = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_custom_url"), "", censor_log=True)
-            if curProvider.has_option("api_key"):
+            if hasattr(curProvider, "api_key"):
                 curProvider.api_key = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_api_key"), censor_log=True)
-            if curProvider.has_option("hash"):
+            if hasattr(curProvider, "hash"):
                 curProvider.hash = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_hash"), censor_log=True)
-            if curProvider.has_option("digest"):
+            if hasattr(curProvider, "digest"):
                 curProvider.digest = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_digest"), censor_log=True)
-            if curProvider.has_option("username"):
+            if hasattr(curProvider, "username"):
                 curProvider.username = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_username"), censor_log=True)
-            if curProvider.has_option("password"):
+            if hasattr(curProvider, "password"):
                 curProvider.password = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_password"), censor_log=True)
-            if curProvider.has_option("passkey"):
+            if hasattr(curProvider, "passkey"):
                 curProvider.passkey = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_passkey"), censor_log=True)
-            if curProvider.has_option("pin"):
+            if hasattr(curProvider, "pin"):
                 curProvider.pin = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_pin"), censor_log=True)
-            if curProvider.has_option("confirmed"):
+            if hasattr(curProvider, "confirmed"):
                 curProvider.confirmed = check_setting_bool(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_confirmed"), True)
-            if curProvider.has_option("ranked"):
+            if hasattr(curProvider, "ranked"):
                 curProvider.ranked = check_setting_bool(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_ranked"), True)
-            if curProvider.has_option("engrelease"):
+            if hasattr(curProvider, "engrelease"):
                 curProvider.engrelease = check_setting_bool(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_engrelease"))
-            if curProvider.has_option("only_spanish_search"):
+            if hasattr(curProvider, "only_spanish_search"):
                 curProvider.only_spanish_search = check_setting_bool(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_only_spanish_search"))
-            if curProvider.has_option("sorting"):
+            if hasattr(curProvider, "sorting"):
                 curProvider.sorting = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_sorting"), "seeders")
-            if curProvider.has_option("options"):
+            if hasattr(curProvider, "options"):
                 curProvider.options = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_options"), "")
-            if curProvider.has_option("ratio"):
+            if hasattr(curProvider, "ratio"):
                 curProvider.ratio = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_ratio"), "")
-            if curProvider.has_option("minseed"):
+            if hasattr(curProvider, "minseed"):
                 curProvider.minseed = check_setting_int(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_minseed"), 1, min_val=0)
-            if curProvider.has_option("minleech"):
-                curProvider.minleech = check_setting_int(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_minleech"), 0, min_val=0)
-            if curProvider.has_option("freeleech"):
+            if hasattr(curProvider, "minleech"):
+                curProvider.minleech = check_setting_int(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_minleech"), min_val=0)
+            if hasattr(curProvider, "freeleech"):
                 curProvider.freeleech = check_setting_bool(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_freeleech"))
-            if curProvider.has_option("search_mode"):
+            if hasattr(curProvider, "search_mode"):
                 curProvider.search_mode = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_search_mode"), "episode")
-            if curProvider.has_option("search_fallback"):
+            if hasattr(curProvider, "search_fallback"):
                 curProvider.search_fallback = check_setting_bool(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_search_fallback"))
-            if curProvider.has_option("enable_daily"):
+            if hasattr(curProvider, "enable_daily"):
                 curProvider.enable_daily = curProvider.can_daily and check_setting_bool(
                     settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_enable_daily"), True
                 )
-            if curProvider.has_option("enable_backlog"):
+            if hasattr(curProvider, "enable_backlog"):
                 curProvider.enable_backlog = curProvider.can_backlog and check_setting_bool(
                     settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_enable_backlog"), curProvider.can_backlog
                 )
-            if curProvider.has_option("cat"):
-                curProvider.cat = check_setting_int(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_cat"), 0)
-            if curProvider.has_option("subtitle"):
+            if hasattr(curProvider, "cat"):
+                curProvider.cat = check_setting_int(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_cat"))
+            if hasattr(curProvider, "subtitle"):
                 curProvider.subtitle = check_setting_bool(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_subtitle"))
-            if curProvider.has_option("cookies"):
+            if hasattr(curProvider, "cookies"):
                 curProvider.cookies = check_setting_str(settings.CFG, curProvider.get_id().upper(), curProvider.get_id("_cookies"), censor_log=True)
 
         providers.check_enabled_providers()
@@ -1081,11 +1080,11 @@ def sig_handler(signum=None, frame=None):
         Shutdown.stop(settings.PID)
 
 
-def saveAll():
+def save_all():
     # write all shows
     logger.info("Saving all shows to the database")
     for show in settings.showList:
-        show.saveToDB()
+        show.save_to_db()
 
     # save config
     logger.info("Saving config file to disk")
@@ -1095,60 +1094,60 @@ def saveAll():
 def save_config():
     new_config = ConfigObj(settings.CONFIG_FILE, encoding="UTF-8", indent_type="  ")
 
-    # For passwords you must include the word `password` in the item_name and add `helpers.encrypt(settings.ITEM_NAME, settings.ENCRYPTION_VERSION)` in save_config()
+    # For passwords, you must include the word `password` in the item_name and add `helpers.encrypt(settings.ITEM_NAME, settings.ENCRYPTION_VERSION)` in save_config()
     # dynamically save provider settings
     for curProvider in providers.sorted_provider_list():
         new_config[curProvider.get_id().upper()] = {}
         new_config[curProvider.get_id().upper()][curProvider.get_id()] = int(curProvider.enabled)
-        if curProvider.has_option("custom_url"):
+        if hasattr(curProvider, "custom_url"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_custom_url")] = curProvider.custom_url
-        if curProvider.has_option("digest"):
+        if hasattr(curProvider, "digest"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_digest")] = curProvider.digest
-        if curProvider.has_option("hash"):
+        if hasattr(curProvider, "hash"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_hash")] = curProvider.hash
-        if curProvider.has_option("api_key"):
+        if hasattr(curProvider, "api_key"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_api_key")] = curProvider.api_key
-        if curProvider.has_option("username"):
+        if hasattr(curProvider, "username"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_username")] = curProvider.username
-        if curProvider.has_option("password"):
+        if hasattr(curProvider, "password"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_password")] = helpers.encrypt(curProvider.password, settings.ENCRYPTION_VERSION)
-        if curProvider.has_option("passkey"):
+        if hasattr(curProvider, "passkey"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_passkey")] = curProvider.passkey
-        if curProvider.has_option("pin"):
+        if hasattr(curProvider, "pin"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_pin")] = curProvider.pin
-        if curProvider.has_option("confirmed"):
+        if hasattr(curProvider, "confirmed"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_confirmed")] = int(curProvider.confirmed)
-        if curProvider.has_option("ranked"):
+        if hasattr(curProvider, "ranked"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_ranked")] = int(curProvider.ranked)
-        if curProvider.has_option("engrelease"):
+        if hasattr(curProvider, "engrelease"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_engrelease")] = int(curProvider.engrelease)
-        if curProvider.has_option("only_spanish_search"):
+        if hasattr(curProvider, "only_spanish_search"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_only_spanish_search")] = int(curProvider.only_spanish_search)
-        if curProvider.has_option("sorting"):
+        if hasattr(curProvider, "sorting"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_sorting")] = curProvider.sorting
-        if curProvider.has_option("ratio"):
+        if hasattr(curProvider, "ratio"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_ratio")] = curProvider.ratio
-        if curProvider.has_option("minseed"):
+        if hasattr(curProvider, "minseed"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_minseed")] = int(curProvider.minseed)
-        if curProvider.has_option("minleech"):
+        if hasattr(curProvider, "minleech"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_minleech")] = int(curProvider.minleech)
-        if curProvider.has_option("options"):
+        if hasattr(curProvider, "options"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_options")] = curProvider.options
-        if curProvider.has_option("freeleech"):
+        if hasattr(curProvider, "freeleech"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_freeleech")] = int(curProvider.freeleech)
-        if curProvider.has_option("search_mode"):
+        if hasattr(curProvider, "search_mode"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_search_mode")] = curProvider.search_mode
-        if curProvider.has_option("search_fallback"):
+        if hasattr(curProvider, "search_fallback"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_search_fallback")] = int(curProvider.search_fallback)
-        if curProvider.has_option("enable_daily"):
+        if hasattr(curProvider, "enable_daily"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_enable_daily")] = int(curProvider.enable_daily and curProvider.can_daily)
-        if curProvider.has_option("enable_backlog"):
+        if hasattr(curProvider, "enable_backlog"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_enable_backlog")] = int(curProvider.enable_backlog and curProvider.can_backlog)
-        if curProvider.has_option("cat"):
+        if hasattr(curProvider, "cat"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_cat")] = int(curProvider.cat)
-        if curProvider.has_option("subtitle"):
+        if hasattr(curProvider, "subtitle"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_subtitle")] = int(curProvider.subtitle)
-        if curProvider.has_option("cookies"):
+        if hasattr(curProvider, "cookies"):
             new_config[curProvider.get_id().upper()][curProvider.get_id("_cookies")] = curProvider.cookies
 
     new_config.update(
@@ -1701,9 +1700,9 @@ def launchBrowser(protocol="http", startPort=None, web_root="/"):
     browserURL = f"{protocol}://localhost:{startPort:d}{web_root}/home/"
 
     try:
-        webbrowser.open(browserURL, 2, True)
+        webbrowser.open(browserURL, 2)
     except Exception:
         try:
-            webbrowser.open(browserURL, 1, True)
+            webbrowser.open(browserURL, 1)
         except Exception:
             logger.exception("Unable to launch a browser")
diff --git a/sickchill/tv.py b/sickchill/tv.py
index 8d0cc766c1..06f3a62079 100644
--- a/sickchill/tv.py
+++ b/sickchill/tv.py
@@ -15,6 +15,7 @@
 
 import imdb
 from imdb import Cinemagoer
+
 from unidecode import unidecode
 from urllib3.exceptions import MaxRetryError, NewConnectionError
 
@@ -125,18 +126,18 @@ def __init__(self, indexer, indexerid: int, lang=""):
 
         self.lock = threading.Lock()
         self.episodes = {}
-        self.nextaired = ""
+        self.next_airdate = ""
         self.release_groups = None
         self._location = ""
         self.indexer = indexer
         self.indexerid = indexerid
         self.lang = lang
 
-        otherShow = Show.find(settings.showList, self.indexerid)
-        if otherShow is not None:
+        other_show = Show.find(settings.showList, self.indexerid)
+        if other_show is not None:
             raise MultipleShowObjectsException("Can't create a show if it already exists")
 
-        self.loadFromDB()
+        self.load_from_db()
 
     @property
     def name(self):
@@ -181,32 +182,32 @@ def network_image_url(self):
     def show_image_url(self, which):
         return settings.IMAGE_CACHE.image_url(self.indexerid, which)
 
-    def _getLocation(self):
+    @property
+    def location(self):
         # no dir check needed if missing show dirs are created during post-processing
         if settings.CREATE_MISSING_SHOW_DIRS or os.path.isdir(self._location):
             return self._location
 
         raise ShowDirectoryNotFoundException("Show folder doesn't exist, you shouldn't be using it")
 
-    def _setLocation(self, newLocation):
-        logger.debug(f"Setter sets location to {newLocation}")
+    @location.setter
+    def location(self, new_location):
+        logger.debug(f"Setter sets location to {new_location}")
         # Don't validate dir if user wants to add shows without creating a dir
-        if settings.ADD_SHOWS_WO_DIR or os.path.isdir(newLocation):
-            if self._location != newLocation:
+        if settings.ADD_SHOWS_WO_DIR or os.path.isdir(new_location):
+            if self._location != new_location:
                 self.dirty = True
-            self._location = newLocation
+            self._location = new_location
         else:
             raise NoNFOException("Invalid folder for the show!")
 
-    location = property(_getLocation, _setLocation)
-
-    def flushEpisodes(self):
-        for curSeason in self.episodes:
-            self.episodes[curSeason].clear()
+    def flush_episodes(self):
+        for current_season in self.episodes:
+            self.episodes[current_season].clear()
 
         self.episodes.clear()
 
-    def getAllEpisodes(self, season=None, has_location=False):
+    def get_all_episodes(self, season=None, has_location=False):
         # detect multi-episodes
         sql_selection = "SELECT season, episode, "
         sql_selection += "(SELECT COUNT (*) FROM tv_episodes WHERE showid = tve.showid "
@@ -228,7 +229,7 @@ def getAllEpisodes(self, season=None, has_location=False):
 
         ep_list = []
         for cur_result in results:
-            cur_ep = self.getEpisode(cur_result["season"], cur_result["episode"])
+            cur_ep = self.get_episode(cur_result["season"], cur_result["episode"])
             if not cur_ep:
                 continue
 
@@ -241,14 +242,14 @@ def getAllEpisodes(self, season=None, has_location=False):
                         [self.indexerid, cur_ep.season, cur_ep.location, cur_ep.episode],
                     )
                     for cur_related_ep in related_eps_result:
-                        related_ep = self.getEpisode(cur_related_ep["season"], cur_related_ep["episode"])
+                        related_ep = self.get_episode(cur_related_ep["season"], cur_related_ep["episode"])
                         if related_ep and related_ep not in cur_ep.related_episodes:
                             cur_ep.related_episodes.append(related_ep)
             ep_list.append(cur_ep)
 
         return ep_list
 
-    def getEpisode(self, season=None, episode=None, ep_file=None, noCreate=False, absolute_number=None) -> Union["TVEpisode", None]:
+    def get_episode(self, season=None, episode=None, ep_file=None, nfo_create=False, absolute_number=None) -> Union["TVEpisode", None]:
         season = try_int(season, None)
         episode = try_int(episode, None)
         absolute_number = try_int(absolute_number, None)
@@ -278,7 +279,7 @@ def getEpisode(self, season=None, episode=None, ep_file=None, noCreate=False, ab
             self.episodes[season] = {}
 
         if not self.episodes[season].get(episode):
-            if noCreate:
+            if nfo_create:
                 return None
 
             if ep_file:
@@ -334,7 +335,7 @@ def should_update(self, update_date=datetime.date.today()):
 
         return False
 
-    def writeShowNFO(self):
+    def write_show_nfo(self):
         result = False
 
         if not os.path.isdir(self._location):
@@ -347,19 +348,19 @@ def writeShowNFO(self):
 
         return result
 
-    def writeMetadata(self, show_only=False):
+    def write_metadata(self, show_only=False):
         if not os.path.isdir(self._location):
             logger.info(f"{self.indexerid}: Show dir doesn't exist, skipping NFO generation")
             return
 
-        self.getImages()
+        self.get_images()
 
-        self.writeShowNFO()
+        self.write_show_nfo()
 
         if not show_only:
-            self.writeEpisodeNFOs()
+            self.write_episode_nfos()
 
-    def writeEpisodeNFOs(self):
+    def write_episode_nfos(self):
         if not os.path.isdir(self._location):
             logger.info(f"{self.indexerid}: Show dir doesn't exist, skipping NFO generation")
             return
@@ -371,13 +372,13 @@ def writeEpisodeNFOs(self):
 
         for epResult in sql_results:
             logger.debug("{id}: Retrieving/creating episode {ep}".format(id=self.indexerid, ep=episode_num(epResult["season"], epResult["episode"])))
-            curEp = self.getEpisode(epResult["season"], epResult["episode"])
-            if not curEp:
+            current_episode = self.get_episode(epResult["season"], epResult["episode"])
+            if not current_episode:
                 continue
 
-            curEp.createMetaFiles()
+            current_episode.create_meta_files()
 
-    def updateMetadata(self):
+    def update_metadata(self):
         if not os.path.isdir(self._location):
             logger.info(f"{self.indexerid}: Show dir doesn't exist, skipping NFO generation")
             return
@@ -394,7 +395,7 @@ def updateMetadata(self):
 
         return result
 
-    def loadEpisodesFromDir(self):
+    def load_episodes_from_dir(self):
         """Find all media files in the show folder and create episodes"""
 
         if not os.path.isdir(self._location):
@@ -409,9 +410,9 @@ def loadEpisodesFromDir(self):
         sql_l = []
         for media_file in media_files:
             logger.debug("{tvdbid}: Creating episode from {filename}".format(tvdbid=str(self.indexerid), filename=os.path.basename(media_file)))
-            curEpisode = None
+            current_episode = None
             try:
-                curEpisode = self.makeEpFromFile(media_file)
+                current_episode = self.make_ep_from_file(media_file)
             except (ShowNotFoundException, EpisodeNotFoundException) as error:
                 media_file_name = os.path.basename(media_file)
                 logger.error(f"Episode {media_file_name} returned an exception: {error}")
@@ -419,11 +420,11 @@ def loadEpisodesFromDir(self):
             except EpisodeDeletedException:
                 logger.debug("The episode deleted itself when I tried making an object for it")
 
-            if curEpisode is None:
+            if current_episode is None:
                 continue
 
             # see if we should save the release name in the db
-            ep_filename = os.path.basename(curEpisode.location)
+            ep_filename = os.path.basename(current_episode.location)
             ep_filename = os.path.splitext(ep_filename)[0]
 
             try:
@@ -433,27 +434,27 @@ def loadEpisodesFromDir(self):
 
             if " " not in ep_filename and parse_result and parse_result.release_group:
                 logger.debug(f"Name {ep_filename} gave release group of {parse_result.release_group}, seems valid")
-                curEpisode.release_name = ep_filename
-                curEpisode.release_group = parse_result.release_group
+                current_episode.release_name = ep_filename
+                current_episode.release_group = parse_result.release_group
 
             # store the reference in the show
-            if curEpisode is not None:
+            if current_episode is not None:
                 if self.subtitles:
                     try:
-                        curEpisode.refreshSubtitles()
+                        current_episode.refresh_subtitles()
                     except Exception:
                         logger.error(f"{self.indexerid}: Could not refresh subtitles")
                         logger.debug(traceback.format_exc())
 
-                sql_l.append(curEpisode.get_sql())
+                sql_l.append(current_episode.get_sql())
 
         if sql_l:
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
 
-    def loadEpisodesFromDB(self):
+    def load_episodes_from_db(self):
         logger.debug("Loading all episodes from the database")
-        scannedEps = {}
+        scanned_episodes = {}
 
         try:
             main_db_con = db.DBConnection()
@@ -461,56 +462,54 @@ def loadEpisodesFromDB(self):
             sql_results = main_db_con.select(sql, [self.indexerid])
         except OperationalError as error:
             logger.error(f"Could not load episodes from the DB. Error: {error}")
-            return scannedEps
+            return scanned_episodes
 
-        curShowid = None
-        curShowName = None
+        showid = None
+        show_name = None
 
-        for curResult in sql_results:
-            curSeason = int(curResult["season"])
-            curEpisode = int(curResult["episode"])
-            curShowid = int(curResult["showid"])
-            curShowName = str(curResult["show_name"])
+        for result in sql_results:
+            season = int(result["season"])
+            episode = int(result["episode"])
+            showid = int(result["showid"])
+            show_name = str(result["show_name"])
 
-            if curSeason not in scannedEps:
-                logger.debug("{id}: Not curSeason in scannedEps".format(id=curShowid))
-                scannedEps[curSeason] = {}
+            if season not in scanned_episodes:
+                logger.debug(f"{showid}: season not in scanned_episodes")
+                scanned_episodes[season] = {}
 
-            logger.debug("{id}: Loading {show} {ep} from the DB".format(id=curShowid, show=curShowName, ep=episode_num(curSeason, curEpisode)))
+            logger.debug(f"{showid}: Loading {show_name} {episode_num(season, episode)} from the DB")
 
             try:
-                curEp = self.getEpisode(curSeason, curEpisode)
-                if not curEp:
+                episode_object = self.get_episode(season, episode)
+                if not episode_object:
                     raise EpisodeNotFoundException
 
-                curEp.loadFromDB(curSeason, curEpisode)
-                scannedEps[curSeason][curEpisode] = True
+                episode_object.load_from_db(season, episode)
+                scanned_episodes[season][episode] = True
             except EpisodeDeletedException:
                 logger.debug(
-                    "{id}: Tried loading {show} {ep} from the DB that should have been deleted, skipping it".format(
-                        id=curShowid, show=curShowName, ep=episode_num(curSeason, curEpisode)
-                    )
+                    f"{showid}: Tried loading {show_name} {episode_num(season, episode)} from the DB that should have been deleted, skipping it"
                 )
                 continue
 
-        if curShowName and curShowid:
-            logger.debug("{id}: Finished loading all episodes for {show} from the DB".format(show=curShowName, id=curShowid))
+        if show_name and showid:
+            logger.debug(f"{showid}: Finished loading all episodes for {show_name} from the DB")
 
-        return scannedEps
+        return scanned_episodes
 
-    def loadEpisodesFromIndexer(self, force_all: bool = False):
+    def load_episodes_from_indexer(self, force_all: bool = False):
         logger.debug(_("{show_id}: Loading all episodes from {indexer_name}...").format(show_id=self.indexerid, indexer_name=self.indexer_name))
 
-        scannedEps = {}
+        scanned_episodes = {}
 
-        for series_episode in self.idxr.episodes(self):
-            if series_episode["airedSeason"] not in scannedEps:
-                scannedEps[series_episode["airedSeason"]] = {}
+        for indexer_episode in self.idxr.episodes(self):
+            if indexer_episode["airedSeason"] not in scanned_episodes:
+                scanned_episodes[indexer_episode["airedSeason"]] = {}
 
-            season_episode = series_episode["airedSeason"], series_episode["airedEpisodeNumber"]
+            season_episode = indexer_episode["airedSeason"], indexer_episode["airedEpisodeNumber"]
             try:
-                show_episode = self.getEpisode(*season_episode)
-                if not show_episode:
+                episode = self.get_episode(*season_episode)
+                if not episode:
                     raise EpisodeNotFoundException
             except EpisodeNotFoundException:
                 logger.info(
@@ -521,24 +520,24 @@ def loadEpisodesFromIndexer(self, force_all: bool = False):
                 continue
             else:
                 try:
-                    with show_episode.lock:
-                        show_episode.load_from_indexer(series_episode["airedSeason"], series_episode["airedEpisodeNumber"], force_all=force_all)
-                        show_episode.saveToDB()
-                        # sql_l.append(show_episode.get_sql())
+                    with episode.lock:
+                        episode.load_from_indexer(indexer_episode["airedSeason"], indexer_episode["airedEpisodeNumber"], force_all=force_all)
+                        episode.save_to_db()
+                        # sql_l.append(episode.get_sql())
                 except EpisodeDeletedException:
                     logger.info("The episode was deleted, skipping the rest of the load")
                     continue
 
-            scannedEps[series_episode["airedSeason"]][series_episode["airedEpisodeNumber"]] = True
+            scanned_episodes[indexer_episode["airedSeason"]][indexer_episode["airedEpisodeNumber"]] = True
 
         # Done updating save last update date
         self.last_update_indexer = datetime.datetime.now().toordinal()
 
-        self.saveToDB()
+        self.save_to_db()
 
-        return scannedEps
+        return scanned_episodes
 
-    def getImages(self):
+    def get_images(self):
         fanart_result = poster_result = banner_result = False
         season_posters_result = season_banners_result = season_all_poster_result = season_all_banner_result = False
 
@@ -562,7 +561,7 @@ def getImages(self):
             or season_all_banner_result
         )
 
-    def makeEpFromFile(self, filepath):
+    def make_ep_from_file(self, filepath):
         """make a TVEpisode object from a media file"""
 
         if not os.path.isfile(filepath):
@@ -572,7 +571,7 @@ def makeEpFromFile(self, filepath):
         logger.debug(f"{self.indexerid}: Creating episode object from {filepath}")
 
         try:
-            parse_result = NameParser(showObj=self, tryIndexers=True, parse_method=("normal", "anime")[self.is_anime]).parse(filepath, True, True)
+            parse_result = NameParser(showObj=self, tryIndexers=True, parse_method=("normal", "anime")[self.is_anime]).parse(filepath, skip_scene_detection=True)
         except (InvalidNameException, InvalidShowException) as error:
             logger.debug(f"{self.indexerid}: {error}")
             return None
@@ -585,20 +584,20 @@ def makeEpFromFile(self, filepath):
 
         # for now let's assume that any episode in the show dir belongs to that show
         season = parse_result.season_number if parse_result.season_number is not None else 1
-        rootEp = None
+        root_episode = None
 
         sql_l = []
-        for current_ep in episodes:
-            logger.debug(f"{self.indexerid}: {filepath} parsed to {self.name} {episode_num(season, current_ep)}")
+        for current_episode in episodes:
+            logger.debug(f"{self.indexerid}: {filepath} parsed to {self.name} {episode_num(season, current_episode)}")
 
-            checkQualityAgain = False
+            check_quality_again = False
             same_file = False
 
-            curEp = self.getEpisode(season, current_ep)
-            if not curEp:
+            episode = self.get_episode(season, current_episode)
+            if not episode:
                 try:
-                    curEp = self.getEpisode(season, current_ep, filepath)
-                    if not curEp:
+                    episode = self.get_episode(season, current_episode, filepath)
+                    if not episode:
                         raise EpisodeNotFoundException
                 except EpisodeNotFoundException:
                     logger.error(f"{self.indexerid}: Unable to figure out what this file is, skipping {filepath}")
@@ -606,90 +605,90 @@ def makeEpFromFile(self, filepath):
 
             else:
                 # if there is a new file associated with this ep then re-check the quality
-                if curEp.location and os.path.normpath(curEp.location) != os.path.normpath(filepath):
+                if episode.location and os.path.normpath(episode.location) != os.path.normpath(filepath):
                     logger.debug(
                         f"{self.indexerid}: The old episode had a different file associated with it, "
                         f"re-checking the quality using the new filename {filepath}"
                     )
-                    checkQualityAgain = True
+                    check_quality_again = True
 
-                with curEp.lock:
-                    old_size = curEp.file_size
-                    curEp.location = filepath
+                with episode.lock:
+                    old_size = episode.file_size
+                    episode.location = filepath
                     # if the sizes are the same then it's probably the same file
-                    same_file = old_size and curEp.file_size == old_size
-                    curEp.checkForMetaFiles()
+                    same_file = old_size and episode.file_size == old_size
+                    episode.check_for_meta_files()
 
-            if rootEp is None:
-                rootEp = curEp
+            if root_episode is None:
+                root_episode = episode
             else:
-                if curEp not in rootEp.related_episodes:
-                    with rootEp.lock:
-                        rootEp.related_episodes.append(curEp)
+                if episode not in root_episode.related_episodes:
+                    with root_episode.lock:
+                        root_episode.related_episodes.append(episode)
 
             # if it's a new file then
             if not same_file:
-                with curEp.lock:
-                    curEp.release_name = ""
-                    curEp.release_group = ""
+                with episode.lock:
+                    episode.release_name = ""
+                    episode.release_group = ""
 
-            # if they replace a file on me I'll make some attempt at re-checking the quality unless I know it's the same file
-            if checkQualityAgain and not same_file:
-                newQuality = Quality.nameQuality(filepath, self.is_anime)
-                logger.debug(f"{self.indexerid}: Since this file has been renamed, I checked {filepath} and found quality {Quality.qualityStrings[newQuality]}")
+            # if they replace a file on me, I'll make some attempt at re-checking the quality unless I know it's the same file
+            if check_quality_again and not same_file:
+                new_quality = Quality.nameQuality(filepath, self.is_anime)
+                logger.debug(f"{self.indexerid}: Since this file has been renamed, I checked {filepath} and found quality {Quality.qualityStrings[new_quality]}")
 
-                with curEp.lock:
-                    curEp.status = Quality.compositeStatus(DOWNLOADED, newQuality)
+                with episode.lock:
+                    episode.status = Quality.compositeStatus(DOWNLOADED, new_quality)
 
             # check for status/quality changes as long as it's a new file
-            elif not same_file and is_media_file(filepath) and curEp.status not in Quality.DOWNLOADED + Quality.ARCHIVED + [IGNORED]:
-                oldStatus, oldQuality = Quality.splitCompositeStatus(curEp.status)
-                newQuality = Quality.nameQuality(filepath, self.is_anime)
+            elif not same_file and is_media_file(filepath) and episode.status not in Quality.DOWNLOADED + Quality.ARCHIVED + [IGNORED]:
+                old_status, old_quality = Quality.splitCompositeStatus(episode.status)
+                new_quality = Quality.nameQuality(filepath, self.is_anime)
 
-                newStatus = None
+                new_status = None
 
                 # if it was snatched and now exists then set the status correctly
-                if oldStatus == SNATCHED and oldQuality <= newQuality:
+                if old_status == SNATCHED and old_quality <= new_quality:
                     logger.debug(
-                        f"{self.indexerid}: This ep used to be snatched with quality {Quality.qualityStrings[oldQuality]} but a "
-                        f"file exists with quality {Quality.qualityStrings[newQuality]} so I'm setting the status to DOWNLOADED"
+                        f"{self.indexerid}: This ep used to be snatched with quality {Quality.qualityStrings[old_quality]} but a "
+                        f"file exists with quality {Quality.qualityStrings[new_quality]} so I'm setting the status to DOWNLOADED"
                     )
-                    newStatus = DOWNLOADED
+                    new_status = DOWNLOADED
 
-                # if it was snatched proper and we found a higher quality one then allow the status change
-                elif oldStatus == SNATCHED_PROPER and oldQuality < newQuality:
+                # if it was snatched proper, and we found a higher quality one then allow the status change
+                elif old_status == SNATCHED_PROPER and old_quality < new_quality:
                     logger.debug(
-                        f"{self.indexerid}: This ep used to be snatched proper with quality {Quality.qualityStrings[oldQuality]} "
-                        f"but a file exists with quality {Quality.qualityStrings[newQuality]} so I'm setting the status to DOWNLOADED"
+                        f"{self.indexerid}: This ep used to be snatched proper with quality {Quality.qualityStrings[old_quality]} "
+                        f"but a file exists with quality {Quality.qualityStrings[new_quality]} so I'm setting the status to DOWNLOADED"
                     )
-                    newStatus = DOWNLOADED
+                    new_status = DOWNLOADED
 
-                elif oldStatus not in (SNATCHED, SNATCHED_PROPER):
-                    newStatus = DOWNLOADED
+                elif old_status not in (SNATCHED, SNATCHED_PROPER):
+                    new_status = DOWNLOADED
 
-                if newStatus is not None:
-                    with curEp.lock:
+                if new_status is not None:
+                    with episode.lock:
                         logger.debug(
-                            f"{self.indexerid}: We have an associated file, so setting the status from {curEp.status} "
+                            f"{self.indexerid}: We have an associated file, so setting the status from {episode.status} "
                             f"to DOWNLOADED/{Quality.statusFromName(filepath, anime=self.is_anime)}"
                         )
-                        curEp.status = Quality.compositeStatus(newStatus, newQuality)
+                        episode.status = Quality.compositeStatus(new_status, new_quality)
 
-            with curEp.lock:
-                sql_l.append(curEp.get_sql())
+            with episode.lock:
+                sql_l.append(episode.get_sql())
 
         if sql_l:
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
 
         # creating metafiles on the root should be good enough
-        if rootEp:
-            with rootEp.lock:
-                rootEp.createMetaFiles()
+        if root_episode:
+            with root_episode.lock:
+                root_episode.create_meta_files()
 
-        return rootEp
+        return root_episode
 
-    def loadFromDB(self):
+    def load_from_db(self):
         """Get Indexer information from database"""
 
         main_db_con = db.DBConnection(row_type="dict")
@@ -901,20 +900,20 @@ def load_imdb_info(self):
         except (SyntaxError, KeyError):
             logger.info("Could not get info from IDMb, pip install lxml")
 
-    def nextEpisode(self):
-        curDate = datetime.date.today().toordinal()
-        if not self.nextaired or self.nextaired and curDate > self.nextaired:
+    def next_episode(self):
+        current_date = datetime.date.today().toordinal()
+        if not self.next_airdate or self.next_airdate and current_date > try_int(self.next_airdate):
             main_db_con = db.DBConnection()
             sql_results = main_db_con.select(
                 "SELECT airdate, season, episode FROM tv_episodes WHERE showid = ? AND airdate >= ? AND status IN (?,?) ORDER BY airdate LIMIT 1",
                 [self.indexerid, datetime.date.today().toordinal(), UNAIRED, WANTED],
             )
 
-            self.nextaired = sql_results[0]["airdate"] if sql_results else ""
+            self.next_airdate = sql_results[0]["airdate"] if sql_results else ""
 
-        return self.nextaired
+        return self.next_airdate
 
-    def deleteShow(self, full=False):
+    def delete_show(self, full=False):
         main_db_con = db.DBConnection()
 
         episodes_locations = main_db_con.select("SELECT location FROM tv_episodes WHERE showid = ? AND location != ''", [self.indexerid])
@@ -1021,11 +1020,11 @@ def deleteShow(self, full=False):
             logger.debug(f"Removing show: indexerid {self.indexerid}, Title {self.name} from Watchlist")
             notifiers.trakt_notifier.update_watchlist(self, update="remove")
 
-    def populateCache(self):
+    def populate_cache(self):
         logger.debug(f"Checking & filling cache for show {self.name}")
         settings.IMAGE_CACHE.fill_cache(self)
 
-    def refreshDir(self):
+    def refresh_dir(self):
         if not os.path.isdir(self._location) and not settings.CREATE_MISSING_SHOW_DIRS:
             logger.info(
                 "Show dir does not exist, and `create missing show dirs` is disabled. Skipping refresh (statuses will not be updated): {}".format(
@@ -1035,7 +1034,7 @@ def refreshDir(self):
             return False
 
         # load from dir
-        self.loadEpisodesFromDir()
+        self.load_episodes_from_dir()
 
         # run through all locations from DB, check that they exist
         logger.debug(f"{self.indexerid}: Loading all episodes with a location from the database")
@@ -1044,29 +1043,29 @@ def refreshDir(self):
         sql_results = main_db_con.select("SELECT season, episode, location FROM tv_episodes WHERE showid = ? AND location != ''", [self.indexerid])
 
         sql_l = []
-        for ep in sql_results:
-            curLoc = os.path.normpath(ep["location"])
-            season = int(ep["season"])
-            episode = int(ep["episode"])
+        for result in sql_results:
+            current_location = os.path.normpath(result["location"])
+            season = int(result["season"])
+            episode = int(result["episode"])
 
             try:
-                curEp = self.getEpisode(season, episode)
-                if not curEp:
+                episode_object = self.get_episode(season, episode)
+                if not episode_object:
                     raise EpisodeDeletedException
             except EpisodeDeletedException:
                 logger.debug("The episode was deleted while we were refreshing it, moving on to the next one")
                 continue
 
             # if the path doesn't exist or if it's not in our show dir
-            if not os.path.isfile(curLoc) or not os.path.normpath(curLoc).startswith(os.path.normpath(self._location)):
+            if not os.path.isfile(current_location) or not os.path.normpath(current_location).startswith(os.path.normpath(self._location)):
                 # check if downloaded files still exist, update our data if this has changed
                 if not settings.SKIP_REMOVED_FILES:
-                    with curEp.lock:
-                        # if it used to have a file associated with it and it doesn't anymore then set it to oldbeard.EP_DEFAULT_DELETED_STATUS
-                        if curEp.status in Quality.DOWNLOADED:
+                    with episode_object.lock:
+                        # if it used to have a file associated with it, and it doesn't anymore then set it to oldbeard.EP_DEFAULT_DELETED_STATUS
+                        if episode_object.status in Quality.DOWNLOADED:
                             if settings.EP_DEFAULT_DELETED_STATUS == ARCHIVED:
-                                oldStatus_, oldQuality = Quality.splitCompositeStatus(curEp.status)
-                                new_status = Quality.compositeStatus(ARCHIVED, oldQuality)
+                                old_status_, old_quality = Quality.splitCompositeStatus(episode_object.status)
+                                new_status = Quality.compositeStatus(ARCHIVED, old_quality)
                             else:
                                 new_status = settings.EP_DEFAULT_DELETED_STATUS
 
@@ -1075,19 +1074,19 @@ def refreshDir(self):
                                     id=self.indexerid, ep=episode_num(season, episode), status=statusStrings[new_status]
                                 )
                             )
-                            curEp.status = new_status
-                            curEp.subtitles = []
-                            curEp.subtitles_searchcount = 0
-                            curEp.subtitles_lastsearch = str(datetime.datetime.min)
-                        curEp.location = ""
-                        curEp.hasnfo = False
-                        curEp.hastbn = False
-                        curEp.release_name = ""
-                        curEp.release_group = ""
-
-                        sql_l.append(curEp.get_sql())
+                            episode_object.status = new_status
+                            episode_object.subtitles = []
+                            episode_object.subtitles_searchcount = 0
+                            episode_object.subtitles_lastsearch = str(datetime.datetime.min)
+                        episode_object.location = ""
+                        episode_object.has_nfo = False
+                        episode_object.has_tbn = False
+                        episode_object.release_name = ""
+                        episode_object.release_group = ""
+
+                        sql_l.append(episode_object.get_sql())
                 else:
-                    logger.info("Skipping updating removed file because `skip removed files` is enabled: {}".format(curLoc))
+                    logger.info(f"Skipping updating removed file because `skip removed files` is enabled: {current_location}")
 
         if sql_l:
             main_db_con = db.DBConnection()
@@ -1101,7 +1100,7 @@ def download_subtitles(self):
         logger.debug(f"{self.indexerid}: Downloading subtitles")
 
         try:
-            episodes = self.getAllEpisodes(has_location=True)
+            episodes = self.get_all_episodes(has_location=True)
             if not episodes:
                 logger.debug(f"{self.indexerid}: No episodes to download subtitles for {self.name}")
                 return
@@ -1113,14 +1112,14 @@ def download_subtitles(self):
             logger.debug(f"{self.indexerid}: Error occurred when downloading subtitles for {self.name}")
             logger.error(traceback.format_exc())
 
-    def saveToDB(self, forceSave=False):
-        if not self.dirty and not forceSave:
+    def save_to_db(self):
+        if not self.dirty:
             return
 
         logger.debug("{0:d}: Saving to database: {1}".format(self.indexerid, self.name))
 
-        controlValueDict = {"indexer_id": self.indexerid}
-        newValueDict = {
+        control_value_dict = {"indexer_id": self.indexerid}
+        new_value_dict = {
             "indexer": self.indexer,
             "show_name": self.show_name,
             "custom_name": self.custom_name,
@@ -1152,13 +1151,13 @@ def saveToDB(self, forceSave=False):
         }
 
         main_db_con = db.DBConnection()
-        main_db_con.upsert("tv_shows", newValueDict, controlValueDict)
+        main_db_con.upsert("tv_shows", new_value_dict, control_value_dict)
 
         helpers.update_anime_support()
 
         if self.imdb_id and self.imdb_info:
             main_db_con = db.DBConnection()
-            main_db_con.upsert("imdb_info", self.imdb_info, controlValueDict)
+            main_db_con.upsert("imdb_info", self.imdb_info, control_value_dict)
 
     def __str__(self):
         info_list = [
@@ -1184,14 +1183,14 @@ def __str__(self):
         return "\n".join(info_list)
 
     @staticmethod
-    def qualitiesToString(qualities=None):
+    def qualities_to_string(qualities=None):
         return ", ".join([Quality.qualityStrings[quality] for quality in qualities or [] if quality and quality in Quality.qualityStrings]) or "None"
 
-    def wantEpisode(self, season, episode, quality, manualSearch=False, downCurQuality=False):
+    def want_episode(self, season, episode, quality, manual_search=False, down_cur_quality=False):
         allowed_qualities, preferred_qualities = Quality.splitQuality(self.quality)
         logger.debug(
-            f"Any,Best = [ {self.qualitiesToString(allowed_qualities)} ] [ {self.qualitiesToString(preferred_qualities)} ]"
-            f" Found = [ {self.qualitiesToString([quality])} ]"
+            f"Any,Best = [ {self.qualities_to_string(allowed_qualities)} ] [ {self.qualities_to_string(preferred_qualities)} ]"
+            f" Found = [ {self.qualities_to_string([quality])} ]"
         )
 
         if quality not in allowed_qualities + preferred_qualities or quality is UNKNOWN:
@@ -1213,28 +1212,28 @@ def wantEpisode(self, season, episode, quality, manualSearch=False, downCurQuali
             )
             return False
 
-        epStatus = int(sql_results[0]["status"])
-        epStatus_text = statusStrings[epStatus]
+        ep_status = int(sql_results[0]["status"])
+        ep_status_text = statusStrings[ep_status]
 
-        if epStatus in Quality.ARCHIVED + [UNAIRED, SKIPPED, IGNORED] and not manualSearch:
+        if ep_status in Quality.ARCHIVED + [UNAIRED, SKIPPED, IGNORED] and not manual_search:
             logger.debug(
                 "Existing episode status is '{status}', ignoring found result for {name} {ep} with quality {quality}".format(
-                    status=epStatus_text, name=self.name, ep=episode_num(season, episode), quality=Quality.qualityStrings[quality]
+                    status=ep_status_text, name=self.name, ep=episode_num(season, episode), quality=Quality.qualityStrings[quality]
                 )
             )
             return False
 
-        curStatus_, curQuality = Quality.splitCompositeStatus(epStatus)
+        cur_status_, cur_quality = Quality.splitCompositeStatus(ep_status)
 
-        if epStatus in (WANTED, SKIPPED, UNKNOWN, FAILED):
+        if ep_status in (WANTED, SKIPPED, UNKNOWN, FAILED):
             logger.debug(
                 "Existing episode status is '{status}', getting found result for {name} {ep} with quality {quality}".format(
-                    status=epStatus_text, name=self.name, ep=episode_num(season, episode), quality=Quality.qualityStrings[quality]
+                    status=ep_status_text, name=self.name, ep=episode_num(season, episode), quality=Quality.qualityStrings[quality]
                 )
             )
             return True
-        elif manualSearch:
-            if (downCurQuality and quality >= curQuality) or (not downCurQuality and quality != curQuality):
+        elif manual_search:
+            if (down_cur_quality and quality >= cur_quality) or (not down_cur_quality and quality != cur_quality):
                 logger.debug(
                     "Usually ignoring found result, but forced search allows the quality,"
                     " getting found result for {name} {ep} with quality {quality}".format(
@@ -1244,21 +1243,21 @@ def wantEpisode(self, season, episode, quality, manualSearch=False, downCurQuali
                 return True
 
         if (
-            epStatus in Quality.DOWNLOADED + Quality.SNATCHED + Quality.SNATCHED_PROPER
+            ep_status in Quality.DOWNLOADED + Quality.SNATCHED + Quality.SNATCHED_PROPER
             and quality in preferred_qualities
-            and (quality > curQuality or curQuality not in preferred_qualities)
+            and (quality > cur_quality or cur_quality not in preferred_qualities)
         ):
             logger.debug(
                 "Episode already exists with quality {existing_quality} but the found result"
                 " quality {new_quality} is wanted more, getting found result for {name} {ep}".format(
-                    existing_quality=Quality.qualityStrings[curQuality],
+                    existing_quality=Quality.qualityStrings[cur_quality],
                     new_quality=Quality.qualityStrings[quality],
                     name=self.name,
                     ep=episode_num(season, episode),
                 )
             )
             return True
-        elif curQuality == Quality.UNKNOWN and manualSearch:
+        elif cur_quality == Quality.UNKNOWN and manual_search:
             logger.debug(
                 "Episode already exists but quality is Unknown, getting found result for {name} {ep} with quality {quality}".format(
                     name=self.name, ep=episode_num(season, episode), quality=Quality.qualityStrings[quality]
@@ -1269,7 +1268,7 @@ def wantEpisode(self, season, episode, quality, manualSearch=False, downCurQuali
             logger.debug(
                 "Episode already exists with quality {existing_quality} and the found result has same/lower quality,"
                 " ignoring found result for {name} {ep} with quality {new_quality}".format(
-                    existing_quality=Quality.qualityStrings[curQuality],
+                    existing_quality=Quality.qualityStrings[cur_quality],
                     name=self.name,
                     ep=episode_num(season, episode),
                     new_quality=Quality.qualityStrings[quality],
@@ -1277,7 +1276,7 @@ def wantEpisode(self, season, episode, quality, manualSearch=False, downCurQuali
             )
         return False
 
-    def getOverview(self, epStatus, backlog=False):
+    def get_overview(self, episode_status, backlog=False):
         """
         Get the Overview status from the Episode status
 
@@ -1285,7 +1284,7 @@ def getOverview(self, epStatus, backlog=False):
         return: an Overview status
         """
 
-        ep_status = try_int(epStatus) or UNKNOWN
+        ep_status = try_int(episode_status) or UNKNOWN
 
         if ep_status == WANTED:
             return Overview.WANTED
@@ -1314,7 +1313,7 @@ def getOverview(self, epStatus, backlog=False):
             else:
                 return Overview.GOOD
         else:
-            logger.error(f"Could not parse episode status into a valid overview status: {epStatus}")
+            logger.error(f"Could not parse episode status into a valid overview status: {episode_status}")
 
     def __getstate__(self):
         d = dict(self.__dict__)
@@ -1336,8 +1335,8 @@ class TVEpisode(object):
     subtitles_searchcount = DirtySetter(0)
     subtitles_lastsearch = DirtySetter(str(datetime.datetime.min))
     airdate = DirtySetter(datetime.date.min)
-    hasnfo = DirtySetter(False)
-    hastbn = DirtySetter(False)
+    has_nfo = DirtySetter(False)
+    has_tbn = DirtySetter(False)
     status = DirtySetter(UNKNOWN)
     indexerid = DirtySetter(0)
     file_size = DirtySetter(0)
@@ -1349,8 +1348,8 @@ class TVEpisode(object):
     startyear = DirtySetter("")
 
     def __init__(self, show: TVShow, season, episode, ep_file=""):
-        self.season = season
-        self.episode = episode
+        self.season: int = season
+        self.episode: int = episode
         self._location = ep_file
         self.startyear = ""
 
@@ -1360,21 +1359,28 @@ def __init__(self, show: TVShow, season, episode, ep_file=""):
         self.show: TVShow = show
         self.indexer = self.show.indexer
 
-        self.scene_season = 0
-        self.scene_episode = 0
+        self.scene_season: int = 0
+        self.scene_episode: int = 0
         self.scene_absolute_number = 0
 
+        self._release_group: str = ""
+
         self.lock = threading.Lock()
 
-        self.specifyEpisode(self.season, self.episode)
+        self.specify_episode(self.season, self.episode)
 
         self.related_episodes = []
 
-        self.checkForMetaFiles()
+        self.check_for_meta_files()
 
         self.wantedQuality = []
 
-    def _set_location(self, new_location):
+    @property
+    def location(self):
+        return self._location
+
+    @location.setter
+    def location(self, new_location):
         logger.debug(f"Setter sets location to {new_location}")
 
         # self._location = newLocation
@@ -1388,8 +1394,6 @@ def _set_location(self, new_location):
         else:
             self.file_size = 0
 
-    location = property(lambda self: self._location, _set_location)
-
     @property
     def idxr(self):
         return self.show.idxr
@@ -1422,11 +1426,11 @@ def min_max_episode_list(self):
 
         return [min(sorted_list), max(sorted_list)]
 
-    def refreshSubtitles(self):
+    def refresh_subtitles(self):
         """Look for subtitles files and refresh the subtitles property"""
         self.subtitles, save_subtitles = subtitles.refresh_subtitles(self)
         if save_subtitles:
-            self.saveToDB()
+            self.save_to_db()
 
     def download_subtitles(self, force_lang=None):
         if not os.path.isfile(self.location):
@@ -1453,7 +1457,7 @@ def download_subtitles(self, force_lang=None):
 
         self.subtitles_searchcount += 1 if self.subtitles_searchcount else 1
         self.subtitles_lastsearch = datetime.datetime.now().strftime(dateTimeFormat)
-        self.saveToDB()
+        self.save_to_db()
 
         if new_subtitles:
             subtitle_list = ", ".join([subtitles.name_from_code(code) for code in new_subtitles])
@@ -1471,9 +1475,9 @@ def download_subtitles(self, force_lang=None):
 
         return new_subtitles
 
-    def checkForMetaFiles(self):
-        oldhasnfo = self.hasnfo
-        oldhastbn = self.hastbn
+    def check_for_meta_files(self):
+        old_has_nfo = self.has_nfo
+        old_has_tbn = self.has_tbn
 
         cur_nfo = False
         cur_tbn = False
@@ -1482,36 +1486,36 @@ def checkForMetaFiles(self):
         if os.path.isfile(self.location):
             for cur_provider in settings.metadata_provider_dict.values():
                 if cur_provider.episode_metadata:
-                    new_result = cur_provider._has_episode_metadata(self)
+                    new_result = cur_provider.has_episode_metadata(self)
                 else:
                     new_result = False
                 cur_nfo = new_result or cur_nfo
 
                 if cur_provider.episode_thumbnails:
-                    new_result = cur_provider._has_episode_thumb(self)
+                    new_result = cur_provider.has_episode_thumb(self)
                 else:
                     new_result = False
                 cur_tbn = new_result or cur_tbn
 
-        self.hasnfo = cur_nfo
-        self.hastbn = cur_tbn
+        self.has_nfo = cur_nfo
+        self.has_tbn = cur_tbn
 
         # if either setting has changed return true, if not return false
-        return oldhasnfo != self.hasnfo or oldhastbn != self.hastbn
+        return old_has_nfo != self.has_nfo or old_has_tbn != self.has_tbn
 
-    def specifyEpisode(self, season, episode):
-        sql_results = self.loadFromDB(season, episode)
+    def specify_episode(self, season, episode):
+        sql_results = self.load_from_db(season, episode)
 
         if not sql_results:
             # only load from NFO if we didn't load from DB
             if os.path.isfile(self.location):
                 try:
-                    self.loadFromNFO(self.location)
+                    self.load_from_nfo(self.location)
                 except NoNFOException:
                     logger.error(f"{self.show.indexerid}: There was an error loading the NFO for episode {episode_num(season, episode)}")
 
                 # if we tried loading it from NFO and didn't find the NFO, try the Indexers
-                if not self.hasnfo:
+                if not self.has_nfo:
                     try:
                         result = self.load_from_indexer(season, episode)
                     except EpisodeDeletedException:
@@ -1521,7 +1525,7 @@ def specifyEpisode(self, season, episode):
                     if not result:
                         raise EpisodeNotFoundException("Couldn't find episode {ep}".format(ep=episode_num(season, episode)))
 
-    def loadFromDB(self, season, episode):
+    def load_from_db(self, season, episode):
         main_db_con = db.DBConnection()
         sql = "SELECT * FROM tv_episodes JOIN tv_shows WHERE showid = indexer_id and showid = ? AND season = ? AND episode = ?"
         sql_results = main_db_con.select(sql, [self.show.indexerid, season, episode])
@@ -1537,7 +1541,7 @@ def loadFromDB(self, season, episode):
 
             self.season = season
             self.episode = episode
-            self.absolute_number = try_int(sql_results[0]["absolute_number"], 0)
+            self.absolute_number = try_int(sql_results[0]["absolute_number"])
             self.description = sql_results[0]["description"]
             if not self.description:
                 self.description = ""
@@ -1563,9 +1567,9 @@ def loadFromDB(self, season, episode):
 
             sickchill.oldbeard.scene_numbering.xem_refresh(self.show.indexerid, self.show.indexer)
 
-            self.scene_season = try_int(sql_results[0]["scene_season"], 0)
-            self.scene_episode = try_int(sql_results[0]["scene_episode"], 0)
-            self.scene_absolute_number = try_int(sql_results[0]["scene_absolute_number"], 0)
+            self.scene_season = try_int(sql_results[0]["scene_season"])
+            self.scene_episode = try_int(sql_results[0]["scene_episode"])
+            self.scene_absolute_number = try_int(sql_results[0]["scene_absolute_number"])
 
             if self.scene_absolute_number == 0:
                 self.scene_absolute_number = sickchill.oldbeard.scene_numbering.get_scene_absolute_numbering(
@@ -1630,7 +1634,7 @@ def load_from_indexer(self, season=None, episode=None, force_all: bool = False):
                     id=self.show.indexerid, ep=episode_num(season or self.season, episode or self.episode), absolute=indexer_episode["absoluteNumber"]
                 )
             )
-            self.absolute_number = try_int(indexer_episode["absoluteNumber"], 0)
+            self.absolute_number = try_int(indexer_episode["absoluteNumber"])
 
         self.season = (season, self.season)[season is None]
         self.episode = (episode, self.episode)[season is None]
@@ -1656,16 +1660,16 @@ def load_from_indexer(self, season=None, episode=None, force_all: bool = False):
             else:
                 first_aired = str(self.airdate)
 
-        rawAirdate = [int(x) for x in first_aired.split("-")]
+        raw_airdate = [int(x) for x in first_aired.split("-")]
 
         try:
-            self.airdate = datetime.date(rawAirdate[0], rawAirdate[1], rawAirdate[2])
+            self.airdate = datetime.date(raw_airdate[0], raw_airdate[1], raw_airdate[2])
         except (ValueError, IndexError, TypeError):
             # Changed this to error because it should NEVER happen now
             logger.error(f"Malformed air date of {first_aired} retrieved from {self.indexer_name} for ({self.show.name} - {episode_num(season, episode)})")
-            # if I'm incomplete on the indexer but I once was complete then just delete myself from the DB for now
+            # if I'm incomplete on the indexer, but I once was complete then just delete myself from the DB for now
             if self.indexerid != -1:
-                self.deleteEpisode()
+                self.delete_episode()
             return False
 
         if indexer_episode.get("id"):
@@ -1674,7 +1678,7 @@ def load_from_indexer(self, season=None, episode=None, force_all: bool = False):
         if not self.indexerid:
             logger.error("Failed to retrieve ID from {indexer}".format(indexer=self.indexer_name))
             if self.indexerid != -1:
-                self.deleteEpisode()
+                self.delete_episode()
             return False
 
         if not os.path.isdir(self.show._location) and not settings.CREATE_MISSING_SHOW_DIRS and not settings.ADD_SHOWS_WO_DIR:
@@ -1723,7 +1727,7 @@ def load_from_indexer(self, season=None, episode=None, force_all: bool = False):
             logger.debug(f"6 Status changes from {self.status} to {UNKNOWN}")
             self.status = UNKNOWN
 
-    def loadFromNFO(self, location):
+    def load_from_nfo(self, location):
         if not os.path.isdir(self.show._location):
             logger.info(f"{self.show.indexerid}: The show dir is missing, not bothering to try loading the episode NFO")
             return
@@ -1737,16 +1741,16 @@ def loadFromNFO(self, location):
                 logger.debug(f"7 Status changes from {self.status} to {Quality.statusFromName(self.location, anime=self.show.is_anime)}")
                 self.status = Quality.statusFromName(self.location, anime=self.show.is_anime)
 
-            nfoFile = replace_extension(self.location, "nfo")
-            logger.debug(f"{self.show.indexerid}: Using NFO name {nfoFile}")
+            nfo_file = replace_extension(self.location, "nfo")
+            logger.debug(f"{self.show.indexerid}: Using NFO name {nfo_file}")
 
-            if os.path.isfile(nfoFile):
+            if os.path.isfile(nfo_file):
                 try:
-                    show_xml = ElementTree.ElementTree(file=nfoFile)
+                    show_xml = ElementTree.ElementTree(file=nfo_file)
                 except (SyntaxError, ValueError) as error:
                     logger.error(f"Error loading the NFO, backing up the NFO and skipping for now: {error}")
                     try:
-                        os.rename(nfoFile, f"{nfoFile}.old")
+                        os.rename(nfo_file, f"{nfo_file}.old")
                     except OSError as error:
                         logger.error(f"Failed to rename your episode's NFO file - you need to delete it or fix it: {error}")
                     raise NoNFOException("Error in NFO format")
@@ -1758,8 +1762,10 @@ def loadFromNFO(self, location):
                         or ep_details.findtext("episode") is None
                         or int(ep_details.findtext("episode")) != self.episode
                     ):
+                        ep_string = episode_num(self.season, self.episode)
+                        other_string = episode_num(ep_details.findtext('season'), ep_details.findtext('episode'))
                         logger.debug(
-                            f"{self.show.indexerid}: NFO has an <episodedetails> block for a different episode - wanted {episode_num(self.season, self.episode)} but got {episode_num(ep_details.findtext('season'), ep_details.findtext('episode'))}"
+                            f"{self.show.indexerid}: NFO has an <episodedetails> block for a different episode - wanted {ep_string} but got {other_string}"
                         )
                         continue
 
@@ -1785,17 +1791,17 @@ def loadFromNFO(self, location):
                         self.description = ""
 
                     if ep_details.findtext("aired"):
-                        rawAirdate = [int(x) for x in ep_details.findtext("aired").split("-")]
-                        self.airdate = datetime.date(rawAirdate[0], rawAirdate[1], rawAirdate[2])
+                        raw_airdate = [int(x) for x in ep_details.findtext("aired").split("-")]
+                        self.airdate = datetime.date(raw_airdate[0], raw_airdate[1], raw_airdate[2])
 
-                    self.hasnfo = True
+                    self.has_nfo = True
             else:
-                self.hasnfo = False
+                self.has_nfo = False
 
-            if os.path.isfile(replace_extension(nfoFile, "tbn")):
-                self.hastbn = True
+            if os.path.isfile(replace_extension(nfo_file, "tbn")):
+                self.has_tbn = True
             else:
-                self.hastbn = False
+                self.has_tbn = False
 
     def __str__(self):
         return "\n".join(
@@ -1807,24 +1813,24 @@ def __str__(self):
                 f"subtitles_searchcount: {self.subtitles_searchcount}",
                 f"subtitles_lastsearch: {self.subtitles_lastsearch}",
                 f"airdate: {self.airdate.toordinal()} ({self.airdate})",
-                f"hasnfo: {self.hasnfo}",
-                f"hastbn: {self.hastbn}",
+                f"hasnfo: {self.has_nfo}",
+                f"hastbn: {self.has_tbn}",
                 f"status: {self.status}",
             ]
         )
 
-    def createMetaFiles(self):
+    def create_meta_files(self):
         if not os.path.isdir(self.show._location):
             logger.info(f"{self.show.indexerid}: The show dir is missing, not bothering to try to create metadata")
             return
 
-        self.createNFO()
-        self.createThumbnail()
+        self.create_nfo()
+        self.create_thumbnail()
 
-        if self.checkForMetaFiles():
-            self.saveToDB()
+        if self.check_for_meta_files():
+            self.save_to_db()
 
-    def createNFO(self):
+    def create_nfo(self):
         result = False
 
         for cur_provider in settings.metadata_provider_dict.values():
@@ -1833,7 +1839,7 @@ def createNFO(self):
 
         return result
 
-    def createThumbnail(self):
+    def create_thumbnail(self):
         result = False
 
         for cur_provider in settings.metadata_provider_dict.values():
@@ -1841,11 +1847,11 @@ def createThumbnail(self):
 
         return result
 
-    def deleteEpisode(self):
+    def delete_episode(self):
         logger.debug(_("Deleting {show} {ep} from the DB").format(show=self.show.name, ep=episode_num(self.season, self.episode)))
 
         # remove myself from the show dictionary
-        if self.show.getEpisode(self.season, self.episode, noCreate=True) == self:
+        if self.show.get_episode(self.season, self.episode, nfo_create=True) == self:
             logger.debug(_("Removing myself from my show's list"))
             del self.show.episodes[self.season][self.episode]
 
@@ -1855,7 +1861,7 @@ def deleteEpisode(self):
         main_db_con.action("DELETE FROM tv_episodes WHERE showid = ? AND season = ? AND episode = ?", [self.show.indexerid, self.season, self.episode])
         raise EpisodeDeletedException()
 
-    def get_sql(self, forceSave=False):
+    def get_sql(self):
         """
         Creates SQL queue for this episode if any of its data has been changed since the last save.
 
@@ -1863,7 +1869,7 @@ def get_sql(self, forceSave=False):
                     last save (aka if the record is not dirty).
         """
         try:
-            if not self.dirty and not forceSave:
+            if not self.dirty:
                 logger.debug(f"{self.show.indexerid}: Not creating SQL queue - record is not dirty")
                 return
 
@@ -1873,11 +1879,11 @@ def get_sql(self, forceSave=False):
                 [self.show.indexerid, self.season, self.episode],
             )
 
-            epID = None
+            ep_id = None
             if rows:
-                epID = int(rows[0]["episode_id"])
+                ep_id = int(rows[0]["episode_id"])
 
-            if epID:
+            if ep_id:
                 # use a custom update method to get the data into the DB for existing records.
                 # Multi or added subtitle or removed subtitles
                 if settings.SUBTITLES_MULTI or not rows[0]["subtitles"] or not self.subtitles:
@@ -1895,8 +1901,8 @@ def get_sql(self, forceSave=False):
                             self.subtitles_searchcount,
                             self.subtitles_lastsearch,
                             self.airdate.toordinal(),
-                            self.hasnfo,
-                            self.hastbn,
+                            self.has_nfo,
+                            self.has_tbn,
                             self.status,
                             self.location,
                             self.file_size,
@@ -1908,7 +1914,7 @@ def get_sql(self, forceSave=False):
                             self.absolute_number,
                             self.version,
                             self.release_group,
-                            epID,
+                            ep_id,
                         ],
                     ]
                 else:
@@ -1926,8 +1932,8 @@ def get_sql(self, forceSave=False):
                             self.subtitles_searchcount,
                             self.subtitles_lastsearch,
                             self.airdate.toordinal(),
-                            self.hasnfo,
-                            self.hastbn,
+                            self.has_nfo,
+                            self.has_tbn,
                             self.status,
                             self.location,
                             self.file_size,
@@ -1939,7 +1945,7 @@ def get_sql(self, forceSave=False):
                             self.absolute_number,
                             self.version,
                             self.release_group,
-                            epID,
+                            ep_id,
                         ],
                     ]
             else:
@@ -1962,8 +1968,8 @@ def get_sql(self, forceSave=False):
                         self.subtitles_searchcount,
                         self.subtitles_lastsearch,
                         self.airdate.toordinal(),
-                        self.hasnfo,
-                        self.hastbn,
+                        self.has_nfo,
+                        self.has_tbn,
                         self.status,
                         self.location,
                         self.file_size,
@@ -1980,7 +1986,7 @@ def get_sql(self, forceSave=False):
         except OperationalError as error:
             logger.error(f"Error while updating database: {error}")
 
-    def saveToDB(self, forceSave=False):
+    def save_to_db(self):
         """
         Saves this episode to the database if any of its data has been changed since the last save.
 
@@ -1988,10 +1994,10 @@ def saveToDB(self, forceSave=False):
                     last save (aka if the record is not dirty).
         """
 
-        if not self.dirty and not forceSave:
+        if not self.dirty:
             return
 
-        newValueDict = {
+        new_value_dict = {
             "indexerid": self.indexerid,
             "indexer": self.indexer,
             "name": self.name,
@@ -2000,8 +2006,8 @@ def saveToDB(self, forceSave=False):
             "subtitles_searchcount": self.subtitles_searchcount,
             "subtitles_lastsearch": self.subtitles_lastsearch,
             "airdate": self.airdate.toordinal(),
-            "hasnfo": self.hasnfo,
-            "hastbn": self.hastbn,
+            "hasnfo": self.has_nfo,
+            "hastbn": self.has_tbn,
             "status": self.status,
             "location": self.location,
             "file_size": self.file_size,
@@ -2012,21 +2018,21 @@ def saveToDB(self, forceSave=False):
             "release_group": self.release_group,
         }
 
-        controlValueDict = {"showid": self.show.indexerid, "season": self.season, "episode": self.episode}
+        control_value_dict = {"showid": self.show.indexerid, "season": self.season, "episode": self.episode}
 
         logger.debug(f"{self.show.indexerid}: Saving episode details to database S{self.season}E{self.episode}: {statusStrings[self.status]}")
 
         # use a custom update/insert method to get the data into the DB
         main_db_con = db.DBConnection()
-        main_db_con.upsert("tv_episodes", newValueDict, controlValueDict)
+        main_db_con.upsert("tv_episodes", new_value_dict, control_value_dict)
 
-    def fullPath(self):
+    def full_path(self):
         if self.location is None or self.location == "":
             return None
         else:
             return os.path.join(self.show.location, self.location)
 
-    def createStrings(self, pattern=None):
+    def create_strings(self, pattern=None):
         patterns = ["%S.N.S%SE%0E", "%S.N.S%0SE%E", "%S.N.S%SE%E", "%S.N.S%0SE%0E", "%SN S%SE%0E", "%SN S%0SE%E", "%SN S%SE%E", "%SN S%0SE%0E"]
 
         strings = []
@@ -2055,42 +2061,42 @@ def pretty_name(self):
     def _ep_name(self):
         """
         Returns the name of the episode to use during renaming. Combines the names of related episodes.
-        Eg. "Ep Name (1)" and "Ep Name (2)" becomes "Ep Name"
+        E.g. "Ep Name (1)" and "Ep Name (2)" becomes "Ep Name"
             "Ep Name" and "Other Ep Name" becomes "Ep Name & Other Ep Name"
         """
 
-        multiNameRegex = r"(.*) \(\d{1,2}\)"
+        multi_name_regex = r"(.*) \(\d{1,2}\)"
 
         self.related_episodes = sorted(self.related_episodes, key=lambda x: x.episode)
 
         if not self.related_episodes:
-            goodName = self.name
+            good_name = self.name
         else:
-            singleName = True
-            curGoodName = None
+            single_name = True
+            current_good_name = None
 
-            for curName in [self.name] + [x.name for x in self.related_episodes]:
-                match = re.match(multiNameRegex, curName)
+            for current_name in [self.name] + [x.name for x in self.related_episodes]:
+                match = re.match(multi_name_regex, current_name)
                 if not match:
-                    singleName = False
+                    single_name = False
                     break
 
-                if curGoodName is None:
-                    curGoodName = match.group(1)
-                elif curGoodName != match.group(1):
-                    singleName = False
+                if current_good_name is None:
+                    current_good_name = match.group(1)
+                elif current_good_name != match.group(1):
+                    single_name = False
                     break
 
-            if singleName:
-                goodName = curGoodName
+            if single_name:
+                good_name = current_good_name
             else:
-                goodName = self.name
-                for relEp in self.related_episodes:
-                    goodName += f" & {relEp.name}"
+                good_name = self.name
+                for related_episode in self.related_episodes:
+                    good_name += f" & {related_episode.name}"
 
-        return goodName
+        return good_name
 
-    def _replace_map(self):
+    def replace_map(self):
         """
         Generates a replacement map for this episode which maps all possible custom naming patterns to the correct
         value for this episode.
@@ -2133,7 +2139,7 @@ def release_group(show, name):
 
             return parse_result.release_group.strip(".- []{}")
 
-        epStatus_, epQual = Quality.splitCompositeStatus(self.status)
+        episode_status_, episode_quality = Quality.splitCompositeStatus(self.status)
 
         # set the different show name variables and only 4 digit years
         show_name = self.show.name
@@ -2155,32 +2161,32 @@ def release_group(show, name):
             show_start_year = re.sub(r"[()]", "", show_start_year).strip()
 
         # try to get the release group
-        rel_grp = {"SICKCHILL": "SICKCHILL"}
+        release_grp = {"SICKCHILL": "SICKCHILL"}
         if hasattr(self, "location"):  # from the location name
-            rel_grp["location"] = release_group(self.show, self.location)
-            if not rel_grp["location"]:
-                del rel_grp["location"]
+            release_grp["location"] = release_group(self.show, self.location)
+            if not release_grp["location"]:
+                del release_grp["location"]
         if hasattr(self, "_release_group"):  # from the release group field in db
-            rel_grp["database"] = self._release_group.strip(".- []{}")
-            if not rel_grp["database"]:
-                del rel_grp["database"]
+            release_grp["database"] = self._release_group.strip(".- []{}")
+            if not release_grp["database"]:
+                del release_grp["database"]
         if hasattr(self, "release_name"):  # from the release name field in db
-            rel_grp["release_name"] = release_group(self.show, self.release_name)
-            if not rel_grp["release_name"]:
-                del rel_grp["release_name"]
+            release_grp["release_name"] = release_group(self.show, self.release_name)
+            if not release_grp["release_name"]:
+                del release_grp["release_name"]
 
         # use release_group, release_name, location in that order
-        if "database" in rel_grp:
+        if "database" in release_grp:
             relgrp = "database"
-        elif "release_name" in rel_grp:
+        elif "release_name" in release_grp:
             relgrp = "release_name"
-        elif "location" in rel_grp:
+        elif "location" in release_grp:
             relgrp = "location"
         else:
             relgrp = "SICKCHILL"
 
         # try to get the release encoder to comply with scene naming standards
-        encoder = Quality.sceneQualityFromName(self.release_name.replace(rel_grp[relgrp], ""), epQual)
+        encoder = Quality.sceneQualityFromName(self.release_name.replace(release_grp[relgrp], ""), episode_quality)
         if encoder:
             logger.debug(f"Found codec for '{show_name}: {ep_name}'.")
 
@@ -2194,25 +2200,25 @@ def release_group(show, name):
             "%EN": ep_name,
             "%E.N": dot(ep_name),
             "%E_N": us(ep_name),
-            "%QN": Quality.qualityStrings[epQual],
-            "%Q.N": dot(Quality.qualityStrings[epQual]),
-            "%Q_N": us(Quality.qualityStrings[epQual]),
-            "%SQN": Quality.sceneQualityStrings[epQual] + encoder,
-            "%SQ.N": dot(Quality.sceneQualityStrings[epQual] + encoder),
-            "%SQ_N": us(Quality.sceneQualityStrings[epQual] + encoder),
+            "%QN": Quality.qualityStrings[episode_quality],
+            "%Q.N": dot(Quality.qualityStrings[episode_quality]),
+            "%Q_N": us(Quality.qualityStrings[episode_quality]),
+            "%SQN": Quality.sceneQualityStrings[episode_quality] + encoder,
+            "%SQ.N": dot(Quality.sceneQualityStrings[episode_quality] + encoder),
+            "%SQ_N": us(Quality.sceneQualityStrings[episode_quality] + encoder),
             "%S": "" if self.season is None else str(self.season),
-            "%0S": "" if self.season is None else f"{int(self.season):02d}",
+            "%0S": "" if self.season is None else f"{self.season:02d}",
             "%E": "" if self.episode is None else str(self.episode),
-            "%0E": "" if self.episode is None else f"{int(self.episode):02d}",
+            "%0E": "" if self.episode is None else f"{self.episode:02d}",
             "%XS": "" if self.scene_season is None else str(self.scene_season),
-            "%0XS": "" if self.scene_season is None else f"{int(self.scene_season):02d}",
+            "%0XS": "" if self.scene_season is None else f"{self.scene_season:02d}",
             "%XE": "" if self.scene_episode is None else str(self.scene_episode),
-            "%0XE": "" if self.scene_episode is None else f"{int(self.scene_episode):02d}",
-            "%AB": "" if self.absolute_number is None else f"{int(self.absolute_number):03d}",
-            "%XAB": "" if self.scene_absolute_number is None else f"{int(self.scene_absolute_number):03d}",
+            "%0XE": "" if self.scene_episode is None else f"{self.scene_episode:02d}",
+            "%AB": "" if self.absolute_number is None else f"{self.absolute_number:03d}",
+            "%XAB": "" if self.scene_absolute_number is None else f"{self.scene_absolute_number:03d}",
             "%RN": release_name(self.release_name),
-            "%RG": rel_grp[relgrp],
-            "%CRG": rel_grp[relgrp].upper(),
+            "%RG": release_grp[relgrp],
+            "%CRG": release_grp[relgrp].upper(),
             "%AD": str(self.airdate or "").replace("-", " ") if self.airdate else "",
             "%A.D": str(self.airdate).replace("-", ".") if self.airdate else "",
             "%A_D": us(str(self.airdate)) if self.airdate else "",
@@ -2229,7 +2235,7 @@ def release_group(show, name):
         }
 
     @staticmethod
-    def _format_string(pattern, replace_map):
+    def format_string(pattern, replace_map):
         """
         Replaces all template strings with the correct value
         """
@@ -2260,13 +2266,13 @@ def naming_pattern(self, pattern=None, multi=None, anime_type=None):
         else:
             anime_type = 3
 
-        replace_map = self._replace_map()
+        replace_map = self.replace_map()
 
         result_name = pattern
 
         # if there's no release group in the db, let the user know we replaced it
         if replace_map["%RG"] and replace_map["%RG"] != "SICKCHILL":
-            if not hasattr(self, "_release_group") or not self._release_group:
+            if not self._release_group:
                 logger.debug(f"Episode has no release group, replacing it with '{replace_map['%RG']}'")
                 self._release_group = replace_map["%RG"]  # if release_group is not in the db, put it there
 
@@ -2324,7 +2330,7 @@ def naming_pattern(self, pattern=None, multi=None, anime_type=None):
 
                 regex_used = season_ep_regex
 
-            # if there's no season then there's not much choice so we'll just force them to use 03-04-05 style
+            # if there's no season then there's not much choice, so we'll just force them to use 03-04-05 style
             elif ep_only_match:
                 season_format = ""
                 ep_sep = "-"
@@ -2339,8 +2345,8 @@ def naming_pattern(self, pattern=None, multi=None, anime_type=None):
             if not ep_sep or not ep_format:
                 continue
 
-            # start with the ep string, eg. E03
-            ep_string = self._format_string(ep_format.upper(), replace_map)
+            # start with the ep string, e.g. E03
+            ep_string = self.format_string(ep_format.upper(), replace_map)
             for other_ep in self.related_episodes:
                 # for limited extend we only append the last ep
                 if multi in (NAMING_LIMITED_EXTEND, NAMING_LIMITED_EXTEND_E_PREFIXED) and other_ep != self.related_episodes[-1]:
@@ -2359,19 +2365,19 @@ def naming_pattern(self, pattern=None, multi=None, anime_type=None):
                 if multi == NAMING_LIMITED_EXTEND_E_PREFIXED:
                     ep_string += "E"
 
-                ep_string += other_ep._format_string(ep_format.upper(), other_ep._replace_map())
+                ep_string += other_ep.format_string(ep_format.upper(), other_ep.replace_map())
 
             if anime_type != 3:
                 if self.absolute_number == 0:
-                    curAbsolute_number = self.episode
+                    current_absolute_number = self.episode
                 else:
-                    curAbsolute_number = self.absolute_number
+                    current_absolute_number = self.absolute_number
 
-                if self.season != 0:  # dont set absolute numbers if we are on specials !
+                if self.season != 0:  # don't set absolute numbers if we are on specials !
                     if anime_type == 1:  # this crazy person wants both ! (note: +=)
-                        ep_string += f"{sep}{curAbsolute_number:03d}"
+                        ep_string += f"{sep}{current_absolute_number:03d}"
                     elif anime_type == 2:  # total anime freak only need the absolute number ! (note: =)
-                        ep_string = f"{curAbsolute_number:03d}"
+                        ep_string = f"{current_absolute_number:03d}"
 
                     for relEp in self.related_episodes:
                         if relEp.absolute_number != 0:
@@ -2392,7 +2398,7 @@ def naming_pattern(self, pattern=None, multi=None, anime_type=None):
                 cur_name_group_result = re.sub("(?i)(?x)" + regex_used, regex_replacement, cur_name_group)
                 result_name = result_name.replace(cur_name_group, cur_name_group_result)
 
-        result_name = self._format_string(result_name, replace_map)
+        result_name = self.format_string(result_name, replace_map)
 
         logger.debug(f"formatting pattern: {pattern} -> {result_name}")
 
@@ -2484,7 +2490,7 @@ def rename(self):
         current_path = absolute_current_path_no_ext
 
         if absolute_current_path_no_ext.startswith(self.show.location):
-            current_path = absolute_current_path_no_ext[len(self.show.location) :]
+            current_path = absolute_current_path_no_ext[len(self.show.location):]
 
         logger.debug(f"Renaming/moving episode from the base path {self.location} to {absolute_proper_path}")
 
@@ -2536,7 +2542,7 @@ def rename(self):
 
         # in case something changed with the metadata just do a quick check
         for curEp in [self] + self.related_episodes:
-            curEp.checkForMetaFiles()
+            curEp.check_for_meta_files()
 
         # save changes to the database
         sql_l = []
@@ -2548,7 +2554,7 @@ def rename(self):
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
 
-    def airdateModifyStamp(self):
+    def airdate_modify_stamp(self):
         """
         Make the modify date and time of a file reflect the show air date and time.
         Note: Also called from postProcessor
diff --git a/sickchill/views/api/webapi.py b/sickchill/views/api/webapi.py
index b8f325a6d6..259d896fc2 100644
--- a/sickchill/views/api/webapi.py
+++ b/sickchill/views/api/webapi.py
@@ -800,7 +800,7 @@ def run(self):
             return _responds(RESULT_FAILURE, msg="Show not found")
 
         # retrieve the episode object and fail if we can't get one
-        episode_object = show_obj.getEpisode(self.s, self.e)
+        episode_object = show_obj.get_episode(self.s, self.e)
         if isinstance(episode_object, str):
             return _responds(RESULT_FAILURE, msg="Episode not found")
 
@@ -939,13 +939,13 @@ def run(self):
         self.status = status_to_code(self.status)
 
         if self.e:
-            episode_object = show_obj.getEpisode(self.s, self.e)
+            episode_object = show_obj.get_episode(self.s, self.e)
             if not episode_object:
                 return _responds(RESULT_FAILURE, msg="Episode not found")
             ep_list = [episode_object]
         else:
             # get all episode numbers from self, season
-            ep_list = show_obj.getAllEpisodes(season=self.s)
+            ep_list = show_obj.get_all_episodes(season=self.s)
 
         def _ep_result(result_code, ep, msg=""):
             return {"season": ep.season, "episode": ep.episode, "status": statusStrings_bare[ep.status], "result": result_type_map[result_code], "message": msg}
@@ -1043,7 +1043,7 @@ def run(self):
             return _responds(RESULT_FAILURE, msg="Show not found")
 
         # retrieve the episode object and fail if we can't get one
-        episode_object = show_obj.getEpisode(self.s, self.e)
+        episode_object = show_obj.get_episode(self.s, self.e)
         if isinstance(episode_object, str):
             return _responds(RESULT_FAILURE, msg="Episode not found")
 
@@ -1227,7 +1227,7 @@ def run(self):
             )
 
             for curResult in sql_results:
-                cur_ep_cat = curShow.getOverview(curResult["status"])
+                cur_ep_cat = curShow.get_overview(curResult["status"])
                 if cur_ep_cat and cur_ep_cat in (Overview.WANTED, Overview.QUAL):
                     show_eps.append(curResult)
 
@@ -1942,9 +1942,9 @@ def run(self):
             show_dict["network"] = ""
         show_dict["status"] = show_obj.status
 
-        if try_int(show_obj.nextaired, 1) > 693595:
+        if try_int(show_obj.next_airdate, 1) > 693595:
             dt_episode_airs = scdatetime.scdatetime.convert_to_setting(
-                network_timezones.parse_date_time(show_obj.nextaired, show_dict["airs"], show_dict["network"])
+                network_timezones.parse_date_time(show_obj.next_airdate, show_dict["airs"], show_dict["network"])
             )
             show_dict["airs"] = scdatetime.scdatetime.scftime(dt_episode_airs, t_preset=timeFormat).lstrip("0").replace(" 0", " ")
             show_dict["next_ep_airdate"] = scdatetime.scdatetime.scfdate(dt_episode_airs, d_preset=dateFormat)
@@ -2763,9 +2763,9 @@ def run(self):
                 "subtitles": (0, 1)[curShow.subtitles],
             }
 
-            if try_int(curShow.nextaired, 1) > 693595:  # 1900
+            if try_int(curShow.next_airdate, 1) > 693595:  # 1900
                 dt_episode_airs = scdatetime.scdatetime.convert_to_setting(
-                    network_timezones.parse_date_time(curShow.nextaired, curShow.airs, show_dict["network"])
+                    network_timezones.parse_date_time(curShow.next_airdate, curShow.airs, show_dict["network"])
                 )
                 show_dict["next_ep_airdate"] = scdatetime.scdatetime.scfdate(dt_episode_airs, d_preset=dateFormat)
             else:
diff --git a/sickchill/views/home.py b/sickchill/views/home.py
index 1265443324..7cbe60a0c2 100644
--- a/sickchill/views/home.py
+++ b/sickchill/views/home.py
@@ -61,9 +61,9 @@ def _getEpisode(show, season=None, episode=None, absolute=None):
             return None, _("Invalid show parameters")
 
         if absolute:
-            episode_object = show_obj.getEpisode(absolute_number=absolute)
+            episode_object = show_obj.get_episode(absolute_number=absolute)
         elif season and episode:
-            episode_object = show_obj.getEpisode(season, episode)
+            episode_object = show_obj.get_episode(season, episode)
         else:
             return None, _("Invalid parameters")
 
@@ -891,7 +891,7 @@ def displayShow(self):
         epCats = {}
 
         for curResult in sql_results:
-            curEpCat = show_obj.getOverview(curResult["status"])
+            curEpCat = show_obj.get_overview(curResult["status"])
             if curEpCat:
                 epCats[str(curResult["season"]) + "x" + str(curResult["episode"])] = curEpCat
                 epCounts[curEpCat] += 1
@@ -1250,7 +1250,7 @@ def get_images(image):
                         )
 
             # save it to the DB
-            show_obj.saveToDB()
+            show_obj.save_to_db()
 
         # force the update
         if do_update:
@@ -1470,7 +1470,7 @@ def setStatus(self, direct=False):
                     logger.debug(f"Something went wrong when trying to setStatus, {episode_num(*ep_info)}")
                     continue
 
-                episode_object = show_obj.getEpisode(ep_info[0], ep_info[1])
+                episode_object = show_obj.get_episode(ep_info[0], ep_info[1])
 
                 if not episode_object:
                     return self._genericMessage(_("Error"), _("Episode couldn't be retrieved"))
@@ -1588,7 +1588,7 @@ def testRename(self):
         except ShowDirectoryNotFoundException:
             return self._genericMessage(_("Error"), _("Can't rename episodes when the show dir is missing."))
 
-        show_obj.getAllEpisodes(has_location=True)
+        show_obj.get_all_episodes(has_location=True)
         t = PageTemplate(rh=self, filename="testRename.mako")
         submenu = [{"title": _("Edit"), "path": f"home/editShow?show={show_obj.indexerid}", "icon": "ui-icon ui-icon-pencil"}]
 
@@ -1625,11 +1625,11 @@ def doRename(self, show=None, eps=None):
                 "SELECT season, episode FROM tv_episodes WHERE location = ? AND episode != ?", [ep_result[0]["location"], ep_info[1]]
             )
 
-            root_ep_obj = show_obj.getEpisode(ep_info[0], ep_info[1])
+            root_ep_obj = show_obj.get_episode(ep_info[0], ep_info[1])
             root_ep_obj.related_episodes = []
 
             for cur_related_ep in related_eps_result:
-                related_ep_obj = show_obj.getEpisode(cur_related_ep["season"], cur_related_ep["episode"])
+                related_ep_obj = show_obj.get_episode(cur_related_ep["season"], cur_related_ep["episode"])
                 if related_ep_obj not in root_ep_obj.related_episodes:
                     root_ep_obj.related_episodes.append(related_ep_obj)
 
@@ -1661,7 +1661,7 @@ def manual_search_show_releases(self):
             )
         else:
             show_object: TVShow = Show.find(settings.showList, show)
-            episodes_sql = "|".join([str(ep.season) for ep in show_object.getAllEpisodes(season=season) if ep.season > 0])
+            episodes_sql = "|".join([str(ep.season) for ep in show_object.get_all_episodes(season=season) if ep.season > 0])
             results = cache_db_con.select(
                 "SELECT * FROM results WHERE indexerid = ? AND season = ? AND episodes LIKE ? AND status != ? ORDER BY seeders DESC",
                 [show, season, f"%{episodes_sql}%", FAILED],
@@ -1762,7 +1762,7 @@ def relative_ep_location(ep_loc, show_loc):
                         "searchstatus": search_status,
                         "status": statusStrings[search_thread.segment.status],
                         "quality": self.getQualityClass(search_thread.segment),
-                        "overview": Overview.overviewStrings[show_obj.getOverview(search_thread.segment.status)],
+                        "overview": Overview.overviewStrings[show_obj.get_overview(search_thread.segment.status)],
                         "location": relative_ep_location(search_thread.segment._location, show_obj._location),
                         "size": pretty_file_size(search_thread.segment.file_size) if search_thread.segment.file_size else "",
                     }
@@ -1779,7 +1779,7 @@ def relative_ep_location(ep_loc, show_loc):
                             "searchstatus": search_status,
                             "status": statusStrings[episode_object.status],
                             "quality": self.getQualityClass(episode_object),
-                            "overview": Overview.overviewStrings[show_obj.getOverview(episode_object.status)],
+                            "overview": Overview.overviewStrings[show_obj.get_overview(episode_object.status)],
                             "location": relative_ep_location(episode_object._location, show_obj._location),
                             "size": pretty_file_size(episode_object.file_size) if episode_object.file_size else "",
                         }
diff --git a/sickchill/views/manage/index.py b/sickchill/views/manage/index.py
index a2ac90f45d..16c1b73d30 100644
--- a/sickchill/views/manage/index.py
+++ b/sickchill/views/manage/index.py
@@ -264,7 +264,7 @@ def downloadSubtitleMissed(self, *args, **kwargs):
                 season, episode = epResult.split("x")
 
                 show = Show.find(settings.showList, int(cur_indexer_id))
-                show.getEpisode(season, episode).download_subtitles()
+                show.get_episode(season, episode).download_subtitles()
 
         return self.redirect("/manage/subtitleMissed/")
 
@@ -305,7 +305,7 @@ def backlogOverview(self):
             )
 
             for curResult in sql_results:
-                curEpCat = current_show.getOverview(curResult["status"], backlog=settings.BACKLOG_MISSING_ONLY)
+                curEpCat = current_show.get_overview(curResult["status"], backlog=settings.BACKLOG_MISSING_ONLY)
                 if curEpCat:
                     epCats["{ep}".format(ep=episode_num(curResult["season"], curResult["episode"]))] = curEpCat
                     epCounts[curEpCat] += 1
diff --git a/tests/conftest.py b/tests/conftest.py
index ddbd46ea4b..86904e9e62 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -145,7 +145,7 @@ def _fake_specify_ep(self, season, episode):
 
 
 # the real one tries to contact TVDB just stop it from getting more info on the ep
-TVEpisode.specifyEpisode = _fake_specify_ep
+TVEpisode.specify_episode = _fake_specify_ep
 
 
 # =================
@@ -203,14 +203,14 @@ def setUp(self):
                 else:
                     episode = TVEpisode(self.show, season, episode)
                 self.show.episodes[season][episode] = episode
-                episode.saveToDB()
+                episode.save_to_db()
 
-        self.show.saveToDB()
+        self.show.save_to_db()
         settings.showList = [self.show]
 
     def tearDown(self):
         settings.showList = []
-        self.show.deleteShow(True)
+        self.show.delete_show(True)
         teardown_test_db()
         teardown_test_episode_file()
         teardown_test_show_dir()
diff --git a/tests/sickchill_tests/show/test_show.py b/tests/sickchill_tests/show/test_show.py
index aea0bbcd4c..c2e93f0e97 100644
--- a/tests/sickchill_tests/show/test_show.py
+++ b/tests/sickchill_tests/show/test_show.py
@@ -118,7 +118,7 @@ class TestTVShow(TVShow):
     def __init__(self, indexer, indexer_id):
         super().__init__(indexer, indexer_id)
 
-    def loadFromDB(self):
+    def load_from_db(self):
         """
         Override TVShow.loadFromDB to avoid DB access during testing
         """
diff --git a/tests/test_notifier.py b/tests/test_notifier.py
index 761dae5d69..d2aac66685 100644
--- a/tests/test_notifier.py
+++ b/tests/test_notifier.py
@@ -44,7 +44,7 @@ def setUpClass(cls):
                 episode.name = f"Episode {episode_counter + 1}"
                 episode.quality = "SDTV"
                 show.episodes.append(episode)
-            show.saveToDB()
+            show.save_to_db()
             cls.legacy_shows.append(show)
 
         for show_counter in range(200, 200 + num_shows):
@@ -56,7 +56,7 @@ def setUpClass(cls):
                 episode.name = f"Episode {episode_counter + 1}"
                 episode.quality = "SDTV"
                 show.episodes.append(episode)
-            show.saveToDB()
+            show.save_to_db()
             cls.shows.append(show)
 
     def setUp(self):
diff --git a/tests/test_pp.py b/tests/test_pp.py
index c09be760c7..e42278592c 100644
--- a/tests/test_pp.py
+++ b/tests/test_pp.py
@@ -50,12 +50,12 @@ def test_process(self):
         show = TVShow(1, 3)
         show.name = conftest.SHOW_NAME
         show.location = conftest.SHOW_DIR
-        show.saveToDB()
+        show.save_to_db()
 
         settings.showList = [show]
         episode = TVEpisode(show, conftest.SEASON, conftest.EPISODE)
         episode.name = "some episode name"
-        episode.saveToDB()
+        episode.save_to_db()
 
         add_name("show name", 3)
         settings.PROCESS_METHOD = "move"
diff --git a/tests/test_search.py b/tests/test_search.py
index 36f68f3ec5..028f05d6dd 100644
--- a/tests/test_search.py
+++ b/tests/test_search.py
@@ -44,7 +44,7 @@ def do_test(self):
         show = TVShow(1, int(cur_data["tvdbid"]))
         show.name = cur_name
         show.quality = common.ANY | common.Quality.UNKNOWN | common.Quality.RAWHDTV
-        show.saveToDB()
+        show.save_to_db()
         settings.showList.append(show)
 
         for ep_number in cur_data["e"]:
@@ -55,7 +55,7 @@ def do_test(self):
             episode.scene_season = cur_data["s"]
             episode.scene_episode = ep_number
 
-            episode.saveToDB()
+            episode.save_to_db()
 
             cur_provider.show = show
             season_strings = cur_provider.get_season_search_strings(episode)
diff --git a/tests/test_snatch.py b/tests/test_snatch.py
index 4ef00355fd..ef22c2ebe4 100644
--- a/tests/test_snatch.py
+++ b/tests/test_snatch.py
@@ -115,14 +115,14 @@ def do_test():
         show = TVShow(1, tvdb_id)
         show.name = show_name
         show.quality = cur_data["q"]
-        show.saveToDB()
+        show.save_to_db()
         settings.showList.append(show)
         episode = None
 
         for epNumber in cur_data["e"]:
             episode = TVEpisode(show, cur_data["s"], epNumber)
             episode.status = common.WANTED
-            episode.saveToDB()
+            episode.save_to_db()
 
         best_result = search.search_providers(show, episode.episode, force_search)
         if not best_result:
diff --git a/tests/test_tv.py b/tests/test_tv.py
index 557f18e7bc..f7c98550fe 100644
--- a/tests/test_tv.py
+++ b/tests/test_tv.py
@@ -24,19 +24,19 @@ def test_init_indexerid(self):
         """
         test init indexer id
         """
-        self.show.loadFromDB()
+        self.show.load_from_db()
         assert self.show.indexerid == 1
 
     def test_change_indexerid(self):
         """
         test change indexer id
         """
-        self.show.loadFromDB()
+        self.show.load_from_db()
         assert self.show.indexerid == 1
 
         self.show.indexerid = 295759
-        self.show.saveToDB()
-        self.show.loadFromDB()
+        self.show.save_to_db()
+        self.show.load_from_db()
 
         assert self.show.indexerid == 295759
 
@@ -46,15 +46,15 @@ def test_set_name(self):
         """
         self.show.name = "newName"
 
-        self.show.saveToDB()
-        self.show.loadFromDB()
+        self.show.save_to_db()
+        self.show.load_from_db()
         assert self.show.name == "newName"
         assert self.show.show_name == "newName"
 
         self.show.show_name = "show_name"
 
-        self.show.saveToDB()
-        self.show.loadFromDB()
+        self.show.save_to_db()
+        self.show.load_from_db()
         assert self.show.name == "show_name"
 
     def test_show_with_custom_name(self):
@@ -64,8 +64,8 @@ def test_show_with_custom_name(self):
         self.show.name = "show name"
         self.show.show_name = "show name"
         self.show.custom_name = "newName"
-        self.show.saveToDB()
-        self.show.loadFromDB()
+        self.show.save_to_db()
+        self.show.load_from_db()
 
         assert self.show.show_name == "show name"
 
@@ -92,8 +92,8 @@ def test_init_empty_db(self):
         show = TVShow(1, 1, "en")
         episode = TVEpisode(show, 1, 1)
         episode.name = "asdasdasdajkaj"
-        episode.saveToDB()
-        episode.loadFromDB(1, 1)
+        episode.save_to_db()
+        episode.load_from_db(1, 1)
         assert episode.name == "asdasdasdajkaj"
 
 
@@ -123,7 +123,7 @@ def test_get_episode():
         show.default_ep_status = "5"
         show.airs = "monday"
         show.startyear = 1987
-        show.saveToDB()
+        show.save_to_db()
         settings.showList = [show]
         # TODO: implement
 

From a3055a7f6c0bf79e1d748c3b90f7fa1c2d1659d4 Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 01:37:35 -0500
Subject: [PATCH 02/29] fix: use property decorators instead of accessors to
 avoid type checking errors

Signed-off-by: miigotu <miigotu@gmail.com>
---
 sickchill/providers/torrent/FrenchProvider.py | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/sickchill/providers/torrent/FrenchProvider.py b/sickchill/providers/torrent/FrenchProvider.py
index 492047d346..934acd6f63 100644
--- a/sickchill/providers/torrent/FrenchProvider.py
+++ b/sickchill/providers/torrent/FrenchProvider.py
@@ -62,15 +62,18 @@ def _retrieve_dllink_from_url(self, inner_url):
 
         return ""
 
-    def _get_custom_url(self):
+    @property
+    def custom_url(self):
         return self._custom_url
 
-    def _set_custom_url(self, url):
+    @custom_url.setter
+    def custom_url(self, url):
         if self._custom_url != url:
             self._custom_url = url
             self._recheck_url = True
 
-    def _get_provider_url(self):
+    @property
+    def url(self):
         if self._recheck_url:
             if self.custom_url:
                 if self.valid_url(self.custom_url):
@@ -82,14 +85,10 @@ def _get_provider_url(self):
 
         return self._used_url
 
-    def _set_provider_url(self, url):
+    @url.setter
+    def url(self, url):
         self._used_url = url
 
-    # noinspection PyTypeChecker
-    url = property(_get_provider_url, _set_provider_url)
-    # noinspection PyTypeChecker
-    custom_url = property(_get_custom_url, _set_custom_url)
-
     def get_season_search_strings(self, episode: "TVEpisode") -> List[Dict]:
         search_string = {"Season": set()}
         for show_name in allPossibleShowNames(episode.show, season=episode.scene_season):

From e36b6fb96df6dbc4cc307e7391983df737db17fd Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 01:40:46 -0500
Subject: [PATCH 03/29] black

Signed-off-by: miigotu <miigotu@gmail.com>
---
 sickchill/tv.py | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/sickchill/tv.py b/sickchill/tv.py
index 06f3a62079..9e4fb1192f 100644
--- a/sickchill/tv.py
+++ b/sickchill/tv.py
@@ -15,7 +15,6 @@
 
 import imdb
 from imdb import Cinemagoer
-
 from unidecode import unidecode
 from urllib3.exceptions import MaxRetryError, NewConnectionError
 
@@ -487,9 +486,7 @@ def load_episodes_from_db(self):
                 episode_object.load_from_db(season, episode)
                 scanned_episodes[season][episode] = True
             except EpisodeDeletedException:
-                logger.debug(
-                    f"{showid}: Tried loading {show_name} {episode_num(season, episode)} from the DB that should have been deleted, skipping it"
-                )
+                logger.debug(f"{showid}: Tried loading {show_name} {episode_num(season, episode)} from the DB that should have been deleted, skipping it")
                 continue
 
         if show_name and showid:
@@ -571,7 +568,9 @@ def make_ep_from_file(self, filepath):
         logger.debug(f"{self.indexerid}: Creating episode object from {filepath}")
 
         try:
-            parse_result = NameParser(showObj=self, tryIndexers=True, parse_method=("normal", "anime")[self.is_anime]).parse(filepath, skip_scene_detection=True)
+            parse_result = NameParser(showObj=self, tryIndexers=True, parse_method=("normal", "anime")[self.is_anime]).parse(
+                filepath, skip_scene_detection=True
+            )
         except (InvalidNameException, InvalidShowException) as error:
             logger.debug(f"{self.indexerid}: {error}")
             return None
@@ -635,7 +634,9 @@ def make_ep_from_file(self, filepath):
             # if they replace a file on me, I'll make some attempt at re-checking the quality unless I know it's the same file
             if check_quality_again and not same_file:
                 new_quality = Quality.nameQuality(filepath, self.is_anime)
-                logger.debug(f"{self.indexerid}: Since this file has been renamed, I checked {filepath} and found quality {Quality.qualityStrings[new_quality]}")
+                logger.debug(
+                    f"{self.indexerid}: Since this file has been renamed, I checked {filepath} and found quality {Quality.qualityStrings[new_quality]}"
+                )
 
                 with episode.lock:
                     episode.status = Quality.compositeStatus(DOWNLOADED, new_quality)
@@ -1763,7 +1764,7 @@ def load_from_nfo(self, location):
                         or int(ep_details.findtext("episode")) != self.episode
                     ):
                         ep_string = episode_num(self.season, self.episode)
-                        other_string = episode_num(ep_details.findtext('season'), ep_details.findtext('episode'))
+                        other_string = episode_num(ep_details.findtext("season"), ep_details.findtext("episode"))
                         logger.debug(
                             f"{self.show.indexerid}: NFO has an <episodedetails> block for a different episode - wanted {ep_string} but got {other_string}"
                         )
@@ -2490,7 +2491,7 @@ def rename(self):
         current_path = absolute_current_path_no_ext
 
         if absolute_current_path_no_ext.startswith(self.show.location):
-            current_path = absolute_current_path_no_ext[len(self.show.location):]
+            current_path = absolute_current_path_no_ext[len(self.show.location) :]
 
         logger.debug(f"Renaming/moving episode from the base path {self.location} to {absolute_proper_path}")
 

From 8a67418bf3325b9056b3878bf7e752f23fa6d84e Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 01:51:58 -0500
Subject: [PATCH 04/29] chore: update release workflow

Signed-off-by: miigotu <miigotu@gmail.com>
---
 .github/workflows/release.yml | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 19c6f246e2..2b6a671273 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -2,11 +2,9 @@ name: Build develop branch
 
 on:
   workflow_run:
-    workflows: [Python Packaging]
-    branches: |
-      - develop
-    types:
-      - completed
+    workflows: [ Python Packaging ]
+    branches: [ develop ]
+    types: [ completed, requested ]
 
 jobs:
   version:

From 89546f49820e2db00e590a2552cf83382718c353 Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 09:18:39 -0500
Subject: [PATCH 05/29] refactor: missed changes

Signed-off-by: miigotu <miigotu@gmail.com>
---
 sickchill/oldbeard/postProcessor.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/sickchill/oldbeard/postProcessor.py b/sickchill/oldbeard/postProcessor.py
index 0c069c7bee..fdc3bcb76b 100644
--- a/sickchill/oldbeard/postProcessor.py
+++ b/sickchill/oldbeard/postProcessor.py
@@ -501,7 +501,7 @@ def _history_lookup(self):
         # search the database for a possible match and return immediately if we find one
         main_db_con = db.DBConnection()
         for curName in names:
-            search_name = re.sub(r"[\.\- ]", "_", curName)
+            search_name = re.sub(r"[.\- ]", "_", curName)
             sql_results = main_db_con.select(
                 "SELECT showid, season, quality, version, resource FROM history WHERE resource LIKE ? AND (action % 100 = 4 OR action % 100 = 6)", [search_name]
             )
@@ -840,7 +840,7 @@ def _run_extra_scripts(self, episode_object):
             self._log(f"Absolute path to script: {script_cmd[0]}", logger.DEBUG)
 
             script_cmd += [
-                episode_object._location,
+                episode_object.location,
                 self.directory,
                 str(episode_object.show.indexerid),
                 str(episode_object.season),
@@ -1174,14 +1174,14 @@ def process(self):
             main_db_con = db.DBConnection()
             main_db_con.mass_action(sql_l)
 
-        episode_object.airdateModifyStamp()
+        episode_object.airdate_modify_stamp()
 
         if settings.USE_ICACLS and os.name == "nt":
-            os.popen('icacls "' + episode_object._location + '"* /reset /T')
+            os.popen(f'icacls "{episode_object._location}"* /reset /T')
 
         # generate nfo/tbn
         try:
-            episode_object.createMetaFiles()
+            episode_object.create_meta_files()
         except Exception:
             logger.info(_("Could not create/update meta files. Continuing with postProcessing..."))
 

From 6989d8c83116b76c1fdfceb989c786619d9ff0ca Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Sat, 3 Feb 2024 22:40:34 +0700
Subject: [PATCH 06/29] additional time error capture

---
 sickchill/tv.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sickchill/tv.py b/sickchill/tv.py
index 9e4fb1192f..cd06c05b35 100644
--- a/sickchill/tv.py
+++ b/sickchill/tv.py
@@ -2599,6 +2599,9 @@ def airdate_modify_stamp(self):
                         f"to show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"
                     )
 
+                except OverflowError or ValueError as error:
+                    logger.warning(f"Date change error: {error}, raw air date time: {airdatetime}")
+
         except OSError:
             logger.warning(f"{self.show.indexerid}: Failed to modify date of '{os.path.basename(self.location)}'")
 

From 7ba09ac41365c96149abb760b3c71752c6f39aea Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 14:09:19 -0500
Subject: [PATCH 07/29] refactor: more renaming and fixing types

Signed-off-by: miigotu <miigotu@gmail.com>
---
 sickchill/gui/slick/views/displayShow.mako    | 12 +--
 sickchill/gui/slick/views/editShow.mako       |  2 +-
 sickchill/gui/slick/views/manage.mako         |  2 +-
 sickchill/gui/slick/views/testRename.mako     |  4 +-
 sickchill/oldbeard/helpers.py                 | 30 +++----
 sickchill/oldbeard/name_parser/parser.py      | 88 ++++++++++---------
 sickchill/oldbeard/name_parser/regexes.py     |  2 +-
 sickchill/oldbeard/naming.py                  |  2 +-
 sickchill/oldbeard/nzbSplitter.py             |  4 +-
 sickchill/oldbeard/postProcessor.py           | 64 ++++++++------
 sickchill/oldbeard/providers/ilcorsaronero.py |  2 +-
 sickchill/oldbeard/providers/tntvillage.py    |  2 +-
 sickchill/oldbeard/show_queue.py              |  4 +-
 sickchill/oldbeard/tvcache.py                 |  2 +-
 sickchill/tv.py                               | 18 ++--
 sickchill/views/home.py                       | 27 +++---
 sickchill/views/index.py                      | 16 ++++
 sickchill/views/manage/index.py               | 74 ++++++++--------
 tests/test_name_parser.py                     |  8 +-
 19 files changed, 194 insertions(+), 169 deletions(-)

diff --git a/sickchill/gui/slick/views/displayShow.mako b/sickchill/gui/slick/views/displayShow.mako
index 619fb322bb..21612f446c 100644
--- a/sickchill/gui/slick/views/displayShow.mako
+++ b/sickchill/gui/slick/views/displayShow.mako
@@ -404,9 +404,9 @@
                         (season_number, episode_number) = (default_season, default_episode)
                         default_episode_numbering = True
 
-                    epLoc = epResult["location"]
-                    if epLoc and show._location and epLoc.lower().startswith(show._location.lower()):
-                        epLoc = epLoc[len(show._location)+1:]
+                    episode_location = epResult["location"]
+                    if episode_location and show.get_location and episode_location.lower().startswith(show.get_location.lower()):
+                        episode_location = episode_location[len(show.get_location)+1:]
                 %>
                 % if int(epResult["season"]) != curSeason:
                     % if epResult["season"] != sql_results[0]["season"]:
@@ -485,8 +485,8 @@
                         <td class="text-center episode">
                             <%
                                 text = str(epResult['episode'])
-                                if epLoc:
-                                    text = '<span title="' + epLoc + '" class="addQTip">' + text + "</span>"
+                                if episode_location:
+                                    text = '<span title="' + episode_location + '" class="addQTip">' + text + "</span>"
                             %>
                         ${text}
                         </td>
@@ -523,7 +523,7 @@
                             % endif
                             ${epResult["name"]}
                         </td>
-                        <td class="col-name location">${epLoc}</td>
+                        <td class="col-name location">${episode_location}</td>
                         <td class="col-ep size">
                             % if epResult["file_size"]:
                             ${pretty_file_size(epResult["file_size"])}
diff --git a/sickchill/gui/slick/views/editShow.mako b/sickchill/gui/slick/views/editShow.mako
index d25dd09934..a80ad49fbc 100644
--- a/sickchill/gui/slick/views/editShow.mako
+++ b/sickchill/gui/slick/views/editShow.mako
@@ -79,7 +79,7 @@
                                     </div>
                                     <div class="col-lg-9 col-md-8 col-sm-7 col-xs-12 component-desc">
                                         <input type="hidden" name="show" id="showID" value="${show.indexerid}" />
-                                        <input type="text" name="location" id="location" value="${show._location}"
+                                        <input type="text" name="location" id="location" value="${show.get_location}"
                                                class="form-control input-sm input350"
                                                autocapitalize="off" title="Location" />
                                     </div>
diff --git a/sickchill/gui/slick/views/manage.mako b/sickchill/gui/slick/views/manage.mako
index 4e30882de0..53d28024e5 100644
--- a/sickchill/gui/slick/views/manage.mako
+++ b/sickchill/gui/slick/views/manage.mako
@@ -109,7 +109,7 @@
                                     <td class="text-center">${statusStrings[curShow.default_ep_status]}</td>
                                     <td class="text-center">${_(curShow.status)}</td>
 
-                                    <td class="text-center">${curShow._location.rsplit('\\', 1)[0]}</td>
+                                    <td class="text-center">${curShow.get_location.rsplit('\\', 1)[0]}</td>
                                     <td class="text-center">
                                         <% disabled = settings.showQueueScheduler.action.is_being_updated(curShow) or settings.showQueueScheduler.action.is_in_update_queue(curShow) %>
                                         <label for="update-${curShow.indexerid}" class="sr-only">${_('Update')} ${curShow.name}</label>
diff --git a/sickchill/gui/slick/views/testRename.mako b/sickchill/gui/slick/views/testRename.mako
index 469a0f9ce4..4b38c31e7d 100644
--- a/sickchill/gui/slick/views/testRename.mako
+++ b/sickchill/gui/slick/views/testRename.mako
@@ -78,14 +78,14 @@
                             % for current_episode in sorted(show.episodes[current_season], reverse=True):
                                 <%
                                     episode_object = show.episodes[current_season][current_episode]
-                                    if not (episode_object and episode_object._location):
+                                    if not (episode_object and episode_object.location):
                                         continue
 
                                     episode_list = episode_object.sorted_episode_list
                                     if episode_object.episode != min(episode_list):
                                         continue
 
-                                    location = episode_object.location[len(show._location)+1:]
+                                    location = episode_object.location[len(show.get_location)+1:]
                                     extension = location.split('.')[-1]
                                     new_location = episode_object.proper_path() + '.' + extension
                                 %>
diff --git a/sickchill/oldbeard/helpers.py b/sickchill/oldbeard/helpers.py
index 03d13e50da..ba0f3beba6 100644
--- a/sickchill/oldbeard/helpers.py
+++ b/sickchill/oldbeard/helpers.py
@@ -891,22 +891,22 @@ def _check_against_names(nameInQuestion, show, season=-1):
     return False
 
 
-def get_show(name, tryIndexers=False):
+def get_show(name, try_indexers=False):
     if not settings.showList:
         return
 
-    showObj = None
-    fromCache = False
+    show_object = None
+    from_cache = False
 
     if not name:
-        return showObj
+        return show_object
 
     try:
         # check cache for show
         cache = sickchill.oldbeard.name_cache.get_id_from_name(name)
         if cache:
-            fromCache = True
-            showObj = Show.find(settings.showList, int(cache))
+            from_cache = True
+            show_object = Show.find(settings.showList, int(cache))
         else:
             check_names = [full_sanitizeSceneName(name), name]
             show_matches = [
@@ -917,31 +917,31 @@ def get_show(name, tryIndexers=False):
             ]
 
             if len(show_matches) == 1:
-                showObj = show_matches[0]
+                show_object = show_matches[0]
 
         # try indexers
-        if not showObj and tryIndexers:
+        if not show_object and try_indexers:
             result = sickchill.indexer.search_indexers_for_series_id(name=full_sanitizeSceneName(name))[1]
             if result:
-                showObj = Show.find(settings.showList, result.id)
+                show_object = Show.find(settings.showList, result.id)
 
         # try scene exceptions
-        if not showObj:
+        if not show_object:
             scene_exceptions = sickchill.oldbeard.scene_exceptions.get_scene_exception_by_name_multiple(name)
             for scene_exception in scene_exceptions:
                 if scene_exception[0]:
-                    showObj = Show.find(settings.showList, scene_exception[0])
-                    if showObj:
+                    show_object = Show.find(settings.showList, scene_exception[0])
+                    if show_object:
                         break
 
         # add show to cache
-        if showObj and not fromCache:
-            sickchill.oldbeard.name_cache.add_name(name, showObj.indexerid)
+        if show_object and not from_cache:
+            sickchill.oldbeard.name_cache.add_name(name, show_object.indexerid)
     except Exception as error:
         logger.debug(_("There was a problem when attempting to find {name} in SickChill. Error: {error}").format(name=name, error=error))
         logger.debug(traceback.format_exc())
 
-    return showObj
+    return show_object
 
 
 def is_hidden_folder(folder):
diff --git a/sickchill/oldbeard/name_parser/parser.py b/sickchill/oldbeard/name_parser/parser.py
index c5072c61c2..5232d60fb9 100644
--- a/sickchill/oldbeard/name_parser/parser.py
+++ b/sickchill/oldbeard/name_parser/parser.py
@@ -3,9 +3,10 @@
 import re
 import time
 from collections import OrderedDict
+from datetime import date
 from operator import attrgetter
 from threading import Lock
-from typing import TYPE_CHECKING
+from typing import Any, TYPE_CHECKING
 
 from dateutil.parser import parse
 
@@ -26,17 +27,17 @@ class NameParser(object):
     NORMAL_REGEX = 1
     ANIME_REGEX = 2
 
-    def __init__(self, filename: bool = True, showObj=None, tryIndexers: bool = False, naming_pattern: bool = False, parse_method: str = None):
+    def __init__(self, filename: bool = True, show_object=None, try_indexers: bool = False, naming_pattern: bool = False, parse_method: str = None):
         self.filename: bool = filename
-        self.showObj: TVShow = showObj
-        self.tryIndexers: bool = tryIndexers
+        self.show_object: TVShow = show_object
+        self.try_indexers: bool = try_indexers
         self.compiled_regexes: List = []
 
         self.naming_pattern = naming_pattern
 
-        if (self.showObj and not self.showObj.is_anime) or parse_method == "normal":
+        if (self.show_object and not self.show_object.is_anime) or parse_method == "normal":
             self._compile_regexes(self.NORMAL_REGEX)
-        elif (self.showObj and self.showObj.is_anime) or parse_method == "anime":
+        elif (self.show_object and self.show_object.is_anime) or parse_method == "anime":
             self._compile_regexes(self.ANIME_REGEX)
         else:
             self._compile_regexes(self.ALL_REGEX)
@@ -57,14 +58,14 @@ def clean_series_name(series_name):
         series_name = re.sub(r"\.(?!\s)(\D)", " \\1", series_name)
         series_name = series_name.replace("_", " ")
         series_name = re.sub(r"-$", "", series_name)
-        series_name = re.sub(r"^\[.*\]", "", series_name)
+        series_name = re.sub(r"^\[.*]", "", series_name)
         return series_name.strip()
 
-    def _compile_regexes(self, regexMode):
-        if regexMode == self.ANIME_REGEX:
+    def _compile_regexes(self, regex_mode):
+        if regex_mode == self.ANIME_REGEX:
             dbg_str = "ANIME"
             uncompiled_regex = [regexes.anime_regexes]
-        elif regexMode == self.NORMAL_REGEX:
+        elif regex_mode == self.NORMAL_REGEX:
             dbg_str = "NORMAL"
             uncompiled_regex = [regexes.normal_regexes]
         else:
@@ -75,8 +76,8 @@ def _compile_regexes(self, regexMode):
             for cur_pattern_num, (cur_pattern_name, cur_pattern) in enumerate(regexItem):
                 try:
                     cur_regex = re.compile(cur_pattern, re.VERBOSE | re.I)
-                except re.error as errormsg:
-                    logger.info(f"WARNING: Invalid episode_pattern using {dbg_str} regexs, {errormsg}. {cur_pattern}")
+                except re.error as error_message:
+                    logger.info(f"WARNING: Invalid episode_pattern using {dbg_str} regexes, {error_message}. {cur_pattern}")
                 else:
                     self.compiled_regexes.append((cur_pattern_num, cur_pattern_name, cur_regex))
 
@@ -145,11 +146,10 @@ def _parse_string(self, name, skip_scene_detection=False):
                     # Workaround for shows that get interpreted as 'air_date' incorrectly.
                     # Shows so far are 11.22.63 and 9-1-1
                     excluded_shows = ["112263", "911"]
-                    assert re.sub(r"[^\d]*", "", air_date) not in excluded_shows
+                    assert re.sub(r"\D*", "", air_date) not in excluded_shows
 
-                    # noinspection PyUnresolvedReferences
                     try:
-                        check = parse(air_date, fuzzy_with_tokens=True)[0].date()
+                        check: date = parse(air_date, fuzzy=True).date()
                         # Make sure a 20th century date isn't returned as a 21st century date
                         # 1 Year into the future (No releases should be coming out a year ahead of time, that's just insane)
                         if check > check.today() and (check - check.today()).days // 365 > 1:
@@ -157,7 +157,8 @@ def _parse_string(self, name, skip_scene_detection=False):
 
                         result.air_date = check
                         result.score += 1
-                    except:
+                    except Exception as error:
+                        logger.debug(error)
                         continue
                 except Exception as error:
                     logger.debug(error)
@@ -193,21 +194,21 @@ def _parse_string(self, name, skip_scene_detection=False):
         # matches = [x for x in matches if x.series_name]
 
         if matches:
-            # pick best match with highest score based on placement
+            # pick the best match with the highest score based on placement
             best_result = max(sorted(matches, reverse=True, key=attrgetter("which_regex")), key=attrgetter("score"))
 
             show = None
             if best_result and best_result.series_name and not self.naming_pattern:
                 # try and create a show object for this result
-                show = helpers.get_show(best_result.series_name, self.tryIndexers)
+                show = helpers.get_show(best_result.series_name, self.try_indexers)
 
             # confirm passed in show object indexer id matches result show object indexer id
             if show:
-                if self.showObj and show.indexerid != self.showObj.indexerid:
+                if self.show_object and show.indexerid != self.show_object.indexerid:
                     show = None
                 best_result.show = show
-            elif self.showObj and not show:
-                best_result.show = self.showObj
+            elif self.show_object and not show:
+                best_result.show = self.show_object
 
             # Only allow anime matches if resolved show or specified show is anime
             best_result = self.check_anime_preferred(best_result, matches)
@@ -241,10 +242,11 @@ def _parse_string(self, name, skip_scene_detection=False):
 
                 if season_number is None or not episode_numbers:
                     try:
-                        epObj = sickchill.indexer.episode(best_result.show, firstAired=best_result.air_date)
-                        season_number = epObj["airedSeason"]
-                        episode_numbers = [epObj["airedEpisode"]]
-                    except Exception:
+                        episode_object = sickchill.indexer.episode(best_result.show, firstAired=best_result.air_date)
+                        season_number = episode_object["airedSeason"]
+                        episode_numbers = [episode_object["airedEpisode"]]
+                    except Exception as error:
+                        logger.debug(error)
                         logger.warning(f"Unable to find episode with date {best_result.air_date} for show {best_result.show.name}, skipping")
                         episode_numbers = []
 
@@ -264,7 +266,7 @@ def _parse_string(self, name, skip_scene_detection=False):
 
                     if best_result.show.is_scene and not skip_scene_detection:
                         a = scene_numbering.get_indexer_absolute_numbering(
-                            best_result.show.indexerid, best_result.show.indexer, epAbsNo, True, best_result.scene_season
+                            best_result.show.indexerid, best_result.show.indexer, epAbsNo, scene_season=best_result.scene_season
                         )
 
                     (s, e) = helpers.get_all_episodes_from_absolute_number(best_result.show, [a])
@@ -288,7 +290,7 @@ def _parse_string(self, name, skip_scene_detection=False):
                     new_episode_numbers.append(e)
                     new_season_numbers.append(s)
 
-            # need to do a quick sanity check heregex.  It's possible that we now have episodes
+            # need to do a quick sanity check regex.  It's possible that we now have episodes
             # from more than one season (by tvdb numbering), and this is just too much
             # for oldbeard, so we'd need to flag it.
             new_season_numbers = list(set(new_season_numbers))  # remove duplicates
@@ -297,8 +299,7 @@ def _parse_string(self, name, skip_scene_detection=False):
                     f"Scene numbering results episodes from seasons {new_season_numbers}, (i.e. more than one) and sickchill does not support this. Sorry."
                 )
 
-            # I guess it's possible that we'd have duplicate episodes too, so lets
-            # eliminate them
+            # I guess it's possible that we'd have duplicate episodes too, so let's eliminate them
             new_episode_numbers = sorted(set(new_episode_numbers))
 
             # maybe even duplicate absolute numbers so why not do them as well
@@ -321,8 +322,8 @@ def _parse_string(self, name, skip_scene_detection=False):
         return best_result
 
     def check_anime_preferred(self, best_result, matches):
-        show = self.showObj or best_result.show
-        if (best_result.show and best_result.show.is_anime and not self.showObj) or (self.showObj and self.showObj.is_anime):
+        show = self.show_object or best_result.show
+        if (best_result.show and best_result.show.is_anime and not self.show_object) or (self.show_object and self.show_object.is_anime):
             anime_matches = [x for x in matches if "anime" in x.which_regex[0]]
             if anime_matches:
                 best_result_anime = max(sorted(anime_matches, reverse=True, key=attrgetter("which_regex")), key=attrgetter("score"))
@@ -335,7 +336,7 @@ def check_anime_preferred(self, best_result, matches):
         return best_result
 
     @staticmethod
-    def _combine_results(first, second, attr):
+    def _combine_results(first: Any, second: Any, attr: str) -> Any:
         # if the first doesn't exist then return the second or nothing
         if not first:
             if not second:
@@ -347,18 +348,18 @@ def _combine_results(first, second, attr):
         if not second:
             return getattr(first, attr)
 
-        a = getattr(first, attr)
-        b = getattr(second, attr)
+        first_value = getattr(first, attr)
+        second_value = getattr(second, attr)
 
-        # if a is good use it
-        if a is not None or (isinstance(a, list) and a):
-            return a
-        # if not use b (if b isn't set it'll just be default)
+        # if first_value is good use it
+        if first_value is not None or (isinstance(first_value, list) and first_value):
+            return first_value
+        # if not use second_value (if second_value isn't set it'll just be default)
         else:
-            return b
+            return second_value
 
     @staticmethod
-    def _unicodify(obj, encoding="utf-8"):
+    def _to_unicode(obj, encoding="utf-8"):
         if isinstance(obj, bytes):
             obj = str(obj, encoding, "replace")
         return obj
@@ -379,7 +380,8 @@ def _convert_number(org_number):
             else:
                 number = 0
 
-        except Exception:
+        except Exception as error:
+            logger.debug(error)
             # on error try converting from Roman numerals
             roman_to_int_map = (
                 ("M", 1000),
@@ -409,7 +411,7 @@ def _convert_number(org_number):
         return number
 
     def parse(self, name, cache_result=True, skip_scene_detection=False):
-        name = self._unicodify(name)
+        name = self._to_unicode(name)
 
         if self.naming_pattern:
             cache_result = False
@@ -583,7 +585,7 @@ def __str__(self):
 
         to_return += f" [ABD: {self.is_air_by_date}] [ANIME: {self.is_anime}] [whichReg: {self.which_regex}] Score: {self.score}"
 
-        return re.sub(r"[ ]+", " ", to_return)
+        return re.sub(r" +", " ", to_return)
 
     @property
     def is_air_by_date(self):
diff --git a/sickchill/oldbeard/name_parser/regexes.py b/sickchill/oldbeard/name_parser/regexes.py
index 6d72165c81..6fa308a6a7 100644
--- a/sickchill/oldbeard/name_parser/regexes.py
+++ b/sickchill/oldbeard/name_parser/regexes.py
@@ -55,7 +55,7 @@
         "newpct",
         # American Horror Story - Temporada 4 HDTV x264[Cap.408_409]SPANISH AUDIO -NEWPCT
         # American Horror Story - Temporada 4 [HDTV][Cap.408][Espanol Castellano]
-        # American Horror Story - Temporada 4 HDTV x264[Cap.408]SPANISH AUDIO –NEWPCT)
+        # American Horror Story - Temporada 4 HDTV x264[Cap.408]SPANISH AUDIO –NEWPCT
         r"""
      (?P<series_name>.+?).-.+\d{1,2}[ ,.]       # Show name: American Horror Story
      (?P<extra_info>.+)\[Cap\.                   # Quality: HDTV x264, [HDTV], HDTV x264
diff --git a/sickchill/oldbeard/naming.py b/sickchill/oldbeard/naming.py
index 4817eac724..be26a52b90 100644
--- a/sickchill/oldbeard/naming.py
+++ b/sickchill/oldbeard/naming.py
@@ -161,7 +161,7 @@ def validate_name(pattern, multi=None, anime_type=None, file_only=False, abd=Fal
     logger.debug("Trying to parse " + new_name)
 
     try:
-        result = NameParser(True, showObj=ep.show, naming_pattern=True).parse(new_name)
+        result = NameParser(True, show_object=ep.show, naming_pattern=True).parse(new_name)
     except (InvalidNameException, InvalidShowException) as error:
         logger.debug(f"{error}")
         return False
diff --git a/sickchill/oldbeard/nzbSplitter.py b/sickchill/oldbeard/nzbSplitter.py
index 297fa4c86e..1162c195cd 100644
--- a/sickchill/oldbeard/nzbSplitter.py
+++ b/sickchill/oldbeard/nzbSplitter.py
@@ -128,7 +128,7 @@ def split_result(obj):
 
     # parse the season ep name
     try:
-        parsed_obj = NameParser(False, showObj=obj.show).parse(obj.name)
+        parsed_obj = NameParser(False, show_object=obj.show).parse(obj.name)
     except (InvalidNameException, InvalidShowException) as error:
         logger.debug(f"{error}")
         return []
@@ -149,7 +149,7 @@ def split_result(obj):
 
         # parse the name
         try:
-            parsed_obj = NameParser(False, showObj=obj.show).parse(new_nzb)
+            parsed_obj = NameParser(False, show_object=obj.show).parse(new_nzb)
         except (InvalidNameException, InvalidShowException) as error:
             logger.debug(f"{error}")
             return []
diff --git a/sickchill/oldbeard/postProcessor.py b/sickchill/oldbeard/postProcessor.py
index fdc3bcb76b..2379c49ce7 100644
--- a/sickchill/oldbeard/postProcessor.py
+++ b/sickchill/oldbeard/postProcessor.py
@@ -4,8 +4,9 @@
 import re
 import stat
 import subprocess
+from datetime import datetime
 from pathlib import Path
-from typing import TYPE_CHECKING, Union
+from typing import List, TYPE_CHECKING, Union
 
 if TYPE_CHECKING:
     from processTV import ParseResult
@@ -99,7 +100,7 @@ def _log(self, message, level=logging.INFO):
     def _checkForExistingFile(self, existing_file):
         """
         Checks if a file exists already and if it does whether it's bigger or smaller than
-        the file we are post processing
+        the file we are post-processing
 
         ;param existing_file: The file to compare to
 
@@ -137,6 +138,9 @@ def list_associated_files(self, file_path, subtitles_only=False, subfolders=Fals
         """
         For a given file path searches for files with the same name but different extension and returns their absolute paths
 
+        :param subtitles_only: only look for subtitles
+        :param subfolders: check in subfolders
+        :param rename: if we are looking for all files to rename
         :param file_path: The file to check for associated files
         :return: A list containing all files which are associated to the given file
         """
@@ -264,7 +268,7 @@ def _delete(self, file_path, associated_files=False):
                 # do the library update for synoindex
                 notifiers.synoindex_notifier.deleteFile(cur_file)
 
-    def _combined_file_operation(self, file_path, new_path, new_base_name, associated_files=False, action=None, subtitles=False):
+    def _combined_file_operation(self, file_path, new_path: str, new_base_name, associated_files=False, action=None, subtitles=False):
         """
         Performs a generic operation (move or copy) on a file. Can rename the file as well as change its location,
         and optionally move associated files too.
@@ -412,7 +416,7 @@ def _int_hard_link(cur_file_path, new_file_path):
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_hard_link, subtitles=subtitles)
 
-    def _moveAndSymlink(self, file_path, new_path, new_base_name, associated_files=False, subtitles=False):
+    def _move_and_symlink(self, file_path, new_path, new_base_name, associated_files=False, subtitles=False):
         """
         Move file, symlink source location back to destination, and set proper permissions
 
@@ -606,17 +610,17 @@ def _analyze_name(self, name):
         return to_return
 
     @staticmethod
-    def _build_anidb_episode(connection, filePath):
+    def _build_anidb_episode(connection, file_path):
         """
         Look up anidb properties for an episode
 
         :param connection: anidb connection handler
-        :param filePath: file to check
+        :param file_path: file to check
         :return: episode object
         """
         ep = adba.Episode(
             connection,
-            file_path=Path(filePath),
+            file_path=Path(file_path),
             paramsF=["quality", "anidb_file_name", "crc32"],
             paramsA=["epno", "english_name", "short_name_list", "other_name", "synonym_list"],
         )
@@ -647,7 +651,7 @@ def _find_info(self):
         """
 
         show = season = quality = version = None
-        episodes = []
+        episodes: Union[List[int], List[datetime]] = []
 
         # try to look up the release in history
         attempt_list = [
@@ -728,10 +732,10 @@ def _find_info(self):
             # if there's no season then we can hopefully just use 1 automatically
             elif season is None and show:
                 main_db_con = db.DBConnection()
-                numseasonsSQlResult = main_db_con.select(
-                    "SELECT COUNT(DISTINCT season) FROM tv_episodes WHERE showid = ? and indexer = ? and season != 0", [show.indexerid, show.indexer]
+                total_seasons_sql_result = main_db_con.select(
+                    "SELECT COUNT(DISTINCT season) as count FROM tv_episodes WHERE showid = ? and indexer = ? and season != 0", [show.indexerid, show.indexer]
                 )
-                if int(numseasonsSQlResult[0][0]) == 1 and season is None:
+                if int(total_seasons_sql_result[0]["count"]) == 1 and season is None:
                     self._log(_("Don't have a season number, but this show appears to only have 1 season, setting season number to 1..."), logger.DEBUG)
                     season = 1
 
@@ -989,9 +993,11 @@ def process(self):
             # Only proceed if the file season is > 0
             if int(episode_object.season) > 0:
                 main_db_con = db.DBConnection()
-                max_season = main_db_con.select("SELECT MAX(season) FROM tv_episodes WHERE showid = ? and indexer = ?", [show.indexerid, show.indexer])
+                max_season = main_db_con.select(
+                    "SELECT MAX(season) as last_season FROM tv_episodes WHERE showid = ? and indexer = ?", [show.indexerid, show.indexer]
+                )
 
-                if not isinstance(max_season[0][0], int) or max_season[0][0] < 0:
+                if not isinstance(max_season[0]["last_season"], int) or max_season[0]["last_season"] < 0:
                     self._log(
                         f"File has season {episode_object.season}, while the database does not have any known seasons yet. "
                         "Try forcing a full update on the show and process this file again. "
@@ -1000,15 +1006,15 @@ def process(self):
                     return False
 
                 # If the file season (episode_object.season) is bigger than the indexer season (max_season[0][0]), skip the file
-                newest_season_num = max_season[0][0]
+                newest_season = max_season[0]["last_season"]
                 episode_season = episode_object.season
-                if int(episode_season) > newest_season_num:
+                if int(episode_season) > newest_season:
                     self._log(
                         _(
-                            "File has season {episode_season}, while the indexer is on season {newest_season_num}. "
+                            "File has season {episode_season}, while the indexer is on season {newest_season}. "
                             "Try forcing a full update on the show and process this file again. "
                             "The file may be incorrectly labeled or fake, aborting."
-                        ).format(episode_season=episode_season, newest_season_num=newest_season_num)
+                        ).format(episode_season=episode_season, newest_season_num=newest_season)
                     )
                     return False
 
@@ -1020,7 +1026,7 @@ def process(self):
         if settings.USE_FREE_SPACE_CHECK:
             if not helpers.is_file_locked(self.directory):
                 if not verify_freespace(
-                    self.directory, episode_object.show._location, [episode_object] + episode_object.related_episodes, method=self.process_method
+                    self.directory, episode_object.show.get_location, [episode_object] + episode_object.related_episodes, method=self.process_method
                 ):
                     self._log(_("Not enough disk space to continue processing, exiting"), logger.WARNING)
                     return False
@@ -1034,7 +1040,7 @@ def process(self):
 
                 # clean up any left over folders
                 if cur_ep.location:
-                    helpers.delete_empty_folders(os.path.dirname(cur_ep.location), keep_dir=episode_object.show._location)
+                    helpers.delete_empty_folders(os.path.dirname(cur_ep.location), keep_dir=episode_object.show.get_location)
 
                 # clean up download-related properties
                 cur_ep.cleanup_download_properties()
@@ -1046,16 +1052,16 @@ def process(self):
             #    curEp.status = common.Quality.compositeStatus(common.SNATCHED, new_ep_quality)
 
         # if the show directory doesn't exist then make it if allowed
-        if not os.path.isdir(episode_object.show._location) and settings.CREATE_MISSING_SHOW_DIRS:
+        if not os.path.isdir(episode_object.show.get_location) and settings.CREATE_MISSING_SHOW_DIRS:
             self._log(_("Show directory doesn't exist, creating it"), logger.DEBUG)
             try:
-                os.mkdir(episode_object.show._location)
-                helpers.chmodAsParent(episode_object.show._location)
+                os.mkdir(episode_object.show.get_location)
+                helpers.chmodAsParent(episode_object.show.get_location)
 
                 # do the library update for synoindex
-                notifiers.synoindex_notifier.addFolder(episode_object.show._location)
+                notifiers.synoindex_notifier.addFolder(episode_object.show.get_location)
             except (OSError, IOError):
-                raise EpisodePostProcessingFailedException(_("Unable to create the show directory: ") + episode_object.show._location)
+                raise EpisodePostProcessingFailedException(_("Unable to create the show directory: ") + episode_object.show.get_location)
 
             # get metadata for the show (but not episode because it hasn't been fully processed)
             episode_object.show.write_metadata(True)
@@ -1117,7 +1123,7 @@ def process(self):
 
         # figure out the base name of the resulting episode file
         if settings.RENAME_EPISODES:
-            old_path = Path(self.filename)
+            old_path = Path(str(self.filename))
             orig_extension = old_path.suffix
             new_base_name = os.path.basename(proper_path)
             new_filename = f"{new_base_name}{orig_extension}"
@@ -1147,7 +1153,7 @@ def process(self):
             elif self.process_method == METHOD_SYMLINK:
                 if helpers.is_file_locked(self.directory, True):
                     raise EpisodePostProcessingFailedException(_("File is locked for reading/writing"))
-                self._moveAndSymlink(
+                self._move_and_symlink(
                     self.directory, dest_path, new_base_name, settings.MOVE_ASSOCIATED_FILES, settings.USE_SUBTITLES and episode_object.show.subtitles
                 )
             elif self.process_method == METHOD_SYMLINK_REVERSED:
@@ -1177,7 +1183,7 @@ def process(self):
         episode_object.airdate_modify_stamp()
 
         if settings.USE_ICACLS and os.name == "nt":
-            os.popen(f'icacls "{episode_object._location}"* /reset /T')
+            os.popen(f'icacls "{episode_object.location}"* /reset /T')
 
         # generate nfo/tbn
         try:
@@ -1232,10 +1238,10 @@ def guessit_findit(name: str) -> Union["ParseResult", None]:
     logger.debug(f"Trying a new way to verify if we can parse this file")
     title = guessit(name, {"type": "episode"}).get("title")
     if title:
-        show: "TVShow" = helpers.get_show(title, False)
+        show: "TVShow" = helpers.get_show(title)
         if show:
             try:
-                np = NameParser(showObj=show).parse(name, cache_result=False)
+                np = NameParser(show_object=show).parse(name, cache_result=False)
                 return np
             except (InvalidNameException, InvalidShowException) as error:
                 logger.debug(f"Sorry, guessit failed to parse the file name for {show}: {name} (Error: {error} ... continuing with the old way")
diff --git a/sickchill/oldbeard/providers/ilcorsaronero.py b/sickchill/oldbeard/providers/ilcorsaronero.py
index 973dacc238..af96fc40f8 100644
--- a/sickchill/oldbeard/providers/ilcorsaronero.py
+++ b/sickchill/oldbeard/providers/ilcorsaronero.py
@@ -156,7 +156,7 @@ def _is_english(name):
     @staticmethod
     def _is_season_pack(name):
         try:
-            parse_result = NameParser(tryIndexers=True).parse(name)
+            parse_result = NameParser(try_indexers=True).parse(name)
         except (InvalidNameException, InvalidShowException) as error:
             logger.debug(f"{error}")
             return False
diff --git a/sickchill/oldbeard/providers/tntvillage.py b/sickchill/oldbeard/providers/tntvillage.py
index 4997ec9804..a3dcfdd66f 100644
--- a/sickchill/oldbeard/providers/tntvillage.py
+++ b/sickchill/oldbeard/providers/tntvillage.py
@@ -231,7 +231,7 @@ def _is_english(torrent_rows):
     @staticmethod
     def _is_season_pack(name):
         try:
-            parse_result = NameParser(tryIndexers=True).parse(name)
+            parse_result = NameParser(try_indexers=True).parse(name)
         except (InvalidNameException, InvalidShowException) as error:
             logger.debug(f"{error}")
             return False
diff --git a/sickchill/oldbeard/show_queue.py b/sickchill/oldbeard/show_queue.py
index a66586f58b..883b995211 100644
--- a/sickchill/oldbeard/show_queue.py
+++ b/sickchill/oldbeard/show_queue.py
@@ -418,7 +418,7 @@ def run(self):
                 # If we have the show in our list, but the location is wrong, lets fix it and refresh!
                 existing_show = Show.find(settings.showList, self.indexer_id)
                 # noinspection PyProtectedMember
-                if existing_show and not os.path.isdir(existing_show._location):
+                if existing_show and not os.path.isdir(existing_show.get_location):
                     new_show = existing_show
                 else:
                     raise error
@@ -743,7 +743,7 @@ def run(self):
             # nmj_notifier kicks off its library update when the notify_download is issued (inside notifiers)
 
             # do the library update for Synology Indexer
-            notifiers.synoindex_notifier.addFolder(self.show._location)
+            notifiers.synoindex_notifier.addFolder(self.show.get_location)
 
             # do the library update for pyTivo
             notifiers.pytivo_notifier.update_library(self.show)
diff --git a/sickchill/oldbeard/tvcache.py b/sickchill/oldbeard/tvcache.py
index 5698c00199..99666f7b46 100644
--- a/sickchill/oldbeard/tvcache.py
+++ b/sickchill/oldbeard/tvcache.py
@@ -346,7 +346,7 @@ def add_cache_entry(self, name, url, size, seeders, leechers, parse_result=None,
                 show_obj = Show.find(settings.showList, indexer_id)
 
             try:
-                parse_result = NameParser(showObj=show_obj).parse(name)
+                parse_result = NameParser(show_object=show_obj).parse(name)
             except (InvalidNameException, InvalidShowException) as error:
                 logger.debug(f"{error}")
                 return None
diff --git a/sickchill/tv.py b/sickchill/tv.py
index cd06c05b35..d74e1c4003 100644
--- a/sickchill/tv.py
+++ b/sickchill/tv.py
@@ -200,6 +200,10 @@ def location(self, new_location):
         else:
             raise NoNFOException("Invalid folder for the show!")
 
+    @property
+    def get_location(self):
+        return self._location
+
     def flush_episodes(self):
         for current_season in self.episodes:
             self.episodes[current_season].clear()
@@ -427,7 +431,7 @@ def load_episodes_from_dir(self):
             ep_filename = os.path.splitext(ep_filename)[0]
 
             try:
-                parse_result = NameParser(False, showObj=self, tryIndexers=True).parse(ep_filename)
+                parse_result = NameParser(False, show_object=self, try_indexers=True).parse(ep_filename)
             except (InvalidNameException, InvalidShowException):
                 parse_result = None
 
@@ -568,7 +572,7 @@ def make_ep_from_file(self, filepath):
         logger.debug(f"{self.indexerid}: Creating episode object from {filepath}")
 
         try:
-            parse_result = NameParser(showObj=self, tryIndexers=True, parse_method=("normal", "anime")[self.is_anime]).parse(
+            parse_result = NameParser(show_object=self, try_indexers=True, parse_method=("normal", "anime")[self.is_anime]).parse(
                 filepath, skip_scene_detection=True
             )
         except (InvalidNameException, InvalidShowException) as error:
@@ -1682,8 +1686,8 @@ def load_from_indexer(self, season=None, episode=None, force_all: bool = False):
                 self.delete_episode()
             return False
 
-        if not os.path.isdir(self.show._location) and not settings.CREATE_MISSING_SHOW_DIRS and not settings.ADD_SHOWS_WO_DIR:
-            logger.info(f"The show dir {self.show._location} is missing, not bothering to change the episode statuses since it'd probably be invalid")
+        if not os.path.isdir(self.show.get_location) and not settings.CREATE_MISSING_SHOW_DIRS and not settings.ADD_SHOWS_WO_DIR:
+            logger.info(f"The show dir {self.show.get_location} is missing, not bothering to change the episode statuses since it'd probably be invalid")
             return
 
         if self.location:
@@ -1729,7 +1733,7 @@ def load_from_indexer(self, season=None, episode=None, force_all: bool = False):
             self.status = UNKNOWN
 
     def load_from_nfo(self, location):
-        if not os.path.isdir(self.show._location):
+        if not os.path.isdir(self.show.get_location):
             logger.info(f"{self.show.indexerid}: The show dir is missing, not bothering to try loading the episode NFO")
             return
 
@@ -1821,7 +1825,7 @@ def __str__(self):
         )
 
     def create_meta_files(self):
-        if not os.path.isdir(self.show._location):
+        if not os.path.isdir(self.show.get_location):
             logger.info(f"{self.show.indexerid}: The show dir is missing, not bothering to try to create metadata")
             return
 
@@ -2130,7 +2134,7 @@ def release_group(show, name):
                 return ""
 
             try:
-                parse_result = NameParser(name, showObj=show, naming_pattern=True).parse(name)
+                parse_result = NameParser(name, show_object=show, naming_pattern=True).parse(name)
             except (InvalidNameException, InvalidShowException) as error:
                 logger.debug(f"Unable to get parse release_group: {error}")
                 return ""
diff --git a/sickchill/views/home.py b/sickchill/views/home.py
index 7cbe60a0c2..28e1ab6117 100644
--- a/sickchill/views/home.py
+++ b/sickchill/views/home.py
@@ -94,7 +94,7 @@ def index(self):
             anime = []
             for show in settings.showList:
                 # noinspection PyProtectedMember
-                if selected_root_dir in show._location:
+                if selected_root_dir in show.get_location:
                     if show.is_anime:
                         anime.append(show)
                     else:
@@ -108,7 +108,7 @@ def index(self):
             shows = []
             for show in settings.showList:
                 # noinspection PyProtectedMember
-                if selected_root_dir in show._location:
+                if selected_root_dir in show.get_location:
                     shows.append(show)
 
             sortedShowLists = [["Shows", sorted(shows, key=lambda mbr: attrgetter("sort_name")(mbr))]]
@@ -569,7 +569,7 @@ def testFlareSolverr(self):
     @staticmethod
     def loadShowNotifyLists():
         main_db_con = db.DBConnection()
-        rows = main_db_con.select("SELECT indexer_id, show_name, notify_list FROM tv_shows ORDER BY show_name ASC")
+        rows = main_db_con.select("SELECT indexer_id, show_name, notify_list FROM tv_shows ORDER BY show_name")
 
         data = {}
         size = 0
@@ -786,8 +786,7 @@ def displayShow(self):
         try:
             showLoc = (show_obj.location, True)
         except ShowDirectoryNotFoundException:
-            # noinspection PyProtectedMember
-            showLoc = (show_obj._location, False)
+            showLoc = (show_obj.get_location, False)
 
         show_message = ""
 
@@ -1221,12 +1220,12 @@ def get_images(image):
             if not directCall:
                 show_obj.lang = indexer_lang
                 show_obj.dvdorder = dvdorder
-                location = self.get_argument("location", show_obj._location)
+                location = self.get_argument("location", show_obj.get_location)
 
             location = os.path.normpath(location)
 
             # noinspection PyProtectedMember
-            old_location = os.path.normpath(show_obj._location)
+            old_location = os.path.normpath(show_obj.get_location)
             # if we change location clear the db of episodes, change it, write to db, and rescan
             if old_location != location:
                 logger.debug(old_location + " != " + location)
@@ -1325,7 +1324,7 @@ def deleteShow(self, show=None, full=0):
 
     def refreshShow(self):
         show = self.get_query_argument("show")
-        force = self.get_query_argument("force", default=False)
+        force = bool(try_int(self.get_query_argument("force", default="0")))
 
         error, show = Show.refresh(show, force)
 
@@ -1343,7 +1342,7 @@ def refreshShow(self):
 
     def updateShow(self):
         show = self.get_query_argument("show")
-        force = self.get_query_argument("force", default=False)
+        force = bool(try_int(self.get_query_argument("force", default="0")))
 
         if not show:
             return self._genericMessage(_("Error"), _("Invalid show ID"))
@@ -1584,7 +1583,7 @@ def testRename(self):
             return self._genericMessage(_("Error"), _("Show not in show list"))
 
         try:
-            show_obj.location
+            show_obj.location()
         except ShowDirectoryNotFoundException:
             return self._genericMessage(_("Error"), _("Can't rename episodes when the show dir is missing."))
 
@@ -1615,9 +1614,7 @@ def doRename(self, show=None, eps=None):
             ep_info = cur_ep.split("x")
 
             # this is probably the worst possible way to deal with double eps but I've kinda painted myself into a corner here with this stupid database
-            ep_result = main_db_con.select(
-                "SELECT location FROM tv_episodes WHERE showid = ? AND season = ? AND episode = ? AND 5=5", [show, ep_info[0], ep_info[1]]
-            )
+            ep_result = main_db_con.select("SELECT location FROM tv_episodes WHERE showid = ? AND season = ? AND episode = ?", [show, ep_info[0], ep_info[1]])
             if not ep_result:
                 logger.warning(f"Unable to find an episode for {show}: {cur_ep} , skipping")
                 continue
@@ -1763,7 +1760,7 @@ def relative_ep_location(ep_loc, show_loc):
                         "status": statusStrings[search_thread.segment.status],
                         "quality": self.getQualityClass(search_thread.segment),
                         "overview": Overview.overviewStrings[show_obj.get_overview(search_thread.segment.status)],
-                        "location": relative_ep_location(search_thread.segment._location, show_obj._location),
+                        "location": relative_ep_location(search_thread.segment.location, show_obj.get_location),
                         "size": pretty_file_size(search_thread.segment.file_size) if search_thread.segment.file_size else "",
                     }
                 )
@@ -1780,7 +1777,7 @@ def relative_ep_location(ep_loc, show_loc):
                             "status": statusStrings[episode_object.status],
                             "quality": self.getQualityClass(episode_object),
                             "overview": Overview.overviewStrings[show_obj.get_overview(episode_object.status)],
-                            "location": relative_ep_location(episode_object._location, show_obj._location),
+                            "location": relative_ep_location(episode_object.location, show_obj.get_location),
                             "size": pretty_file_size(episode_object.file_size) if episode_object.file_size else "",
                         }
                     )
diff --git a/sickchill/views/index.py b/sickchill/views/index.py
index 717642d0ac..17e97d79d3 100644
--- a/sickchill/views/index.py
+++ b/sickchill/views/index.py
@@ -8,9 +8,11 @@
 from mimetypes import guess_type
 from operator import attrgetter
 from secrets import compare_digest
+from typing import Any, TYPE_CHECKING
 from urllib.parse import urljoin
 
 from mako.exceptions import RichTraceback
+from tornado import httputil
 from tornado.concurrent import run_on_executor
 from tornado.web import authenticated, HTTPError, RequestHandler
 
@@ -32,8 +34,22 @@
 except Exception:
     has_cryptography = False
 
+if TYPE_CHECKING:
+    from tornado.web import Application
+
 
 class BaseHandler(RequestHandler):
+    def __init__(
+        self,
+        application: "Application",
+        request: httputil.HTTPServerRequest,
+        **kwargs: Any,
+    ):
+        super().__init__(application, request, **kwargs)
+        self.startTime = None
+        self.to_change_show = None
+        self.to_change_eps = None
+
     def data_received(self, chunk):
         pass
 
diff --git a/sickchill/views/manage/index.py b/sickchill/views/manage/index.py
index 16c1b73d30..bc458a9fd4 100644
--- a/sickchill/views/manage/index.py
+++ b/sickchill/views/manage/index.py
@@ -279,13 +279,13 @@ def backlogShow(self, indexer_id):
     def backlogOverview(self):
         t = PageTemplate(rh=self, filename="manage_backlogOverview.mako")
 
-        showCounts = {}
-        showCats = {}
-        showSQLResults = {}
+        show_counts = {}
+        show_categories = {}
+        show_sql_results = {}
 
         main_db_con = db.DBConnection()
         for current_show in settings.showList:
-            epCounts = {
+            episode_counts = {
                 Overview.SKIPPED: 0,
                 Overview.WANTED: 0,
                 Overview.QUAL: 0,
@@ -295,7 +295,7 @@ def backlogOverview(self):
                 Overview.SNATCHED_PROPER: 0,
                 Overview.SNATCHED_BEST: 0,
             }
-            epCats = {}
+            episode_categories = {}
 
             sql_results = main_db_con.select(
                 "SELECT status, season, episode, name, airdate FROM tv_episodes WHERE tv_episodes.season IS NOT NULL "
@@ -304,47 +304,47 @@ def backlogOverview(self):
                 [current_show.indexerid],
             )
 
-            for curResult in sql_results:
-                curEpCat = current_show.get_overview(curResult["status"], backlog=settings.BACKLOG_MISSING_ONLY)
+            for result in sql_results:
+                curEpCat = current_show.get_overview(result["status"], backlog=settings.BACKLOG_MISSING_ONLY)
                 if curEpCat:
-                    epCats["{ep}".format(ep=episode_num(curResult["season"], curResult["episode"]))] = curEpCat
-                    epCounts[curEpCat] += 1
+                    episode_categories["{ep}".format(ep=episode_num(result["season"], result["episode"]))] = curEpCat
+                    episode_counts[curEpCat] += 1
 
-            showCounts[current_show.indexerid] = epCounts
-            showCats[current_show.indexerid] = epCats
-            showSQLResults[current_show.indexerid] = sql_results
+            show_counts[current_show.indexerid] = episode_counts
+            show_categories[current_show.indexerid] = episode_categories
+            show_sql_results[current_show.indexerid] = sql_results
 
-        def showQualSnatched(show):
+        def show_qual_snatched(show):
             return Quality.splitQuality(show.quality)[1]
 
-        totalWanted = totalQual = totalQualSnatched = 0
-        backLogShows = sorted(
+        total_wanted = total_qual = total_qual_snatched = 0
+        backlog_shows = sorted(
             [
                 x
                 for x in settings.showList
                 if (
-                    showCounts[x.indexerid][Overview.QUAL]
-                    or showCounts[x.indexerid][Overview.WANTED]
-                    or (0, showCounts[x.indexerid][Overview.SNATCHED])[len(showQualSnatched(x)) > 0]
+                    show_counts[x.indexerid][Overview.QUAL]
+                    or show_counts[x.indexerid][Overview.WANTED]
+                    or (0, show_counts[x.indexerid][Overview.SNATCHED])[len(show_qual_snatched(x)) > 0]
                 )
             ],
             key=lambda x: x.sort_name,
         )
-        for current_show in backLogShows:
-            totalWanted += showCounts[current_show.indexerid][Overview.WANTED]
-            totalQual += showCounts[current_show.indexerid][Overview.QUAL]
-            if showQualSnatched(current_show):
-                totalQualSnatched += showCounts[current_show.indexerid][Overview.SNATCHED]
+        for current_show in backlog_shows:
+            total_wanted += show_counts[current_show.indexerid][Overview.WANTED]
+            total_qual += show_counts[current_show.indexerid][Overview.QUAL]
+            if show_qual_snatched(current_show):
+                total_qual_snatched += show_counts[current_show.indexerid][Overview.SNATCHED]
 
         return t.render(
-            showCounts=showCounts,
-            showCats=showCats,
-            totalQual=totalQual,
-            showQualSnatched=showQualSnatched,
-            totalWanted=totalWanted,
-            totalQualSnatched=totalQualSnatched,
-            backLogShows=backLogShows,
-            showSQLResults=showSQLResults,
+            show_counts=show_counts,
+            show_categories=show_categories,
+            total_qual=total_qual,
+            show_qual_snatched=show_qual_snatched,
+            total_wanted=total_wanted,
+            total_qual_snatched=total_qual_snatched,
+            backlog_shows=backlog_shows,
+            show_sql_results=show_sql_results,
             controller="manage",
             action="backlogOverview",
             title=_("Backlog Overview"),
@@ -406,8 +406,8 @@ def massEdit(self):
         root_dir_list = []
 
         for current_show in show_list:
-            show_root_dir = self.__gooey_path(current_show._location, "dirname")
-            if show_root_dir and show_root_dir != current_show._location and show_root_dir not in root_dir_list:
+            show_root_dir = self.__gooey_path(current_show.get_location, "dirname")
+            if show_root_dir and show_root_dir != current_show.get_location and show_root_dir not in root_dir_list:
                 root_dir_list.append(show_root_dir)
 
             # if we know they're not all the same then no point even bothering
@@ -538,13 +538,13 @@ def massEditSubmit(self):
             if not show_object:
                 continue
 
-            show_root_dir = self.__gooey_path(show_object._location, "dirname")
-            cur_show_dir = self.__gooey_path(show_object._location, "basename")
+            show_root_dir = self.__gooey_path(show_object.get_location, "dirname")
+            cur_show_dir = self.__gooey_path(show_object.get_location, "basename")
             if show_root_dir and root_dir_map.get(show_root_dir) and show_root_dir != root_dir_map.get(show_root_dir):
                 new_show_dir = os.path.join(root_dir_map[show_root_dir], cur_show_dir)
-                logger.info(f"For show {show_object.name} changing dir from {show_object._location} to {new_show_dir}")
+                logger.info(f"For show {show_object.name} changing dir from {show_object.get_location} to {new_show_dir}")
             else:
-                new_show_dir = show_object._location
+                new_show_dir = show_object.get_location
 
             new_paused = ("off", "on")[(paused == "enable", show_object.paused)[paused == "keep"]]
             new_default_ep_status = (default_ep_status, show_object.default_ep_status)[default_ep_status == "keep"]
diff --git a/tests/test_name_parser.py b/tests/test_name_parser.py
index de77a840d2..8183235dfb 100644
--- a/tests/test_name_parser.py
+++ b/tests/test_name_parser.py
@@ -176,7 +176,7 @@ def _test_unicode(self, name, result):
         :param result:
         :return:
         """
-        name_parser = parser.NameParser(True, showObj=self.show)
+        name_parser = parser.NameParser(True, show_object=self.show)
         parse_result = name_parser.parse(name)
 
         # this shouldn't raise an exception
@@ -303,7 +303,7 @@ def _test_names(self, name_parser, section, transform=None, verbose=False):
             result = SIMPLE_TEST_CASES[section][cur_test_base]
 
             self.show.name = result.series_name if result else None
-            name_parser.showObj = self.show
+            name_parser.show_object = self.show
             if not result:
                 self.assertRaises(parser.InvalidNameException, name_parser.parse, cur_test)
                 return
@@ -475,7 +475,7 @@ def _test_names(self, name_parser, section, transform=None, verbose=False):
             result = ANIME_TEST_CASES[section][cur_test_base]
 
             self.show.name = result.series_name if result else None
-            name_parser.showObj = self.show
+            name_parser.show_object = self.show
             if not result:
                 self.assertRaises(parser.InvalidNameException, name_parser.parse, cur_test)
                 return
@@ -554,7 +554,7 @@ def _test_names(self, name_parser, section, transform=None, verbose=False):
             result = SIMPLE_TEST_CASES[section][cur_test_base]
 
             self.show.name = result.series_name if result else None
-            name_parser.showObj = self.show
+            name_parser.show_object = self.show
             if not result:
                 self.assertRaises(parser.InvalidNameException, name_parser.parse, cur_test)
                 return

From 0bcd73f238133472cd18abf6ec8dd6236bb5950e Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 18:55:09 -0500
Subject: [PATCH 08/29] fix: can't add init to tornado base class? causes
 PageTemplate initialization to fail somehow

Signed-off-by: miigotu <miigotu@gmail.com>
---
 sickchill/gui/slick/views/layouts/main.mako |  2 +-
 sickchill/views/common.py                   |  2 +-
 sickchill/views/index.py                    | 10 ----------
 3 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/sickchill/gui/slick/views/layouts/main.mako b/sickchill/gui/slick/views/layouts/main.mako
index d6fabe6bd6..76317d51ea 100644
--- a/sickchill/gui/slick/views/layouts/main.mako
+++ b/sickchill/gui/slick/views/layouts/main.mako
@@ -382,7 +382,7 @@
                             % if resource:
                                 <span class="footer-item">${_('Memory used')}: <span class="footerhighlight">${pretty_file_size(resource.getrusage(resource.RUSAGE_SELF).ru_maxrss*1024)}</span></span> |
                             % endif
-                            <span class="footer-item">${_('Load time')}: <span class="footerhighlight">${"{:.4f}".format(time() - sbStartTime)}s</span></span> |
+                            <span class="footer-item">${_('Load time')}: <span class="footerhighlight">${"{:.4f}".format(time() - scStartTime)}s</span></span> |
                             <span class="footer-item">Mako: <span class="footerhighlight">${"{:.4f}".format(time() - makoStartTime)}s</span></span> |
                             <span class="footer-item">${_('Version')}: <span class="footerhighlight">${get_current_version()}</span></span> |
                             <span class="footer-item">${_('Now')}: <span class="footerhighlight">${datetime.datetime.now().strftime(settings.DATE_PRESET+" "+settings.TIME_PRESET)}</span></span>
diff --git a/sickchill/views/common.py b/sickchill/views/common.py
index 6c15dc5d6f..ef85168a2c 100644
--- a/sickchill/views/common.py
+++ b/sickchill/views/common.py
@@ -43,7 +43,7 @@ def __init__(self, rh, filename, test_exception: bool = False):
         self.context["sbHandleReverseProxy"] = settings.HANDLE_REVERSE_PROXY
         self.context["sbDefaultPage"] = settings.DEFAULT_PAGE
         self.context["scLogin"] = rh.get_current_user()
-        self.context["sbStartTime"] = rh.startTime
+        self.context["scStartTime"] = rh.startTime
         self.context["static_url"] = rh.static_url
         self.context["reverse_url"] = rh.reverse_url
         self.context["linkify"] = linkify
diff --git a/sickchill/views/index.py b/sickchill/views/index.py
index 17e97d79d3..42b07efd42 100644
--- a/sickchill/views/index.py
+++ b/sickchill/views/index.py
@@ -39,16 +39,6 @@
 
 
 class BaseHandler(RequestHandler):
-    def __init__(
-        self,
-        application: "Application",
-        request: httputil.HTTPServerRequest,
-        **kwargs: Any,
-    ):
-        super().__init__(application, request, **kwargs)
-        self.startTime = None
-        self.to_change_show = None
-        self.to_change_eps = None
 
     def data_received(self, chunk):
         pass

From 6850259e9efec83bebdf6775a9b9a02af0c61ad0 Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 19:53:14 -0500
Subject: [PATCH 09/29] fix: try to fix airdate modify timestamp, remove some
 unneded mako context variables, refactor variable names

Signed-off-by: miigotu <miigotu@gmail.com>
---
 .editorconfig                               | 10 +----
 sickchill/gui/slick/views/layouts/main.mako | 42 ++++++++++-----------
 sickchill/gui/slick/views/restart.mako      |  2 +-
 sickchill/tv.py                             | 39 +++++++++----------
 sickchill/views/common.py                   | 34 ++++-------------
 sickchill/views/index.py                    |  2 +-
 sickchill/views/server_settings.py          | 14 -------
 7 files changed, 50 insertions(+), 93 deletions(-)

diff --git a/.editorconfig b/.editorconfig
index ac0331d697..7e7880565b 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -1,15 +1,10 @@
-# top-most EditorConfig file
 root = true
 
-# Unix-style newlines with a newline ending every file
-# and trailing whitespace removed
 [*]
 end_of_line = lf
 insert_final_newline = true
 trim_trailing_whitespace = true
 
-# Matches multiple files with brace expansion notation
-# Set default charset
 [*.{py,mako}]
 charset = utf-8
 indent_style = space
@@ -20,12 +15,9 @@ charset = utf-8
 indent_style = space
 indent_size = 4
 
-# Matches configuration files for services like Travis, AppVeyor and Codecov
 [*.yml]
 indent_style = space
 indent_size = 2
 
-[{package.json, bower.json, webpack.config.js}]
-charset = utf-8
-indent_style = space
+[{package.json,bower.json,webpack.config.js}]
 indent_size = 2
diff --git a/sickchill/gui/slick/views/layouts/main.mako b/sickchill/gui/slick/views/layouts/main.mako
index 76317d51ea..37d041a791 100644
--- a/sickchill/gui/slick/views/layouts/main.mako
+++ b/sickchill/gui/slick/views/layouts/main.mako
@@ -120,19 +120,19 @@
         <nav class="navbar navbar-default navbar-fixed-top hidden-print">
             <div class="container-fluid">
                 <%
-                    numCombined = numErrors + numWarnings + settings.NEWS_UNREAD
-                    if numCombined:
-                        if numErrors:
+                    total_warning_error_count = error_count + warning_count + settings.NEWS_UNREAD
+                    if total_warning_error_count:
+                        if error_count:
                             toolsBadgeClass = ' btn-danger'
-                        elif numWarnings:
+                        elif warning_count:
                             toolsBadgeClass = ' btn-warning'
                         else:
                             toolsBadgeClass = ''
                 %>
                 <div class="navbar-header">
                     <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#collapsible-navbar">
-                        % if numCombined:
-                            <span class="floating-badge${ toolsBadgeClass }">${ str(numCombined) }</span>
+                        % if total_warning_error_count:
+                            <span class="floating-badge${ toolsBadgeClass }">${ str(total_warning_error_count) }</span>
                         % endif
                         <span class="sr-only">Toggle navigation</span>
                         <span class="icon-bar"></span>
@@ -142,7 +142,7 @@
                     <a class="navbar-brand" href="${static_url('home/', include_version=False)}" title="SickChill"><img alt="SickChill" src="${static_url('images/sickchill.png')}"
                                                                                  class="img-responsive pull-left" /></a>
                 </div>
-                % if scLogin:
+                % if current_user:
                     <div class="collapse navbar-collapse" id="collapsible-navbar">
                         <ul class="nav navbar-nav navbar-right">
                             <%block name="navbar" />
@@ -243,8 +243,8 @@
                                 else:
                                     newsBadge = ''
 
-                                if numCombined:
-                                    toolsBadge = ' <span class="badge'+toolsBadgeClass+'">'+str(numCombined)+'</span>'
+                                if total_warning_error_count:
+                                    toolsBadge = ' <span class="badge'+toolsBadgeClass+'">'+str(total_warning_error_count)+'</span>'
                                 else:
                                     toolsBadge = ''
                             %>
@@ -260,26 +260,26 @@
                                     <li><a href="${static_url('changes/', include_version=False)}"><i class="fa fa-fw fa-globe"></i>&nbsp;${_('Changelog')}</a></li>
                                     <li><a href="${anon_url('https://github.com/SickChill/SickChill/wiki/Donations')}" rel="noreferrer" target="_blank"><i class="fa fa-fw fa-life-ring"></i>&nbsp;${_('Support SickChill')}</a></li>
                                     <li role="separator" class="divider"></li>
-                                    %if numErrors:
-                                        <li><a href="${static_url('errorlogs/', include_version=False)}"><i class="fa fa-fw fa-exclamation-circle"></i>&nbsp;${_('View Errors')} <span class="badge btn-danger">${numErrors}</span></a></li>
+                                    %if error_count:
+                                        <li><a href="${static_url('errorlogs/', include_version=False)}"><i class="fa fa-fw fa-exclamation-circle"></i>&nbsp;${_('View Errors')} <span class="badge btn-danger">${error_count}</span></a></li>
                                     %endif
-                                    %if numWarnings:
+                                    %if warning_count:
                                         <li>
                                           <a href="${static_url('errorlogs/?level={}'.format(logger.WARNING), include_version=False)}">
-                                            <i class="fa fa-fw fa-exclamation-triangle"></i>&nbsp;${_('View Warnings')} <span class="badge btn-warning">${numWarnings}</span>
+                                            <i class="fa fa-fw fa-exclamation-triangle"></i>&nbsp;${_('View Warnings')} <span class="badge btn-warning">${warning_count}</span>
                                           </a>
                                         </li>
                                     %endif
                                     <li><a href="${static_url('errorlogs/viewlog/', include_version=False)}"><i class="fa fa-fw fa-file-text-o"></i>&nbsp;${_('View Log')}</a></li>
                                     <li role="separator" class="divider"></li>
                                     % if hasattr(settings, "DISABLE_UPDATER") and not settings.DISABLE_UPDATER:
-                                    <li><a href="${static_url('home/updateCheck?pid={}'.format(scPID), include_version=False)}"><i class="fa fa-fw fa-wrench"></i>&nbsp;${_('Check For Updates')}</a></li>
+                                    <li><a href="${static_url('home/updateCheck?pid={}'.format(process_id), include_version=False)}"><i class="fa fa-fw fa-wrench"></i>&nbsp;${_('Check For Updates')}</a></li>
                                     % endif
-                                    <li><a href="${static_url('home/restart/?pid={}'.format(scPID), include_version=False)}" class="confirm restart"><i
+                                    <li><a href="${static_url('home/restart/?pid={}'.format(process_id), include_version=False)}" class="confirm restart"><i
                                         class="fa fa-fw fa-repeat"></i>&nbsp;${_('Restart')}</a></li>
-                                    <li><a href="${static_url('home/shutdown/?pid={}'.format(scPID), include_version=False)}" class="confirm shutdown"><i
+                                    <li><a href="${static_url('home/shutdown/?pid={}'.format(process_id), include_version=False)}" class="confirm shutdown"><i
                                         class="fa fa-fw fa-power-off"></i>&nbsp;${_('Shutdown')}</a></li>
-                                    % if scLogin:
+                                    % if current_user:
                                         <li><a href="${static_url('logout', include_version=False)}" class="confirm logout"><i class="fa fa-fw fa-sign-out"></i>&nbsp;${_('Logout')}</a></li>
                                     % endif
                                     <li role="separator" class="divider"></li>
@@ -320,7 +320,7 @@
                     </div>
                 % endif
                 <div class="clearfix"></div>
-                % if scLogin:
+                % if current_user:
                     <div id="site-messages"></div>
                 % endif
             </div>
@@ -349,7 +349,7 @@
                 </div>
             </div>
 
-            % if scLogin:
+            % if current_user:
                 <div class="row">
                     <div class="footer clearfix col-lg-10 col-lg-offset-1 col-md-10 col-md-offset-1 col-sm-12 col-xs-12">
                         <%
@@ -382,8 +382,8 @@
                             % if resource:
                                 <span class="footer-item">${_('Memory used')}: <span class="footerhighlight">${pretty_file_size(resource.getrusage(resource.RUSAGE_SELF).ru_maxrss*1024)}</span></span> |
                             % endif
-                            <span class="footer-item">${_('Load time')}: <span class="footerhighlight">${"{:.4f}".format(time() - scStartTime)}s</span></span> |
-                            <span class="footer-item">Mako: <span class="footerhighlight">${"{:.4f}".format(time() - makoStartTime)}s</span></span> |
+                            <span class="footer-item">${_('Load time')}: <span class="footerhighlight">${"{:.4f}".format(time() - page_load_start_time)}s</span></span> |
+                            <span class="footer-item">Mako: <span class="footerhighlight">${"{:.4f}".format(time() - mako_load_start_time)}s</span></span> |
                             <span class="footer-item">${_('Version')}: <span class="footerhighlight">${get_current_version()}</span></span> |
                             <span class="footer-item">${_('Now')}: <span class="footerhighlight">${datetime.datetime.now().strftime(settings.DATE_PRESET+" "+settings.TIME_PRESET)}</span></span>
                         </div>
diff --git a/sickchill/gui/slick/views/restart.mako b/sickchill/gui/slick/views/restart.mako
index 7ae284da4a..af72fc3d63 100644
--- a/sickchill/gui/slick/views/restart.mako
+++ b/sickchill/gui/slick/views/restart.mako
@@ -1,6 +1,6 @@
 <%inherit file="/layouts/main.mako" />
 <%block name="metas">
-    <meta data-var="scDefaultPage" data-content="${sbDefaultPage}">
+    <meta data-var="scDefaultPage" data-content="${sc_default_page}">
 </%block>
 
 <%block name="css">
diff --git a/sickchill/tv.py b/sickchill/tv.py
index d74e1c4003..d2b5bd1e96 100644
--- a/sickchill/tv.py
+++ b/sickchill/tv.py
@@ -2568,46 +2568,43 @@ def airdate_modify_stamp(self):
         if not all([settings.AIRDATE_EPISODES, self.airdate, self.location, self.show, self.show.airs, self.show.network]):
             return
 
+        airdatetime = None
+
         try:
             airdate_ordinal = self.airdate.toordinal()
             if airdate_ordinal < 1:
                 return
 
             airdatetime = network_timezones.parse_date_time(airdate_ordinal, self.show.airs, self.show.network)
+            compare_tz = network_timezones.get_network_timezone(self.show.network)
 
             if settings.FILE_TIMESTAMP_TIMEZONE == "local":
+                compare_tz = network_timezones.sc_timezone
                 airdatetime = airdatetime.astimezone(network_timezones.sc_timezone)
 
-            filemtime = datetime.datetime.fromtimestamp(os.path.getmtime(self.location)).replace(tzinfo=network_timezones.sc_timezone)
+            file_mtime = datetime.datetime.fromtimestamp(os.path.getmtime(self.location)).replace(tzinfo=compare_tz)
 
-            if filemtime != airdatetime:
+            if file_mtime != airdatetime:
                 airdatetime = airdatetime.timetuple()
                 logger.debug(
                     f"{self.show.indexerid}: About to modify date of '{self.location}' to show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"
                 )
-                try:
-                    if helpers.touchFile(self.location, time.mktime(airdatetime)):
-                        logger.info(
-                            f"{self.show.indexerid}: Changed modify date of '{os.path.basename(self.location)}' to "
-                            f"show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"
-                        )
-                    else:
-                        logger.warning(
-                            f"{self.show.indexerid}: Unable to modify date of '{os.path.basename(self.location)}' "
-                            f"to show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"
-                        )
-
-                except OSError:
+                if helpers.touchFile(self.location, time.mktime(time.localtime(airdatetime))):
+                    logger.info(
+                        f"{self.show.indexerid}: Changed modify date of '{os.path.basename(self.location)}' to "
+                        f"show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"
+                    )
+                else:
                     logger.warning(
-                        f"{self.show.indexerid}: Failed to modify date of '{os.path.basename(self.location)}' "
+                        f"{self.show.indexerid}: Unable to modify date of '{os.path.basename(self.location)}' "
                         f"to show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"
                     )
 
-                except OverflowError or ValueError as error:
-                    logger.warning(f"Date change error: {error}, raw air date time: {airdatetime}")
-
-        except OSError:
-            logger.warning(f"{self.show.indexerid}: Failed to modify date of '{os.path.basename(self.location)}'")
+        except (OSError, OverflowError, ValueError) as error:
+            logger.warning(
+                f"{self.show.indexerid}: Failed to modify date of '{os.path.basename(self.location)}' "
+                f"to show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}, raw air date time: {airdatetime}: {error}"
+            )
 
     def cleanup_download_properties(self):
         """
diff --git a/sickchill/views/common.py b/sickchill/views/common.py
index ef85168a2c..2672bb8fe3 100644
--- a/sickchill/views/common.py
+++ b/sickchill/views/common.py
@@ -20,8 +20,7 @@ def get_lookup():
             directories=[os.path.join(settings.PROG_DIR, "gui/" + settings.GUI_NAME + "/views/")],
             module_directory=os.path.join(settings.CACHE_DIR, "mako"),
             strict_undefined=settings.DEVELOPER or settings.DEBUG,
-            #  format_exceptions=True,
-            filesystem_checks=True,
+            format_exceptions=True,
             imports=["from sickchill.oldbeard.filters import checked, disabled, hidden, selected"],
         ),
     )
@@ -37,33 +36,16 @@ def __init__(self, rh, filename, test_exception: bool = False):
         self.template = lookup.get_template(filename)
 
         self.context["scRoot"] = settings.WEB_ROOT
-        self.context["sbHttpPort"] = settings.WEB_PORT
-        self.context["sbHttpsPort"] = settings.WEB_PORT
-        self.context["sbHttpsEnabled"] = settings.ENABLE_HTTPS
-        self.context["sbHandleReverseProxy"] = settings.HANDLE_REVERSE_PROXY
-        self.context["sbDefaultPage"] = settings.DEFAULT_PAGE
-        self.context["scLogin"] = rh.get_current_user()
-        self.context["scStartTime"] = rh.startTime
+        self.context["sc_default_page"] = settings.DEFAULT_PAGE
+        self.context["current_user"] = rh.get_current_user()
+        self.context["page_load_start_time"] = rh.page_load_start_time
         self.context["static_url"] = rh.static_url
         self.context["reverse_url"] = rh.reverse_url
         self.context["linkify"] = linkify
 
-        # if rh.request.headers['Host'][0] == '[':
-        #     self.context['sbHost'] = re.match(r"^\[.*\]", rh.request.headers['Host'], re.X | re.M | re.S).group(0)
-        # else:
-        #     self.context['sbHost'] = re.match(r"^[^:]+", rh.request.headers['Host'], re.X | re.M | re.S).group(0)
-        #
-        # if "X-Forwarded-Host" in rh.request.headers:
-        #     self.context['sbHost'] = rh.request.headers['X-Forwarded-Host']
-        # if "X-Forwarded-Port" in rh.request.headers:
-        #     sbHttpPort = rh.request.headers['X-Forwarded-Port']
-        #     self.context['sbHttpsPort'] = sbHttpPort
-        # if "X-Forwarded-Proto" in rh.request.headers:
-        #     self.context['sbHttpsEnabled'] = rh.request.headers['X-Forwarded-Proto'].lower() == 'https'
-
-        self.context["numErrors"] = len(classes.ErrorViewer.errors)
-        self.context["numWarnings"] = len(classes.WarningViewer.errors)
-        self.context["scPID"] = str(settings.PID)
+        self.context["error_count"] = len(classes.ErrorViewer.errors)
+        self.context["warning_count"] = len(classes.WarningViewer.errors)
+        self.context["process_id"] = str(settings.PID)
 
         self.context["title"] = "FixME"
         self.context["header"] = "FixME"
@@ -77,7 +59,7 @@ def __init__(self, rh, filename, test_exception: bool = False):
         self.context["remote_ip"] = rh.request.remote_ip
 
     def render(self, *args, **kwargs):
-        self.context["makoStartTime"] = time.time()
+        self.context["mako_load_start_time"] = time.time()
         context = self.context
         context.update(kwargs)
         # noinspection PyBroadException
diff --git a/sickchill/views/index.py b/sickchill/views/index.py
index 42b07efd42..00dea2b5ee 100644
--- a/sickchill/views/index.py
+++ b/sickchill/views/index.py
@@ -45,7 +45,7 @@ def data_received(self, chunk):
 
     def initialize(self):
         super().initialize()
-        self.startTime = time.time()
+        self.page_load_start_time = time.time()
 
     def set_default_headers(self):
         self.set_header("X-Robots-Tag", "noindex")
diff --git a/sickchill/views/server_settings.py b/sickchill/views/server_settings.py
index b4ab2faa26..dfc1275919 100644
--- a/sickchill/views/server_settings.py
+++ b/sickchill/views/server_settings.py
@@ -17,20 +17,6 @@
 
 from .routes import Route
 
-# from sickchill.views.index import RequestHandler
-# from sickchill.views.common import PageTemplate
-
-
-# class Custom404Handler(RequestHandler):
-#     startTime = 0.0
-#
-#     def prepare(self):
-#         # return self.redirect(self.reverse_url("home", ""))
-#
-#         self.set_status(404)
-#         t = PageTemplate(rh=self, filename="404.mako")
-#         return self.finish(t.render(title="404", header=_("Oops")))
-
 
 class SickChillStaticFileHandler(StaticFileHandler):
     @classmethod

From 846aa4a4985e4becdfb5a2ff054023f1a78ce9f0 Mon Sep 17 00:00:00 2001
From: miigotu <miigotu@gmail.com>
Date: Sat, 3 Feb 2024 19:54:15 -0500
Subject: [PATCH 10/29] chore:black formatting

Signed-off-by: miigotu <miigotu@gmail.com>
---
 sickchill/views/index.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sickchill/views/index.py b/sickchill/views/index.py
index 00dea2b5ee..a72d29f619 100644
--- a/sickchill/views/index.py
+++ b/sickchill/views/index.py
@@ -39,7 +39,6 @@
 
 
 class BaseHandler(RequestHandler):
-
     def data_received(self, chunk):
         pass
 

From 754e34f64bacd73601b8ddc586bef21c778b56bd Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Sun, 4 Feb 2024 12:18:54 +0700
Subject: [PATCH 11/29] air date tm_isdst

---
 sickchill/tv.py | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/sickchill/tv.py b/sickchill/tv.py
index d2b5bd1e96..851ad772e6 100644
--- a/sickchill/tv.py
+++ b/sickchill/tv.py
@@ -2568,28 +2568,25 @@ def airdate_modify_stamp(self):
         if not all([settings.AIRDATE_EPISODES, self.airdate, self.location, self.show, self.show.airs, self.show.network]):
             return
 
-        airdatetime = None
-
         try:
             airdate_ordinal = self.airdate.toordinal()
             if airdate_ordinal < 1:
                 return
 
             airdatetime = network_timezones.parse_date_time(airdate_ordinal, self.show.airs, self.show.network)
-            compare_tz = network_timezones.get_network_timezone(self.show.network)
 
             if settings.FILE_TIMESTAMP_TIMEZONE == "local":
-                compare_tz = network_timezones.sc_timezone
                 airdatetime = airdatetime.astimezone(network_timezones.sc_timezone)
 
-            file_mtime = datetime.datetime.fromtimestamp(os.path.getmtime(self.location)).replace(tzinfo=compare_tz)
+            file_mtime = datetime.datetime.fromtimestamp(os.path.getmtime(self.location)).replace(tzinfo=airdatetime.tzinfo)
 
             if file_mtime != airdatetime:
-                airdatetime = airdatetime.timetuple()
+                # Get airdatetime, remove tm_isdst and set to -1 unknown for autofill by mktime
+                airdatetime = time.struct_time(airdatetime.timetuple()[:8] + (-1,))
                 logger.debug(
                     f"{self.show.indexerid}: About to modify date of '{self.location}' to show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"
                 )
-                if helpers.touchFile(self.location, time.mktime(time.localtime(airdatetime))):
+                if helpers.touchFile(self.location, time.mktime(airdatetime)):
                     logger.info(
                         f"{self.show.indexerid}: Changed modify date of '{os.path.basename(self.location)}' to "
                         f"show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}"

From c20da346c2d6dcacdd9b663472c29eba43b89a9e Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Sun, 4 Feb 2024 13:02:59 +0700
Subject: [PATCH 12/29] air date tm_isdst clean

---
 sickchill/tv.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sickchill/tv.py b/sickchill/tv.py
index 851ad772e6..cde36974bc 100644
--- a/sickchill/tv.py
+++ b/sickchill/tv.py
@@ -2568,6 +2568,8 @@ def airdate_modify_stamp(self):
         if not all([settings.AIRDATE_EPISODES, self.airdate, self.location, self.show, self.show.airs, self.show.network]):
             return
 
+        airdatetime = None
+
         try:
             airdate_ordinal = self.airdate.toordinal()
             if airdate_ordinal < 1:
@@ -2599,8 +2601,8 @@ def airdate_modify_stamp(self):
 
         except (OSError, OverflowError, ValueError) as error:
             logger.warning(
-                f"{self.show.indexerid}: Failed to modify date of '{os.path.basename(self.location)}' "
-                f"to show air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}, raw air date time: {airdatetime}: {error}"
+                f"{self.show.indexerid}: Failed to modify date of '{os.path.basename(self.location)}' to show "
+                f"air date {time.strftime('%b %d,%Y (%H:%M)', airdatetime)}, raw air date time: {airdatetime}: {error}"
             )
 
     def cleanup_download_properties(self):

From cb4c31baf8f863b7b813eacb5e0b93603bcdb0ef Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Sun, 11 Feb 2024 14:39:29 +0700
Subject: [PATCH 13/29] backlog page variables - log reduction

---
 .../slick/views/manage_backlogOverview.mako   | 38 +++++++++----------
 sickchill/views/index.py                      |  5 ++-
 2 files changed, 23 insertions(+), 20 deletions(-)

diff --git a/sickchill/gui/slick/views/manage_backlogOverview.mako b/sickchill/gui/slick/views/manage_backlogOverview.mako
index 1c48b26830..cbfdbe5dae 100644
--- a/sickchill/gui/slick/views/manage_backlogOverview.mako
+++ b/sickchill/gui/slick/views/manage_backlogOverview.mako
@@ -10,16 +10,16 @@
     <div class="row">
         <div class="col-lg-8 col-md-7 col-sm-6 col-xs-12 pull-right">
             <div class="pull-right">
-                % if totalWanted > 0:
-                    <span class="listing-key wanted">${_('Wanted')}: <b>${totalWanted}</b></span>
+                % if total_wanted > 0:
+                    <span class="listing-key wanted">${_('Wanted')}: <b>${total_wanted}</b></span>
                 % endif
 
-                % if totalQualSnatched > 0:
-                    <span class="listing-key snatched">${_('Snatched (Allowed)')}: <b>${totalQualSnatched}</b></span>
+                % if total_qual_snatched > 0:
+                    <span class="listing-key snatched">${_('Snatched (Allowed)')}: <b>${total_qual_snatched}</b></span>
                 % endif
 
-                % if totalQual > 0:
-                    <span class="listing-key qual">${_('Allowed')}: <b>${totalQual}</b></span>
+                % if total_qual > 0:
+                    <span class="listing-key qual">${_('Allowed')}: <b>${total_qual}</b></span>
                 % endif
             </div>
         </div>
@@ -35,31 +35,31 @@
         <div class="col-md-12">
             <label for="pickShow">${_('Jump to Show')}:</label>
             <select id="pickShow" class="form-control form-control-inline input-sm">
-                % for curShow in backLogShows:
+                % for curShow in backlog_shows:
                     <option value="${curShow.indexerid}">${curShow.name}</option>
                 % endfor
             </select>
         </div>
     </div>
 
-    % for curShow in backLogShows:
-        % if not showQualSnatched(curShow) and not showCounts[curShow.indexerid][Overview.WANTED] + showCounts[curShow.indexerid][Overview.QUAL]:
+    % for curShow in backlog_shows:
+        % if not show_qual_snatched(curShow) and not show_counts[curShow.indexerid][Overview.WANTED] + show_counts[curShow.indexerid][Overview.QUAL]:
             <% continue %>
         % endif
 
         <div class="row">
             <div class="col-md-12">
                 <div class="pull-right" style="margin-top: 30px;">
-                    % if showCounts[curShow.indexerid][Overview.WANTED] > 0:
-                        <span class="listing-key wanted">${_('Wanted')}: <b>${showCounts[curShow.indexerid][Overview.WANTED]}</b></span>
+                    % if show_counts[curShow.indexerid][Overview.WANTED] > 0:
+                        <span class="listing-key wanted">${_('Wanted')}: <b>${show_counts[curShow.indexerid][Overview.WANTED]}</b></span>
                     % endif
 
-                    % if showQualSnatched(curShow) and showCounts[curShow.indexerid][Overview.SNATCHED] > 0:
-                        <span class="listing-key snatched">${_('Snatched (Allowed)')}: <b>${showCounts[curShow.indexerid][Overview.SNATCHED]}</b></span>
+                    % if show_qual_snatched(curShow) and show_counts[curShow.indexerid][Overview.SNATCHED] > 0:
+                        <span class="listing-key snatched">${_('Snatched (Allowed)')}: <b>${show_counts[curShow.indexerid][Overview.SNATCHED]}</b></span>
                     % endif
 
-                    % if showCounts[curShow.indexerid][Overview.QUAL] > 0:
-                        <span class="listing-key qual">${_('Allowed')}: <b>${showCounts[curShow.indexerid][Overview.QUAL]}</b></span>
+                    % if show_counts[curShow.indexerid][Overview.QUAL] > 0:
+                        <span class="listing-key qual">${_('Allowed')}: <b>${show_counts[curShow.indexerid][Overview.QUAL]}</b></span>
                     % endif
 
                     <a class="btn btn-inline forceBacklog" href="${scRoot}/manage/backlogShow?indexer_id=${curShow.indexerid}"><i class="icon-play-circle icon-white"></i> ${_('Force Backlog')}</a>
@@ -79,16 +79,16 @@
                         </tr>
                         <tr class="seasoncols"><th>${_('Episode')}</th><th>${_('Name')}</th><th class="nowrap">${_('Airdate')}</th></tr>
 
-                        % for curResult in showSQLResults[curShow.indexerid]:
+                        % for curResult in show_sql_results[curShow.indexerid]:
                         <%
                             whichStr = episode_num(curResult['season'], curResult['episode']) or episode_num(curResult['season'], curResult['episode'], numbering='absolute')
-                            if whichStr not in showCats[curShow.indexerid] or showCats[curShow.indexerid][whichStr] not in (Overview.QUAL, Overview.WANTED, Overview.SNATCHED):
+                            if whichStr not in show_categories[curShow.indexerid] or show_categories[curShow.indexerid][whichStr] not in (Overview.QUAL, Overview.WANTED, Overview.SNATCHED):
                                 continue
 
-                            if not showQualSnatched(curShow) and showCats[curShow.indexerid][whichStr] == Overview.SNATCHED:
+                            if not show_qual_snatched(curShow) and show_categories[curShow.indexerid][whichStr] == Overview.SNATCHED:
                                 continue
                         %>
-                            <tr class="seasonstyle ${Overview.overviewStrings[showCats[curShow.indexerid][whichStr]]}">
+                            <tr class="seasonstyle ${Overview.overviewStrings[show_categories[curShow.indexerid][whichStr]]}">
                                 <td class="tableleft text-center">${whichStr}</td>
                                 <td class="tableright text-center nowrap">
                                     ${curResult["name"]}
diff --git a/sickchill/views/index.py b/sickchill/views/index.py
index a72d29f619..56a38f8c71 100644
--- a/sickchill/views/index.py
+++ b/sickchill/views/index.py
@@ -183,7 +183,10 @@ async def get(self, route, *args, **kwargs):
             try:
                 await self.finish(results)
             except Exception as e:
-                logger.debug(f"self.finish exception {e}, result {results}")
+                if settings.DEVELOPER:
+                    logger.debug(f"self.finish exception {e}, result {results}")
+                else:
+                    logger.debug(f"self.finish exception {e}")
 
         except AttributeError:
             logger.debug('Failed doing webui request "{0}": {1}'.format(route, traceback.format_exc()))

From 2a6deff910034e34baf370a6ff514cf74f172033 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Sun, 11 Feb 2024 14:45:55 +0700
Subject: [PATCH 14/29] backlog page variables lowercase 2

---
 .../slick/views/manage_backlogOverview.mako   | 48 +++++++++----------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/sickchill/gui/slick/views/manage_backlogOverview.mako b/sickchill/gui/slick/views/manage_backlogOverview.mako
index cbfdbe5dae..d67d6a100a 100644
--- a/sickchill/gui/slick/views/manage_backlogOverview.mako
+++ b/sickchill/gui/slick/views/manage_backlogOverview.mako
@@ -35,38 +35,38 @@
         <div class="col-md-12">
             <label for="pickShow">${_('Jump to Show')}:</label>
             <select id="pickShow" class="form-control form-control-inline input-sm">
-                % for curShow in backlog_shows:
-                    <option value="${curShow.indexerid}">${curShow.name}</option>
+                % for cur_show in backlog_shows:
+                    <option value="${cur_show.indexerid}">${cur_show.name}</option>
                 % endfor
             </select>
         </div>
     </div>
 
-    % for curShow in backlog_shows:
-        % if not show_qual_snatched(curShow) and not show_counts[curShow.indexerid][Overview.WANTED] + show_counts[curShow.indexerid][Overview.QUAL]:
+    % for cur_show in backlog_shows:
+        % if not show_qual_snatched(cur_show) and not show_counts[cur_show.indexerid][Overview.WANTED] + show_counts[cur_show.indexerid][Overview.QUAL]:
             <% continue %>
         % endif
 
         <div class="row">
             <div class="col-md-12">
                 <div class="pull-right" style="margin-top: 30px;">
-                    % if show_counts[curShow.indexerid][Overview.WANTED] > 0:
-                        <span class="listing-key wanted">${_('Wanted')}: <b>${show_counts[curShow.indexerid][Overview.WANTED]}</b></span>
+                    % if show_counts[cur_show.indexerid][Overview.WANTED] > 0:
+                        <span class="listing-key wanted">${_('Wanted')}: <b>${show_counts[cur_show.indexerid][Overview.WANTED]}</b></span>
                     % endif
 
-                    % if show_qual_snatched(curShow) and show_counts[curShow.indexerid][Overview.SNATCHED] > 0:
-                        <span class="listing-key snatched">${_('Snatched (Allowed)')}: <b>${show_counts[curShow.indexerid][Overview.SNATCHED]}</b></span>
+                    % if show_qual_snatched(cur_show) and show_counts[cur_show.indexerid][Overview.SNATCHED] > 0:
+                        <span class="listing-key snatched">${_('Snatched (Allowed)')}: <b>${show_counts[cur_show.indexerid][Overview.SNATCHED]}</b></span>
                     % endif
 
-                    % if show_counts[curShow.indexerid][Overview.QUAL] > 0:
-                        <span class="listing-key qual">${_('Allowed')}: <b>${show_counts[curShow.indexerid][Overview.QUAL]}</b></span>
+                    % if show_counts[cur_show.indexerid][Overview.QUAL] > 0:
+                        <span class="listing-key qual">${_('Allowed')}: <b>${show_counts[cur_show.indexerid][Overview.QUAL]}</b></span>
                     % endif
 
-                    <a class="btn btn-inline forceBacklog" href="${scRoot}/manage/backlogShow?indexer_id=${curShow.indexerid}"><i class="icon-play-circle icon-white"></i> ${_('Force Backlog')}</a>
+                    <a class="btn btn-inline forceBacklog" href="${scRoot}/manage/backlogShow?indexer_id=${cur_show.indexerid}"><i class="icon-play-circle icon-white"></i> ${_('Force Backlog')}</a>
                 </div>
 
                 <h2 style="display: inline-block;">
-                    <a href="${scRoot}/home/displayShow?show=${curShow.indexerid}">${curShow.name}</a>
+                    <a href="${scRoot}/home/displayShow?show=${cur_show.indexerid}">${cur_show.name}</a>
                 </h2>
             </div>
         </div>
@@ -74,31 +74,31 @@
             <div class="col-md-12">
                 <div class="horizontal-scroll">
                     <table class="sickchillTable">
-                        <tr class="seasonheader" id="show-${curShow.indexerid}">
+                        <tr class="seasonheader" id="show-${cur_show.indexerid}">
                             <td colspan="3" class="align-left" style="position: relative;"></td>
                         </tr>
                         <tr class="seasoncols"><th>${_('Episode')}</th><th>${_('Name')}</th><th class="nowrap">${_('Airdate')}</th></tr>
 
-                        % for curResult in show_sql_results[curShow.indexerid]:
+                        % for cur_result in show_sql_results[cur_show.indexerid]:
                         <%
-                            whichStr = episode_num(curResult['season'], curResult['episode']) or episode_num(curResult['season'], curResult['episode'], numbering='absolute')
-                            if whichStr not in show_categories[curShow.indexerid] or show_categories[curShow.indexerid][whichStr] not in (Overview.QUAL, Overview.WANTED, Overview.SNATCHED):
+                            which_str = episode_num(cur_result['season'], cur_result['episode']) or episode_num(cur_result['season'], cur_result['episode'], numbering='absolute')
+                            if which_str not in show_categories[cur_show.indexerid] or show_categories[cur_show.indexerid][which_str] not in (Overview.QUAL, Overview.WANTED, Overview.SNATCHED):
                                 continue
 
-                            if not show_qual_snatched(curShow) and show_categories[curShow.indexerid][whichStr] == Overview.SNATCHED:
+                            if not show_qual_snatched(cur_show) and show_categories[cur_show.indexerid][which_str] == Overview.SNATCHED:
                                 continue
                         %>
-                            <tr class="seasonstyle ${Overview.overviewStrings[show_categories[curShow.indexerid][whichStr]]}">
-                                <td class="tableleft text-center">${whichStr}</td>
+                            <tr class="seasonstyle ${Overview.overviewStrings[show_categories[cur_show.indexerid][which_str]]}">
+                                <td class="tableleft text-center">${which_str}</td>
                                 <td class="tableright text-center nowrap">
-                                    ${curResult["name"]}
+                                    ${cur_result["name"]}
                                 </td>
                                 <td>
                                 % try:
-                                    % if int(curResult['airdate']) > 1:
-                                    <% air_date = datetime.datetime.fromordinal(curResult['airdate']) %>
-                                    % if air_date > datetime.datetime.utcfromtimestamp(0) and curShow.network:
-                                        <% air_date = scdatetime.scdatetime.convert_to_setting(network_timezones.parse_date_time(curResult['airdate'], curShow.airs, curShow.network)) %>
+                                    % if int(cur_result['airdate']) > 1:
+                                    <% air_date = datetime.datetime.fromordinal(cur_result['airdate']) %>
+                                    % if air_date > datetime.datetime.utcfromtimestamp(0) and cur_show.network:
+                                        <% air_date = scdatetime.scdatetime.convert_to_setting(network_timezones.parse_date_time(cur_result['airdate'], cur_show.airs, cur_show.network)) %>
                                     % endif
                                         <time datetime="${air_date.isoformat('T')}" class="date">${scdatetime.scdatetime.scfdatetime(air_date)}</time>
                                     % else:

From 47350058322423c2b3c6478d226fbab983f93bcb Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Sun, 11 Feb 2024 15:01:18 +0700
Subject: [PATCH 15/29] trending add - redirectable

---
 sickchill/gui/slick/views/trendingShows.mako | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sickchill/gui/slick/views/trendingShows.mako b/sickchill/gui/slick/views/trendingShows.mako
index a02b4a82e5..4dfdcba4e3 100644
--- a/sickchill/gui/slick/views/trendingShows.mako
+++ b/sickchill/gui/slick/views/trendingShows.mako
@@ -40,7 +40,7 @@
                             <i>${cur_show['show']['votes']} ${_('votes')}</i>
                             <div class="traktShowTitleIcons">
                                 <a href="${scRoot}/addShows/addShowByID?indexer_id=${cur_show['show']['ids']['tvdb']}&amp;show_name=${cur_show['show']['title'] | u}"
-                                   class="btn btn-xs" data-no-redirect>${_('Add Show')}</a>
+                                   class="btn btn-xs">${_('Add Show')}</a>
                                 % if black_list:
                                     <a href="${scRoot}/addShows/addShowToBlacklist?indexer_id=${cur_show['show']['ids']['tvdb'] or cur_show['show']['ids']['tvrage']}"
                                        class="btn btn-xs">${_('Remove Show')}</a>

From 9614388762ecc08702de12e0b080adfbca181c00 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Sun, 11 Feb 2024 22:35:28 +0700
Subject: [PATCH 16/29] searchBacklog needs int

---
 sickchill/oldbeard/searchBacklog.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sickchill/oldbeard/searchBacklog.py b/sickchill/oldbeard/searchBacklog.py
index 3467e5987a..bf46f04445 100644
--- a/sickchill/oldbeard/searchBacklog.py
+++ b/sickchill/oldbeard/searchBacklog.py
@@ -15,7 +15,7 @@ def nextRun(self):
         if self.action.lastBacklog <= 1:
             return datetime.date.today()
         else:
-            return datetime.date.fromordinal(self.action.lastBacklog + self.action.cycleTime)
+            return datetime.date.fromordinal(int(self.action.lastBacklog + self.action.cycleTime))
 
 
 class BacklogSearcher(object):

From 0ac7c4cec911ee1716a1d34d0f0fb8c69a60e0c3 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 00:28:45 +0700
Subject: [PATCH 17/29] subtitles remove legendastv

---
 sickchill/gui/slick/views/config_subtitles.mako |  1 -
 sickchill/oldbeard/subtitles.py                 | 11 +++--------
 sickchill/start.py                              |  5 -----
 sickchill/views/config/subtitles.py             |  4 ----
 4 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/sickchill/gui/slick/views/config_subtitles.mako b/sickchill/gui/slick/views/config_subtitles.mako
index fe4165c092..1f52ab8f30 100644
--- a/sickchill/gui/slick/views/config_subtitles.mako
+++ b/sickchill/gui/slick/views/config_subtitles.mako
@@ -326,7 +326,6 @@
                     <fieldset class="component-group-list">
                         <%
                             providerLoginDict = {
-                                'legendastv': {'user': settings.LEGENDASTV_USER, 'pass': settings.LEGENDASTV_PASS},
                                 'addic7ed': {'user': settings.ADDIC7ED_USER, 'pass': settings.ADDIC7ED_PASS},
                                 'itasa': {'user': settings.ITASA_USER, 'pass': settings.ITASA_PASS},
                                 'opensubtitles': {'user': settings.OPENSUBTITLES_USER, 'pass': settings.OPENSUBTITLES_PASS},
diff --git a/sickchill/oldbeard/subtitles.py b/sickchill/oldbeard/subtitles.py
index 38d37bc41c..ff01e83a69 100644
--- a/sickchill/oldbeard/subtitles.py
+++ b/sickchill/oldbeard/subtitles.py
@@ -22,8 +22,7 @@
 
 # https://github.com/Diaoul/subliminal/issues/536
 # provider_manager.register('napiprojekt = subliminal.providers.napiprojekt:NapiProjektProvider')
-# if 'legendastv' not in subliminal.provider_manager.names():
-#     subliminal.provider_manager.register('legendastv = subliminal.providers.legendastv:LegendasTVProvider')
+# 'legendastv' closed down
 if "itasa" not in subliminal.provider_manager.names():
     subliminal.provider_manager.register("itasa = sickchill.providers.subtitle.itasa:ItaSAProvider")
 if "wizdom" not in subliminal.provider_manager.names():
@@ -38,16 +37,13 @@
 subliminal.region.configure("dogpile.cache.memory")
 
 PROVIDER_URLS = {
-    "addic7ed": "http://www.addic7ed.com",
+    "addic7ed": "https://www.addic7ed.com",
     "bsplayer": "http://bsplayer-subtitles.com",
     "itasa": "http://www.italiansubs.net/",
-    "legendastv": "http://www.legendas.tv",
     "napiprojekt": "http://www.napiprojekt.pl",
     "opensubtitles": "https://www.opensubtitles.com",
     "podnapisi": "http://www.podnapisi.net",
-    "subscenter": "http://www.subscenter.info",
     "subtitulamos": "https://www.subtitulamos.tv",
-    "thesubdb": "http://www.thesubdb.com",
     "wizdom": "http://wizdom.xyz",
     "tvsubtitles": "http://www.tvsubtitles.net",
 }
@@ -78,7 +74,6 @@ def __init_instance():
             provider_configs = {
                 "addic7ed": {"username": settings.ADDIC7ED_USER, "password": settings.ADDIC7ED_PASS},
                 "itasa": {"username": settings.ITASA_USER, "password": settings.ITASA_PASS},
-                "legendastv": {"username": settings.LEGENDASTV_USER, "password": settings.LEGENDASTV_PASS},
                 "opensubtitles": {"username": settings.OPENSUBTITLES_USER, "password": settings.OPENSUBTITLES_PASS},
                 "subscenter": {"username": settings.SUBSCENTER_USER, "password": settings.SUBSCENTER_PASS},
             }
@@ -106,7 +101,7 @@ def __getattr__(self, attr):
 
 def sorted_service_list():
     new_list = []
-    lmgtfy = "https://lmgtfy.com/?q=%s"
+    lmgtfy = "https://blog.lmgtfy.com/?q=%s"
 
     current_index = 0
     for current_service in settings.SUBTITLES_SERVICES_LIST:
diff --git a/sickchill/start.py b/sickchill/start.py
index 51185eb422..5c82a0e08d 100644
--- a/sickchill/start.py
+++ b/sickchill/start.py
@@ -700,9 +700,6 @@ def path_leaf(path):
         settings.ITASA_USER = check_setting_str(settings.CFG, "Subtitles", "itasa_username", censor_log=True)
         settings.ITASA_PASS = check_setting_str(settings.CFG, "Subtitles", "itasa_password", censor_log=True)
 
-        settings.LEGENDASTV_USER = check_setting_str(settings.CFG, "Subtitles", "legendastv_username", censor_log=True)
-        settings.LEGENDASTV_PASS = check_setting_str(settings.CFG, "Subtitles", "legendastv_password", censor_log=True)
-
         settings.OPENSUBTITLES_USER = check_setting_str(settings.CFG, "Subtitles", "opensubtitles_username", censor_log=True)
         settings.OPENSUBTITLES_PASS = check_setting_str(settings.CFG, "Subtitles", "opensubtitles_password", censor_log=True)
 
@@ -1661,8 +1658,6 @@ def save_config():
                 "addic7ed_password": helpers.encrypt(settings.ADDIC7ED_PASS, settings.ENCRYPTION_VERSION),
                 "itasa_username": settings.ITASA_USER,
                 "itasa_password": helpers.encrypt(settings.ITASA_PASS, settings.ENCRYPTION_VERSION),
-                "legendastv_username": settings.LEGENDASTV_USER,
-                "legendastv_password": helpers.encrypt(settings.LEGENDASTV_PASS, settings.ENCRYPTION_VERSION),
                 "opensubtitles_username": settings.OPENSUBTITLES_USER,
                 "opensubtitles_password": helpers.encrypt(settings.OPENSUBTITLES_PASS, settings.ENCRYPTION_VERSION),
                 "subscenter_username": settings.SUBSCENTER_USER,
diff --git a/sickchill/views/config/subtitles.py b/sickchill/views/config/subtitles.py
index a4c92f6d13..1be675375b 100644
--- a/sickchill/views/config/subtitles.py
+++ b/sickchill/views/config/subtitles.py
@@ -39,8 +39,6 @@ def saveSubtitles(
         addic7ed_pass=None,
         itasa_user=None,
         itasa_pass=None,
-        legendastv_user=None,
-        legendastv_pass=None,
         opensubtitles_user=None,
         opensubtitles_pass=None,
         subscenter_user=None,
@@ -80,8 +78,6 @@ def saveSubtitles(
         settings.ADDIC7ED_PASS = filters.unhide(settings.ADDIC7ED_PASS, addic7ed_pass) or ""
         settings.ITASA_USER = itasa_user or ""
         settings.ITASA_PASS = filters.unhide(settings.ITASA_PASS, itasa_pass) or ""
-        settings.LEGENDASTV_USER = legendastv_user or ""
-        settings.LEGENDASTV_PASS = filters.unhide(settings.LEGENDASTV_PASS, legendastv_pass) or ""
         settings.OPENSUBTITLES_USER = opensubtitles_user or ""
         settings.OPENSUBTITLES_PASS = filters.unhide(settings.OPENSUBTITLES_PASS, opensubtitles_pass) or ""
         settings.SUBSCENTER_USER = subscenter_user or ""

From 7b588314c941013d0a3fc0bce19277b4a9a21c07 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 14:03:07 +0700
Subject: [PATCH 18/29] add shows redirect allowed

---
 sickchill/gui/slick/views/addShows_favoriteShows.mako | 2 +-
 sickchill/gui/slick/views/addShows_popularShows.mako  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sickchill/gui/slick/views/addShows_favoriteShows.mako b/sickchill/gui/slick/views/addShows_favoriteShows.mako
index b588f8950a..6074c460ce 100644
--- a/sickchill/gui/slick/views/addShows_favoriteShows.mako
+++ b/sickchill/gui/slick/views/addShows_favoriteShows.mako
@@ -96,7 +96,7 @@
                                         <i>${cur_result.siteRatingCount}</i>
                                         <div class="traktShowTitleIcons">
                                             <a href="${scRoot}/addShows/addShowByID?indexer_id=${cur_result.id}&amp;show_name=${cur_result.seriesName | u}&amp;indexer=TVDB"
-                                               class="btn btn-xs" data-no-redirect>${_('Add Show')}</a>
+                                               class="btn btn-xs">${_('Add Show')}</a>
                                         </div>
                                     </div>
                                 </div>
diff --git a/sickchill/gui/slick/views/addShows_popularShows.mako b/sickchill/gui/slick/views/addShows_popularShows.mako
index 5ba74deb8f..620f5ae778 100644
--- a/sickchill/gui/slick/views/addShows_popularShows.mako
+++ b/sickchill/gui/slick/views/addShows_popularShows.mako
@@ -75,7 +75,7 @@
 
                                         <div class="traktShowTitleIcons">
                                             <a href="${scRoot}/addShows/addShowByID?indexer_id=${current_imdb_id}&amp;show_name=${current_result['title'] | u}&amp;indexer=IMDB"
-                                               class="btn btn-xs" data-no-redirect>${_('Add Show')}</a>
+                                               class="btn btn-xs">${_('Add Show')}</a>
                                         </div>
                                     </div>
                                 </div>

From 18c4a7d2520e53c52dfed641347eb231ceaf2409 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 15:08:59 +0700
Subject: [PATCH 19/29] regex single char alternation - Qodana

---
 sickchill/oldbeard/common.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sickchill/oldbeard/common.py b/sickchill/oldbeard/common.py
index 39cd90ff8a..2e7b209192 100644
--- a/sickchill/oldbeard/common.py
+++ b/sickchill/oldbeard/common.py
@@ -445,9 +445,9 @@ def sceneQualityFromName(name, quality):
 
         # 2 corresponds to SDDVD quality
         if quality == 2:
-            if re.search(r"b(r|d|rd)?(-| |\.)?(rip|mux)", name.lower()):
+            if re.search(r"b(r|d|rd)?([- .])?(rip|mux)", name.lower()):
                 rip_type = " BDRip"
-            elif re.search(r"(dvd)(-| |\.)?(rip|mux)?", name.lower()):
+            elif re.search(r"(dvd)([- .])?(rip|mux)?", name.lower()):
                 rip_type = " DVDRip"
             else:
                 rip_type = ""

From b44dc29bcbc2087a5e17a366991c06d09109652c Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 15:20:15 +0700
Subject: [PATCH 20/29] docstring parameters - Qodana

---
 sickchill/oldbeard/scene_numbering.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sickchill/oldbeard/scene_numbering.py b/sickchill/oldbeard/scene_numbering.py
index d541d82bec..cc9bfb640a 100644
--- a/sickchill/oldbeard/scene_numbering.py
+++ b/sickchill/oldbeard/scene_numbering.py
@@ -23,6 +23,7 @@ def get_scene_numbering(indexer_id, indexer, season, episode, fallback_to_xem=Tr
     (so the return values will always be set)
 
     :param indexer_id: int
+    :param indexer: int
     :param season: int
     :param episode: int
     :param fallback_to_xem: bool If set (the default), check xem for matches if there is no local scene numbering
@@ -247,6 +248,7 @@ def find_xem_absolute_numbering(indexer_id, indexer, absolute_number):
     Refreshes/Loads as needed.
 
     :param indexer_id: int
+    :param indexer: int
     :param absolute_number: int
     :return: int
     """
@@ -305,6 +307,7 @@ def get_indexer_absolute_numbering_for_xem(indexer_id, indexer, sceneAbsoluteNum
     :param indexer_id: int
     :param indexer: int
     :param sceneAbsoluteNumber: int
+    :param scene_season: default None
     :return: int
     """
     if indexer_id is None or sceneAbsoluteNumber is None:
@@ -459,6 +462,8 @@ def xem_refresh(indexer_id, indexer, force=False):
     Refresh data from xem for a tv show
 
     :param indexer_id: int
+    :param indexer: int
+    :param force: default False
     """
     if not indexer_id or indexer_id < 1:
         return

From 6340a58f8e40a9d17d4130cbe198bbbf391f2681 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 16:33:25 +0700
Subject: [PATCH 21/29] fstring logs

---
 sickchill/oldbeard/helpers.py             | 148 +++++++++-------------
 sickchill/oldbeard/notifiers/libnotify.py |   8 +-
 sickchill/oldbeard/postProcessor.py       |  78 +++++-------
 sickchill/oldbeard/providers/norbits.py   |   2 +-
 4 files changed, 96 insertions(+), 140 deletions(-)

diff --git a/sickchill/oldbeard/helpers.py b/sickchill/oldbeard/helpers.py
index ba0f3beba6..5bc741dc0e 100644
--- a/sickchill/oldbeard/helpers.py
+++ b/sickchill/oldbeard/helpers.py
@@ -315,16 +315,12 @@ def hardlinkFile(srcFile, destFile):
             except (OSError, IOError) as error:
                 logger.log(
                     _(
-                        "The destination file already exists, and we were unable to remove it, so hard linking might fail. Trying anyway. Location: {destFile}. Error: {error}"
-                    ).format(destFile=destFile, error=error),
+                        f"The destination file already exists, and we were unable to remove it, so hard linking might fail. Trying anyway. Location: {destFile}. Error: {error}"
+                    )
                 )
         os.link(srcFile, destFile)
     except Exception as error:
-        logger.warning(
-            _("There was a problem creating a hardlink of {srcFile} at {destFile}. Copying instead. Error: {error}").format(
-                srcFile=srcFile, destFile=destFile, error=error
-            )
-        )
+        logger.warning(_(f"There was a problem creating a hardlink of {srcFile} at {destFile}. Copying instead. Error: {error}"))
         copyFile(srcFile, destFile)
 
     fixSetGroupID(destFile)
@@ -344,11 +340,7 @@ def moveAndSymlinkFile(srcFile, destFile):
         moveFile(srcFile, destFile)
         os.symlink(destFile, srcFile)
     except Exception as error:
-        logger.warning(
-            _("There was a problem creating a symlink of {srcFile} at {destFile}. Copying instead. Error: {error}").format(
-                srcFile=srcFile, destFile=destFile, error=error
-            )
-        )
+        logger.warning(_(f"There was a problem creating a symlink of {srcFile} at {destFile}. Copying instead. Error: {error}"))
         copyFile(srcFile, destFile)
 
 
@@ -358,16 +350,16 @@ def make_dirs(path):
     parents
     """
 
-    logger.debug(_("Checking if the path {path} already exists").format(path=path))
+    logger.debug(_(f"Checking if the path {path} already exists"))
 
     if not os.path.isdir(path):
         # Windows, create all missing folders
         if platform.system() == "Windows":
             try:
-                logger.debug(_("Folder {path} didn't exist, creating it").format(path=path))
+                logger.debug(_(f"Folder {path} didn't exist, creating it"))
                 os.makedirs(path)
             except (OSError, IOError) as error:
-                logger.exception(_("There was a problem creating {path}. Error: {error}").format(path=path, error=error))
+                logger.exception(_(f"There was a problem creating {path}. Error: {error}"))
                 return False
 
         # not Windows, create all missing folders and set permissions
@@ -384,14 +376,14 @@ def make_dirs(path):
                     continue
 
                 try:
-                    logger.debug(_("Folder {sofar} didn't exist, creating it").format(sofar=sofar))
+                    logger.debug(_(f"Folder {sofar} didn't exist, creating it"))
                     os.mkdir(sofar)
                     # use normpath to remove end separator, otherwise checks permissions against itself
                     chmodAsParent(os.path.normpath(sofar))
                     # do the library update for synoindex
                     sickchill.oldbeard.notifiers.synoindex_notifier.addFolder(sofar)
                 except (OSError, IOError) as error:
-                    logger.exception(_("There was a problem creating {sofar}. Error: {error}").format(sofar=sofar, error=error))
+                    logger.exception(_(f"There was a problem creating {sofar}. Error: {error}"))
                     return False
 
     return True
@@ -433,10 +425,10 @@ def rename_ep_file(cur_path, new_path, old_path_length=0):
 
     # move the file
     try:
-        logger.info(_("Renaming file from {cur_path} to {new_path}").format(cur_path=cur_path, new_path=new_path))
+        logger.info(_(f"Renaming file from {cur_path} to {new_path}"))
         shutil.move(cur_path, new_path)
     except (OSError, IOError) as error:
-        logger.exception(_("There was a problem renaming {cur_path} to {new_path}. Error: {error}").format(cur_path=cur_path, new_path=new_path, error=error))
+        logger.exception(_(f"There was a problem renaming {cur_path} to {new_path}. Error: {error}"))
         return False
 
     # clean up any old folders that are empty
@@ -457,7 +449,7 @@ def delete_empty_folders(check_empty_dir, keep_dir=None):
     # treat check_empty_dir as empty when it only contains these items
     ignore_items = []
 
-    logger.info(_("Trying to clean any empty folders under {check_empty_dir}").format(check_empty_dir=check_empty_dir))
+    logger.info(_(f"Trying to clean any empty folders under {check_empty_dir}"))
 
     # as long as the folder exists and doesn't contain any files, delete it
     while os.path.isdir(check_empty_dir) and check_empty_dir != keep_dir:
@@ -466,13 +458,13 @@ def delete_empty_folders(check_empty_dir, keep_dir=None):
         if not check_files or (len(check_files) <= len(ignore_items) and all(check_file in ignore_items for check_file in check_files)):
             # directory is empty or contains only ignore_items
             try:
-                logger.info(_("Deleting empty folder: {check_empty_dir}").format(check_empty_dir=check_empty_dir))
+                logger.info(_(f"Deleting empty folder: {check_empty_dir}"))
                 # need shutil.rmtree when ignore_items is really implemented
                 os.rmdir(check_empty_dir)
                 # do the library update for synoindex
                 sickchill.oldbeard.notifiers.synoindex_notifier.deleteFolder(check_empty_dir)
             except OSError as error:
-                logger.warning(_("There was a problem trying to delete {check_empty_dir}. Error: {error}").format(check_empty_dir=check_empty_dir, error=error))
+                logger.warning(_(f"There was a problem trying to delete {check_empty_dir}. Error: {error}"))
                 break
             check_empty_dir = os.path.dirname(check_empty_dir)
         else:
@@ -511,7 +503,7 @@ def chmodAsParent(childPath):
     parentPath = os.path.dirname(childPath)
 
     if not parentPath:
-        logger.debug(_("No parent path provided in {childPath} unable to get permissions from it").format(childPath=childPath))
+        logger.debug(_(f"No parent path provided in {childPath} unable to get permissions from it"))
         return
 
     childPath = os.path.join(parentPath, os.path.basename(childPath))
@@ -534,17 +526,13 @@ def chmodAsParent(childPath):
     user_id = os.geteuid()  # @UndefinedVariable - only available on UNIX
 
     if user_id not in (childPath_owner, 0):
-        logger.debug(_("Not running as root or owner of {childPath}, not trying to set permissions").format(childPath=childPath))
+        logger.debug(_(f"Not running as root or owner of {childPath}, not trying to set permissions"))
         return
 
     try:
         os.chmod(childPath, childMode)
     except OSError as error:
-        logger.debug(
-            _("There was a problem setting permissions of {childPath} to {childMode:o}, parent directory has {parentMode:o}. Error: {error}").format(
-                childPath=childPath, childMode=childMode, parentMode=parentMode, error=error
-            )
-        )
+        logger.debug(_(f"There was a problem setting permissions of {childPath} to {childMode:o}, parent directory has {parentMode:o}. Error: {error}"))
 
 
 def fixSetGroupID(childPath):
@@ -578,22 +566,20 @@ def fixSetGroupID(childPath):
             user_id = os.geteuid()
 
             if user_id not in (childPath_owner, 0):
-                logger.debug(_("Not running as root or owner of {childPath}, not trying to set the set-group-ID").format(childPath=childPath))
+                logger.debug(_(f"Not running as root or owner of {childPath}, not trying to set the set-group-ID"))
                 return
 
             try:
                 os.chown(childPath, -1, parentGID)
-                logger.debug(_("Respecting the set-group-ID bit on the parent directory of {childPath}").format(childPath=childPath))
+                logger.debug(_(f"Respecting the set-group-ID bit on the parent directory of {childPath}"))
             except (OSError, PermissionError) as error:
                 logger.debug(
                     _(
-                        "There was a problem respecting the set-group-ID bit on the parent directory of {childPath} (setting group ID {parentGID}). Error: {error}"
-                    ).format(childPath=childPath, parentGID=parentGID, error=error)
+                        f"There was a problem respecting the set-group-ID bit on the parent directory of {childPath} (setting group ID {parentGID}). Error: {error}"
+                    )
                 )
     except Exception as error:
-        logger.debug(
-            _("There was a problem setting set-group-id on the parent directory of {childPath}. Error: {error}").format(childPath=childPath, error=error)
-        )
+        logger.debug(_(f"There was a problem setting set-group-id on the parent directory of {childPath}. Error: {error}"))
 
 
 def is_anime_in_show_list():
@@ -637,15 +623,9 @@ def get_absolute_number_from_season_and_episode(show, season, episode):
         season_episode = episode_num(season, episode)
         if len(sql_results) == 1:
             absolute_number = int(sql_results[0]["absolute_number"])
-            logger.debug(
-                _("Found absolute number {absolute_number} for show {show_name} {season_episode}").format(
-                    absolute_number=absolute_number, show_name=show.name, season_episode=season_episode
-                )
-            )
+            logger.debug(_(f"Found absolute number {absolute_number} for show {show.name} {season_episode}"))
         else:
-            logger.debug(
-                _("No entries found for the absolute number of {show_name} {season_episode}").format(show_name=show.name, season_episode=season_episode)
-            )
+            logger.debug(_(f"No entries found for the absolute number of {show.name} {season_episode}"))
 
     return absolute_number
 
@@ -745,11 +725,11 @@ def create_https_certificates(ssl_cert, ssl_key):
         Path(ssl_cert).write_bytes(crypto.dump_certificate(crypto.FILETYPE_PEM, cert))
     except Exception as error:
         logger.info(traceback.format_exc())
-        logger.warning(_("There was a problem creating the SSL key and certificate. Error: {error}").format(error=error))
+        logger.warning(_(f"There was a problem creating the SSL key and certificate. Error: {error}"))
         return False
 
-    logger.info(_("Created https key: {ssl_key}").format(ssl_key=ssl_key))
-    logger.info(_("Created https cert: {ssl_cert}").format(ssl_cert=ssl_cert))
+    logger.info(_(f"Created https key: {ssl_key}"))
+    logger.info(_(f"Created https cert: {ssl_cert}"))
     return True
 
 
@@ -772,26 +752,22 @@ def backupVersionedFile(old_file, version):
     new_file = old_file.with_suffix(f"{old_file.suffix}.v{version}")
     while not os.path.isfile(new_file):
         if not os.path.isfile(old_file):
-            logger.debug(_("Not creating backup, {old_file} doesn't exist").format(old_file=old_file))
+            logger.debug(_(f"Not creating backup, {old_file} doesn't exist"))
             break
 
         try:
-            logger.debug(_("Trying to back up {old_file} to {new_file}").format(old_file=old_file, new_file=new_file))
+            logger.debug(_(f"Trying to back up {old_file} to {new_file}"))
             shutil.copy(old_file, new_file)
             logger.debug(_("Backup done"))
             break
         except Exception as error:
-            logger.warning(
-                _("There was a problem while trying to back up {old_file} to {new_file}. Error: {error}").format(
-                    old_file=old_file, new_file=new_file, error=error
-                )
-            )
+            logger.warning(_(f"There was a problem while trying to back up {old_file} to {new_file}. Error: {error}"))
             numTries += 1
             time.sleep(1)
             logger.debug(_("Trying again."))
 
         if numTries >= 10:
-            logger.exception(_("Unable to back up {old_file} to {new_file} please do it manually.").format(old_file=old_file, new_file=new_file))
+            logger.exception(_(f"Unable to back up {old_file} to {new_file} please do it manually."))
             return False
 
     return True
@@ -938,7 +914,7 @@ def get_show(name, try_indexers=False):
         if show_object and not from_cache:
             sickchill.oldbeard.name_cache.add_name(name, show_object.indexerid)
     except Exception as error:
-        logger.debug(_("There was a problem when attempting to find {name} in SickChill. Error: {error}").format(name=name, error=error))
+        logger.debug(_(f"There was a problem when attempting to find {name} in SickChill. Error: {error}"))
         logger.debug(traceback.format_exc())
 
     return show_object
@@ -1010,12 +986,12 @@ def set_up_anidb_connection():
     if not settings.ADBA_CONNECTION:
 
         def anidb_logger(msg):
-            return logger.debug(_("{msg}").format(msg=msg))
+            return logger.debug(_(f"{msg}"))
 
         try:
             settings.ADBA_CONNECTION = adba.Connection(keep_alive=True, log=anidb_logger)
         except Exception as error:
-            logger.warning(_("There was a problem attempting to connect to anidb. Error: {error}").format(error=error))
+            logger.warning(_(f"There was a problem attempting to connect to anidb. Error: {error}"))
             return False
 
     try:
@@ -1024,7 +1000,7 @@ def anidb_logger(msg):
         else:
             return True
     except Exception as error:
-        logger.warning(_("There was a problem attempting to authenticate with anidb. Error: {error}").format(error=error))
+        logger.warning(_(f"There was a problem attempting to authenticate with anidb. Error: {error}"))
         return False
 
     return settings.ADBA_CONNECTION.authed()
@@ -1046,7 +1022,7 @@ def makeZip(fileList, archive):
         a.close()
         return True
     except Exception as error:
-        logger.exception(_("There was a problem creating the zip file. Error: {error}").format(error=error))
+        logger.exception(_(f"There was a problem creating the zip file. Error: {error}"))
         return False
 
 
@@ -1079,7 +1055,7 @@ def extractZip(archive, targetDir):
         zip_file.close()
         return True
     except Exception as error:
-        logger.exception(_("There was a problem extracting the zip file {archive}. Error: {error}").format(archive=archive, error=error))
+        logger.exception(_(f"There was a problem extracting the zip file {archive}. Error: {error}"))
         return False
 
 
@@ -1102,7 +1078,7 @@ def backup_config_zip(fileList, archive, arcname=None):
         a.close()
         return True
     except Exception as error:
-        logger.warning(_("There was a problem creating the zip file. Error: {error}").format(error=error))
+        logger.warning(_(f"There was a problem creating the zip file. Error: {error}"))
         return False
 
 
@@ -1137,7 +1113,7 @@ def path_leaf(path):
         zip_file.close()
         return True
     except Exception as error:
-        logger.exception(_("There was a problem extracting zip file {archive}. Error: {error}").format(archive=archive, error=error))
+        logger.exception(_(f"There was a problem extracting zip file {archive}. Error: {error}"))
         shutil.rmtree(targetDir)
         return False
 
@@ -1164,7 +1140,7 @@ def make_indexer_session():
     session = make_session()
     session.verify = (False, certifi.where())[settings.SSL_VERIFY]
     if settings.PROXY_SETTING and settings.PROXY_INDEXERS:
-        logger.debug(_("Using global proxy for indexers: {proxy_settings}").format(proxy_settings=settings.PROXY_SETTING))
+        logger.debug(_(f"Using global proxy for indexers: {settings.PROXY_SETTING}"))
         session.proxies = {"http": settings.PROXY_SETTING, "https": settings.PROXY_SETTING}
     return session
 
@@ -1180,7 +1156,7 @@ def request_defaults(kwargs):
 
     # request session proxies
     if kwargs.pop("allow_proxy", True) and settings.PROXY_SETTING:
-        logger.debug(_("Using global proxy: {proxy}").format(proxy=settings.PROXY_SETTING))
+        logger.debug(_(f"Using global proxy: {settings.PROXY_SETTING}"))
         proxies = {"http": settings.PROXY_SETTING, "https": settings.PROXY_SETTING}
     else:
         proxies = None
@@ -1262,7 +1238,7 @@ def getURL(
     try:
         return response if response_type in ("response", None) else response.json() if response_type == "json" else getattr(response, response_type, response)
     except ValueError:
-        logger.debug(_("Requested a json response but response was not json, check the url: {url}").format(url=url))
+        logger.debug(_(f"Requested a json response but response was not json, check the url: {url}"))
         return None
 
 
@@ -1302,9 +1278,7 @@ def download_file(url, filename, session=None, headers=None, **kwargs):  # pylin
 
                 chmodAsParent(filename)
             except Exception as error:
-                logger.warning(
-                    _("There was a problem downloading, setting permissions, or writing to {filename}. Error: {error}").format(filename=filename, error=error)
-                )
+                logger.warning(_(f"There was a problem downloading, setting permissions, or writing to {filename}. Error: {error}"))
 
     except Exception as error:
         # noinspection PyTypeChecker
@@ -1397,16 +1371,10 @@ def classname(error: Exception) -> str:
         raise requests_exception
     except requests.exceptions.SSLError as error:
         if ssl.OPENSSL_VERSION_INFO < (1, 0, 1, 5):
-            logger.info(
-                _("SSL Error requesting url: '{error.request.url}' You have {ssl.OPENSSL_VERSION}, try upgrading OpenSSL to 1.0.1e+. Error: {error}").format(
-                    error=error, ssl=ssl
-                )
-            )
+            logger.info(_(f"SSL Error requesting url: '{error.request.url}' You have {ssl.OPENSSL_VERSION}, try upgrading OpenSSL to 1.0.1e+. Error: {error}"))
         if settings.SSL_VERIFY:
             logger.info(
-                _(
-                    "SSL Error requesting url: '{error.request.url}' Try disabling Cert Verification on the advanced tab of /config/general. Error: {error}"
-                ).format(error=error)
+                _(f"SSL Error requesting url: '{error.request.url}' Try disabling Cert Verification on the advanced tab of /config/general. Error: {error}")
             )
         logger.debug(default.format(error, classname(error)))
         logger.debug(traceback.format_exc())
@@ -1429,10 +1397,10 @@ def classname(error: Exception) -> str:
         level = get_level(error)
         logger.log(level, default.format(error, classname(error)))
         if hasattr(requests_exception, "request") and requests_exception.request:
-            logger.info(_("url is {requests_exception.request.url}").format(requests_exception=requests_exception))
-            logger.info(_("headers are {requests_exception.request.headers}").format(requests_exception=requests_exception))
-            logger.info(_("params are {requests_exception.request.params}").format(requests_exception=requests_exception))
-            logger.info(_("post_data is {requests_exception.request.data}").format(requests_exception=requests_exception))
+            logger.info(_(f"url is {requests_exception.request.url}"))
+            logger.info(_(f"headers are {requests_exception.request.headers}"))
+            logger.info(_(f"params are {requests_exception.request.params}"))
+            logger.info(_(f"post_data is {requests_exception.request.data}"))
         if level == logger.WARNING:
             logger.debug(traceback.format_exc())
     except Exception as error:
@@ -1459,12 +1427,12 @@ def get_size(start_path="."):
             fp = os.path.join(dirpath, f)
             if os.path.islink(fp) and not os.path.isfile(fp):
                 log = logger.debug if settings.IGNORE_BROKEN_SYMLINKS else logger.warning
-                log(_("Unable to get size for file {fp} because the link to the file is not valid").format(fp=fp))
+                log(_(f"Unable to get size for file {fp} because the link to the file is not valid"))
                 continue
             try:
                 total_size += os.path.getsize(fp)
             except OSError as error:
-                logger.exception(_("Unable to get size for file {fp}. Error: {error}").format(fp=fp, error=error))
+                logger.exception(_(f"Unable to get size for file {fp}. Error: {error}"))
                 logger.debug(traceback.format_exc())
     return total_size
 
@@ -1533,14 +1501,12 @@ def verify_freespace(src, dest, oldfile=None, method="copy"):
     logger.debug(_("Trying to determine free space on the destination drive"))
 
     if not os.path.isfile(src):
-        logger.warning(_("A path to a file is required for the source. {src} is not a file.").format(src=src))
+        logger.warning(_(f"A path to a file is required for the source. {src} is not a file."))
         return True
 
     if not (os.path.isdir(dest) or (settings.CREATE_MISSING_SHOW_DIRS and os.path.isdir(os.path.dirname(dest)))):
         logger.warning(
-            _("A path is required for the destination. Check that the root dir and show locations are correct for {old_file_name} (I got '{dest}')").format(
-                old_file_name=oldfile[0].name, dest=dest
-            )
+            _(f"A path is required for the destination. Check that the root dir and show locations are correct for {oldfile[0].name} (I got '{dest}')")
         )
         return False
 
@@ -1557,7 +1523,7 @@ def verify_freespace(src, dest, oldfile=None, method="copy"):
         disk_free = disk_usage(dest)
     except Exception as error:
         logger.warning(_("Unable to determine free space, so I will assume there is enough."))
-        logger.debug(_("Error: {error}").format(error=error))
+        logger.debug(_(f"Error: {error}"))
         logger.debug(traceback.format_exc())
         return True
 
@@ -1577,8 +1543,8 @@ def verify_freespace(src, dest, oldfile=None, method="copy"):
     else:
         logger.warning(
             _(
-                "Not enough free space: Needed: {needed_space} bytes ( {pretty_file_size(needed_space)} ), found: {disk_free} bytes ( {pretty_file_size(disk_free)} )"
-            ).format(needed_space=needed_space, disk_free=disk_free)
+                f"Not enough free space: Needed: {needed_space} bytes ( {pretty_file_size(needed_space)} ), found: {disk_free} bytes ( {pretty_file_size(disk_free)} )"
+            )
         )
         return False
 
@@ -1594,7 +1560,7 @@ def disk_usage_hr(diskPath=None):
             free = disk_usage(diskPath)
         except Exception as error:
             logger.warning(_("Unable to determine free space"))
-            logger.debug(_("Error: {error}").format(error=error))
+            logger.debug(_(f"Error: {error}"))
             logger.debug(traceback.format_exc())
         else:
             return pretty_file_size(free)
diff --git a/sickchill/oldbeard/notifiers/libnotify.py b/sickchill/oldbeard/notifiers/libnotify.py
index 8f9b5cd5b1..6e84596926 100644
--- a/sickchill/oldbeard/notifiers/libnotify.py
+++ b/sickchill/oldbeard/notifiers/libnotify.py
@@ -55,16 +55,16 @@ def diagnose():
             try:
                 bus = dbus.SessionBus()
             except dbus.DBusException as error:
-                return ("<p>Error: unable to connect to D-Bus session bus: <code>{}</code>." "<p>Are you running SickChill in a desktop session?").format(
-                    html.escape(error)
+                return (
+                    f"<p>Error: unable to connect to D-Bus session bus: <code>{html.escape(error)}</code>." "<p>Are you running SickChill in a desktop session?"
                 )
             try:
                 bus.get_object("org.freedesktop.Notifications", "/org/freedesktop/Notifications")
             except dbus.DBusException as error:
                 return (
-                    "<p>Error: there doesn't seem to be a notification daemon available: <code>{}</code> "
+                    f"<p>Error: there doesn't seem to be a notification daemon available: <code>{html.escape(error)}</code> "
                     "<p>Try installing notification-daemon or notify-osd."
-                ).format(html.escape(error))
+                )
 
         return "<p>Error: Unable to send notification."
 
diff --git a/sickchill/oldbeard/postProcessor.py b/sickchill/oldbeard/postProcessor.py
index 2379c49ce7..cf28690147 100644
--- a/sickchill/oldbeard/postProcessor.py
+++ b/sickchill/oldbeard/postProcessor.py
@@ -119,19 +119,19 @@ def _checkForExistingFile(self, existing_file):
         if os.path.isfile(existing_file):
             # see if it's bigger than our old file
             if os.path.getsize(existing_file) > os.path.getsize(self.directory):
-                self._log(_("File {existing_file} is larger than {directory}").format(existing_file=existing_file, directory=self.directory), logger.DEBUG)
+                self._log(_(f"File {existing_file} is larger than {self.directory}"), logger.DEBUG)
                 return PostProcessor.EXISTS_LARGER
 
             elif os.path.getsize(existing_file) == os.path.getsize(self.directory):
-                self._log(_("File {existing_file} is the same size as {directory}").format(existing_file=existing_file, directory=self.directory), logger.DEBUG)
+                self._log(_(f"File {existing_file} is the same size as {self.directory}"), logger.DEBUG)
                 return PostProcessor.EXISTS_SAME
 
             else:
-                self._log(_("File {existing_file} is smaller than {directory}").format(existing_file=existing_file, directory=self.directory), logger.DEBUG)
+                self._log(_(f"File {existing_file} is smaller than {self.directory}"), logger.DEBUG)
                 return PostProcessor.EXISTS_SMALLER
 
         else:
-            self._log(_("File {existing_file} doesn't exist so there's no worries about replacing it").format(existing_file=existing_file), logger.DEBUG)
+            self._log(_(f"File {existing_file} doesn't exist so there's no worries about replacing it"), logger.DEBUG)
             return PostProcessor.DOESNT_EXIST
 
     def list_associated_files(self, file_path, subtitles_only=False, subfolders=False, rename=False):
@@ -198,29 +198,23 @@ def list_associated_files(self, file_path, subtitles_only=False, subfolders=Fals
 
         if file_path_list_to_allow or file_path_list_to_delete:
             self._log(
-                _("Found the following associated files for {file_path}: {allow_and_delete}").format(
-                    file_path=file_path, allow_and_delete=file_path_list_to_allow + file_path_list_to_delete
-                ),
+                _(f"Found the following associated files for {file_path}: {file_path_list_to_allow + file_path_list_to_delete}"),
                 logger.DEBUG,
             )
             if file_path_list_to_delete:
                 self._log(
-                    _("Deleting non-allowed associated files for {file_path}: {file_path_list_to_delete}").format(
-                        file_path=file_path, file_path_list_to_delete=file_path_list_to_delete
-                    ),
+                    _(f"Deleting non-allowed associated files for {file_path}: {file_path_list_to_delete}"),
                     logger.DEBUG,
                 )
                 # Delete all extensions the user doesn't allow
                 self._delete(file_path_list_to_delete)
             if file_path_list_to_allow:
                 self._log(
-                    _("Allowing associated files for {file_path}: {file_path_list_to_allow}").format(
-                        file_path=file_path, file_path_list_to_allow=file_path_list_to_allow
-                    ),
+                    _(f"Allowing associated files for {file_path}: {file_path_list_to_allow}"),
                     logger.DEBUG,
                 )
         else:
-            self._log(_("No associated files for {file_path} were found during this pass").format(file_path=file_path), logger.DEBUG)
+            self._log(_(f"No associated files for {file_path} were found during this pass"), logger.DEBUG)
 
         return file_path_list_to_allow
 
@@ -246,22 +240,22 @@ def _delete(self, file_path, associated_files=False):
             file_list += self.list_associated_files(file_path, subfolders=True)
 
         if not file_list:
-            self._log(_("There were no files associated with {file_path}, not deleting anything").format(file_path=file_path), logger.DEBUG)
+            self._log(_(f"There were no files associated with {file_path}, not deleting anything"), logger.DEBUG)
             return
 
         # delete the file and any other files which we want to delete
         for cur_file in file_list:
             if os.path.isfile(cur_file):
-                self._log(_("Deleting file {cur_file}").format(cur_file=cur_file), logger.DEBUG)
+                self._log(_(f"Deleting file {cur_file}"), logger.DEBUG)
                 # check first the read-only attribute
                 file_attribute = os.stat(cur_file)[0]
                 if not file_attribute & stat.S_IWRITE:
                     # File is read-only, so make it writeable
-                    self._log(_("Read only mode on file {cur_file} Will try to make it writeable").format(cur_file=cur_file), logger.DEBUG)
+                    self._log(_(f"Read only mode on file {cur_file} Will try to make it writeable"), logger.DEBUG)
                     try:
                         os.chmod(cur_file, stat.S_IWRITE)
                     except Exception:
-                        self._log(_("Cannot change permissions of {cur_file}").format(cur_file=cur_file), logger.WARNING)
+                        self._log(_(f"Cannot change permissions of {cur_file}"), logger.WARNING)
 
                 os.remove(cur_file)
 
@@ -293,7 +287,7 @@ def _combined_file_operation(self, file_path, new_path: str, new_base_name, asso
             file_list += self.list_associated_files(file_path, subtitles_only=True, subfolders=subfolders)
 
         if not file_list:
-            self._log(_("There were no files associated with {file_path}, not moving anything").format(file_path=file_path), logger.DEBUG)
+            self._log(_(f"There were no files associated with {file_path}, not moving anything"), logger.DEBUG)
             return
 
         # deal with all files
@@ -327,7 +321,7 @@ def _combined_file_operation(self, file_path, new_path: str, new_base_name, asso
                 subs_new_path = os.path.join(new_path, settings.SUBTITLES_DIR)
                 dir_exists = helpers.makeDir(subs_new_path)
                 if not dir_exists:
-                    logger.exception(_("Unable to create subtitles folder {subs_new_path}").format(subs_new_path=subs_new_path))
+                    logger.exception(_(f"Unable to create subtitles folder {subs_new_path}"))
                 else:
                     helpers.chmodAsParent(subs_new_path)
                 new_file_path = os.path.join(subs_new_path, new_filename)
@@ -347,15 +341,13 @@ def _move(self, file_path, new_path, new_base_name, associated_files=False, subt
         """
 
         def _int_move(cur_file_path, new_file_path):
-            self._log(_("Moving file from {cur_file_path} to {new_file_path}").format(cur_file_path=cur_file_path, new_file_path=new_file_path), logger.DEBUG)
+            self._log(_(f"Moving file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
             try:
                 helpers.moveFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
                 self._log(
-                    _("Unable to move file from {cur_file_path} to {new_file_path}: {error}").format(
-                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
-                    ),
+                    _(f"Unable to move file from {cur_file_path} to {new_file_path}: {error}"),
                     logger.ERROR,
                 )
                 raise
@@ -373,7 +365,7 @@ def _copy(self, file_path, new_path, new_base_name, associated_files=False, subt
         """
 
         def _int_copy(cur_file_path, new_file_path):
-            self._log(_("Copying file from {cur_file_path} to {new_file_path}").format(cur_file_path=cur_file_path, new_file_path=new_file_path), logger.DEBUG)
+            self._log(_(f"Copying file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
             try:
                 helpers.copyFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
@@ -399,9 +391,7 @@ def _hardlink(self, file_path, new_path, new_base_name, associated_files=False,
         """
 
         def _int_hard_link(cur_file_path, new_file_path):
-            self._log(
-                _("Hard linking file from {cur_file_path} to {new_file_path}").format(cur_file_path=cur_file_path, new_file_path=new_file_path), logger.DEBUG
-            )
+            self._log(_(f"Hard linking file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
             try:
                 helpers.hardlinkFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
@@ -701,7 +691,7 @@ def _find_info(self):
                     airdate = episodes[0].toordinal()
                 except AttributeError:
                     airdate_value = episodes[0]
-                    self._log(_("Could not convert to a valid airdate: {airdate_value}").format(airdate_value=airdate_value), logger.DEBUG)
+                    self._log(_(f"Could not convert to a valid airdate: {airdate_value}"), logger.DEBUG)
                     episodes = []
                     continue
 
@@ -766,7 +756,7 @@ def _get_ep_obj(self, show, season, episodes):
                 if not curEp:
                     raise EpisodeNotFoundException()
             except EpisodeNotFoundException as error:
-                self._log(_("Unable to create episode: {error}").format(error=error), logger.DEBUG)
+                self._log(_(f"Unable to create episode: {error}"), logger.DEBUG)
                 raise EpisodePostProcessingFailedException()
 
             # associate all the episodes together under a single root episode
@@ -791,7 +781,7 @@ def _get_quality(self, episode_object):
         if episode_object.status in common.Quality.SNATCHED + common.Quality.SNATCHED_PROPER + common.Quality.SNATCHED_BEST:
             ep_status_, ep_quality = common.Quality.splitCompositeStatus(episode_object.status)
             if ep_quality != common.Quality.UNKNOWN:
-                self._log(_("The old status had a quality in it, using that: ") + common.Quality.qualityStrings[ep_quality], logger.DEBUG)
+                self._log(_(f"The old status had a quality in it, using that: {common.Quality.qualityStrings[ep_quality]}"), logger.DEBUG)
                 return ep_quality
 
         # release name is the most reliable if it exists, followed by folder name and lastly file name
@@ -860,7 +850,7 @@ def _run_extra_scripts(self, episode_object):
                 )
                 out, err = p.communicate()
 
-                self._log(_("Script result: {out}").format(out=(out or err).strip()), logger.DEBUG)
+                self._log(_(f"Script result: {(out or err).strip()}"), logger.DEBUG)
 
             except Exception as error:
                 self._log(f"Unable to run extra_script: {error}")
@@ -917,19 +907,19 @@ def process(self):
         :return: True on success, False on failure
         """
 
-        self._log(_("Processing {directory} ({release_name})").format(directory=self.directory, release_name=self.release_name))
+        self._log(_(f"Processing {self.directory} ({self.release_name})"))
 
         if os.path.isdir(self.directory):
-            self._log(_("File {directory} seems to be a directory").format(directory=self.directory))
+            self._log(_(f"File {self.directory} seems to be a directory"))
             return False
 
         if not os.path.exists(self.directory):
-            self._log(_("File {directory} doesn't exist, did unrar fail?").format(directory=self.directory))
+            self._log(_(f"File {self.directory} doesn't exist, did unrar fail?"))
             return False
 
         for ignore_file in self.IGNORED_FILESTRINGS:
             if ignore_file in self.directory:
-                self._log(_("File {directory} is ignored type, skipping").format(directory=self.directory))
+                self._log(_(f"File {self.directory} is ignored type, skipping"))
                 return False
 
         # reset per-file stuff
@@ -953,21 +943,21 @@ def process(self):
 
         # get the quality of the episode we're processing
         if quality and not common.Quality.qualityStrings[quality] == "Unknown":
-            self._log(_("Snatch history had a quality in it, using that: ") + common.Quality.qualityStrings[quality], logger.DEBUG)
+            self._log(_(f"Snatch history had a quality in it, using that: {common.Quality.qualityStrings[quality]}"), logger.DEBUG)
             new_ep_quality = quality
         else:
             new_ep_quality = self._get_quality(episode_object)
 
         new_quality_string = common.Quality.qualityStrings[new_ep_quality]
-        logger.debug(_("Quality of the episode we're processing: {new_quality_string}").format(new_quality_string=new_quality_string))
+        logger.debug(_(f"Quality of the episode we're processing: {new_quality_string}"))
 
         # see if this is a priority download (is it snatched, in history, PROPER, or BEST)
         priority_download = self._is_priority(episode_object, new_ep_quality)
-        self._log(_("Is ep a priority download: ") + str(priority_download), logger.DEBUG)
+        self._log(_(f"Is ep a priority download: {str(priority_download)}"), logger.DEBUG)
 
         # get the version of the episode we're processing
         if version:
-            self._log(_("Snatch history had a version in it, using that: v") + str(version), logger.DEBUG)
+            self._log(_(f"Snatch history had a version in it, using that: v{str(version)}"), logger.DEBUG)
             new_ep_version = version
         else:
             new_ep_version = -1
@@ -1061,7 +1051,7 @@ def process(self):
                 # do the library update for synoindex
                 notifiers.synoindex_notifier.addFolder(episode_object.show.get_location)
             except (OSError, IOError):
-                raise EpisodePostProcessingFailedException(_("Unable to create the show directory: ") + episode_object.show.get_location)
+                raise EpisodePostProcessingFailedException(_(f"Unable to create the show directory: {episode_object.show.get_location}"))
 
             # get metadata for the show (but not episode because it hasn't been fully processed)
             episode_object.show.write_metadata(True)
@@ -1072,11 +1062,11 @@ def process(self):
         for cur_ep in [episode_object] + episode_object.related_episodes:
             with cur_ep.lock:
                 if self.release_name:
-                    self._log(_("Found release name ") + self.release_name, logger.DEBUG)
+                    self._log(_(f"Found release name: {self.release_name}"), logger.DEBUG)
                     cur_ep.release_name = self.release_name
                 elif self.filename:
                     # If we can't get the release name we expect, save the original release name instead
-                    self._log(_("Using original release name ") + self.filename, logger.DEBUG)
+                    self._log(_(f"Using original release name: {self.filename}"), logger.DEBUG)
                     cur_ep.release_name = self.filename
                 else:
                     cur_ep.release_name = ""
@@ -1116,7 +1106,7 @@ def process(self):
         except ShowDirectoryNotFoundException:
             raise EpisodePostProcessingFailedException(_("Unable to post-process an episode if the show dir doesn't exist, quitting"))
 
-        self._log(_("Destination folder for this episode: ") + dest_path, logger.DEBUG)
+        self._log(_(f"Destination folder for this episode: {dest_path}"), logger.DEBUG)
 
         # create any folders we need
         helpers.make_dirs(dest_path)
diff --git a/sickchill/oldbeard/providers/norbits.py b/sickchill/oldbeard/providers/norbits.py
index c9418d7b98..fc4cb6a7e3 100644
--- a/sickchill/oldbeard/providers/norbits.py
+++ b/sickchill/oldbeard/providers/norbits.py
@@ -27,7 +27,7 @@ def __init__(self):
 
     def _check_auth(self):
         if not self.username or not self.passkey:
-            raise AuthException(("Your authentication credentials for {} are " "missing, check your config.").format(self.name))
+            raise AuthException(f"Your authentication credentials for {self.name} are missing, check your config.")
 
         return True
 

From 212444f2428479404dfcc3829a15c909710819d9 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 17:42:45 +0700
Subject: [PATCH 22/29] fstring logs 2

---
 sickchill/oldbeard/notifiers/libnotify.py |  9 +--
 sickchill/oldbeard/postProcessor.py       | 81 +++++------------------
 2 files changed, 17 insertions(+), 73 deletions(-)

diff --git a/sickchill/oldbeard/notifiers/libnotify.py b/sickchill/oldbeard/notifiers/libnotify.py
index 6e84596926..1a0a9b67ad 100644
--- a/sickchill/oldbeard/notifiers/libnotify.py
+++ b/sickchill/oldbeard/notifiers/libnotify.py
@@ -55,16 +55,11 @@ def diagnose():
             try:
                 bus = dbus.SessionBus()
             except dbus.DBusException as error:
-                return (
-                    f"<p>Error: unable to connect to D-Bus session bus: <code>{html.escape(error)}</code>." "<p>Are you running SickChill in a desktop session?"
-                )
+                return f"<p>Error: unable to connect to D-Bus session bus: <code>{html.escape(error)}</code>.<p>Are you running SickChill in a desktop session?"
             try:
                 bus.get_object("org.freedesktop.Notifications", "/org/freedesktop/Notifications")
             except dbus.DBusException as error:
-                return (
-                    f"<p>Error: there doesn't seem to be a notification daemon available: <code>{html.escape(error)}</code> "
-                    "<p>Try installing notification-daemon or notify-osd."
-                )
+                return f"<p>Error: there doesn't seem to be a notification daemon available: <code>{html.escape(error)}</code>.<p>Try installing notification-daemon or notify-osd."
 
         return "<p>Error: Unable to send notification."
 
diff --git a/sickchill/oldbeard/postProcessor.py b/sickchill/oldbeard/postProcessor.py
index cf28690147..aba5869ed6 100644
--- a/sickchill/oldbeard/postProcessor.py
+++ b/sickchill/oldbeard/postProcessor.py
@@ -101,9 +101,7 @@ def _checkForExistingFile(self, existing_file):
         """
         Checks if a file exists already and if it does whether it's bigger or smaller than
         the file we are post-processing
-
-        ;param existing_file: The file to compare to
-
+        :param existing_file: The file to compare to
         :return:
             DOESNT_EXIST if the file doesn't exist
             EXISTS_LARGER if the file exists and is larger than the file we are post processing
@@ -197,22 +195,13 @@ def list_associated_files(self, file_path, subtitles_only=False, subfolders=Fals
                     file_path_list_to_delete.append(associated_file_path)
 
         if file_path_list_to_allow or file_path_list_to_delete:
-            self._log(
-                _(f"Found the following associated files for {file_path}: {file_path_list_to_allow + file_path_list_to_delete}"),
-                logger.DEBUG,
-            )
+            self._log(_(f"Found the following associated files for {file_path}: {file_path_list_to_allow + file_path_list_to_delete}"), logger.DEBUG)
             if file_path_list_to_delete:
-                self._log(
-                    _(f"Deleting non-allowed associated files for {file_path}: {file_path_list_to_delete}"),
-                    logger.DEBUG,
-                )
+                self._log(_(f"Deleting non-allowed associated files for {file_path}: {file_path_list_to_delete}"), logger.DEBUG)
                 # Delete all extensions the user doesn't allow
                 self._delete(file_path_list_to_delete)
             if file_path_list_to_allow:
-                self._log(
-                    _(f"Allowing associated files for {file_path}: {file_path_list_to_allow}"),
-                    logger.DEBUG,
-                )
+                self._log(_(f"Allowing associated files for {file_path}: {file_path_list_to_allow}"), logger.DEBUG)
         else:
             self._log(_(f"No associated files for {file_path} were found during this pass"), logger.DEBUG)
 
@@ -346,10 +335,7 @@ def _int_move(cur_file_path, new_file_path):
                 helpers.moveFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(
-                    _(f"Unable to move file from {cur_file_path} to {new_file_path}: {error}"),
-                    logger.ERROR,
-                )
+                self._log(_(f"Unable to move file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_move, subtitles=subtitles)
@@ -370,12 +356,7 @@ def _int_copy(cur_file_path, new_file_path):
                 helpers.copyFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(
-                    _("Unable to copy file from {cur_file_path} to {new_file_path}: {error}").format(
-                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
-                    ),
-                    logger.ERROR,
-                )
+                self._log(_(f"Unable to copy file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_copy, subtitles=subtitles)
@@ -396,12 +377,7 @@ def _int_hard_link(cur_file_path, new_file_path):
                 helpers.hardlinkFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(
-                    _("Unable to link file from {cur_file_path} to {new_file_path}: {error}").format(
-                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
-                    ),
-                    logger.ERROR,
-                )
+                self._log(_(f"Unable to link file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_hard_link, subtitles=subtitles)
@@ -417,22 +393,12 @@ def _move_and_symlink(self, file_path, new_path, new_base_name, associated_files
         """
 
         def _int_move_and_sym_link(cur_file_path, new_file_path):
-            self._log(
-                _("Moving then symbolically linking file from {cur_file_path} to {new_file_path}").format(
-                    cur_file_path=cur_file_path, new_file_path=new_file_path
-                ),
-                logger.DEBUG,
-            )
+            self._log(_(f"Moving then symbolically linking file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
             try:
                 helpers.moveAndSymlinkFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(
-                    _("Unable to link file from {cur_file_path} to {new_file_path}: {error}").format(
-                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
-                    ),
-                    logger.ERROR,
-                )
+                self._log(_(f"Unable to link file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_move_and_sym_link, subtitles=subtitles)
@@ -448,22 +414,12 @@ def _symlink(self, file_path, new_path, new_base_name, associated_files=False, s
         """
 
         def _int_sym_link(cur_file_path, new_file_path):
-            self._log(
-                _("Creating then symbolically linking file from {new_file_path} to {cur_file_path}").format(
-                    cur_file_path=cur_file_path, new_file_path=new_file_path
-                ),
-                logger.DEBUG,
-            )
+            self._log(_(f"Creating then symbolically linking file from {new_file_path} to {cur_file_path}"), logger.DEBUG)
             try:
                 os.symlink(cur_file_path, new_file_path)
                 helpers.chmodAsParent(cur_file_path)
             except (IOError, OSError) as error:
-                self._log(
-                    _("Unable to link file {cur_file_path} to {new_file_path}: {error}").format(
-                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
-                    ),
-                    logger.ERROR,
-                )
+                self._log(_(f"Unable to link file {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_sym_link, subtitles=subtitles)
@@ -519,12 +475,7 @@ def _history_lookup(self):
 
             qual_str = common.Quality.qualityStrings[quality] if quality is not None else quality
             result_name = show.name if show else "UNDEFINED"
-            self._log(
-                _("Found result in history for {result_name} - Season: {season} - Quality: {qual_str} - Version: {version}").format(
-                    result_name=result_name, season=season, qual_str=qual_str, version=version
-                ),
-                logger.DEBUG,
-            )
+            self._log(_(f"Found result in history for {result_name} - Season: {season} - Quality: {qual_str} - Version: {version}"), logger.DEBUG)
 
             return to_return
 
@@ -1001,10 +952,8 @@ def process(self):
                 if int(episode_season) > newest_season:
                     self._log(
                         _(
-                            "File has season {episode_season}, while the indexer is on season {newest_season}. "
-                            "Try forcing a full update on the show and process this file again. "
-                            "The file may be incorrectly labeled or fake, aborting."
-                        ).format(episode_season=episode_season, newest_season_num=newest_season)
+                            f"File has season {episode_season}, while the indexer is on season {newest_season}. Try forcing a full update on the show and process this file again. The file may be incorrectly labeled or fake, aborting."
+                        )
                     )
                     return False
 
@@ -1151,7 +1100,7 @@ def process(self):
                     self.directory, dest_path, new_base_name, settings.MOVE_ASSOCIATED_FILES, settings.USE_SUBTITLES and episode_object.show.subtitles
                 )
             else:
-                logger.exception(_("Unknown process method: ") + str(self.process_method))
+                logger.exception(_(f"Unknown process method: {str(self.process_method)}"))
                 raise EpisodePostProcessingFailedException(_("Unable to move the files to their new home"))
         except (OSError, IOError):
             raise EpisodePostProcessingFailedException(_("Unable to move the files to their new home"))

From dacdd68c7f67bd874579f2c0dc6f2b2310550397 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 17:58:31 +0700
Subject: [PATCH 23/29] wordle

---
 sickchill/views/home.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sickchill/views/home.py b/sickchill/views/home.py
index 28e1ab6117..ac8b518f9e 100644
--- a/sickchill/views/home.py
+++ b/sickchill/views/home.py
@@ -1645,7 +1645,7 @@ def manual_search_show_releases(self):
         # show_object: TVShow = Show.find(settings.showList, show)
         # sickchill.oldbeard.search.search_providers(
         #     show_object,
-        #     show_object.getEpisode(season=season, episode=episode or 1),
+        #     show_object.get_episode(season=season, episode=episode or 1),
         #     downCurQuality=True,
         #     manual=True,
         #     manual_snatch=('season', 'episode')[episode is not None]

From 140482a692ed70db62f5f137b596f793e9ac4c1e Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 19:54:23 +0700
Subject: [PATCH 24/29] remove show get*

---
 sickchill/gui/slick/js/core.js | 2 +-
 sickchill/views/home.py        | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/sickchill/gui/slick/js/core.js b/sickchill/gui/slick/js/core.js
index 89d2b87f43..7ee067ee3e 100644
--- a/sickchill/gui/slick/js/core.js
+++ b/sickchill/gui/slick/js/core.js
@@ -137,7 +137,7 @@ const SICKCHILL = {
                     + '<input type="checkbox" id="deleteFiles" name="deleteFiles"/>&nbsp;'
                     + '<label for="deleteFiles" class="red-text">Check to delete files as well. IRREVERSIBLE</label>',
                 confirm(event) {
-                    location.href = event.context.href + ($('#deleteFiles')[0].checked ? '&full=1' : '');
+                    location.href = event.context.href + ($('#deleteFiles')[0].checked ? '&full=1' : '&full=0');
                 },
             });
 
diff --git a/sickchill/views/home.py b/sickchill/views/home.py
index ac8b518f9e..ba25f5041a 100644
--- a/sickchill/views/home.py
+++ b/sickchill/views/home.py
@@ -1299,7 +1299,9 @@ def togglePause(self, show=None):
 
         return self.redirect(f"/home/displayShow?show={show.indexerid}")
 
-    def deleteShow(self, show=None, full=0):
+    def deleteShow(self):
+        show = self.get_query_argument("show")
+        full = int(self.get_query_argument("full"))
         if show:
             error, show = Show.delete(show, full)
 

From 8e44069c472ee3b5cea3c8e3655014bdef0bd208 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 20:19:32 +0700
Subject: [PATCH 25/29] snaking vars

---
 sickchill/gui/slick/views/displayShow.mako | 28 +++++-----
 sickchill/gui/slick/views/home.mako        | 18 +++---
 sickchill/views/api/webapi.py              |  6 +-
 sickchill/views/config/backup.py           | 26 ++++-----
 sickchill/views/home.py                    | 64 +++++++++++-----------
 5 files changed, 71 insertions(+), 71 deletions(-)

diff --git a/sickchill/gui/slick/views/displayShow.mako b/sickchill/gui/slick/views/displayShow.mako
index 21612f446c..2196d022b5 100644
--- a/sickchill/gui/slick/views/displayShow.mako
+++ b/sickchill/gui/slick/views/displayShow.mako
@@ -36,14 +36,14 @@
                                 <span id="prevShow" class="displayshow-icon-left" title="${_('Prev Show')}"></span>
                             </div>
                             <select id="pickShow" class="form-control input-sm" title="Change Show">
-                                % for curShowList in sortedShowLists:
-                                    % if len(sortedShowLists) > 1:
-                                        <optgroup label="${curShowList[0]}">
+                                % for cur_show_list in sorted_show_lists:
+                                    % if len(sorted_show_lists) > 1:
+                                        <optgroup label="${cur_show_list[0]}">
                                     % endif
-                                    % for curShow in curShowList[1]:
+                                    % for curShow in cur_show_list[1]:
                                         <option value="${curShow.indexerid}" ${selected(curShow == show)}>${curShow.name}</option>
                                     % endfor
-                                    % if len(sortedShowLists) > 1:
+                                    % if len(sorted_show_lists) > 1:
                                         </optgroup>
                                     % endif
                                 % endfor
@@ -213,15 +213,15 @@
                                                 <td class="showLegend">${_('Default EP Status')}: </td>
                                                 <td>${statusStrings[show.default_ep_status]}</td>
                                             </tr>
-                                            % if showLoc[1]:
+                                            % if show_location[1]:
                                                 <tr>
                                                     <td class="showLegend">${_('Location')}: </td>
-                                                    <td>${showLoc[0]}</td>
+                                                    <td>${show_location[0]}</td>
                                                 </tr>
                                             % else:
                                                 <tr>
                                                     <td class="showLegend"><span style="color: red;">${_('Location')}: </span></td>
-                                                    <td><span style="color: red;">${showLoc[0]}</span> (${_('Missing')})</td>
+                                                    <td><span style="color: red;">${show_location[0]}</span> (${_('Missing')})</td>
                                                 </tr>
                                             % endif
                                             <tr>
@@ -263,7 +263,7 @@
                                             % endif
                                             <tr>
                                                 <td class="showLegend">${_('Size')}:</td>
-                                                <td>${pretty_file_size(helpers.get_size(showLoc[0]))}</td>
+                                                <td>${pretty_file_size(helpers.get_size(show_location[0]))}</td>
                                             </tr>
                                         </table>
                                     </div>
@@ -325,11 +325,11 @@
                 <div class="col-lg-8 col-md-8 col-sm-12 col-xs-12 pull-right">
                     <div class="pull-right" id="checkboxControls">
                         <div style="padding-bottom: 5px;">
-                            <% total_snatched = epCounts[Overview.SNATCHED] + epCounts[Overview.SNATCHED_PROPER] + epCounts[Overview.SNATCHED_BEST] %>
-                            <label class="pull-right" for="wanted"><span class="wanted"><input type="checkbox" id="wanted" checked="checked" /> ${_('Wanted')}: <b>${epCounts[Overview.WANTED]}</b></span></label>
-                            <label class="pull-right" for="qual"><span class="qual"><input type="checkbox" id="qual" checked="checked" /> ${_('Allowed')}: <b>${epCounts[Overview.QUAL]}</b></span></label>
-                            <label class="pull-right" for="good"><span class="good"><input type="checkbox" id="good" checked="checked" /> ${_('Preferred')}: <b>${epCounts[Overview.GOOD]}</b></span></label>
-                            <label class="pull-right" for="skipped"><span class="skipped"><input type="checkbox" id="skipped" checked="checked" /> ${_('Skipped')}: <b>${epCounts[Overview.SKIPPED]}</b></span></label>
+                            <% total_snatched = ep_counts[Overview.SNATCHED] + ep_counts[Overview.SNATCHED_PROPER] + ep_counts[Overview.SNATCHED_BEST] %>
+                            <label class="pull-right" for="wanted"><span class="wanted"><input type="checkbox" id="wanted" checked="checked" /> ${_('Wanted')}: <b>${ep_counts[Overview.WANTED]}</b></span></label>
+                            <label class="pull-right" for="qual"><span class="qual"><input type="checkbox" id="qual" checked="checked" /> ${_('Allowed')}: <b>${ep_counts[Overview.QUAL]}</b></span></label>
+                            <label class="pull-right" for="good"><span class="good"><input type="checkbox" id="good" checked="checked" /> ${_('Preferred')}: <b>${ep_counts[Overview.GOOD]}</b></span></label>
+                            <label class="pull-right" for="skipped"><span class="skipped"><input type="checkbox" id="skipped" checked="checked" /> ${_('Skipped')}: <b>${ep_counts[Overview.SKIPPED]}</b></span></label>
                             <label class="pull-right" for="snatched"><span class="snatched"><input type="checkbox" id="snatched" checked="checked" /> ${_('Snatched')}: <b>${total_snatched}</b></span></label>
                         </div>
                         <div class="clearfix"></div>
diff --git a/sickchill/gui/slick/views/home.mako b/sickchill/gui/slick/views/home.mako
index 788b0b1b93..306be3944a 100644
--- a/sickchill/gui/slick/views/home.mako
+++ b/sickchill/gui/slick/views/home.mako
@@ -16,18 +16,18 @@
         <div id="showTabs">
             <!-- Nav tabs -->
             <ul>
-                % for curShowlist in sortedShowLists:
-                    % if curShowlist[1]:
-                        <li><a href="#${curShowlist[0].lower()}TabContent" id="${curShowlist[0].lower()}Tab">${curShowlist[0]}</a></li>
+                % for cur_show_list in sorted_show_lists:
+                    % if cur_show_list[1]:
+                        <li><a href="#${cur_show_list[0].lower()}TabContent" id="${cur_show_list[0].lower()}Tab">${cur_show_list[0]}</a></li>
                     % endif
                 % endfor
             </ul>
             <!-- Tab panes -->
         <div>
         % endif
-        % for curShowlist in sortedShowLists:
-            % if curShowlist[1]:
-            <% curListType = curShowlist[0] %>
+        % for cur_show_list in sorted_show_lists:
+            % if cur_show_list[1]:
+            <% curListType = cur_show_list[0] %>
                 <div id=${("showsTabContent", "animeTabContent")[curListType == "Anime"]}>
                     <div class="row home-container">
                         <div class="col-md-12">
@@ -39,7 +39,7 @@
                             % endif
                             <div class="row">
                                 <div class="col-md-12">
-                                        <%include file="/inc_home_show_list.mako" args="curListType=curListType, myShowList=curShowlist[1]" />
+                                        <%include file="/inc_home_show_list.mako" args="curListType=curListType, myShowList=cur_show_list[1]" />
                                 </div>
                             </div>
                         </div>
@@ -58,10 +58,10 @@
                 % if settings.HOME_LAYOUT == 'poster':
                     <div class="loading-spinner"></div>
                 % endif
-                % for curShowlist in sortedShowLists:
+                % for cur_show_list in sorted_show_lists:
                     <div class="row">
                         <div class="col-md-12">
-                                <%include file="/inc_home_show_list.mako" args="curListType=curShowlist[0], myShowList=curShowlist[1]" />
+                                <%include file="/inc_home_show_list.mako" args="curListType=cur_show_list[0], myShowList=cur_show_list[1]" />
                         </div>
                     </div>
                 % endfor
diff --git a/sickchill/views/api/webapi.py b/sickchill/views/api/webapi.py
index 259d896fc2..435e1a4655 100644
--- a/sickchill/views/api/webapi.py
+++ b/sickchill/views/api/webapi.py
@@ -1226,10 +1226,10 @@ def run(self):
                 [curShow.indexerid],
             )
 
-            for curResult in sql_results:
-                cur_ep_cat = curShow.get_overview(curResult["status"])
+            for cur_result in sql_results:
+                cur_ep_cat = curShow.get_overview(cur_result["status"])
                 if cur_ep_cat and cur_ep_cat in (Overview.WANTED, Overview.QUAL):
-                    show_eps.append(curResult)
+                    show_eps.append(cur_result)
 
             if show_eps:
                 shows.append({"indexerid": curShow.indexerid, "show_name": curShow.name, "status": curShow.status, "episodes": show_eps})
diff --git a/sickchill/views/config/backup.py b/sickchill/views/config/backup.py
index 6fb5f15f85..65a442c252 100644
--- a/sickchill/views/config/backup.py
+++ b/sickchill/views/config/backup.py
@@ -28,7 +28,7 @@ def index(self):
 
     @staticmethod
     def backup(backupDir=None):
-        finalResult = ""
+        final_result = ""
 
         if backupDir:
             source = [
@@ -47,32 +47,32 @@ def backup(backupDir=None):
                     source.append(os.path.join(path, filename))
 
             if helpers.backup_config_zip(source, target, settings.DATA_DIR):
-                finalResult += "Successful backup to " + target
+                final_result += "Successful backup to " + target
             else:
-                finalResult += "Backup FAILED"
+                final_result += "Backup FAILED"
         else:
-            finalResult += "You need to choose a folder to save your backup to!"
+            final_result += "You need to choose a folder to save your backup to!"
 
-        finalResult += "<br>\n"
+        final_result += "<br>\n"
 
-        return finalResult
+        return final_result
 
     @staticmethod
     def restore(backupFile=None):
-        finalResult = ""
+        final_result = ""
 
         if backupFile:
             source = backupFile
             target_dir = os.path.join(settings.DATA_DIR, "restore")
 
             if helpers.restore_config_zip(source, target_dir):
-                finalResult += "Successfully extracted restore files to " + target_dir
-                finalResult += "<br>Restart sickchill to complete the restore."
+                final_result += "Successfully extracted restore files to " + target_dir
+                final_result += "<br>Restart sickchill to complete the restore."
             else:
-                finalResult += "Restore FAILED"
+                final_result += "Restore FAILED"
         else:
-            finalResult += "You need to select a backup file to restore!"
+            final_result += "You need to select a backup file to restore!"
 
-        finalResult += "<br>\n"
+        final_result += "<br>\n"
 
-        return finalResult
+        return final_result
diff --git a/sickchill/views/home.py b/sickchill/views/home.py
index ba25f5041a..3ab7c03628 100644
--- a/sickchill/views/home.py
+++ b/sickchill/views/home.py
@@ -100,7 +100,7 @@ def index(self):
                     else:
                         shows.append(show)
 
-            sortedShowLists = [
+            sorted_show_lists = [
                 ["Shows", sorted(shows, key=lambda mbr: attrgetter("sort_name")(mbr))],
                 ["Anime", sorted(anime, key=lambda mbr: attrgetter("sort_name")(mbr))],
             ]
@@ -111,14 +111,14 @@ def index(self):
                 if selected_root_dir in show.get_location:
                     shows.append(show)
 
-            sortedShowLists = [["Shows", sorted(shows, key=lambda mbr: attrgetter("sort_name")(mbr))]]
+            sorted_show_lists = [["Shows", sorted(shows, key=lambda mbr: attrgetter("sort_name")(mbr))]]
 
         stats = self.show_statistics()
         return t.render(
             title=_("Home"),
             header=_("Show List"),
             topmenu="home",
-            sortedShowLists=sortedShowLists,
+            sorted_show_lists=sorted_show_lists,
             show_stat=stats[0],
             max_download_count=stats[1],
             controller="home",
@@ -445,18 +445,18 @@ def testPHT(self):
         host = config.clean_hosts(self.get_query_argument("host"))
         password = filters.unhide(settings.PLEX_CLIENT_PASSWORD, self.get_query_argument("password"))
 
-        finalResult = ""
-        for curHost in [x.strip() for x in host.split(",")]:
-            curResult = notifiers.plex_notifier.test_notify_pht(unquote_plus(curHost), username, password)
-            if len(curResult.split(":")) > 2 and "OK" in curResult.split(":")[2]:
-                finalResult += _("Successful test notice sent to Plex Home Theater ... {plex_clients}").format(plex_clients=unquote_plus(curHost))
+        final_result = ""
+        for cur_host in [x.strip() for x in host.split(",")]:
+            cur_result = notifiers.plex_notifier.test_notify_pht(unquote_plus(cur_host), username, password)
+            if len(cur_result.split(":")) > 2 and "OK" in cur_result.split(":")[2]:
+                final_result += _("Successful test notice sent to Plex Home Theater ... {plex_clients}").format(plex_clients=unquote_plus(cur_host))
             else:
-                finalResult += _("Test failed for Plex Home Theater ... {plex_clients}").format(plex_clients=unquote_plus(curHost))
-            finalResult += "<br>" + "\n"
+                final_result += _("Test failed for Plex Home Theater ... {plex_clients}").format(plex_clients=unquote_plus(cur_host))
+            final_result += "<br>" + "\n"
 
         ui.notifications.message(_("Tested Plex Home Theater(s)") + ":", unquote_plus(host.replace(",", ", ")))
 
-        return finalResult
+        return final_result
 
     def testPMS(self):
         self.set_header("Cache-Control", "max-age=0,no-cache,no-store")
@@ -466,20 +466,20 @@ def testPMS(self):
         password = filters.unhide(settings.PLEX_SERVER_PASSWORD, self.get_query_argument("password"))
         plex_server_token = self.get_query_argument("plex_server_token")
 
-        finalResult = ""
+        final_result = ""
 
-        curResult = notifiers.plex_notifier.test_notify_pms(unquote_plus(host), username, password, plex_server_token)
-        if curResult is None:
-            finalResult += _("Successful test of Plex Media Server(s) ... {plex_servers}").format(plex_servers=unquote_plus(host.replace(",", ", ")))
-        elif curResult is False:
-            finalResult += _("Test failed, No Plex Media Server host specified")
+        cur_result = notifiers.plex_notifier.test_notify_pms(unquote_plus(host), username, password, plex_server_token)
+        if cur_result is None:
+            final_result += _("Successful test of Plex Media Server(s) ... {plex_servers}").format(plex_servers=unquote_plus(host.replace(",", ", ")))
+        elif cur_result is False:
+            final_result += _("Test failed, No Plex Media Server host specified")
         else:
-            finalResult += _("Test failed for Plex Media Server(s) ... {plex_servers}").format(plex_servers=unquote_plus(str(curResult).replace(",", ", ")))
-        finalResult += "<br>" + "\n"
+            final_result += _("Test failed for Plex Media Server(s) ... {plex_servers}").format(plex_servers=unquote_plus(str(cur_result).replace(",", ", ")))
+        final_result += "<br>" + "\n"
 
         ui.notifications.message(_("Tested Plex Media Server host(s)") + ":", unquote_plus(host.replace(",", ", ")))
 
-        return finalResult
+        return final_result
 
     @staticmethod
     def testLibnotify():
@@ -784,9 +784,9 @@ def displayShow(self):
         submenu = [{"title": _("Edit"), "path": f"home/editShow?show={show_obj.indexerid}", "icon": "fa fa-pencil"}]
 
         try:
-            showLoc = (show_obj.location, True)
+            show_location = (show_obj.location, True)
         except ShowDirectoryNotFoundException:
-            showLoc = (show_obj.get_location, False)
+            show_location = (show_obj.get_location, False)
 
         show_message = ""
 
@@ -877,7 +877,7 @@ def displayShow(self):
                     # noinspection PyPep8
                     submenu.append({"title": _("Download Subtitles"), "path": f"home/subtitleShow?show={show_obj.indexerid}", "icon": "fa fa-language"})
 
-        epCounts = {
+        ep_counts = {
             Overview.SKIPPED: 0,
             Overview.WANTED: 0,
             Overview.QUAL: 0,
@@ -889,11 +889,11 @@ def displayShow(self):
         }
         epCats = {}
 
-        for curResult in sql_results:
-            curEpCat = show_obj.get_overview(curResult["status"])
+        for cur_result in sql_results:
+            curEpCat = show_obj.get_overview(cur_result["status"])
             if curEpCat:
-                epCats[str(curResult["season"]) + "x" + str(curResult["episode"])] = curEpCat
-                epCounts[curEpCat] += 1
+                epCats[str(cur_result["season"]) + "x" + str(cur_result["episode"])] = curEpCat
+                ep_counts[curEpCat] += 1
 
         if settings.ANIME_SPLIT_HOME:
             shows = []
@@ -903,12 +903,12 @@ def displayShow(self):
                     anime.append(show)
                 else:
                     shows.append(show)
-            sortedShowLists = [
+            sorted_show_lists = [
                 ["Shows", sorted(shows, key=lambda mbr: attrgetter("sort_name")(mbr))],
                 ["Anime", sorted(anime, key=lambda mbr: attrgetter("sort_name")(mbr))],
             ]
         else:
-            sortedShowLists = [["Shows", sorted(settings.showList, key=lambda mbr: attrgetter("sort_name")(mbr))]]
+            sorted_show_lists = [["Shows", sorted(settings.showList, key=lambda mbr: attrgetter("sort_name")(mbr))]]
 
         bwl = None
         if show_obj.is_anime:
@@ -938,14 +938,14 @@ def displayShow(self):
 
         return t.render(
             submenu=submenu,
-            showLoc=showLoc,
+            show_location=show_location,
             show_message=show_message,
             show=show_obj,
             sql_results=sql_results,
             seasonResults=seasonResults,
-            sortedShowLists=sortedShowLists,
+            sorted_show_lists=sorted_show_lists,
             bwl=bwl,
-            epCounts=epCounts,
+            ep_counts=ep_counts,
             epCats=epCats,
             all_scene_exceptions=show_obj.exceptions,
             scene_numbering=get_scene_numbering_for_show(indexerid, indexer),

From 735ea0ae1467929a48f6f761e3fd0d1aca09caf2 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 20:30:33 +0700
Subject: [PATCH 26/29] home unused var removal

---
 sickchill/views/home.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sickchill/views/home.py b/sickchill/views/home.py
index 3ab7c03628..8916c1041b 100644
--- a/sickchill/views/home.py
+++ b/sickchill/views/home.py
@@ -722,7 +722,7 @@ def updateCheck(self):
 
         return self.redirect("/" + settings.DEFAULT_PAGE + "/")
 
-    def update(self, pid, branch=None):
+    def update(self, pid):
         if settings.DISABLE_UPDATER or str(pid) != str(settings.PID):
             return self.redirect("/" + settings.DEFAULT_PAGE + "/")
 
@@ -1681,7 +1681,7 @@ def manual_search_show_releases(self):
             submenu=submenu, title=_("Manual Snatch"), header=_("Manual Snatch"), controller="home", action="manual_search_show_releases", results=results
         )
 
-    def manual_snatch_show_release(self, *args, **kwargs):
+    def manual_snatch_show_release(self):
         url = self.get_body_argument("url")
         show = self.get_body_argument("show")
 

From 0fb6c6bd32412dbb992aa0a60c1952d644b946d4 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 20:39:46 +0700
Subject: [PATCH 27/29] t.render layout

---
 sickchill/views/changelog.py              |  9 ++++-
 sickchill/views/config/anime.py           |  9 ++++-
 sickchill/views/config/providers.py       |  7 +++-
 sickchill/views/config/search.py          |  7 +++-
 sickchill/views/config/subtitles.py       |  7 +++-
 sickchill/views/home.py                   | 42 ++++++++++++++++++++---
 sickchill/views/index.py                  |  9 ++++-
 sickchill/views/manage/add_shows.py       |  8 ++++-
 sickchill/views/manage/index.py           |  8 ++++-
 sickchill/views/manage/post_processing.py |  8 ++++-
 sickchill/views/movies.py                 | 28 +++++++++++++--
 sickchill/views/news.py                   |  9 ++++-
 12 files changed, 133 insertions(+), 18 deletions(-)

diff --git a/sickchill/views/changelog.py b/sickchill/views/changelog.py
index edf4700788..dd3529f742 100644
--- a/sickchill/views/changelog.py
+++ b/sickchill/views/changelog.py
@@ -21,4 +21,11 @@ def index(self, *args, **kwargs):
         t = PageTemplate(rh=self, filename="markdown.mako")
         data = markdown2.markdown(changes if changes else _("The was a problem connecting to github, please refresh and try again"), extras=["header-ids"])
 
-        return t.render(title=_("Changelog"), header=_("Changelog"), topmenu="system", data=data, controller="changes", action="index")
+        return t.render(
+            title=_("Changelog"),
+            header=_("Changelog"),
+            topmenu="system",
+            data=data,
+            controller="changes",
+            action="index",
+        )
diff --git a/sickchill/views/config/anime.py b/sickchill/views/config/anime.py
index 6a63fbf06c..4ba497104d 100644
--- a/sickchill/views/config/anime.py
+++ b/sickchill/views/config/anime.py
@@ -17,7 +17,14 @@ class ConfigAnime(Config):
     def index(self):
         t = PageTemplate(rh=self, filename="config_anime.mako")
 
-        return t.render(submenu=self.ConfigMenu(), title=_("Config - Anime"), header=_("Anime"), topmenu="config", controller="config", action="anime")
+        return t.render(
+            submenu=self.ConfigMenu(),
+            title=_("Config - Anime"),
+            header=_("Anime"),
+            topmenu="config",
+            controller="config",
+            action="anime",
+        )
 
     def saveAnime(self, use_anidb=None, anidb_username=None, anidb_password=None, anidb_use_mylist=None, split_home=None, split_home_in_tabs=None):
         settings.USE_ANIDB = config.checkbox_to_value(use_anidb)
diff --git a/sickchill/views/config/providers.py b/sickchill/views/config/providers.py
index 0d6567454c..0f8be8f929 100644
--- a/sickchill/views/config/providers.py
+++ b/sickchill/views/config/providers.py
@@ -24,7 +24,12 @@ def index(self):
         t = PageTemplate(rh=self, filename="config_providers.mako")
 
         return t.render(
-            submenu=self.ConfigMenu(), title=_("Config - Providers"), header=_("Search Providers"), topmenu="config", controller="config", action="providers"
+            submenu=self.ConfigMenu(),
+            title=_("Config - Providers"),
+            header=_("Search Providers"),
+            topmenu="config",
+            controller="config",
+            action="providers",
         )
 
     @staticmethod
diff --git a/sickchill/views/config/search.py b/sickchill/views/config/search.py
index 29b96c6c4d..aedb7f4a57 100644
--- a/sickchill/views/config/search.py
+++ b/sickchill/views/config/search.py
@@ -19,7 +19,12 @@ def index(self):
         t = PageTemplate(rh=self, filename="config_search.mako")
 
         return t.render(
-            submenu=self.ConfigMenu(), title=_("Config - Episode Search"), header=_("Search Settings"), topmenu="config", controller="config", action="search"
+            submenu=self.ConfigMenu(),
+            title=_("Config - Episode Search"),
+            header=_("Search Settings"),
+            topmenu="config",
+            controller="config",
+            action="search",
         )
 
     def saveSearch(
diff --git a/sickchill/views/config/subtitles.py b/sickchill/views/config/subtitles.py
index 1be675375b..9c6910c127 100644
--- a/sickchill/views/config/subtitles.py
+++ b/sickchill/views/config/subtitles.py
@@ -18,7 +18,12 @@ def index(self):
         t = PageTemplate(rh=self, filename="config_subtitles.mako")
 
         return t.render(
-            submenu=self.ConfigMenu(), title=_("Config - Subtitles"), header=_("Subtitles"), topmenu="config", controller="config", action="subtitles"
+            submenu=self.ConfigMenu(),
+            title=_("Config - Subtitles"),
+            header=_("Subtitles"),
+            topmenu="config",
+            controller="config",
+            action="subtitles",
         )
 
     def saveSubtitles(
diff --git a/sickchill/views/home.py b/sickchill/views/home.py
index 8916c1041b..abfccbb591 100644
--- a/sickchill/views/home.py
+++ b/sickchill/views/home.py
@@ -691,7 +691,15 @@ def status(self):
                 rootDir[subject] = helpers.disk_usage_hr(subject)
 
         t = PageTemplate(rh=self, filename="status.mako")
-        return t.render(title=_("Status"), header=_("Status"), topmenu="system", tvdirFree=tvdirFree, rootDir=rootDir, controller="home", action="status")
+        return t.render(
+            title=_("Status"),
+            header=_("Status"),
+            topmenu="system",
+            tvdirFree=tvdirFree,
+            rootDir=rootDir,
+            controller="home",
+            action="status",
+        )
 
     def shutdown(self):
         pid = self.get_query_argument("pid")
@@ -710,7 +718,13 @@ def restart(self):
 
         t = PageTemplate(rh=self, filename="restart.mako")
 
-        return t.render(title=_("Home"), header=_("Restarting SickChill"), topmenu="system", controller="home", action="restart")
+        return t.render(
+            title=_("Home"),
+            header=_("Restarting SickChill"),
+            topmenu="system",
+            controller="home",
+            action="restart",
+        )
 
     def updateCheck(self):
         pid = self.get_query_argument("pid")
@@ -733,7 +747,13 @@ def update(self, pid):
                 settings.events.put(settings.events.SystemEvent.RESTART)
 
                 t = PageTemplate(rh=self, filename="restart.mako")
-                return t.render(title=_("Home"), header=_("Restarting SickChill"), topmenu="home", controller="home", action="restart")
+                return t.render(
+                    title=_("Home"),
+                    header=_("Restarting SickChill"),
+                    topmenu="home",
+                    controller="home",
+                    action="restart",
+                )
             else:
                 return self._genericMessage(_("Update Failed"), _("Update wasn't successful, not restarting. Check your log for more information."))
         else:
@@ -1593,7 +1613,14 @@ def testRename(self):
         t = PageTemplate(rh=self, filename="testRename.mako")
         submenu = [{"title": _("Edit"), "path": f"home/editShow?show={show_obj.indexerid}", "icon": "ui-icon ui-icon-pencil"}]
 
-        return t.render(submenu=submenu, show=show_obj, title=_("Preview Rename"), header=_("Preview Rename"), controller="home", action="previewRename")
+        return t.render(
+            submenu=submenu,
+            show=show_obj,
+            title=_("Preview Rename"),
+            header=_("Preview Rename"),
+            controller="home",
+            action="previewRename",
+        )
 
     def doRename(self, show=None, eps=None):
         if not (show and eps):
@@ -1678,7 +1705,12 @@ def manual_search_show_releases(self):
         t = PageTemplate(rh=self, filename="manual_search_show_releases.mako")
         submenu = [{"title": _("Edit"), "path": f"home/editShow?show={show}", "icon": "fa fa-pencil"}]
         return t.render(
-            submenu=submenu, title=_("Manual Snatch"), header=_("Manual Snatch"), controller="home", action="manual_search_show_releases", results=results
+            submenu=submenu,
+            title=_("Manual Snatch"),
+            header=_("Manual Snatch"),
+            controller="home",
+            action="manual_search_show_releases",
+            results=results,
         )
 
     def manual_snatch_show_release(self):
diff --git a/sickchill/views/index.py b/sickchill/views/index.py
index 56a38f8c71..41c6299243 100644
--- a/sickchill/views/index.py
+++ b/sickchill/views/index.py
@@ -273,7 +273,14 @@ def apibuilder(self):
             apikey = _("API Key not generated")
 
         t = PageTemplate(rh=self, filename="apiBuilder.mako")
-        return t.render(title=_("API Builder"), header=_("API Builder"), shows=shows, episodes=episodes, apikey=apikey, commands=function_mapper)
+        return t.render(
+            title=_("API Builder"),
+            header=_("API Builder"),
+            shows=shows,
+            episodes=episodes,
+            apikey=apikey,
+            commands=function_mapper,
+        )
 
     def setHomeLayout(self):
         layout = self.get_query_argument("layout")
diff --git a/sickchill/views/manage/add_shows.py b/sickchill/views/manage/add_shows.py
index c89b734139..c8b0b6a65f 100644
--- a/sickchill/views/manage/add_shows.py
+++ b/sickchill/views/manage/add_shows.py
@@ -29,7 +29,13 @@
 class AddShows(Home):
     def index(self):
         t = PageTemplate(rh=self, filename="addShows.mako")
-        return t.render(title=_("Add Shows"), header=_("Add Shows"), topmenu="home", controller="addShows", action="index")
+        return t.render(
+            title=_("Add Shows"),
+            header=_("Add Shows"),
+            topmenu="home",
+            controller="addShows",
+            action="index",
+        )
 
     def sanitizeFileName(self):
         return sanitize_filename(self.get_body_argument("name"))
diff --git a/sickchill/views/manage/index.py b/sickchill/views/manage/index.py
index bc458a9fd4..8ba7837912 100644
--- a/sickchill/views/manage/index.py
+++ b/sickchill/views/manage/index.py
@@ -18,7 +18,13 @@
 class Manage(Home, WebRoot):
     def index(self):
         t = PageTemplate(rh=self, filename="manage.mako")
-        return t.render(title=_("Mass Update"), header=_("Mass Update"), topmenu="manage", controller="manage", action="index")
+        return t.render(
+            title=_("Mass Update"),
+            header=_("Mass Update"),
+            topmenu="manage",
+            controller="manage",
+            action="index",
+        )
 
     @staticmethod
     def showEpisodeStatuses(indexer_id, whichStatus):
diff --git a/sickchill/views/manage/post_processing.py b/sickchill/views/manage/post_processing.py
index 0849a9eeb0..9fa5175253 100644
--- a/sickchill/views/manage/post_processing.py
+++ b/sickchill/views/manage/post_processing.py
@@ -12,7 +12,13 @@ class PostProcess(Home):
     @addslash
     def index(self):
         t = PageTemplate(rh=self, filename="home_postprocess.mako")
-        return t.render(title=_("Post Processing"), header=_("Post Processing"), topmenu="home", controller="home", action="postProcess")
+        return t.render(
+            title=_("Post Processing"),
+            header=_("Post Processing"),
+            topmenu="home",
+            controller="home",
+            action="postProcess",
+        )
 
     def processEpisode(
         self,
diff --git a/sickchill/views/movies.py b/sickchill/views/movies.py
index 550d65945d..2549374cbe 100644
--- a/sickchill/views/movies.py
+++ b/sickchill/views/movies.py
@@ -16,7 +16,14 @@ def _genericMessage(self, subject=None, message=None):
 
     def index(self):
         t = PageTemplate(rh=self, filename="movies/index.mako")
-        return t.render(title=_("Movies"), header=_("Movie List"), topmenu="movies", movies=settings.movie_list, controller="movies", action="index")
+        return t.render(
+            title=_("Movies"),
+            header=_("Movie List"),
+            topmenu="movies",
+            movies=settings.movie_list,
+            controller="movies",
+            action="index",
+        )
 
     def search(self):
         query = self.get_body_argument("query", "")
@@ -64,7 +71,14 @@ def remove(self):
             settings.movie_list.delete(pk)
 
         t = PageTemplate(rh=self, filename="movies/remove.mako")
-        return t.render(title=_("Movies"), header=_("Movie Remove"), topmenu="movies", movies=settings.movie_list, controller="movies", action="remove")
+        return t.render(
+            title=_("Movies"),
+            header=_("Movie Remove"),
+            topmenu="movies",
+            movies=settings.movie_list,
+            controller="movies",
+            action="remove",
+        )
 
     def details(self):
         movie = settings.movie_list.by_slug(self.path_kwargs.get("slug"))
@@ -72,4 +86,12 @@ def details(self):
             return self._genericMessage(_("Error"), _("Movie not found"))
 
         t = PageTemplate(rh=self, filename="movies/details.mako")
-        return t.render(title=_("Movies"), header=_("Movie Remove"), topmenu="movies", controller="movies", action="details", movie=movie, movie_message=None)
+        return t.render(
+            title=_("Movies"),
+            header=_("Movie Remove"),
+            topmenu="movies",
+            controller="movies",
+            action="details",
+            movie=movie,
+            movie_message=None,
+        )
diff --git a/sickchill/views/news.py b/sickchill/views/news.py
index 6f9a6c447f..243740d967 100644
--- a/sickchill/views/news.py
+++ b/sickchill/views/news.py
@@ -25,4 +25,11 @@ def index(self):
         t = PageTemplate(rh=self, filename="markdown.mako")
         data = markdown2.markdown(news if news else _("The was a problem connecting to github, please refresh and try again"), extras=["header-ids"])
 
-        return t.render(title=_("News"), header=_("News"), topmenu="system", data=data, controller="news", action="index")
+        return t.render(
+            title=_("News"),
+            header=_("News"),
+            topmenu="system",
+            data=data,
+            controller="news",
+            action="index",
+        )

From bae210c51666d8f07953ff4d44d0b4ced81a5244 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 21:37:41 +0700
Subject: [PATCH 28/29] Failed download + params

---
 sickchill/oldbeard/notifiers/gotify.py | 2 +-
 sickchill/views/history.py             | 2 +-
 sickchill/views/manage/index.py        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sickchill/oldbeard/notifiers/gotify.py b/sickchill/oldbeard/notifiers/gotify.py
index 6e7d57c18e..682e76eb03 100644
--- a/sickchill/oldbeard/notifiers/gotify.py
+++ b/sickchill/oldbeard/notifiers/gotify.py
@@ -116,7 +116,7 @@ def notify_login(self, ipaddress=""):
             title = notifyStrings[NOTIFY_LOGIN]
             self._notify_gotify(title, update_text.format(ipaddress))
 
-    def _notify_gotify(self, title, message, host, token=None, force=False):
+    def _notify_gotify(self, title, message, host=None, token=None, force=False):
         """
         Sends a Gotify notification
 
diff --git a/sickchill/views/history.py b/sickchill/views/history.py
index 4c9595c915..15049dd3a3 100644
--- a/sickchill/views/history.py
+++ b/sickchill/views/history.py
@@ -16,7 +16,7 @@ def initialize(self):
         self.history = HistoryTool()
 
     def index(self):
-        settings.HISTORY_LIMIT = try_int(self.get_query_argument("limit", default=100), 100)
+        settings.HISTORY_LIMIT = try_int(self.get_query_argument("limit", default="100"), 100)
         sickchill.start.save_config()
 
         compact = []
diff --git a/sickchill/views/manage/index.py b/sickchill/views/manage/index.py
index 8ba7837912..9653b2df8f 100644
--- a/sickchill/views/manage/index.py
+++ b/sickchill/views/manage/index.py
@@ -712,7 +712,7 @@ def massUpdate(self):
         return self.redirect("/manage/")
 
     def failedDownloads(self):
-        remove = self.get_body_arguments("remove")
+        remove = self.get_body_arguments("remove[]")
         limit = self.get_argument("limit", "100")
         failed_db_con = db.DBConnection("failed.db")
 

From a6ed3a4a77f82f011e88e1d28a306cf88c59fe61 Mon Sep 17 00:00:00 2001
From: BKSteve <stephen.rieger@gmail.com>
Date: Mon, 12 Feb 2024 22:30:54 +0700
Subject: [PATCH 29/29] revert (_(f

---
 sickchill/oldbeard/helpers.py       | 148 +++++++++++++++++-----------
 sickchill/oldbeard/postProcessor.py | 147 ++++++++++++++++++---------
 2 files changed, 194 insertions(+), 101 deletions(-)

diff --git a/sickchill/oldbeard/helpers.py b/sickchill/oldbeard/helpers.py
index 5bc741dc0e..ba0f3beba6 100644
--- a/sickchill/oldbeard/helpers.py
+++ b/sickchill/oldbeard/helpers.py
@@ -315,12 +315,16 @@ def hardlinkFile(srcFile, destFile):
             except (OSError, IOError) as error:
                 logger.log(
                     _(
-                        f"The destination file already exists, and we were unable to remove it, so hard linking might fail. Trying anyway. Location: {destFile}. Error: {error}"
-                    )
+                        "The destination file already exists, and we were unable to remove it, so hard linking might fail. Trying anyway. Location: {destFile}. Error: {error}"
+                    ).format(destFile=destFile, error=error),
                 )
         os.link(srcFile, destFile)
     except Exception as error:
-        logger.warning(_(f"There was a problem creating a hardlink of {srcFile} at {destFile}. Copying instead. Error: {error}"))
+        logger.warning(
+            _("There was a problem creating a hardlink of {srcFile} at {destFile}. Copying instead. Error: {error}").format(
+                srcFile=srcFile, destFile=destFile, error=error
+            )
+        )
         copyFile(srcFile, destFile)
 
     fixSetGroupID(destFile)
@@ -340,7 +344,11 @@ def moveAndSymlinkFile(srcFile, destFile):
         moveFile(srcFile, destFile)
         os.symlink(destFile, srcFile)
     except Exception as error:
-        logger.warning(_(f"There was a problem creating a symlink of {srcFile} at {destFile}. Copying instead. Error: {error}"))
+        logger.warning(
+            _("There was a problem creating a symlink of {srcFile} at {destFile}. Copying instead. Error: {error}").format(
+                srcFile=srcFile, destFile=destFile, error=error
+            )
+        )
         copyFile(srcFile, destFile)
 
 
@@ -350,16 +358,16 @@ def make_dirs(path):
     parents
     """
 
-    logger.debug(_(f"Checking if the path {path} already exists"))
+    logger.debug(_("Checking if the path {path} already exists").format(path=path))
 
     if not os.path.isdir(path):
         # Windows, create all missing folders
         if platform.system() == "Windows":
             try:
-                logger.debug(_(f"Folder {path} didn't exist, creating it"))
+                logger.debug(_("Folder {path} didn't exist, creating it").format(path=path))
                 os.makedirs(path)
             except (OSError, IOError) as error:
-                logger.exception(_(f"There was a problem creating {path}. Error: {error}"))
+                logger.exception(_("There was a problem creating {path}. Error: {error}").format(path=path, error=error))
                 return False
 
         # not Windows, create all missing folders and set permissions
@@ -376,14 +384,14 @@ def make_dirs(path):
                     continue
 
                 try:
-                    logger.debug(_(f"Folder {sofar} didn't exist, creating it"))
+                    logger.debug(_("Folder {sofar} didn't exist, creating it").format(sofar=sofar))
                     os.mkdir(sofar)
                     # use normpath to remove end separator, otherwise checks permissions against itself
                     chmodAsParent(os.path.normpath(sofar))
                     # do the library update for synoindex
                     sickchill.oldbeard.notifiers.synoindex_notifier.addFolder(sofar)
                 except (OSError, IOError) as error:
-                    logger.exception(_(f"There was a problem creating {sofar}. Error: {error}"))
+                    logger.exception(_("There was a problem creating {sofar}. Error: {error}").format(sofar=sofar, error=error))
                     return False
 
     return True
@@ -425,10 +433,10 @@ def rename_ep_file(cur_path, new_path, old_path_length=0):
 
     # move the file
     try:
-        logger.info(_(f"Renaming file from {cur_path} to {new_path}"))
+        logger.info(_("Renaming file from {cur_path} to {new_path}").format(cur_path=cur_path, new_path=new_path))
         shutil.move(cur_path, new_path)
     except (OSError, IOError) as error:
-        logger.exception(_(f"There was a problem renaming {cur_path} to {new_path}. Error: {error}"))
+        logger.exception(_("There was a problem renaming {cur_path} to {new_path}. Error: {error}").format(cur_path=cur_path, new_path=new_path, error=error))
         return False
 
     # clean up any old folders that are empty
@@ -449,7 +457,7 @@ def delete_empty_folders(check_empty_dir, keep_dir=None):
     # treat check_empty_dir as empty when it only contains these items
     ignore_items = []
 
-    logger.info(_(f"Trying to clean any empty folders under {check_empty_dir}"))
+    logger.info(_("Trying to clean any empty folders under {check_empty_dir}").format(check_empty_dir=check_empty_dir))
 
     # as long as the folder exists and doesn't contain any files, delete it
     while os.path.isdir(check_empty_dir) and check_empty_dir != keep_dir:
@@ -458,13 +466,13 @@ def delete_empty_folders(check_empty_dir, keep_dir=None):
         if not check_files or (len(check_files) <= len(ignore_items) and all(check_file in ignore_items for check_file in check_files)):
             # directory is empty or contains only ignore_items
             try:
-                logger.info(_(f"Deleting empty folder: {check_empty_dir}"))
+                logger.info(_("Deleting empty folder: {check_empty_dir}").format(check_empty_dir=check_empty_dir))
                 # need shutil.rmtree when ignore_items is really implemented
                 os.rmdir(check_empty_dir)
                 # do the library update for synoindex
                 sickchill.oldbeard.notifiers.synoindex_notifier.deleteFolder(check_empty_dir)
             except OSError as error:
-                logger.warning(_(f"There was a problem trying to delete {check_empty_dir}. Error: {error}"))
+                logger.warning(_("There was a problem trying to delete {check_empty_dir}. Error: {error}").format(check_empty_dir=check_empty_dir, error=error))
                 break
             check_empty_dir = os.path.dirname(check_empty_dir)
         else:
@@ -503,7 +511,7 @@ def chmodAsParent(childPath):
     parentPath = os.path.dirname(childPath)
 
     if not parentPath:
-        logger.debug(_(f"No parent path provided in {childPath} unable to get permissions from it"))
+        logger.debug(_("No parent path provided in {childPath} unable to get permissions from it").format(childPath=childPath))
         return
 
     childPath = os.path.join(parentPath, os.path.basename(childPath))
@@ -526,13 +534,17 @@ def chmodAsParent(childPath):
     user_id = os.geteuid()  # @UndefinedVariable - only available on UNIX
 
     if user_id not in (childPath_owner, 0):
-        logger.debug(_(f"Not running as root or owner of {childPath}, not trying to set permissions"))
+        logger.debug(_("Not running as root or owner of {childPath}, not trying to set permissions").format(childPath=childPath))
         return
 
     try:
         os.chmod(childPath, childMode)
     except OSError as error:
-        logger.debug(_(f"There was a problem setting permissions of {childPath} to {childMode:o}, parent directory has {parentMode:o}. Error: {error}"))
+        logger.debug(
+            _("There was a problem setting permissions of {childPath} to {childMode:o}, parent directory has {parentMode:o}. Error: {error}").format(
+                childPath=childPath, childMode=childMode, parentMode=parentMode, error=error
+            )
+        )
 
 
 def fixSetGroupID(childPath):
@@ -566,20 +578,22 @@ def fixSetGroupID(childPath):
             user_id = os.geteuid()
 
             if user_id not in (childPath_owner, 0):
-                logger.debug(_(f"Not running as root or owner of {childPath}, not trying to set the set-group-ID"))
+                logger.debug(_("Not running as root or owner of {childPath}, not trying to set the set-group-ID").format(childPath=childPath))
                 return
 
             try:
                 os.chown(childPath, -1, parentGID)
-                logger.debug(_(f"Respecting the set-group-ID bit on the parent directory of {childPath}"))
+                logger.debug(_("Respecting the set-group-ID bit on the parent directory of {childPath}").format(childPath=childPath))
             except (OSError, PermissionError) as error:
                 logger.debug(
                     _(
-                        f"There was a problem respecting the set-group-ID bit on the parent directory of {childPath} (setting group ID {parentGID}). Error: {error}"
-                    )
+                        "There was a problem respecting the set-group-ID bit on the parent directory of {childPath} (setting group ID {parentGID}). Error: {error}"
+                    ).format(childPath=childPath, parentGID=parentGID, error=error)
                 )
     except Exception as error:
-        logger.debug(_(f"There was a problem setting set-group-id on the parent directory of {childPath}. Error: {error}"))
+        logger.debug(
+            _("There was a problem setting set-group-id on the parent directory of {childPath}. Error: {error}").format(childPath=childPath, error=error)
+        )
 
 
 def is_anime_in_show_list():
@@ -623,9 +637,15 @@ def get_absolute_number_from_season_and_episode(show, season, episode):
         season_episode = episode_num(season, episode)
         if len(sql_results) == 1:
             absolute_number = int(sql_results[0]["absolute_number"])
-            logger.debug(_(f"Found absolute number {absolute_number} for show {show.name} {season_episode}"))
+            logger.debug(
+                _("Found absolute number {absolute_number} for show {show_name} {season_episode}").format(
+                    absolute_number=absolute_number, show_name=show.name, season_episode=season_episode
+                )
+            )
         else:
-            logger.debug(_(f"No entries found for the absolute number of {show.name} {season_episode}"))
+            logger.debug(
+                _("No entries found for the absolute number of {show_name} {season_episode}").format(show_name=show.name, season_episode=season_episode)
+            )
 
     return absolute_number
 
@@ -725,11 +745,11 @@ def create_https_certificates(ssl_cert, ssl_key):
         Path(ssl_cert).write_bytes(crypto.dump_certificate(crypto.FILETYPE_PEM, cert))
     except Exception as error:
         logger.info(traceback.format_exc())
-        logger.warning(_(f"There was a problem creating the SSL key and certificate. Error: {error}"))
+        logger.warning(_("There was a problem creating the SSL key and certificate. Error: {error}").format(error=error))
         return False
 
-    logger.info(_(f"Created https key: {ssl_key}"))
-    logger.info(_(f"Created https cert: {ssl_cert}"))
+    logger.info(_("Created https key: {ssl_key}").format(ssl_key=ssl_key))
+    logger.info(_("Created https cert: {ssl_cert}").format(ssl_cert=ssl_cert))
     return True
 
 
@@ -752,22 +772,26 @@ def backupVersionedFile(old_file, version):
     new_file = old_file.with_suffix(f"{old_file.suffix}.v{version}")
     while not os.path.isfile(new_file):
         if not os.path.isfile(old_file):
-            logger.debug(_(f"Not creating backup, {old_file} doesn't exist"))
+            logger.debug(_("Not creating backup, {old_file} doesn't exist").format(old_file=old_file))
             break
 
         try:
-            logger.debug(_(f"Trying to back up {old_file} to {new_file}"))
+            logger.debug(_("Trying to back up {old_file} to {new_file}").format(old_file=old_file, new_file=new_file))
             shutil.copy(old_file, new_file)
             logger.debug(_("Backup done"))
             break
         except Exception as error:
-            logger.warning(_(f"There was a problem while trying to back up {old_file} to {new_file}. Error: {error}"))
+            logger.warning(
+                _("There was a problem while trying to back up {old_file} to {new_file}. Error: {error}").format(
+                    old_file=old_file, new_file=new_file, error=error
+                )
+            )
             numTries += 1
             time.sleep(1)
             logger.debug(_("Trying again."))
 
         if numTries >= 10:
-            logger.exception(_(f"Unable to back up {old_file} to {new_file} please do it manually."))
+            logger.exception(_("Unable to back up {old_file} to {new_file} please do it manually.").format(old_file=old_file, new_file=new_file))
             return False
 
     return True
@@ -914,7 +938,7 @@ def get_show(name, try_indexers=False):
         if show_object and not from_cache:
             sickchill.oldbeard.name_cache.add_name(name, show_object.indexerid)
     except Exception as error:
-        logger.debug(_(f"There was a problem when attempting to find {name} in SickChill. Error: {error}"))
+        logger.debug(_("There was a problem when attempting to find {name} in SickChill. Error: {error}").format(name=name, error=error))
         logger.debug(traceback.format_exc())
 
     return show_object
@@ -986,12 +1010,12 @@ def set_up_anidb_connection():
     if not settings.ADBA_CONNECTION:
 
         def anidb_logger(msg):
-            return logger.debug(_(f"{msg}"))
+            return logger.debug(_("{msg}").format(msg=msg))
 
         try:
             settings.ADBA_CONNECTION = adba.Connection(keep_alive=True, log=anidb_logger)
         except Exception as error:
-            logger.warning(_(f"There was a problem attempting to connect to anidb. Error: {error}"))
+            logger.warning(_("There was a problem attempting to connect to anidb. Error: {error}").format(error=error))
             return False
 
     try:
@@ -1000,7 +1024,7 @@ def anidb_logger(msg):
         else:
             return True
     except Exception as error:
-        logger.warning(_(f"There was a problem attempting to authenticate with anidb. Error: {error}"))
+        logger.warning(_("There was a problem attempting to authenticate with anidb. Error: {error}").format(error=error))
         return False
 
     return settings.ADBA_CONNECTION.authed()
@@ -1022,7 +1046,7 @@ def makeZip(fileList, archive):
         a.close()
         return True
     except Exception as error:
-        logger.exception(_(f"There was a problem creating the zip file. Error: {error}"))
+        logger.exception(_("There was a problem creating the zip file. Error: {error}").format(error=error))
         return False
 
 
@@ -1055,7 +1079,7 @@ def extractZip(archive, targetDir):
         zip_file.close()
         return True
     except Exception as error:
-        logger.exception(_(f"There was a problem extracting the zip file {archive}. Error: {error}"))
+        logger.exception(_("There was a problem extracting the zip file {archive}. Error: {error}").format(archive=archive, error=error))
         return False
 
 
@@ -1078,7 +1102,7 @@ def backup_config_zip(fileList, archive, arcname=None):
         a.close()
         return True
     except Exception as error:
-        logger.warning(_(f"There was a problem creating the zip file. Error: {error}"))
+        logger.warning(_("There was a problem creating the zip file. Error: {error}").format(error=error))
         return False
 
 
@@ -1113,7 +1137,7 @@ def path_leaf(path):
         zip_file.close()
         return True
     except Exception as error:
-        logger.exception(_(f"There was a problem extracting zip file {archive}. Error: {error}"))
+        logger.exception(_("There was a problem extracting zip file {archive}. Error: {error}").format(archive=archive, error=error))
         shutil.rmtree(targetDir)
         return False
 
@@ -1140,7 +1164,7 @@ def make_indexer_session():
     session = make_session()
     session.verify = (False, certifi.where())[settings.SSL_VERIFY]
     if settings.PROXY_SETTING and settings.PROXY_INDEXERS:
-        logger.debug(_(f"Using global proxy for indexers: {settings.PROXY_SETTING}"))
+        logger.debug(_("Using global proxy for indexers: {proxy_settings}").format(proxy_settings=settings.PROXY_SETTING))
         session.proxies = {"http": settings.PROXY_SETTING, "https": settings.PROXY_SETTING}
     return session
 
@@ -1156,7 +1180,7 @@ def request_defaults(kwargs):
 
     # request session proxies
     if kwargs.pop("allow_proxy", True) and settings.PROXY_SETTING:
-        logger.debug(_(f"Using global proxy: {settings.PROXY_SETTING}"))
+        logger.debug(_("Using global proxy: {proxy}").format(proxy=settings.PROXY_SETTING))
         proxies = {"http": settings.PROXY_SETTING, "https": settings.PROXY_SETTING}
     else:
         proxies = None
@@ -1238,7 +1262,7 @@ def getURL(
     try:
         return response if response_type in ("response", None) else response.json() if response_type == "json" else getattr(response, response_type, response)
     except ValueError:
-        logger.debug(_(f"Requested a json response but response was not json, check the url: {url}"))
+        logger.debug(_("Requested a json response but response was not json, check the url: {url}").format(url=url))
         return None
 
 
@@ -1278,7 +1302,9 @@ def download_file(url, filename, session=None, headers=None, **kwargs):  # pylin
 
                 chmodAsParent(filename)
             except Exception as error:
-                logger.warning(_(f"There was a problem downloading, setting permissions, or writing to {filename}. Error: {error}"))
+                logger.warning(
+                    _("There was a problem downloading, setting permissions, or writing to {filename}. Error: {error}").format(filename=filename, error=error)
+                )
 
     except Exception as error:
         # noinspection PyTypeChecker
@@ -1371,10 +1397,16 @@ def classname(error: Exception) -> str:
         raise requests_exception
     except requests.exceptions.SSLError as error:
         if ssl.OPENSSL_VERSION_INFO < (1, 0, 1, 5):
-            logger.info(_(f"SSL Error requesting url: '{error.request.url}' You have {ssl.OPENSSL_VERSION}, try upgrading OpenSSL to 1.0.1e+. Error: {error}"))
+            logger.info(
+                _("SSL Error requesting url: '{error.request.url}' You have {ssl.OPENSSL_VERSION}, try upgrading OpenSSL to 1.0.1e+. Error: {error}").format(
+                    error=error, ssl=ssl
+                )
+            )
         if settings.SSL_VERIFY:
             logger.info(
-                _(f"SSL Error requesting url: '{error.request.url}' Try disabling Cert Verification on the advanced tab of /config/general. Error: {error}")
+                _(
+                    "SSL Error requesting url: '{error.request.url}' Try disabling Cert Verification on the advanced tab of /config/general. Error: {error}"
+                ).format(error=error)
             )
         logger.debug(default.format(error, classname(error)))
         logger.debug(traceback.format_exc())
@@ -1397,10 +1429,10 @@ def classname(error: Exception) -> str:
         level = get_level(error)
         logger.log(level, default.format(error, classname(error)))
         if hasattr(requests_exception, "request") and requests_exception.request:
-            logger.info(_(f"url is {requests_exception.request.url}"))
-            logger.info(_(f"headers are {requests_exception.request.headers}"))
-            logger.info(_(f"params are {requests_exception.request.params}"))
-            logger.info(_(f"post_data is {requests_exception.request.data}"))
+            logger.info(_("url is {requests_exception.request.url}").format(requests_exception=requests_exception))
+            logger.info(_("headers are {requests_exception.request.headers}").format(requests_exception=requests_exception))
+            logger.info(_("params are {requests_exception.request.params}").format(requests_exception=requests_exception))
+            logger.info(_("post_data is {requests_exception.request.data}").format(requests_exception=requests_exception))
         if level == logger.WARNING:
             logger.debug(traceback.format_exc())
     except Exception as error:
@@ -1427,12 +1459,12 @@ def get_size(start_path="."):
             fp = os.path.join(dirpath, f)
             if os.path.islink(fp) and not os.path.isfile(fp):
                 log = logger.debug if settings.IGNORE_BROKEN_SYMLINKS else logger.warning
-                log(_(f"Unable to get size for file {fp} because the link to the file is not valid"))
+                log(_("Unable to get size for file {fp} because the link to the file is not valid").format(fp=fp))
                 continue
             try:
                 total_size += os.path.getsize(fp)
             except OSError as error:
-                logger.exception(_(f"Unable to get size for file {fp}. Error: {error}"))
+                logger.exception(_("Unable to get size for file {fp}. Error: {error}").format(fp=fp, error=error))
                 logger.debug(traceback.format_exc())
     return total_size
 
@@ -1501,12 +1533,14 @@ def verify_freespace(src, dest, oldfile=None, method="copy"):
     logger.debug(_("Trying to determine free space on the destination drive"))
 
     if not os.path.isfile(src):
-        logger.warning(_(f"A path to a file is required for the source. {src} is not a file."))
+        logger.warning(_("A path to a file is required for the source. {src} is not a file.").format(src=src))
         return True
 
     if not (os.path.isdir(dest) or (settings.CREATE_MISSING_SHOW_DIRS and os.path.isdir(os.path.dirname(dest)))):
         logger.warning(
-            _(f"A path is required for the destination. Check that the root dir and show locations are correct for {oldfile[0].name} (I got '{dest}')")
+            _("A path is required for the destination. Check that the root dir and show locations are correct for {old_file_name} (I got '{dest}')").format(
+                old_file_name=oldfile[0].name, dest=dest
+            )
         )
         return False
 
@@ -1523,7 +1557,7 @@ def verify_freespace(src, dest, oldfile=None, method="copy"):
         disk_free = disk_usage(dest)
     except Exception as error:
         logger.warning(_("Unable to determine free space, so I will assume there is enough."))
-        logger.debug(_(f"Error: {error}"))
+        logger.debug(_("Error: {error}").format(error=error))
         logger.debug(traceback.format_exc())
         return True
 
@@ -1543,8 +1577,8 @@ def verify_freespace(src, dest, oldfile=None, method="copy"):
     else:
         logger.warning(
             _(
-                f"Not enough free space: Needed: {needed_space} bytes ( {pretty_file_size(needed_space)} ), found: {disk_free} bytes ( {pretty_file_size(disk_free)} )"
-            )
+                "Not enough free space: Needed: {needed_space} bytes ( {pretty_file_size(needed_space)} ), found: {disk_free} bytes ( {pretty_file_size(disk_free)} )"
+            ).format(needed_space=needed_space, disk_free=disk_free)
         )
         return False
 
@@ -1560,7 +1594,7 @@ def disk_usage_hr(diskPath=None):
             free = disk_usage(diskPath)
         except Exception as error:
             logger.warning(_("Unable to determine free space"))
-            logger.debug(_(f"Error: {error}"))
+            logger.debug(_("Error: {error}").format(error=error))
             logger.debug(traceback.format_exc())
         else:
             return pretty_file_size(free)
diff --git a/sickchill/oldbeard/postProcessor.py b/sickchill/oldbeard/postProcessor.py
index aba5869ed6..dfe3ebe228 100644
--- a/sickchill/oldbeard/postProcessor.py
+++ b/sickchill/oldbeard/postProcessor.py
@@ -117,19 +117,19 @@ def _checkForExistingFile(self, existing_file):
         if os.path.isfile(existing_file):
             # see if it's bigger than our old file
             if os.path.getsize(existing_file) > os.path.getsize(self.directory):
-                self._log(_(f"File {existing_file} is larger than {self.directory}"), logger.DEBUG)
+                self._log(_("File {existing_file} is larger than {directory}").format(existing_file=existing_file, directory=self.directory), logger.DEBUG)
                 return PostProcessor.EXISTS_LARGER
 
             elif os.path.getsize(existing_file) == os.path.getsize(self.directory):
-                self._log(_(f"File {existing_file} is the same size as {self.directory}"), logger.DEBUG)
+                self._log(_("File {existing_file} is the same size as {directory}").format(existing_file=existing_file, directory=self.directory), logger.DEBUG)
                 return PostProcessor.EXISTS_SAME
 
             else:
-                self._log(_(f"File {existing_file} is smaller than {self.directory}"), logger.DEBUG)
+                self._log(_("File {existing_file} is smaller than {directory}").format(existing_file=existing_file, directory=self.directory), logger.DEBUG)
                 return PostProcessor.EXISTS_SMALLER
 
         else:
-            self._log(_(f"File {existing_file} doesn't exist so there's no worries about replacing it"), logger.DEBUG)
+            self._log(_("File {existing_file} doesn't exist so there's no worries about replacing it").format(existing_file=existing_file), logger.DEBUG)
             return PostProcessor.DOESNT_EXIST
 
     def list_associated_files(self, file_path, subtitles_only=False, subfolders=False, rename=False):
@@ -195,15 +195,30 @@ def list_associated_files(self, file_path, subtitles_only=False, subfolders=Fals
                     file_path_list_to_delete.append(associated_file_path)
 
         if file_path_list_to_allow or file_path_list_to_delete:
-            self._log(_(f"Found the following associated files for {file_path}: {file_path_list_to_allow + file_path_list_to_delete}"), logger.DEBUG)
+            self._log(
+                _("Found the following associated files for {file_path}: {allow_and_delete}").format(
+                    file_path=file_path, allow_and_delete=file_path_list_to_allow + file_path_list_to_delete
+                ),
+                logger.DEBUG,
+            )
             if file_path_list_to_delete:
-                self._log(_(f"Deleting non-allowed associated files for {file_path}: {file_path_list_to_delete}"), logger.DEBUG)
+                self._log(
+                    _("Deleting non-allowed associated files for {file_path}: {file_path_list_to_delete}").format(
+                        file_path=file_path, file_path_list_to_delete=file_path_list_to_delete
+                    ),
+                    logger.DEBUG,
+                )
                 # Delete all extensions the user doesn't allow
                 self._delete(file_path_list_to_delete)
             if file_path_list_to_allow:
-                self._log(_(f"Allowing associated files for {file_path}: {file_path_list_to_allow}"), logger.DEBUG)
+                self._log(
+                    _("Allowing associated files for {file_path}: {file_path_list_to_allow}").format(
+                        file_path=file_path, file_path_list_to_allow=file_path_list_to_allow
+                    ),
+                    logger.DEBUG,
+                )
         else:
-            self._log(_(f"No associated files for {file_path} were found during this pass"), logger.DEBUG)
+            self._log(_("No associated files for {file_path} were found during this pass").format(file_path=file_path), logger.DEBUG)
 
         return file_path_list_to_allow
 
@@ -229,22 +244,22 @@ def _delete(self, file_path, associated_files=False):
             file_list += self.list_associated_files(file_path, subfolders=True)
 
         if not file_list:
-            self._log(_(f"There were no files associated with {file_path}, not deleting anything"), logger.DEBUG)
+            self._log(_("There were no files associated with {file_path}, not deleting anything").format(file_path=file_path), logger.DEBUG)
             return
 
         # delete the file and any other files which we want to delete
         for cur_file in file_list:
             if os.path.isfile(cur_file):
-                self._log(_(f"Deleting file {cur_file}"), logger.DEBUG)
+                self._log(_("Deleting file {cur_file}").format(cur_file=cur_file), logger.DEBUG)
                 # check first the read-only attribute
                 file_attribute = os.stat(cur_file)[0]
                 if not file_attribute & stat.S_IWRITE:
                     # File is read-only, so make it writeable
-                    self._log(_(f"Read only mode on file {cur_file} Will try to make it writeable"), logger.DEBUG)
+                    self._log(_("Read only mode on file {cur_file} Will try to make it writeable").format(cur_file=cur_file), logger.DEBUG)
                     try:
                         os.chmod(cur_file, stat.S_IWRITE)
                     except Exception:
-                        self._log(_(f"Cannot change permissions of {cur_file}"), logger.WARNING)
+                        self._log(_("Cannot change permissions of {cur_file}").format(cur_file=cur_file), logger.WARNING)
 
                 os.remove(cur_file)
 
@@ -276,7 +291,7 @@ def _combined_file_operation(self, file_path, new_path: str, new_base_name, asso
             file_list += self.list_associated_files(file_path, subtitles_only=True, subfolders=subfolders)
 
         if not file_list:
-            self._log(_(f"There were no files associated with {file_path}, not moving anything"), logger.DEBUG)
+            self._log(_("There were no files associated with {file_path}, not moving anything").format(file_path=file_path), logger.DEBUG)
             return
 
         # deal with all files
@@ -310,7 +325,7 @@ def _combined_file_operation(self, file_path, new_path: str, new_base_name, asso
                 subs_new_path = os.path.join(new_path, settings.SUBTITLES_DIR)
                 dir_exists = helpers.makeDir(subs_new_path)
                 if not dir_exists:
-                    logger.exception(_(f"Unable to create subtitles folder {subs_new_path}"))
+                    logger.exception(_("Unable to create subtitles folder {subs_new_path}").format(subs_new_path=subs_new_path))
                 else:
                     helpers.chmodAsParent(subs_new_path)
                 new_file_path = os.path.join(subs_new_path, new_filename)
@@ -330,12 +345,17 @@ def _move(self, file_path, new_path, new_base_name, associated_files=False, subt
         """
 
         def _int_move(cur_file_path, new_file_path):
-            self._log(_(f"Moving file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
+            self._log(_("Moving file from {cur_file_path} to {new_file_path}").format(cur_file_path=cur_file_path, new_file_path=new_file_path), logger.DEBUG)
             try:
                 helpers.moveFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(_(f"Unable to move file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
+                self._log(
+                    _("Unable to move file from {cur_file_path} to {new_file_path}: {error}").format(
+                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
+                    ),
+                    logger.ERROR,
+                )
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_move, subtitles=subtitles)
@@ -351,12 +371,17 @@ def _copy(self, file_path, new_path, new_base_name, associated_files=False, subt
         """
 
         def _int_copy(cur_file_path, new_file_path):
-            self._log(_(f"Copying file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
+            self._log(_("Copying file from {cur_file_path} to {new_file_path}").format(cur_file_path=cur_file_path, new_file_path=new_file_path), logger.DEBUG)
             try:
                 helpers.copyFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(_(f"Unable to copy file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
+                self._log(
+                    _("Unable to copy file from {cur_file_path} to {new_file_path}: {error}").format(
+                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
+                    ),
+                    logger.ERROR,
+                )
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_copy, subtitles=subtitles)
@@ -372,12 +397,19 @@ def _hardlink(self, file_path, new_path, new_base_name, associated_files=False,
         """
 
         def _int_hard_link(cur_file_path, new_file_path):
-            self._log(_(f"Hard linking file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
+            self._log(
+                _("Hard linking file from {cur_file_path} to {new_file_path}").format(cur_file_path=cur_file_path, new_file_path=new_file_path), logger.DEBUG
+            )
             try:
                 helpers.hardlinkFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(_(f"Unable to link file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
+                self._log(
+                    _("Unable to link file from {cur_file_path} to {new_file_path}: {error}").format(
+                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
+                    ),
+                    logger.ERROR,
+                )
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_hard_link, subtitles=subtitles)
@@ -393,12 +425,22 @@ def _move_and_symlink(self, file_path, new_path, new_base_name, associated_files
         """
 
         def _int_move_and_sym_link(cur_file_path, new_file_path):
-            self._log(_(f"Moving then symbolically linking file from {cur_file_path} to {new_file_path}"), logger.DEBUG)
+            self._log(
+                _("Moving then symbolically linking file from {cur_file_path} to {new_file_path}").format(
+                    cur_file_path=cur_file_path, new_file_path=new_file_path
+                ),
+                logger.DEBUG,
+            )
             try:
                 helpers.moveAndSymlinkFile(cur_file_path, new_file_path)
                 helpers.chmodAsParent(new_file_path)
             except (IOError, OSError) as error:
-                self._log(_(f"Unable to link file from {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
+                self._log(
+                    _("Unable to link file from {cur_file_path} to {new_file_path}: {error}").format(
+                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
+                    ),
+                    logger.ERROR,
+                )
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_move_and_sym_link, subtitles=subtitles)
@@ -414,12 +456,22 @@ def _symlink(self, file_path, new_path, new_base_name, associated_files=False, s
         """
 
         def _int_sym_link(cur_file_path, new_file_path):
-            self._log(_(f"Creating then symbolically linking file from {new_file_path} to {cur_file_path}"), logger.DEBUG)
+            self._log(
+                _("Creating then symbolically linking file from {new_file_path} to {cur_file_path}").format(
+                    cur_file_path=cur_file_path, new_file_path=new_file_path
+                ),
+                logger.DEBUG,
+            )
             try:
                 os.symlink(cur_file_path, new_file_path)
                 helpers.chmodAsParent(cur_file_path)
             except (IOError, OSError) as error:
-                self._log(_(f"Unable to link file {cur_file_path} to {new_file_path}: {error}"), logger.ERROR)
+                self._log(
+                    _("Unable to link file {cur_file_path} to {new_file_path}: {error}").format(
+                        cur_file_path=cur_file_path, new_file_path=new_file_path, error=error
+                    ),
+                    logger.ERROR,
+                )
                 raise
 
         self._combined_file_operation(file_path, new_path, new_base_name, associated_files, action=_int_sym_link, subtitles=subtitles)
@@ -475,7 +527,12 @@ def _history_lookup(self):
 
             qual_str = common.Quality.qualityStrings[quality] if quality is not None else quality
             result_name = show.name if show else "UNDEFINED"
-            self._log(_(f"Found result in history for {result_name} - Season: {season} - Quality: {qual_str} - Version: {version}"), logger.DEBUG)
+            self._log(
+                _("Found result in history for {result_name} - Season: {season} - Quality: {qual_str} - Version: {version}").format(
+                    result_name=result_name, season=season, qual_str=qual_str, version=version
+                ),
+                logger.DEBUG,
+            )
 
             return to_return
 
@@ -642,7 +699,7 @@ def _find_info(self):
                     airdate = episodes[0].toordinal()
                 except AttributeError:
                     airdate_value = episodes[0]
-                    self._log(_(f"Could not convert to a valid airdate: {airdate_value}"), logger.DEBUG)
+                    self._log(_("Could not convert to a valid airdate: {airdate_value}").format(airdate_value=airdate_value), logger.DEBUG)
                     episodes = []
                     continue
 
@@ -707,7 +764,7 @@ def _get_ep_obj(self, show, season, episodes):
                 if not curEp:
                     raise EpisodeNotFoundException()
             except EpisodeNotFoundException as error:
-                self._log(_(f"Unable to create episode: {error}"), logger.DEBUG)
+                self._log(_("Unable to create episode: {error}").format(error=error), logger.DEBUG)
                 raise EpisodePostProcessingFailedException()
 
             # associate all the episodes together under a single root episode
@@ -732,7 +789,7 @@ def _get_quality(self, episode_object):
         if episode_object.status in common.Quality.SNATCHED + common.Quality.SNATCHED_PROPER + common.Quality.SNATCHED_BEST:
             ep_status_, ep_quality = common.Quality.splitCompositeStatus(episode_object.status)
             if ep_quality != common.Quality.UNKNOWN:
-                self._log(_(f"The old status had a quality in it, using that: {common.Quality.qualityStrings[ep_quality]}"), logger.DEBUG)
+                self._log(_("The old status had a quality in it, using that: ") + common.Quality.qualityStrings[ep_quality], logger.DEBUG)
                 return ep_quality
 
         # release name is the most reliable if it exists, followed by folder name and lastly file name
@@ -801,7 +858,7 @@ def _run_extra_scripts(self, episode_object):
                 )
                 out, err = p.communicate()
 
-                self._log(_(f"Script result: {(out or err).strip()}"), logger.DEBUG)
+                self._log(_("Script result: {out}").format(out=(out or err).strip()), logger.DEBUG)
 
             except Exception as error:
                 self._log(f"Unable to run extra_script: {error}")
@@ -858,19 +915,19 @@ def process(self):
         :return: True on success, False on failure
         """
 
-        self._log(_(f"Processing {self.directory} ({self.release_name})"))
+        self._log(_("Processing {directory} ({release_name})").format(directory=self.directory, release_name=self.release_name))
 
         if os.path.isdir(self.directory):
-            self._log(_(f"File {self.directory} seems to be a directory"))
+            self._log(_("File {directory} seems to be a directory").format(directory=self.directory))
             return False
 
         if not os.path.exists(self.directory):
-            self._log(_(f"File {self.directory} doesn't exist, did unrar fail?"))
+            self._log(_("File {directory} doesn't exist, did unrar fail?").format(directory=self.directory))
             return False
 
         for ignore_file in self.IGNORED_FILESTRINGS:
             if ignore_file in self.directory:
-                self._log(_(f"File {self.directory} is ignored type, skipping"))
+                self._log(_("File {directory} is ignored type, skipping").format(directory=self.directory))
                 return False
 
         # reset per-file stuff
@@ -894,21 +951,21 @@ def process(self):
 
         # get the quality of the episode we're processing
         if quality and not common.Quality.qualityStrings[quality] == "Unknown":
-            self._log(_(f"Snatch history had a quality in it, using that: {common.Quality.qualityStrings[quality]}"), logger.DEBUG)
+            self._log(_("Snatch history had a quality in it, using that: ") + common.Quality.qualityStrings[quality], logger.DEBUG)
             new_ep_quality = quality
         else:
             new_ep_quality = self._get_quality(episode_object)
 
         new_quality_string = common.Quality.qualityStrings[new_ep_quality]
-        logger.debug(_(f"Quality of the episode we're processing: {new_quality_string}"))
+        logger.debug(_("Quality of the episode we're processing: {new_quality_string}").format(new_quality_string=new_quality_string))
 
         # see if this is a priority download (is it snatched, in history, PROPER, or BEST)
         priority_download = self._is_priority(episode_object, new_ep_quality)
-        self._log(_(f"Is ep a priority download: {str(priority_download)}"), logger.DEBUG)
+        self._log(_("Is ep a priority download: ") + str(priority_download), logger.DEBUG)
 
         # get the version of the episode we're processing
         if version:
-            self._log(_(f"Snatch history had a version in it, using that: v{str(version)}"), logger.DEBUG)
+            self._log(_("Snatch history had a version in it, using that: v") + str(version), logger.DEBUG)
             new_ep_version = version
         else:
             new_ep_version = -1
@@ -952,8 +1009,10 @@ def process(self):
                 if int(episode_season) > newest_season:
                     self._log(
                         _(
-                            f"File has season {episode_season}, while the indexer is on season {newest_season}. Try forcing a full update on the show and process this file again. The file may be incorrectly labeled or fake, aborting."
-                        )
+                            "File has season {episode_season}, while the indexer is on season {newest_season}. "
+                            "Try forcing a full update on the show and process this file again. "
+                            "The file may be incorrectly labeled or fake, aborting."
+                        ).format(episode_season=episode_season, newest_season_num=newest_season)
                     )
                     return False
 
@@ -1000,7 +1059,7 @@ def process(self):
                 # do the library update for synoindex
                 notifiers.synoindex_notifier.addFolder(episode_object.show.get_location)
             except (OSError, IOError):
-                raise EpisodePostProcessingFailedException(_(f"Unable to create the show directory: {episode_object.show.get_location}"))
+                raise EpisodePostProcessingFailedException(_("Unable to create the show directory: ") + episode_object.show.get_location)
 
             # get metadata for the show (but not episode because it hasn't been fully processed)
             episode_object.show.write_metadata(True)
@@ -1011,11 +1070,11 @@ def process(self):
         for cur_ep in [episode_object] + episode_object.related_episodes:
             with cur_ep.lock:
                 if self.release_name:
-                    self._log(_(f"Found release name: {self.release_name}"), logger.DEBUG)
+                    self._log(_("Found release name ") + self.release_name, logger.DEBUG)
                     cur_ep.release_name = self.release_name
                 elif self.filename:
                     # If we can't get the release name we expect, save the original release name instead
-                    self._log(_(f"Using original release name: {self.filename}"), logger.DEBUG)
+                    self._log(_("Using original release name ") + self.filename, logger.DEBUG)
                     cur_ep.release_name = self.filename
                 else:
                     cur_ep.release_name = ""
@@ -1055,7 +1114,7 @@ def process(self):
         except ShowDirectoryNotFoundException:
             raise EpisodePostProcessingFailedException(_("Unable to post-process an episode if the show dir doesn't exist, quitting"))
 
-        self._log(_(f"Destination folder for this episode: {dest_path}"), logger.DEBUG)
+        self._log(_("Destination folder for this episode: ") + dest_path, logger.DEBUG)
 
         # create any folders we need
         helpers.make_dirs(dest_path)
@@ -1100,7 +1159,7 @@ def process(self):
                     self.directory, dest_path, new_base_name, settings.MOVE_ASSOCIATED_FILES, settings.USE_SUBTITLES and episode_object.show.subtitles
                 )
             else:
-                logger.exception(_(f"Unknown process method: {str(self.process_method)}"))
+                logger.exception(_("Unknown process method: ") + str(self.process_method))
                 raise EpisodePostProcessingFailedException(_("Unable to move the files to their new home"))
         except (OSError, IOError):
             raise EpisodePostProcessingFailedException(_("Unable to move the files to their new home"))