Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched Solidity Versions #2885

Closed
Brando753 opened this issue Jun 7, 2022 · 2 comments
Closed

Mismatched Solidity Versions #2885

Brando753 opened this issue Jun 7, 2022 · 2 comments
Assignees
Labels
Low Peggy Team Peggy team task

Comments

@Brando753
Copy link
Contributor

Contracts have matched Solidity versions; Blocklist.sol uses v0.5.16 while other contracts use 0.8.0. If compiled with a future version of the compiler, contracts may perform in unexpected ways.

@Brando753 Brando753 added the Peggy Team Peggy team task label Jun 7, 2022
@Brando753 Brando753 self-assigned this Jun 7, 2022
@Brando753 Brando753 added the Low label Jun 8, 2022
@Brando753
Copy link
Contributor Author

The Blocklist.sol contract is independent of the bridgebank/cosmosbridge contracts, not upgradeable, and already deployed on the Ethereum Network, so keeping the version number consistent with the deployed contract should allow better testing of contract interaction than compiling local copies differently from the deployed copy. Currently, ticket #3193 would rewrite the Blocklist contract to be more efficient, and that version should use the same version numbers; however, it is my opinion that this issue should be closed as not an issue. @smartyalgo or @juniuszhou please let me know if you concur or not so we can close this issue.

@Brando753 Brando753 assigned juniuszhou and smartyalgo and unassigned Brando753 Sep 1, 2022
@smartyalgo
Copy link
Contributor

Agreed. It is already deployed and non-upgradeable. This keeps it close to what we have in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Peggy Team Peggy team task
Projects
None yet
Development

No branches or pull requests

3 participants