Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONR-01 | Incomplete Workflow of Function OnRecPacketWhitelistConvert() #3169

Open
Brando753 opened this issue Aug 25, 2022 · 0 comments
Open

ONR-01 | Incomplete Workflow of Function OnRecPacketWhitelistConvert() #3169

Brando753 opened this issue Aug 25, 2022 · 0 comments
Assignees
@smartyalgo
Labels
Medium A Medium level security issue or medium level priority Peggy Team Peggy team task Peggy2 Audit - Sifnode Issue Issue that came out of the Peggy2 audits that requires remediation by Sifnode Peggy 2.0 An issue blocking the Peggy 2.0 release Sifnode Team

Comments

@Brando753
Copy link
Contributor

Affected Files: onrecv_packet.go L57

Description

As the comment states, the non-x versions of tokens received should be registered to the tokenRegistry module to allow the following token conversion operations. Without proper token registrations, the function call on line 58 will return an error and the following tokens conversions will not be executed.

convertToDenomEntry, err := whitelistKeeper.GetRegistryEntry(ctx, mintedDenomEntry.UnitDenom)

Recommendation

Recommend the Sifchian Team to complete the aforementioned workflow by validating and registering the non-x versions of tokens before further execution if necessary.
@Brando753 Brando753 added Peggy Team Peggy team task Sifnode Team Medium A Medium level security issue or medium level priority Peggy2 Audit - Sifnode Issue Issue that came out of the Peggy2 audits that requires remediation by Sifnode labels Aug 25, 2022
@Brando753 Brando753 added the Peggy 2.0 An issue blocking the Peggy 2.0 release label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smartyalgo smartyalgo

Labels
Medium A Medium level security issue or medium level priority Peggy Team Peggy team task Peggy2 Audit - Sifnode Issue Issue that came out of the Peggy2 audits that requires remediation by Sifnode Peggy 2.0 An issue blocking the Peggy 2.0 release Sifnode Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Brando753 @smartyalgo