MSG-02 | Lack of Price Slippage Protection When Adding or Removing Liquidity

[Brando753]

Affected Files: clp/keeper/msg_server.go L241,403

Description

In x/clp/keeper/msg_server.go, the price slippage protection is applied in the function Swap() by introducing the parameter MinReceivingAmount:

	if emitAmount.LT(msg.MinReceivingAmount) {
		ctx.EventManager().EmitEvents(sdk.Events{
			sdk.NewEvent(
				types.EventTypeSwapFailed,
				...

However, the protection is not applied in the functions RemoveLiquidity() and AddLiquidity(). When a significant price fluctuation happens, the message sender might not be able to receive the expected pool units when adding liquidity to a pool or expected token amounts when removing liquidity from a pool.

Recommendation

Recommend adding price slippage protections for adding liquidity to or removing liquidity from pools.