Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL-12 open todos #3261

Open
juniuszhou opened this issue Sep 18, 2022 · 2 comments
Open

HAL-12 open todos #3261

juniuszhou opened this issue Sep 18, 2022 · 2 comments
Assignees
Labels
Peggy Team Peggy team task

Comments

@juniuszhou
Copy link
Contributor

juniuszhou commented Sep 18, 2022

Description

Open To-dos can point to architecture or programming issues that still need to be resolved. Often these kinds of comments indicate areas of complexity or confusion for developers. This provides value and insight to an attacker who aims to cause damage to the protocol.

Code Location:

Listing 23
1 ./x/ ethbridge / test / test_helpers .go :69: // TODO : staking . TStoreKey removed in favor of? 
2 ./x/ tokenregistry / types / genesis .go :15: TODO : This is commented out because it no longer works after merging release /13.4.

Recommendation:
Consider resolving the To-dos before deploying code to a production context. Use an independent issue tracker or other project management software to track development tasks.

@juniuszhou juniuszhou self-assigned this Sep 18, 2022
@juniuszhou juniuszhou added the Peggy Team Peggy team task label Sep 18, 2022
@juniuszhou
Copy link
Contributor Author

too many TODOs in code, need lots time to confirm how to fix them

@pandaring2you
Copy link
Contributor

Note: One 1 todo remaining for Peggy2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Peggy Team Peggy team task
Projects
None yet
Development

No branches or pull requests

2 participants