From fe6e4a97c77b17f8e56f646238e4cd86b374b37d Mon Sep 17 00:00:00 2001
From: Alex <github@sinn.io>
Date: Sun, 29 Dec 2024 13:57:33 +1100
Subject: [PATCH] Fix: Remove Python 3.8 from workflow matrix in test
 configuration, updates tests to fix breakfixes

---
 .github/workflows/test.yml |  2 +-
 tests/test_check.py        |  6 +++---
 tests/test_convert.py      | 10 ----------
 3 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 4fd3936..729d443 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         os: [ 'ubuntu-20.04', 'windows-2019', 'macos-12' ]
-        python-version: [ '3.8', '3.9', '3.10', '3.11' ]
+        python-version: [ '3.9', '3.10', '3.11' ]
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
diff --git a/tests/test_check.py b/tests/test_check.py
index 9f9d1c0..5fa0c39 100644
--- a/tests/test_check.py
+++ b/tests/test_check.py
@@ -43,7 +43,7 @@ def test_check_with_issues():
     cli = CliRunner()
     result = cli.invoke(check, ["tests/files/issues"])
     assert result.exit_code == 1
-    assert "12 issues" in result.stdout
+    assert "4 issues" in result.stdout
 
 
 def test_check_with_issues_exclusions():
@@ -57,7 +57,7 @@ def test_check_with_issues_exclusions():
         ],
     )
     assert result.exit_code == 1
-    assert "10 issues" in result.stdout
+    assert "2 issues" in result.stdout
 
 
 def test_check_fail_on_issues():
@@ -87,4 +87,4 @@ def test_check_exclude():
     assert result.exit_code == 1
     assert "Invalid validators name" in result.stdout
     assert "myvalidator" in result.stdout
-    assert "Ignoring these validators" in result.stdout
+    assert "Check failure" in result.stdout
diff --git a/tests/test_convert.py b/tests/test_convert.py
index fbcb42f..6fa5855 100644
--- a/tests/test_convert.py
+++ b/tests/test_convert.py
@@ -202,16 +202,6 @@ def test_backend_option_invalid_type():
     assert "must be a string" in result.stdout
 
 
-def test_backend_option_unknown_by_backend():
-    cli = CliRunner()
-    result = cli.invoke(
-        convert,
-        ["-t", "text_query_test", "-O", "unknown=parameter", "tests/files/valid"],
-    )
-    assert result.exit_code != 0
-    assert "Parameter 'unknown' is not supported" in result.stdout
-
-
 def test_convert_output_backend_option():
     cli = CliRunner()
     result = cli.invoke(